ijuma commented on code in PR #13012:
URL: https://github.com/apache/kafka/pull/13012#discussion_r1054822697
##########
clients/src/test/java/org/apache/kafka/common/utils/PrimitiveRefTest.java:
##########
@@ -14,15 +14,19 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
+package org.apache.kafka.common.utils;
-package kafka.common
+import org.junit.jupiter.api.Test;
-import org.apache.kafka.common.errors.ApiException
-import org.apache.kafka.common.requests.ProduceResponse.RecordError
+import static org.junit.jupiter.api.Assertions.assertEquals;
-import scala.collection.Seq
-
-class RecordValidationException(val invalidException: ApiException,
- val recordErrors: Seq[RecordError])
- extends RuntimeException(invalidException) {
+public class PrimitiveRefTest {
+ @Test
+ public void testLongRef() {
Review Comment:
`IntRef` was there before, but yes, I can take the chance to improve
coverage.
##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -846,21 +842,26 @@ class UnifiedLog(@volatile var logStartOffset: Long,
config.messageTimestampDifferenceMaxMs,
leaderEpoch,
origin,
- interBrokerProtocolVersion,
- brokerTopicStats,
+ interBrokerProtocolVersion
+ )
+ validator.validateMessagesAndAssignOffsets(offset,
+ validatorMetricsRecorder(brokerTopicStats.allTopicsStats),
Review Comment:
Good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
