[GitHub] [kafka] ijuma commented on a diff in pull request #13013: KAFKA-14466 Move ClassloaderAwareRemoteStorageManager to storage module

2022-12-19 Thread GitBox
ijuma commented on code in PR #13013: URL: https://github.com/apache/kafka/pull/13013#discussion_r1051923726 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/ClassLoaderAction.java: ## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [kafka] ijuma commented on a diff in pull request #13013: KAFKA-14466 Move ClassloaderAwareRemoteStorageManager to storage module

2022-12-19 Thread GitBox
ijuma commented on code in PR #13013: URL: https://github.com/apache/kafka/pull/13013#discussion_r1051924558 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/ClassLoaderAction.java: ## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[jira] [Commented] (KAFKA-14470) Move log layer to storage module

2022-12-19 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649214#comment-17649214 ] Ismael Juma commented on KAFKA-14470: - [~satish.duggana] What aspect in particular?

[GitHub] [kafka] satishd commented on a diff in pull request #13013: KAFKA-14466 Move ClassloaderAwareRemoteStorageManager to storage module

2022-12-19 Thread GitBox
satishd commented on code in PR #13013: URL: https://github.com/apache/kafka/pull/13013#discussion_r1051962413 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/ClassLoaderAction.java: ## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] ijuma commented on a diff in pull request #13013: KAFKA-14466 Move ClassloaderAwareRemoteStorageManager to storage module

2022-12-19 Thread GitBox
ijuma commented on code in PR #13013: URL: https://github.com/apache/kafka/pull/13013#discussion_r1051966825 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/ClassLoaderAction.java: ## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[jira] [Commented] (KAFKA-14470) Move log layer to storage module

2022-12-19 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649225#comment-17649225 ] Satish Duggana commented on KAFKA-14470: [~ijuma] I understand that the Java co

[GitHub] [kafka] satishd commented on pull request #13013: KAFKA-14466 Move ClassloaderAwareRemoteStorageManager to storage module

2022-12-19 Thread GitBox
satishd commented on PR #13013: URL: https://github.com/apache/kafka/pull/13013#issuecomment-1357351385 Thanks @ijuma for your review. Addressed them with the latest commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] vamossagar12 commented on pull request #13014: KAFKA-14461: Move StoreQueryIntegrationTest to junit5 and fixing logic in a couple of tests for finding active streams

2022-12-19 Thread GitBox
vamossagar12 commented on PR #13014: URL: https://github.com/apache/kafka/pull/13014#issuecomment-1357356617 Looks like there was a checkstyle failure. Would push a fix for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] showuon opened a new pull request, #13015: KAFKA-14529: set inter.broker.protocol.version to pass broker registration

2022-12-19 Thread GitBox
showuon opened a new pull request, #13015: URL: https://github.com/apache/kafka/pull/13015 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgra

[jira] [Commented] (KAFKA-14470) Move log layer to storage module

2022-12-19 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649227#comment-17649227 ] Ismael Juma commented on KAFKA-14470: - The scala.util.Logging approach is an anti-pa

[GitHub] [kafka] ijuma commented on pull request #13013: KAFKA-14466 Move ClassloaderAwareRemoteStorageManager to storage module

2022-12-19 Thread GitBox
ijuma commented on PR #13013: URL: https://github.com/apache/kafka/pull/13013#issuecomment-1357360605 Thanks. I'll take a look soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [kafka] ijuma commented on a diff in pull request #13007: KAFKA-14473: Move AbstractIndex to storage module

2022-12-19 Thread GitBox
ijuma commented on code in PR #13007: URL: https://github.com/apache/kafka/pull/13007#discussion_r1051987790 ## storage/src/main/java/org/apache/kafka/server/log/internals/AbstractIndex.java: ## @@ -0,0 +1,553 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Commented] (KAFKA-9990) Supporting transactions in tiered storage

2022-12-19 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649230#comment-17649230 ] Satish Duggana commented on KAFKA-9990: --- This is fixed with https://github.com/apac

[jira] [Updated] (KAFKA-9990) Supporting transactions in tiered storage

2022-12-19 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-9990: -- Fix Version/s: 3.5.0 > Supporting transactions in tiered storage >

[jira] [Resolved] (KAFKA-9990) Supporting transactions in tiered storage

2022-12-19 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana resolved KAFKA-9990. --- Resolution: Fixed > Supporting transactions in tiered storage > -

[GitHub] [kafka] ijuma commented on pull request #13010: KAFKA-14475: Move TimeIndex/LazyIndex to storage module

2022-12-19 Thread GitBox
ijuma commented on PR #13010: URL: https://github.com/apache/kafka/pull/13010#issuecomment-1357363645 Yes, I'll push that commit soon. Feel free to help review the transactions index one (first unmerged in the series) if you have cycles. :) -- This is an automated message from the Apache

[GitHub] [kafka] showuon opened a new pull request, #13016: KAFKA-14498: reduce the startup nodes to avoid timeout error

2022-12-19 Thread GitBox
showuon opened a new pull request, #13016: URL: https://github.com/apache/kafka/pull/13016 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgra

[GitHub] [kafka] showuon commented on pull request #13016: KAFKA-14498: reduce the startup nodes to avoid timeout error

2022-12-19 Thread GitBox
showuon commented on PR #13016: URL: https://github.com/apache/kafka/pull/13016#issuecomment-1357394768 @dengziming , please take a look. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Comment Edited] (KAFKA-14470) Move log layer to storage module

2022-12-19 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649225#comment-17649225 ] Satish Duggana edited comment on KAFKA-14470 at 12/19/22 10:13 AM: ---

[jira] [Updated] (KAFKA-7739) Kafka Tiered Storage

2022-12-19 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-7739: -- Fix Version/s: 3.5.0 > Kafka Tiered Storage > > > Key: KAF

[jira] [Updated] (KAFKA-9550) RemoteLogManager implementation

2022-12-19 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-9550: -- Fix Version/s: 3.5.0 > RemoteLogManager implementation > > >

[jira] [Updated] (KAFKA-9550) RemoteLogManager - copying eligible log segments to remote storage implementation

2022-12-19 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-9550: -- Summary: RemoteLogManager - copying eligible log segments to remote storage implementation (w

[jira] [Updated] (KAFKA-9550) RemoteLogManager implementation

2022-12-19 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-9550: -- Description: Implementation of RLM as mentioned in the HLD section of KIP-405, this JIRA cover

[GitHub] [kafka] dajac merged pull request #12865: MINOR: Serialize response in KafkaApisTest

2022-12-19 Thread GitBox
dajac merged PR #12865: URL: https://github.com/apache/kafka/pull/12865 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] shekhar-rajak commented on a diff in pull request #12735: Replace EasyMock and PowerMock with Mockito in connect/runtime/ErrorHandlingTaskTest | KAFKA-14059

2022-12-19 Thread GitBox
shekhar-rajak commented on code in PR #12735: URL: https://github.com/apache/kafka/pull/12735#discussion_r1052074908 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/ErrorHandlingTaskTest.java: ## @@ -494,72 +502,29 @@ private void assertErrorHandlingMetricValue

[GitHub] [kafka] shekhar-rajak commented on pull request #12739: Replace EasyMock and PowerMock with Mockito | TimeOrderedCachingPersistentWindowStoreTest

2022-12-19 Thread GitBox
shekhar-rajak commented on PR #12739: URL: https://github.com/apache/kafka/pull/12739#issuecomment-1357467108 Hi @cadonna, Just a reminder for the review. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] dajac commented on pull request #9243: Add ConsumerGroupCommand to delete static members

2022-12-19 Thread GitBox
dajac commented on PR #9243: URL: https://github.com/apache/kafka/pull/9243#issuecomment-1357468275 @sndp2693 I left a few comments in the discuss thread. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[jira] [Commented] (KAFKA-14133) Remaining EasyMock to Mockito tests

2022-12-19 Thread Shekhar Prasad Rajak (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649264#comment-17649264 ] Shekhar Prasad Rajak commented on KAFKA-14133: -- Hi Team,   Please review

[GitHub] [kafka] showuon commented on pull request #13015: KAFKA-14529: set inter.broker.protocol.version to pass broker registration

2022-12-19 Thread GitBox
showuon commented on PR #13015: URL: https://github.com/apache/kafka/pull/13015#issuecomment-1357599437 @mumrah @cmccabe , please take a look. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] showuon commented on a diff in pull request #13015: KAFKA-14529: set inter.broker.protocol.version to pass broker registration

2022-12-19 Thread GitBox
showuon commented on code in PR #13015: URL: https://github.com/apache/kafka/pull/13015#discussion_r1052162050 ## core/src/test/java/kafka/test/junit/ZkClusterInvocationContext.java: ## @@ -109,7 +109,9 @@ public void modifyConfigs(Seq props) { @Override

[GitHub] [kafka] showuon commented on a diff in pull request #13015: KAFKA-14529: set inter.broker.protocol.version to pass broker registration

2022-12-19 Thread GitBox
showuon commented on code in PR #13015: URL: https://github.com/apache/kafka/pull/13015#discussion_r1052162050 ## core/src/test/java/kafka/test/junit/ZkClusterInvocationContext.java: ## @@ -109,7 +109,9 @@ public void modifyConfigs(Seq props) { @Override

[jira] [Created] (KAFKA-14530) Check state updater more than once in process loops

2022-12-19 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-14530: -- Summary: Check state updater more than once in process loops Key: KAFKA-14530 URL: https://issues.apache.org/jira/browse/KAFKA-14530 Project: Kafka Issue

[jira] [Assigned] (KAFKA-14530) Check state updater more than once in process loops

2022-12-19 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy reassigned KAFKA-14530: -- Assignee: Lucas Brutschy > Check state updater more than once in process loops >

[GitHub] [kafka] lucasbru opened a new pull request, #13017: KAFKA-14530: Check state updater more often

2022-12-19 Thread GitBox
lucasbru opened a new pull request, #13017: URL: https://github.com/apache/kafka/pull/13017 In the new state restoration code, the state updater needs to be checked regularly by the main thread to transfer ownership of tasks back to the main thread once the state of the task is restored. Th

[GitHub] [kafka] lucasbru commented on pull request #13017: KAFKA-14530: Check state updater more often

2022-12-19 Thread GitBox
lucasbru commented on PR #13017: URL: https://github.com/apache/kafka/pull/13017#issuecomment-1357663698 @cadonna could you please have a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] cadonna commented on a diff in pull request #12985: KAFKA-13602: Remove unwanted logging in RecordCollectorImpl.java

2022-12-19 Thread GitBox
cadonna commented on code in PR #12985: URL: https://github.com/apache/kafka/pull/12985#discussion_r1052198261 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java: ## @@ -159,7 +159,8 @@ public void send(final String topic,

[GitHub] [kafka] cadonna commented on pull request #12301: KAFKA-14003: Migrate streams module to JUnit 5 - Part 2

2022-12-19 Thread GitBox
cadonna commented on PR #12301: URL: https://github.com/apache/kafka/pull/12301#issuecomment-1357691852 @clolov @ijuma once the conflicts are resolved, we can merge this PR since all those tests do not contain EasyMock/PowerMock mocks which we agreed to migrate to Mockito before we migrate

[GitHub] [kafka] vamossagar12 commented on pull request #13014: KAFKA-14461: Move StoreQueryIntegrationTest to junit5 and fixing logic in a couple of tests for finding active streams

2022-12-19 Thread GitBox
vamossagar12 commented on PR #13014: URL: https://github.com/apache/kafka/pull/13014#issuecomment-1357757733 > Looks like there was a checkstyle failure. Would push a fix for that. Fixed the checkstyle issue. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] ijuma commented on pull request #13013: KAFKA-14466 Move ClassloaderAwareRemoteStorageManager to storage module

2022-12-19 Thread GitBox
ijuma commented on PR #13013: URL: https://github.com/apache/kafka/pull/13013#issuecomment-1357765376 Test failures are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [kafka] ijuma merged pull request #13013: KAFKA-14466 Move ClassloaderAwareRemoteStorageManager to storage module

2022-12-19 Thread GitBox
ijuma merged PR #13013: URL: https://github.com/apache/kafka/pull/13013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] ijuma commented on a diff in pull request #13016: KAFKA-14498: reduce the startup nodes to avoid timeout error

2022-12-19 Thread GitBox
ijuma commented on code in PR #13016: URL: https://github.com/apache/kafka/pull/13016#discussion_r1052279836 ## tools/src/test/java/org/apache/kafka/tools/MetadataQuorumCommandTest.java: ## @@ -53,12 +53,12 @@ public MetadataQuorumCommandTest(ClusterInstance cluster) { * 3

[GitHub] [kafka] ijuma commented on a diff in pull request #13007: KAFKA-14473: Move AbstractIndex to storage module

2022-12-19 Thread GitBox
ijuma commented on code in PR #13007: URL: https://github.com/apache/kafka/pull/13007#discussion_r1052315081 ## storage/src/main/java/org/apache/kafka/server/log/internals/AbstractIndex.java: ## @@ -0,0 +1,553 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] ijuma opened a new pull request, #13018: MINOR: Use `withClassLoader` in a couple more places

2022-12-19 Thread GitBox
ijuma opened a new pull request, #13018: URL: https://github.com/apache/kafka/pull/13018 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes)

[GitHub] [kafka] ijuma commented on pull request #13018: MINOR: Use `withClassLoader` in a couple more places

2022-12-19 Thread GitBox
ijuma commented on PR #13018: URL: https://github.com/apache/kafka/pull/13018#issuecomment-1357819169 cc @satishd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[jira] [Assigned] (KAFKA-14525) Move CLI tools from `core` to `tools` module

2022-12-19 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison reassigned KAFKA-14525: -- Assignee: Mickael Maison > Move CLI tools from `core` to `tools` module > ---

[GitHub] [kafka] cadonna commented on a diff in pull request #12801: KAFKA-14343: Upgrade tests for state updater

2022-12-19 Thread GitBox
cadonna commented on code in PR #12801: URL: https://github.com/apache/kafka/pull/12801#discussion_r1052298197 ## tests/kafkatest/tests/streams/streams_upgrade_test.py: ## @@ -211,23 +211,13 @@ def test_rolling_upgrade_with_2_bounces(self, from_version, to_version): el

[jira] [Created] (KAFKA-14531) KRaft controller time-based snapshots are too frequent

2022-12-19 Thread David Arthur (Jira)
David Arthur created KAFKA-14531: Summary: KRaft controller time-based snapshots are too frequent Key: KAFKA-14531 URL: https://issues.apache.org/jira/browse/KAFKA-14531 Project: Kafka Issue

[GitHub] [kafka] hachikuji merged pull request #12968: KAFKA-14417: Producer doesn't handle REQUEST_TIMED_OUT for InitProducerIdRequest, treats as fatal error -- Addressing the error server side

2022-12-19 Thread GitBox
hachikuji merged PR #12968: URL: https://github.com/apache/kafka/pull/12968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

[GitHub] [kafka] mumrah opened a new pull request, #13019: KAFKA-14531 Fix controller snapshot interval

2022-12-19 Thread GitBox
mumrah opened a new pull request, #13019: URL: https://github.com/apache/kafka/pull/13019 Previously, we were passing in the `metadata.log.max.snapshot.interval.ms` config value as nanoseconds to SnapshotGenerator. With the default value of 1 hour (360 milliseconds), this results in a s

[GitHub] [kafka] hachikuji merged pull request #12862: KAFKA-14264; New logic to discover group coordinator

2022-12-19 Thread GitBox
hachikuji merged PR #12862: URL: https://github.com/apache/kafka/pull/12862 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

[GitHub] [kafka] mumrah opened a new pull request, #13020: KAFKA-14529 Use the MetadataVersion from ClusterConfig in ZK ClusterTests

2022-12-19 Thread GitBox
mumrah opened a new pull request, #13020: URL: https://github.com/apache/kafka/pull/13020 Rather than using the MetadataVersion specified in IntegrationTestHarness, we should be using the MetadataVersion specified in the `@ClusterTest` annotation. This patch fixes the ZK setup for cluster t

[GitHub] [kafka] mumrah commented on pull request #13015: KAFKA-14529: set inter.broker.protocol.version to pass broker registration

2022-12-19 Thread GitBox
mumrah commented on PR #13015: URL: https://github.com/apache/kafka/pull/13015#issuecomment-1358030527 I opened a PR here https://github.com/apache/kafka/pull/13020 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] philipnee opened a new pull request, #13021: KAFKA-14468: Implement CommitRequestManager to manage the commit and autocommit requests

2022-12-19 Thread GitBox
philipnee opened a new pull request, #13021: URL: https://github.com/apache/kafka/pull/13021 In this issue, we implemented a CommitRequestManager to handle the commit request from the client and the autocommit state. When the client commits offsets, a "staged" commit will be added to a que

[GitHub] [kafka] rondagostino commented on a diff in pull request #12994: KAFKA-14457; Controller metrics should only expose committed data

2022-12-19 Thread GitBox
rondagostino commented on code in PR #12994: URL: https://github.com/apache/kafka/pull/12994#discussion_r1052461737 ## metadata/src/main/java/org/apache/kafka/controller/ControllerMetricsManager.java: ## @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] rondagostino commented on a diff in pull request #12994: KAFKA-14457; Controller metrics should only expose committed data

2022-12-19 Thread GitBox
rondagostino commented on code in PR #12994: URL: https://github.com/apache/kafka/pull/12994#discussion_r1052472398 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -871,6 +871,9 @@ public void handleCommit(BatchReader reader) {

[GitHub] [kafka] rondagostino commented on a diff in pull request #12994: KAFKA-14457; Controller metrics should only expose committed data

2022-12-19 Thread GitBox
rondagostino commented on code in PR #12994: URL: https://github.com/apache/kafka/pull/12994#discussion_r1052472398 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -871,6 +871,9 @@ public void handleCommit(BatchReader reader) {

[GitHub] [kafka] gharris1727 commented on pull request #11818: KAFKA-12558: Do not prematurely mutate partiton state and provide con…

2022-12-19 Thread GitBox
gharris1727 commented on PR #11818: URL: https://github.com/apache/kafka/pull/11818#issuecomment-1358073474 @emilnkrastev Thanks for the fix! Are you still interested in making this change? If so, I would suggest removing the configuration changes, as those would require a KIP. We ca

[GitHub] [kafka] rondagostino commented on a diff in pull request #12994: KAFKA-14457; Controller metrics should only expose committed data

2022-12-19 Thread GitBox
rondagostino commented on code in PR #12994: URL: https://github.com/apache/kafka/pull/12994#discussion_r1052506712 ## metadata/src/test/java/org/apache/kafka/controller/ControllerMetricsManagerTest.java: ## @@ -0,0 +1,283 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [kafka] bbejeck commented on pull request #13002: MINOR: No error with zero results state query

2022-12-19 Thread GitBox
bbejeck commented on PR #13002: URL: https://github.com/apache/kafka/pull/13002#issuecomment-1358082562 All failures unrelated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [kafka] bbejeck merged pull request #13002: MINOR: No error with zero results state query

2022-12-19 Thread GitBox
bbejeck merged PR #13002: URL: https://github.com/apache/kafka/pull/13002 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] bbejeck commented on pull request #13002: MINOR: No error with zero results state query

2022-12-19 Thread GitBox
bbejeck commented on PR #13002: URL: https://github.com/apache/kafka/pull/13002#issuecomment-1358084690 Merged #13002 into trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [kafka] emilnkrastev commented on pull request #11818: KAFKA-12558: Do not prematurely mutate partiton state and provide con…

2022-12-19 Thread GitBox
emilnkrastev commented on PR #11818: URL: https://github.com/apache/kafka/pull/11818#issuecomment-1358109982 @gharris1727 I'm still interested in the change and I will update the MR in the next couple of days. Thanks for the reply! -- This is an automated message from the Apache Gi

[jira] [Updated] (KAFKA-14527) Move `kafka.security` from `core` to separate module

2022-12-19 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-14527: Description: A possible module name would be `server-security`. We should consider moving `Standa

[GitHub] [kafka] ijuma commented on pull request #12996: KAFKA-14472: Move TransactionIndex and related to storage module

2022-12-19 Thread GitBox
ijuma commented on PR #12996: URL: https://github.com/apache/kafka/pull/12996#issuecomment-1358151502 Failures are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] lucasbru commented on a diff in pull request #12801: KAFKA-14343: Upgrade tests for state updater

2022-12-19 Thread GitBox
lucasbru commented on code in PR #12801: URL: https://github.com/apache/kafka/pull/12801#discussion_r1052560860 ## tests/kafkatest/tests/streams/streams_upgrade_test.py: ## @@ -293,7 +262,62 @@ def test_version_probing_upgrade(self): current_generation = self.do_rol

[GitHub] [kafka] mumrah merged pull request #13020: KAFKA-14529 Use the MetadataVersion from ClusterConfig in ZK ClusterTests

2022-12-19 Thread GitBox
mumrah merged PR #13020: URL: https://github.com/apache/kafka/pull/13020 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

[GitHub] [kafka] ijuma merged pull request #12996: KAFKA-14472: Move TransactionIndex and related to storage module

2022-12-19 Thread GitBox
ijuma merged PR #12996: URL: https://github.com/apache/kafka/pull/12996 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] mumrah commented on pull request #13019: KAFKA-14531 Fix controller snapshot interval

2022-12-19 Thread GitBox
mumrah commented on PR #13019: URL: https://github.com/apache/kafka/pull/13019#issuecomment-1358156533 @jsancio I added an integration test, PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] akhileshchg commented on a diff in pull request #13001: KAFKA-14446: code style improvements for broker-to-controller forwarding

2022-12-19 Thread GitBox
akhileshchg commented on code in PR #13001: URL: https://github.com/apache/kafka/pull/13001#discussion_r1052573317 ## core/src/main/scala/kafka/server/KafkaServer.scala: ## @@ -703,8 +703,8 @@ class KafkaServer( case None => info(s"Broker regi

[GitHub] [kafka] mjsax opened a new pull request, #13022: MINOR: fix expected version in streams upgrade test

2022-12-19 Thread GitBox
mjsax opened a new pull request, #13022: URL: https://github.com/apache/kafka/pull/13022 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing s

[GitHub] [kafka] mjsax commented on pull request #13022: MINOR: fix expected version in streams upgrade test

2022-12-19 Thread GitBox
mjsax commented on PR #13022: URL: https://github.com/apache/kafka/pull/13022#issuecomment-1358168697 System test run: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/5317/ -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] suhas-satish commented on a diff in pull request #13022: MINOR: fix expected version in streams upgrade test

2022-12-19 Thread GitBox
suhas-satish commented on code in PR #13022: URL: https://github.com/apache/kafka/pull/13022#discussion_r1052581567 ## tests/kafkatest/tests/streams/streams_upgrade_test.py: ## @@ -506,7 +508,7 @@ def do_rolling_bounce(self, processor, counter, current_generation):

[GitHub] [kafka] mjsax commented on a diff in pull request #13022: MINOR: fix expected version in streams upgrade test

2022-12-19 Thread GitBox
mjsax commented on code in PR #13022: URL: https://github.com/apache/kafka/pull/13022#discussion_r1052583424 ## tests/kafkatest/tests/streams/streams_upgrade_test.py: ## @@ -506,7 +508,7 @@ def do_rolling_bounce(self, processor, counter, current_generation):

[jira] [Updated] (KAFKA-14490) Consider using UncheckdIOException instead of IOException in the log layer

2022-12-19 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-14490: Description: IOException is a checked exception, which makes it difficult to use with lambdas. We

[GitHub] [kafka] lucasbru commented on a diff in pull request #13022: MINOR: fix expected version in streams upgrade test

2022-12-19 Thread GitBox
lucasbru commented on code in PR #13022: URL: https://github.com/apache/kafka/pull/13022#discussion_r1052605282 ## tests/kafkatest/tests/streams/streams_upgrade_test.py: ## @@ -489,6 +489,8 @@ def do_rolling_bounce(self, processor, counter, current_generation): first_o

[GitHub] [kafka] ijuma commented on pull request #13010: KAFKA-14475: Move TimeIndex/LazyIndex to storage module

2022-12-19 Thread GitBox
ijuma commented on PR #13010: URL: https://github.com/apache/kafka/pull/13010#issuecomment-1358245641 @satishd I pushed the `LazyIndex` commit too. Note that I haven't verified if all tests pass yet. I'll check the CI build later and fix any issues that come up. -- This is an automated m

[GitHub] [kafka] mumrah commented on a diff in pull request #13001: KAFKA-14446: code style improvements for broker-to-controller forwarding

2022-12-19 Thread GitBox
mumrah commented on code in PR #13001: URL: https://github.com/apache/kafka/pull/13001#discussion_r1052593947 ## core/src/main/scala/kafka/server/KafkaServer.scala: ## @@ -703,8 +703,8 @@ class KafkaServer( case None => info(s"Broker registrat

[GitHub] [kafka] lucasbru commented on a diff in pull request #12959: MINOR: Fix various memory leaks in tests

2022-12-19 Thread GitBox
lucasbru commented on code in PR #12959: URL: https://github.com/apache/kafka/pull/12959#discussion_r1052575316 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionStoreReceiveProcessorSupplierTest.java: ## @@ -130,6 +134,8 @@ public vo

[GitHub] [kafka] ijuma commented on a diff in pull request #13001: KAFKA-14446: code style improvements for broker-to-controller forwarding

2022-12-19 Thread GitBox
ijuma commented on code in PR #13001: URL: https://github.com/apache/kafka/pull/13001#discussion_r1052615536 ## core/src/main/scala/kafka/server/KafkaServer.scala: ## @@ -703,8 +703,8 @@ class KafkaServer( case None => info(s"Broker registrati

[jira] [Created] (KAFKA-14532) IllegalStateException when fetch failure happens after assignment changed

2022-12-19 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-14532: -- Summary: IllegalStateException when fetch failure happens after assignment changed Key: KAFKA-14532 URL: https://issues.apache.org/jira/browse/KAFKA-14532 Project

[jira] [Updated] (KAFKA-14532) IllegalStateException when fetch failure happens after assignment changed

2022-12-19 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-14532: --- Description: On master, all our long-running test jobs are running into this exception:   

[jira] [Updated] (KAFKA-14532) IllegalStateException when fetch failure happens after assignment changed

2022-12-19 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-14532: --- Description: On master, all our long-running test jobs are running into this exception:  {co

[GitHub] [kafka] jsancio commented on a diff in pull request #12994: KAFKA-14457; Controller metrics should only expose committed data

2022-12-19 Thread GitBox
jsancio commented on code in PR #12994: URL: https://github.com/apache/kafka/pull/12994#discussion_r1052646518 ## metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java: ## @@ -17,6 +17,11 @@ package org.apache.kafka.controller; +import java.util.Arr

[GitHub] [kafka] lucasbru opened a new pull request, #13023: KAFKA-14532: Correctly handle failed fetch when partitions unassigned

2022-12-19 Thread GitBox
lucasbru opened a new pull request, #13023: URL: https://github.com/apache/kafka/pull/13023 The failure handling code for fetches of `KafkaConsumer` could run into an `IllegalStateException` if a fetch response came back with a failure after the corresponding topic partition has alr

[GitHub] [kafka] lucasbru commented on pull request #13023: KAFKA-14532: Correctly handle failed fetch when partitions unassigned

2022-12-19 Thread GitBox
lucasbru commented on PR #13023: URL: https://github.com/apache/kafka/pull/13023#issuecomment-1358395338 @artemlivshits could you have a look? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] rondagostino commented on pull request #13018: MINOR: Use `withClassLoader` in a couple more places

2022-12-19 Thread GitBox
rondagostino commented on PR #13018: URL: https://github.com/apache/kafka/pull/13018#issuecomment-1358395379 Test failures are unrelated -- they either pass locally on this branch or they also fail locally on trunk (not sure why that would be, but still unrelated to this change). Merging

[GitHub] [kafka] ijuma commented on a diff in pull request #13001: KAFKA-14446: code style improvements for broker-to-controller forwarding

2022-12-19 Thread GitBox
ijuma commented on code in PR #13001: URL: https://github.com/apache/kafka/pull/13001#discussion_r1052651610 ## core/src/main/scala/kafka/server/KafkaServer.scala: ## @@ -703,8 +703,8 @@ class KafkaServer( case None => info(s"Broker registrati

[GitHub] [kafka] rondagostino merged pull request #13018: MINOR: Use `withClassLoader` in a couple more places

2022-12-19 Thread GitBox
rondagostino merged PR #13018: URL: https://github.com/apache/kafka/pull/13018 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

[jira] [Updated] (KAFKA-14532) IllegalStateException when fetch failure happens after assignment changed

2022-12-19 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-14532: --- Priority: Blocker (was: Major) > IllegalStateException when fetch failure happens after ass

[jira] [Updated] (KAFKA-14532) IllegalStateException when fetch failure happens after assignment changed

2022-12-19 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-14532: --- Labels: clients (was: ) > IllegalStateException when fetch failure happens after assignment

[jira] [Updated] (KAFKA-14532) IllegalStateException when fetch failure happens after assignment changed

2022-12-19 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-14532: --- Labels: (was: clients) > IllegalStateException when fetch failure happens after assignment

[GitHub] [kafka] akhileshchg commented on a diff in pull request #13001: KAFKA-14446: code style improvements for broker-to-controller forwarding

2022-12-19 Thread GitBox
akhileshchg commented on code in PR #13001: URL: https://github.com/apache/kafka/pull/13001#discussion_r1052655482 ## core/src/main/scala/kafka/server/KafkaServer.scala: ## @@ -703,8 +703,8 @@ class KafkaServer( case None => info(s"Broker regi

[GitHub] [kafka] jsancio commented on a diff in pull request #12994: KAFKA-14457; Controller metrics should only expose committed data

2022-12-19 Thread GitBox
jsancio commented on code in PR #12994: URL: https://github.com/apache/kafka/pull/12994#discussion_r1052656028 ## metadata/src/main/java/org/apache/kafka/controller/ControllerMetricsManager.java: ## @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] dajac commented on pull request #13023: KAFKA-14532: Correctly handle failed fetch when partitions unassigned

2022-12-19 Thread GitBox
dajac commented on PR #13023: URL: https://github.com/apache/kafka/pull/13023#issuecomment-1358415058 I can take a look at it tomorrow. We should mark it as blocker for 3.4. cc @ableegoldman -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] rondagostino commented on a diff in pull request #12994: KAFKA-14457; Controller metrics should only expose committed data

2022-12-19 Thread GitBox
rondagostino commented on code in PR #12994: URL: https://github.com/apache/kafka/pull/12994#discussion_r1052658922 ## metadata/src/main/java/org/apache/kafka/controller/ControllerMetricsManager.java: ## @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] akhileshchg commented on a diff in pull request #13001: KAFKA-14446: code style improvements for broker-to-controller forwarding

2022-12-19 Thread GitBox
akhileshchg commented on code in PR #13001: URL: https://github.com/apache/kafka/pull/13001#discussion_r1052660421 ## core/src/main/scala/kafka/server/KafkaServer.scala: ## @@ -703,8 +703,8 @@ class KafkaServer( case None => info(s"Broker regi

[GitHub] [kafka] junrao commented on a diff in pull request #13007: KAFKA-14473: Move AbstractIndex to storage module

2022-12-19 Thread GitBox
junrao commented on code in PR #13007: URL: https://github.com/apache/kafka/pull/13007#discussion_r1052673808 ## storage/src/main/java/org/apache/kafka/server/log/internals/AbstractIndex.java: ## @@ -0,0 +1,553 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [kafka] jsancio commented on a diff in pull request #12994: KAFKA-14457; Controller metrics should only expose committed data

2022-12-19 Thread GitBox
jsancio commented on code in PR #12994: URL: https://github.com/apache/kafka/pull/12994#discussion_r1052681560 ## metadata/src/main/java/org/apache/kafka/controller/ControllerMetricsManager.java: ## @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] jsancio commented on a diff in pull request #12994: KAFKA-14457; Controller metrics should only expose committed data

2022-12-19 Thread GitBox
jsancio commented on code in PR #12994: URL: https://github.com/apache/kafka/pull/12994#discussion_r1052687763 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -871,6 +871,9 @@ public void handleCommit(BatchReader reader) {

[GitHub] [kafka] jsancio commented on a diff in pull request #12994: KAFKA-14457; Controller metrics should only expose committed data

2022-12-19 Thread GitBox
jsancio commented on code in PR #12994: URL: https://github.com/apache/kafka/pull/12994#discussion_r105261 ## metadata/src/main/java/org/apache/kafka/controller/ControllerMetricsManager.java: ## @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

  1   2   >