lucasbru commented on code in PR #13022:
URL: https://github.com/apache/kafka/pull/13022#discussion_r1052605282
##########
tests/kafkatest/tests/streams/streams_upgrade_test.py:
##########
@@ -489,6 +489,8 @@ def do_rolling_bounce(self, processor, counter,
current_generation):
first_other_node = first_other_processor.node
second_other_node = second_other_processor.node
+ kafka_version_str = self.get_version_string(self.base_version_number)
Review Comment:
This will work, but make the check slightly weaker, since it will never
check for `SNAPSHOT`, even if I am currently on a snapshot version.
```suggestion
kafka_version_str = self.get_version_string(str(DEV_VERSION))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
