Mehrdad Karami created KAFKA-14431:
--
Summary: TopologyTestDriver instantiation raised NPE in JUnit5
Key: KAFKA-14431
URL: https://issues.apache.org/jira/browse/KAFKA-14431
Project: Kafka
Iss
vamossagar12 commented on code in PR #12802:
URL: https://github.com/apache/kafka/pull/12802#discussion_r1036857522
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##
@@ -1645,6 +1646,8 @@ private void startAndStop(Collection
[
https://issues.apache.org/jira/browse/KAFKA-14431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mehrdad Karami resolved KAFKA-14431.
Resolution: Fixed
Saw already fixed in truck branch
> TopologyTestDriver instantiation ra
omkreddy merged PR #12924:
URL: https://github.com/apache/kafka/pull/12924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
mimaison commented on code in PR #12913:
URL: https://github.com/apache/kafka/pull/12913#discussion_r1036885976
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -490,25 +575,19 @@ class KafkaServer(
private def initZkClient(time: Time): Unit = {
info(s"Conn
mimaison commented on PR #12895:
URL: https://github.com/apache/kafka/pull/12895#issuecomment-1333509571
Thanks for the update! I wonder if it would be better to have Connect and
Streams in separate PRs especially as it's likely going to be different people
reviewing them.
--
This is an
showuon commented on PR #12847:
URL: https://github.com/apache/kafka/pull/12847#issuecomment-1333528295
Sorry, was busy recently. I'll review it this week or next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
lucasbru commented on PR #12925:
URL: https://github.com/apache/kafka/pull/12925#issuecomment-1333536861
@cadonna Could you retrigger this? It is just one configuration (JDK 8 and
Scala 2.12) that has lots of tests timing out, so that looks more like a node
issue to me.
--
This is an aut
[
https://issues.apache.org/jira/browse/KAFKA-10582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641826#comment-17641826
]
sandeep commented on KAFKA-10582:
--
I'm having similar issue with latest version of kaf
cadonna opened a new pull request, #12931:
URL: https://github.com/apache/kafka/pull/12931
PR #12684 introduced a better format for timestamps in log messages.
Unfortunately, we missed that one of the modified log messages is used by a
system test for validation.
This PR adapts the s
cadonna commented on PR #12931:
URL: https://github.com/apache/kafka/pull/12931#issuecomment-1333724608
Locally the system test
`kafkatest.tests.streams.streams_upgrade_test.StreamsUpgradeTest.test_version_probing_upgrade`
passes with this PR.
--
This is an automated message from the Apa
cadonna commented on PR #12925:
URL: https://github.com/apache/kafka/pull/12925#issuecomment-1333730811
I've already retriggered it once yesterday but I can retrigger again now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
ijuma commented on PR #12912:
URL: https://github.com/apache/kafka/pull/12912#issuecomment-1333773568
I don't think most of these are actual compiler warnings are they? They seem
like lint type warnings. It would be good to clarify in the PR description.
--
This is an automated message fr
rajinisivaram commented on code in PR #12914:
URL: https://github.com/apache/kafka/pull/12914#discussion_r1037112256
##
clients/src/main/resources/common/message/ConsumerProtocolSubscription.json:
##
@@ -21,7 +21,10 @@
// The current implementation assumes that future version
ijuma commented on PR #12280:
URL: https://github.com/apache/kafka/pull/12280#issuecomment-1333777333
There is quite a lot of unit test flakiness, but it doesn't seem related to
this PR (it's happening in trunk too).
--
This is an automated message from the Apache Git Service.
To respond
ijuma merged PR #12280:
URL: https://github.com/apache/kafka/pull/12280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
reta commented on code in PR #12898:
URL: https://github.com/apache/kafka/pull/12898#discussion_r1037130900
##
bin/kafka-run-class.sh:
##
@@ -212,7 +212,7 @@ fi
# JMX port to use
if [ $JMX_PORT ]; then
- KAFKA_JMX_OPTS="$KAFKA_JMX_OPTS
-Dcom.sun.management.jmxremote.port=
[
https://issues.apache.org/jira/browse/KAFKA-14425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-14425:
Summary: The Kafka protocol should support nullable structs (was:
Automated protocol should suppo
C0urante commented on code in PR #12898:
URL: https://github.com/apache/kafka/pull/12898#discussion_r1037153804
##
bin/kafka-run-class.sh:
##
@@ -212,7 +212,7 @@ fi
# JMX port to use
if [ $JMX_PORT ]; then
- KAFKA_JMX_OPTS="$KAFKA_JMX_OPTS
-Dcom.sun.management.jmxremote.p
dajac opened a new pull request, #12932:
URL: https://github.com/apache/kafka/pull/12932
WIP
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgr
[
https://issues.apache.org/jira/browse/KAFKA-14366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641951#comment-17641951
]
Chetan commented on KAFKA-14366:
Hi [~pnee],
# We have created a custom Listener from
a364176773 commented on code in PR #12898:
URL: https://github.com/apache/kafka/pull/12898#discussion_r1037170338
##
bin/kafka-run-class.sh:
##
@@ -212,7 +212,7 @@ fi
# JMX port to use
if [ $JMX_PORT ]; then
- KAFKA_JMX_OPTS="$KAFKA_JMX_OPTS
-Dcom.sun.management.jmxremote
dajac commented on code in PR #12848:
URL: https://github.com/apache/kafka/pull/12848#discussion_r1037177201
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -1764,42 +1764,38 @@ class KafkaApis(val requestChannel: RequestChannel,
})
}
- def handleHeartbeatR
dajac commented on code in PR #12848:
URL: https://github.com/apache/kafka/pull/12848#discussion_r1037178096
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -1764,42 +1764,38 @@ class KafkaApis(val requestChannel: RequestChannel,
})
}
- def handleHeartbeatR
divijvaidya commented on PR #12821:
URL: https://github.com/apache/kafka/pull/12821#issuecomment-1333861957
@clolov please fix the checkstyle failures in this PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
andymg3 commented on code in PR #12892:
URL: https://github.com/apache/kafka/pull/12892#discussion_r1037170517
##
metadata/src/main/java/org/apache/kafka/metadata/placement/StripedReplicaPlacer.java:
##
@@ -440,6 +441,6 @@ public List> place(
for (int partition = 0; par
[
https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-14133:
-
Description:
{color:#de350b}There are tests which use both PowerMock and EasyMock. I have
put t
mimaison merged PR #12343:
URL: https://github.com/apache/kafka/pull/12343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
divijvaidya opened a new pull request, #12933:
URL: https://github.com/apache/kafka/pull/12933
In the selector code path, we record some values for some sensors which do
not have any metric associated with them that requires quota. Yet, a redundant
check for quotas is made which consumes ~0
andymg3 commented on PR #12892:
URL: https://github.com/apache/kafka/pull/12892#issuecomment-1333944951
> Thanks for the changes @andymg3 .
>
> Should we also improve the `PartitionRegistration` type to use a
`PartitionAssignment` instead of `int[] replicas`?
Thanks for the rev
a364176773 commented on PR #12898:
URL: https://github.com/apache/kafka/pull/12898#issuecomment-1333973530
> @a364176773 Thank you for your understanding, and thank you for the fix!
LGTM
>
> Tested locally via Docker container; with this fix, all that was necessary
was to set the `$J
lucasbru commented on PR #12925:
URL: https://github.com/apache/kafka/pull/12925#issuecomment-1333981153
Tests look fine, now.
However, in the meantime I have found the cause of the leak (or at least
one) in trunk. We could consider waiting for this fix to go in and not revert
this.
Lucas Brutschy created KAFKA-14432:
--
Summary: RocksDBStore relies on finalizers to not leak memory
Key: KAFKA-14432
URL: https://issues.apache.org/jira/browse/KAFKA-14432
Project: Kafka
Issu
[
https://issues.apache.org/jira/browse/KAFKA-14432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy updated KAFKA-14432:
---
Description:
Relying on finalizers in RocksDB has been deprecated for a long time, and
star
C0urante commented on code in PR #12366:
URL: https://github.com/apache/kafka/pull/12366#discussion_r1037300881
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java:
##
@@ -185,11 +193,52 @@ public ConfigDef config() {
return Mirror
C0urante commented on PR #12366:
URL: https://github.com/apache/kafka/pull/12366#issuecomment-1333998703
Thanks @mimaison. I've rebased and addressed your comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
C0urante commented on PR #12355:
URL: https://github.com/apache/kafka/pull/12355#issuecomment-1334019842
Thanks Mickael
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
C0urante merged PR #12355:
URL: https://github.com/apache/kafka/pull/12355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
gharris1727 commented on code in PR #12802:
URL: https://github.com/apache/kafka/pull/12802#discussion_r1037326575
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##
@@ -1645,6 +1646,8 @@ private void startAndStop(Collection>
lucasbru opened a new pull request, #12935:
URL: https://github.com/apache/kafka/pull/12935
RocksDBStore relied on finalizers to not leak memory (and leaked memory
after the upgrade to RocksDB 7).
The problem was that every call to `options.statistics` creates a new
wrapper object th
[
https://issues.apache.org/jira/browse/KAFKA-14366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642049#comment-17642049
]
Philip Nee commented on KAFKA-14366:
Hey [~Chetu]
Any specific reason why you are
lucasbru commented on PR #12355:
URL: https://github.com/apache/kafka/pull/12355#issuecomment-1334068328
Are you sure this change compiles? Doesn't build for me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
hachikuji commented on PR #12837:
URL: https://github.com/apache/kafka/pull/12837#issuecomment-1334076245
The test failures in the latest build are showing an NPE:
```
java.lang.NullPointerException: Cannot invoke
"kafka.raft.KafkaRaftManager.client()" because the return value of
"kaf
ijuma commented on code in PR #12837:
URL: https://github.com/apache/kafka/pull/12837#discussion_r1037363599
##
core/src/main/scala/kafka/server/JointServer.scala:
##
@@ -0,0 +1,246 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor li
cmccabe merged PR #12930:
URL: https://github.com/apache/kafka/pull/12930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
gharris1727 opened a new pull request, #12936:
URL: https://github.com/apache/kafka/pull/12936
Signed-off-by: Greg Harris
Split off from #12895 to target only Streams packages.
There are currently no descriptions of packages in the javadocs, which can
be intimidating to new us
gharris1727 opened a new pull request, #12937:
URL: https://github.com/apache/kafka/pull/12937
Signed-off-by: Greg Harris
Split off from #12895 to target only Connect packages.
There are currently no descriptions of packages in the javadocs, which can
be intimidating to new us
[
https://issues.apache.org/jira/browse/KAFKA-14432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-14432:
Component/s: streams
> RocksDBStore relies on finalizers to not leak memory
>
gharris1727 commented on PR #12895:
URL: https://github.com/apache/kafka/pull/12895#issuecomment-1334084826
@mimaison I had some wishful thinking that putting everything together would
mean that we're more motivated to get everything in, but I agree that the
packages are logically separate
alexec commented on PR #12697:
URL: https://github.com/apache/kafka/pull/12697#issuecomment-1334085360
We ended up building our own tool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
alexec closed pull request #12697: KAFKA-2526 : fix deserializer/serializer
from properties for console …
URL: https://github.com/apache/kafka/pull/12697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mimaison opened a new pull request, #12938:
URL: https://github.com/apache/kafka/pull/12938
Fix compilation failure introduced in
https://github.com/apache/kafka/pull/12355
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verif
[
https://issues.apache.org/jira/browse/KAFKA-12679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642054#comment-17642054
]
Matthias J. Sax commented on KAFKA-12679:
-
[~lbrutschy] Can you link the corresp
cmccabe commented on PR #12837:
URL: https://github.com/apache/kafka/pull/12837#issuecomment-1334090428
> The test failures in the latest build are showing an NPE:
Yes. raftManager is initialized in `JointServer#start` so
`BrokerServer#raftManager` needs to be a function, not a val.
cmccabe commented on code in PR #12837:
URL: https://github.com/apache/kafka/pull/12837#discussion_r1037371708
##
core/src/main/scala/kafka/server/JointServer.scala:
##
@@ -0,0 +1,246 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor
mimaison commented on code in PR #12366:
URL: https://github.com/apache/kafka/pull/12366#discussion_r1037373964
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java:
##
@@ -185,11 +193,52 @@ public ConfigDef config() {
return Mirror
mjsax commented on PR #12934:
URL: https://github.com/apache/kafka/pull/12934#issuecomment-1334095663
Thanks for the PR -- what about the corresponding consumer/producer metrics
that got added?
cf
https://cwiki.apache.org/confluence/display/KAFKA/KIP-761%3A+Add+Total+Blocked+Time+Met
[
https://issues.apache.org/jira/browse/KAFKA-12635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642058#comment-17642058
]
Mickael Maison commented on KAFKA-12635:
[~chetan-pandey] Have these negative of
Colin McCabe created KAFKA-14433:
Summary: Clear all yammer metrics when test harnesses clean up
Key: KAFKA-14433
URL: https://issues.apache.org/jira/browse/KAFKA-14433
Project: Kafka
Issue T
vamossagar12 commented on code in PR #12802:
URL: https://github.com/apache/kafka/pull/12802#discussion_r1037397259
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##
@@ -1645,6 +1646,8 @@ private void startAndStop(Collection
dajac opened a new pull request, #12939:
URL: https://github.com/apache/kafka/pull/12939
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing s
[
https://issues.apache.org/jira/browse/KAFKA-14299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-14299:
Component/s: streams
> Benchmark and stabilize state updater
> ---
[
https://issues.apache.org/jira/browse/KAFKA-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-14412:
Labels: kip (was: )
> Transactional semantics for StateStores
> -
jsancio merged PR #12929:
URL: https://github.com/apache/kafka/pull/12929
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
divijvaidya opened a new pull request, #12940:
URL: https://github.com/apache/kafka/pull/12940
When we want to add a sensor to `Metrics.java`, we synchronize the entire
method. However both, `sensors` and `childrenSensors` are concurrent hash maps
and full method synchronization is not requ
hachikuji commented on code in PR #12837:
URL: https://github.com/apache/kafka/pull/12837#discussion_r1037431796
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -66,14 +67,14 @@ class BrokerSnapshotWriterBuilder(raftClient:
RaftClient[ApiMessageAndVersion])
* A
C0urante commented on PR #12355:
URL: https://github.com/apache/kafka/pull/12355#issuecomment-1334169937
@lucasbru There's a compilation failure introduced by a change that landed
on trunk between when the last commit for this PR was filed, and when it was
merged. There is a fix PR already
C0urante commented on PR #12898:
URL: https://github.com/apache/kafka/pull/12898#issuecomment-1334172537
Update: trunk is currently failing to build with a compilation error; as
soon as a fix is merged and stabilized, I'll re-run the CI build on this one
and merge if there don't appear to b
hachikuji commented on code in PR #12915:
URL: https://github.com/apache/kafka/pull/12915#discussion_r1036589456
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java:
##
@@ -1678,6 +1678,39 @@ public void testMultipleAddPartitionsPerFo
C0urante opened a new pull request, #12941:
URL: https://github.com/apache/kafka/pull/12941
[Jira](https://issues.apache.org/jira/browse/KAFKA-13709)
Rebased on top of https://github.com/apache/kafka/pull/12938 to fix
recently-introduced compilation failures on trunk.
--
This is an
[
https://issues.apache.org/jira/browse/KAFKA-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-13709:
--
Description:
Add documentation for the support for exactly-once source connectors introduced
[
https://issues.apache.org/jira/browse/KAFKA-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-13709:
--
Description:
Add documentation for the support for exactly-once source connectors introduced
[
https://issues.apache.org/jira/browse/KAFKA-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642115#comment-17642115
]
Chris Egerton commented on KAFKA-13709:
---
I've decided to keep the rollback instruc
C0urante commented on PR #12941:
URL: https://github.com/apache/kafka/pull/12941#issuecomment-1334192798
@joel-hamill would you be interested in taking a look at this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
[
https://issues.apache.org/jira/browse/KAFKA-14433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-14433:
-
Attachment: image-2022-12-01-13-53-57-886.png
> Clear all yammer metrics when test harnesses cle
[
https://issues.apache.org/jira/browse/KAFKA-14433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-14433:
-
Attachment: image-2022-12-01-13-55-35-488.png
> Clear all yammer metrics when test harnesses cle
[
https://issues.apache.org/jira/browse/KAFKA-14433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642123#comment-17642123
]
David Arthur commented on KAFKA-14433:
--
I did some investigation on this. Running {
dajac merged PR #12848:
URL: https://github.com/apache/kafka/pull/12848
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
jsancio commented on code in PR #12892:
URL: https://github.com/apache/kafka/pull/12892#discussion_r1037457258
##
metadata/src/test/java/org/apache/kafka/controller/ClusterControlManagerTest.java:
##
@@ -407,13 +405,8 @@ public void testPlaceReplicas(int numUsableBrokers) throws
andymg3 commented on code in PR #12892:
URL: https://github.com/apache/kafka/pull/12892#discussion_r1037473300
##
metadata/src/test/java/org/apache/kafka/controller/ClusterControlManagerTest.java:
##
@@ -407,13 +405,8 @@ public void testPlaceReplicas(int numUsableBrokers) throws
andymg3 commented on code in PR #12892:
URL: https://github.com/apache/kafka/pull/12892#discussion_r1037475316
##
metadata/src/test/java/org/apache/kafka/controller/ClusterControlManagerTest.java:
##
@@ -407,13 +405,8 @@ public void testPlaceReplicas(int numUsableBrokers) throws
andymg3 commented on code in PR #12892:
URL: https://github.com/apache/kafka/pull/12892#discussion_r1037475316
##
metadata/src/test/java/org/apache/kafka/controller/ClusterControlManagerTest.java:
##
@@ -407,13 +405,8 @@ public void testPlaceReplicas(int numUsableBrokers) throws
andymg3 commented on code in PR #12892:
URL: https://github.com/apache/kafka/pull/12892#discussion_r1037477576
##
metadata/src/test/java/org/apache/kafka/metadata/placement/StripedReplicaPlacerTest.java:
##
@@ -95,12 +94,7 @@ private List> place(
PlacementSpec placement
andymg3 commented on code in PR #12892:
URL: https://github.com/apache/kafka/pull/12892#discussion_r1037481276
##
metadata/src/main/java/org/apache/kafka/metadata/placement/TopicAssignment.java:
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
[
https://issues.apache.org/jira/browse/KAFKA-14374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642135#comment-17642135
]
Matthias J. Sax commented on KAFKA-14374:
-
Thanks for the details. – It would be
andymg3 commented on code in PR #12892:
URL: https://github.com/apache/kafka/pull/12892#discussion_r1037485087
##
metadata/src/test/java/org/apache/kafka/metadata/placement/PartitionAssignmentTest.java:
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
philipnee commented on code in PR #12862:
URL: https://github.com/apache/kafka/pull/12862#discussion_r1037502209
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java:
##
@@ -145,19 +166,46 @@ void runOnce() {
this.infligh
mumrah opened a new pull request, #12942:
URL: https://github.com/apache/kafka/pull/12942
The anonymous functions we create in classes like Partition will end up
getting held by the singleton Yammer metrics registry.
```
newGauge("UnderReplicated", () => if (isUnderReplicated) 1
mumrah commented on PR #12942:
URL: https://github.com/apache/kafka/pull/12942#issuecomment-1334405072
Prior to this patch, I was seeing several KafkaRaftClient (and
KafkaRaftManager) objects hanging around in memory after running the test suite
for 30 minutes or so.
https://user-im
hachikuji commented on code in PR #12942:
URL: https://github.com/apache/kafka/pull/12942#discussion_r1037533828
##
core/src/test/scala/integration/kafka/server/QuorumTestHarness.scala:
##
@@ -386,6 +386,7 @@ abstract class QuorumTestHarness extends Logging {
def tearDown():
gmcquillan commented on PR #8066:
URL: https://github.com/apache/kafka/pull/8066#issuecomment-1334412501
Hey -- has there been any movement on this? Is there anything I can do to
help push this forward? This is a constant source of frustration for my teams.
--
This is an automated message
mumrah commented on code in PR #12928:
URL: https://github.com/apache/kafka/pull/12928#discussion_r1037537646
##
metadata/src/main/java/org/apache/kafka/migration/MigrationRecoveryState.java:
##
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
pprovenzano commented on code in PR #12896:
URL: https://github.com/apache/kafka/pull/12896#discussion_r1037538569
##
core/src/test/scala/integration/kafka/api/EndToEndAuthorizationTest.scala:
##
@@ -36,15 +37,33 @@ import
org.apache.kafka.common.errors.{GroupAuthorizationExcep
hachikuji commented on code in PR #12942:
URL: https://github.com/apache/kafka/pull/12942#discussion_r1037533828
##
core/src/test/scala/integration/kafka/server/QuorumTestHarness.scala:
##
@@ -386,6 +386,7 @@ abstract class QuorumTestHarness extends Logging {
def tearDown():
mumrah commented on code in PR #12928:
URL: https://github.com/apache/kafka/pull/12928#discussion_r1037541558
##
metadata/src/main/java/org/apache/kafka/migration/MigrationRecoveryState.java:
##
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
hachikuji commented on code in PR #12942:
URL: https://github.com/apache/kafka/pull/12942#discussion_r1037543086
##
core/src/test/scala/integration/kafka/server/QuorumTestHarness.scala:
##
@@ -386,6 +386,7 @@ abstract class QuorumTestHarness extends Logging {
def tearDown():
vvcephei commented on code in PR #12803:
URL: https://github.com/apache/kafka/pull/12803#discussion_r1037554572
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsMetadataState.java:
##
@@ -459,12 +461,23 @@ private List
rebuildMetadataForSingleTopolog
hachikuji merged PR #12938:
URL: https://github.com/apache/kafka/pull/12938
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apach
jsancio commented on code in PR #12892:
URL: https://github.com/apache/kafka/pull/12892#discussion_r1037576847
##
metadata/src/test/java/org/apache/kafka/metadata/placement/PartitionAssignmentTest.java:
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
jsancio commented on code in PR #12892:
URL: https://github.com/apache/kafka/pull/12892#discussion_r1037576847
##
metadata/src/test/java/org/apache/kafka/metadata/placement/PartitionAssignmentTest.java:
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
1 - 100 of 127 matches
Mail list logo
