[GitHub] [kafka] hachikuji commented on a diff in pull request #12837: MINOR: extract jointly owned parts of BrokerServer and ControllerServer

[GitBox]

hachikuji commented on code in PR #12837:
URL: https://github.com/apache/kafka/pull/12837#discussion_r1037431796


##########
core/src/main/scala/kafka/server/BrokerServer.scala:
##########
@@ -66,14 +67,14 @@ class BrokerSnapshotWriterBuilder(raftClient: 
RaftClient[ApiMessageAndVersion])
  * A Kafka broker that runs in KRaft (Kafka Raft) mode.
  */
 class BrokerServer(
-  val jointServer: JointServer,
+  val sharedServer: SharedServer,
   val initialOfflineDirs: Seq[String],
 ) extends KafkaBroker {
-  val threadNamePrefix = jointServer.threadNamePrefix
-  val config = jointServer.config
-  val time = jointServer.time
-  val metrics = jointServer.metrics
-  val raftManager = jointServer.raftManager
+  val threadNamePrefix = sharedServer.threadNamePrefix
+  val config = sharedServer.config
+  val time = sharedServer.time
+  val metrics = sharedServer.metrics
+  def raftManager: KafkaRaftManager[ApiMessageAndVersion] = 
sharedServer.raftManager

Review Comment:
   Can you add a comment here why this needs to be a `def`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org