[GitHub] [kafka] sudeshwasnik commented on a diff in pull request #12784: MINOR: Do not perform prodcuerCommit on serializationError when trying offsetWriter flush

sudeshwasnik commented on code in PR #12784: URL: https://github.com/apache/kafka/pull/12784#discussion_r1006513264 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ExactlyOnceWorkerSourceTask.java: ## @@ -280,15 +282,16 @@ private void commitTransaction() {

[jira] [Commented] (KAFKA-14337) topic name with "." cannot be created after deletion

[ https://issues.apache.org/jira/browse/KAFKA-14337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624931#comment-17624931 ] thanhnd96 commented on KAFKA-14337: --- Hi admin, Tks you for fixed , after i change cod

[jira] [Commented] (KAFKA-13419) sync group failed with rebalanceInProgress error might cause out-of-date ownedPartition in Cooperative protocol

[ https://issues.apache.org/jira/browse/KAFKA-13419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624934#comment-17624934 ] A. Sophie Blee-Goldman commented on KAFKA-13419: Cool, thanks for confir

[jira] [Assigned] (KAFKA-10149) Do not prevent automatic preferred election when reassignment in progress

[ https://issues.apache.org/jira/browse/KAFKA-10149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton reassigned KAFKA-10149: - Assignee: Shenglong Zhang > Do not prevent automatic preferred election when reassignme

[jira] [Comment Edited] (KAFKA-13419) sync group failed with rebalanceInProgress error might cause out-of-date ownedPartition in Cooperative protocol

[ https://issues.apache.org/jira/browse/KAFKA-13419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624934#comment-17624934 ] A. Sophie Blee-Goldman edited comment on KAFKA-13419 at 10/27/22 7:56 AM:

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12781: KAFKA-14132; Replace EasyMock with Mockito in KafkaBasedLogTest

mdedetrich commented on code in PR #12781: URL: https://github.com/apache/kafka/pull/12781#discussion_r1006531902 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/KafkaBasedLogTest.java: ## @@ -135,8 +161,7 @@ public class KafkaBasedLogTest { @SuppressWarnings

[GitHub] [kafka] sudeshwasnik commented on a diff in pull request #12784: MINOR: Do not perform prodcuerCommit on serializationError when trying offsetWriter flush

sudeshwasnik commented on code in PR #12784: URL: https://github.com/apache/kafka/pull/12784#discussion_r1006513264 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ExactlyOnceWorkerSourceTask.java: ## @@ -280,15 +282,16 @@ private void commitTransaction() {

[GitHub] [kafka] shirenchuang opened a new pull request, #12793: [KAFKA-14328]: KafkaAdminClient should be Changing the exception level …

shirenchuang opened a new pull request, #12793: URL: https://github.com/apache/kafka/pull/12793 [ISSUE: KAFKA-14328](https://issues.apache.org/jira/browse/KAFKA-14328) PR： return the real error while we return the timeout error In the Pending Call timeout scenario, record the

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12781: KAFKA-14132; Replace EasyMock with Mockito in KafkaBasedLogTest

mdedetrich commented on code in PR #12781: URL: https://github.com/apache/kafka/pull/12781#discussion_r1006543034 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/KafkaBasedLogTest.java: ## @@ -547,32 +538,18 @@ public void testReadEndOffsetsUsingAdminThatFailsWit

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12781: KAFKA-14132; Replace EasyMock with Mockito in KafkaBasedLogTest

mdedetrich commented on code in PR #12781: URL: https://github.com/apache/kafka/pull/12781#discussion_r1006543034 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/KafkaBasedLogTest.java: ## @@ -547,32 +538,18 @@ public void testReadEndOffsetsUsingAdminThatFailsWit

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12781: KAFKA-14132; Replace EasyMock with Mockito in KafkaBasedLogTest

mdedetrich commented on code in PR #12781: URL: https://github.com/apache/kafka/pull/12781#discussion_r1006543034 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/KafkaBasedLogTest.java: ## @@ -547,32 +538,18 @@ public void testReadEndOffsetsUsingAdminThatFailsWit

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12781: KAFKA-14132; Replace EasyMock with Mockito in KafkaBasedLogTest

mdedetrich commented on code in PR #12781: URL: https://github.com/apache/kafka/pull/12781#discussion_r1006543034 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/KafkaBasedLogTest.java: ## @@ -547,32 +538,18 @@ public void testReadEndOffsetsUsingAdminThatFailsWit

[jira] [Commented] (KAFKA-14328) KafkaAdminClient should be Changing the exception level When an exception occurs

[ https://issues.apache.org/jira/browse/KAFKA-14328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624947#comment-17624947 ] shizhenzhen commented on KAFKA-14328: - PR:  https://github.com/apache/kafka/pull/127

[jira] [Commented] (KAFKA-14016) Revoke more partitions than expected in Cooperative rebalance

[ https://issues.apache.org/jira/browse/KAFKA-14016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624948#comment-17624948 ] A. Sophie Blee-Goldman commented on KAFKA-14016: Hey, I realize there's

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12781: KAFKA-14132; Replace EasyMock with Mockito in KafkaBasedLogTest

mdedetrich commented on code in PR #12781: URL: https://github.com/apache/kafka/pull/12781#discussion_r1006531902 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/KafkaBasedLogTest.java: ## @@ -135,8 +161,7 @@ public class KafkaBasedLogTest { @SuppressWarnings

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12781: KAFKA-14132; Replace EasyMock with Mockito in KafkaBasedLogTest

mdedetrich commented on code in PR #12781: URL: https://github.com/apache/kafka/pull/12781#discussion_r1006560892 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/KafkaBasedLogTest.java: ## @@ -547,32 +538,18 @@ public void testReadEndOffsetsUsingAdminThatFailsWit

[GitHub] [kafka] C0urante commented on pull request #12784: MINOR: Do not perform prodcuerCommit on serializationError when trying offsetWriter flush

C0urante commented on PR #12784: URL: https://github.com/apache/kafka/pull/12784#issuecomment-1293192830 Thanks @sudeshwasnik, good catch! Would you mind filing a Jira for this so that others who encounter the same bug can track its status and fixed versions? Regarding the actual chan

[GitHub] [kafka] shekhar-rajak commented on pull request #12777: Replace EasyMock and PowerMock with Mockito - TimeOrderedWindowStoreTest

shekhar-rajak commented on PR #12777: URL: https://github.com/apache/kafka/pull/12777#issuecomment-1293213497 @divijvaidya Please have a look now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12781: KAFKA-14132; Replace EasyMock with Mockito in KafkaBasedLogTest

mdedetrich commented on code in PR #12781: URL: https://github.com/apache/kafka/pull/12781#discussion_r1006616025 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/KafkaBasedLogTest.java: ## @@ -547,32 +538,18 @@ public void testReadEndOffsetsUsingAdminThatFailsWit

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12781: KAFKA-14132; Replace EasyMock with Mockito in KafkaBasedLogTest

mdedetrich commented on code in PR #12781: URL: https://github.com/apache/kafka/pull/12781#discussion_r1006616339 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/KafkaBasedLogTest.java: ## @@ -135,8 +161,7 @@ public class KafkaBasedLogTest { @SuppressWarnings

[GitHub] [kafka] C0urante commented on a diff in pull request #12789: KAFKA-13989: Errors while evaluating connector type should return UNKNOWN

C0urante commented on code in PR #12789: URL: https://github.com/apache/kafka/pull/12789#discussion_r1006589610 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java: ## @@ -700,6 +707,9 @@ public ConnectorType connectorTypeForClass(String connCl

[GitHub] [kafka] C0urante commented on a diff in pull request #12789: KAFKA-13989: Errors while evaluating connector type should return UNKNOWN

C0urante commented on code in PR #12789: URL: https://github.com/apache/kafka/pull/12789#discussion_r1006588134 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java: ## @@ -691,7 +691,14 @@ protected Connector getConnector(String connType) {

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12781: KAFKA-14132; Replace EasyMock with Mockito in KafkaBasedLogTest

mdedetrich commented on code in PR #12781: URL: https://github.com/apache/kafka/pull/12781#discussion_r1006616339 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/KafkaBasedLogTest.java: ## @@ -135,8 +161,7 @@ public class KafkaBasedLogTest { @SuppressWarnings

[GitHub] [kafka] mdedetrich commented on pull request #12781: KAFKA-14132; Replace EasyMock with Mockito in KafkaBasedLogTest

mdedetrich commented on PR #12781: URL: https://github.com/apache/kafka/pull/12781#issuecomment-1293252697 @C0urante @gharris1727 So now that I understand what the `expectStart` and `expectStop` was meant to do, I have both fixed this issue as well as the `initializer` being of the

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12781: KAFKA-14132; Replace EasyMock with Mockito in KafkaBasedLogTest

mdedetrich commented on code in PR #12781: URL: https://github.com/apache/kafka/pull/12781#discussion_r1006635305 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/KafkaBasedLogTest.java: ## @@ -115,10 +115,32 @@ public class KafkaBasedLogTest { private static

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12777: Replace EasyMock and PowerMock with Mockito - TimeOrderedWindowStoreTest

divijvaidya commented on code in PR #12777: URL: https://github.com/apache/kafka/pull/12777#discussion_r1006648492 ## streams/src/test/java/org/apache/kafka/streams/state/internals/TimeOrderedWindowStoreTest.java: ## @@ -1166,58 +1164,43 @@ public void shouldNotThrowInvalidBack

[jira] [Commented] (KAFKA-14016) Revoke more partitions than expected in Cooperative rebalance

[ https://issues.apache.org/jira/browse/KAFKA-14016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625003#comment-17625003 ] Luke Chen commented on KAFKA-14016: --- [~ableegoldman] , thanks for the comment. Yes, we

[GitHub] [kafka] C0urante commented on a diff in pull request #12791: KAFKA-14338: Use MockTime in RetryUtilTest to eliminate flakiness

C0urante commented on code in PR #12791: URL: https://github.com/apache/kafka/pull/12791#discussion_r100618 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/RetryUtilTest.java: ## @@ -50,16 +52,15 @@ public void setUp() throws Exception { @Test public

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12725: KAFKA-14132; Replace EasyMock with Mockito ConnectorsResourceTest

mdedetrich commented on code in PR #12725: URL: https://github.com/apache/kafka/pull/12725#discussion_r1006723063 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResourceTest.java: ## @@ -153,19 +157,23 @@ public class ConnectorsResourc

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #12784: MINOR: Do not perform prodcuerCommit on serializationError when trying offsetWriter flush

vamossagar12 commented on code in PR #12784: URL: https://github.com/apache/kafka/pull/12784#discussion_r1006758803 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ExactlyOnceWorkerSourceTask.java: ## @@ -280,16 +280,18 @@ private void commitTransaction() {

[GitHub] [kafka] vamossagar12 commented on pull request #12784: MINOR: Do not perform prodcuerCommit on serializationError when trying offsetWriter flush

vamossagar12 commented on PR #12784: URL: https://github.com/apache/kafka/pull/12784#issuecomment-1293401822 Thanks @sudeshwasnik . This is a nice catch. I have requested couple of cosmetic changes. And I agree with Chris, might need to increase the test coverage. Currently the only test pa

[GitHub] [kafka] sudeshwasnik commented on a diff in pull request #12784: MINOR: Do not perform prodcuerCommit on serializationError when trying offsetWriter flush

sudeshwasnik commented on code in PR #12784: URL: https://github.com/apache/kafka/pull/12784#discussion_r1006763859 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ExactlyOnceWorkerSourceTask.java: ## @@ -280,16 +280,18 @@ private void commitTransaction() {

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #12784: MINOR: Do not perform prodcuerCommit on serializationError when trying offsetWriter flush

vamossagar12 commented on code in PR #12784: URL: https://github.com/apache/kafka/pull/12784#discussion_r1006767287 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ExactlyOnceWorkerSourceTask.java: ## @@ -280,16 +280,18 @@ private void commitTransaction() {

[GitHub] [kafka] sudeshwasnik commented on a diff in pull request #12784: MINOR: Do not perform prodcuerCommit on serializationError when trying offsetWriter flush

sudeshwasnik commented on code in PR #12784: URL: https://github.com/apache/kafka/pull/12784#discussion_r1006768071 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ExactlyOnceWorkerSourceTask.java: ## @@ -280,16 +280,18 @@ private void commitTransaction() {

[GitHub] [kafka] sudeshwasnik commented on a diff in pull request #12784: MINOR: Do not perform prodcuerCommit on serializationError when trying offsetWriter flush

sudeshwasnik commented on code in PR #12784: URL: https://github.com/apache/kafka/pull/12784#discussion_r1006768071 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ExactlyOnceWorkerSourceTask.java: ## @@ -280,16 +280,18 @@ private void commitTransaction() {

[GitHub] [kafka] viktorsomogyi commented on pull request #12671: KAFKA-14250: MirrorSourceTask exception causes the task to fail

viktorsomogyi commented on PR #12671: URL: https://github.com/apache/kafka/pull/12671#issuecomment-1293420143 @C0urante in fact this was as escalation that our customer brought to us, they were using a dedicated MM2 cluster. In the meantime during another case with the customer we figured o

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #12784: MINOR: Do not perform prodcuerCommit on serializationError when trying offsetWriter flush

vamossagar12 commented on code in PR #12784: URL: https://github.com/apache/kafka/pull/12784#discussion_r1006791813 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ExactlyOnceWorkerSourceTask.java: ## @@ -280,16 +280,18 @@ private void commitTransaction() {

[GitHub] [kafka] ableegoldman commented on a diff in pull request #12771: KAFKA-14299: Handle TaskCorruptedException during initialization

ableegoldman commented on code in PR #12771: URL: https://github.com/apache/kafka/pull/12771#discussion_r1006792420 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -810,10 +810,19 @@ private void transitRestoredTaskToRunning(final Ta

[GitHub] [kafka] ableegoldman commented on a diff in pull request #12773: KAFKA-14299: Return emptied ChangelogReader to ACTIVE_RESTORING

ableegoldman commented on code in PR #12773: URL: https://github.com/apache/kafka/pull/12773#discussion_r1006804068 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java: ## @@ -990,6 +991,10 @@ public void unregister(final Collection r

[GitHub] [kafka] dajac commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

dajac commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r1006823247 ## core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala: ## @@ -0,0 +1,97 @@ +/** + * Licensed to the Apache Software Foundation (ASF) unde

[jira] [Created] (KAFKA-14339) producer commits-transaction even if offsetWriter faces serializationError

Sudesh Wasnik created KAFKA-14339: - Summary: producer commits-transaction even if offsetWriter faces serializationError Key: KAFKA-14339 URL: https://issues.apache.org/jira/browse/KAFKA-14339 Project:

[GitHub] [kafka] dajac commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

dajac commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r1006833685 ## core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala: ## @@ -1100,6 +1100,66 @@ class ReplicaFetcherThreadTest { assertEquals(Collections.singleto

[GitHub] [kafka] dajac commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

dajac commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r1006834496 ## core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala: ## @@ -1100,6 +1100,66 @@ class ReplicaFetcherThreadTest { assertEquals(Collections.singleto

[GitHub] [kafka] dajac commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

dajac commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r1006836805 ## core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala: ## @@ -1100,6 +1100,66 @@ class ReplicaFetcherThreadTest { assertEquals(Collections.singleto

[GitHub] [kafka] ableegoldman commented on a diff in pull request #12772: KAFKA-14299: Avoid busy polling in state updater

ableegoldman commented on code in PR #12772: URL: https://github.com/apache/kafka/pull/12772#discussion_r1006838904 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java: ## @@ -353,19 +353,21 @@ public static StreamThread create(final TopologyM

[GitHub] [kafka] dajac commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

dajac commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r1006845821 ## core/src/main/scala/kafka/server/ReplicaFetcherThread.scala: ## @@ -132,9 +141,17 @@ class ReplicaFetcherThread(name: String, brokerTopicStats.updateReplication

[GitHub] [kafka] dajac commented on pull request #12783: KAFKA-14334: complete delayed purgatory after replication

dajac commented on PR #12783: URL: https://github.com/apache/kafka/pull/12783#issuecomment-1293497553 @jeffkbkim Thanks for the update. I left a few more comments/suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [kafka] dajac closed pull request #12674: KAFKA-14255: Fetching from follower should be disallowed if fetch from follower is disabled

dajac closed pull request #12674: KAFKA-14255: Fetching from follower should be disallowed if fetch from follower is disabled URL: https://github.com/apache/kafka/pull/12674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] dengziming commented on a diff in pull request #12790: KAFKA-14337: correctly remove topicsWithCollisionChars after topic deletion

dengziming commented on code in PR #12790: URL: https://github.com/apache/kafka/pull/12790#discussion_r1006976348 ## core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala: ## @@ -470,6 +471,30 @@ class TopicCommandIntegrationTest extends KafkaServerTestH

[GitHub] [kafka] C0urante commented on pull request #12366: KAFKA-14021: Implement new KIP-618 APIs in MirrorSourceConnector

C0urante commented on PR #12366: URL: https://github.com/apache/kafka/pull/12366#issuecomment-1293697763 Thanks @OmniaGM, good idea. I've updated the README and added an integration test that verifies that MM2 can still run with exactly-once support enabled. I should note that the `te

[GitHub] [kafka] dajac closed pull request #12734: KAFKA-14255; Return an empty record instead of an OffsetOutOfRangeException when fetching from a follower without a leader epoch

dajac closed pull request #12734: KAFKA-14255; Return an empty record instead of an OffsetOutOfRangeException when fetching from a follower without a leader epoch URL: https://github.com/apache/kafka/pull/12734 -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [kafka] mimaison commented on a diff in pull request #12544: KAFKA-14098: Add meaningful default client IDs for Connect workers

mimaison commented on code in PR #12544: URL: https://github.com/apache/kafka/pull/12544#discussion_r1007088373 ## connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectDistributed.java: ## @@ -106,6 +108,7 @@ public Connect startConnect(Map workerProps) {

[jira] [Commented] (KAFKA-14016) Revoke more partitions than expected in Cooperative rebalance

[ https://issues.apache.org/jira/browse/KAFKA-14016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625187#comment-17625187 ] Shawn Wang commented on KAFKA-14016: [~ableegoldman]  Yes, we experienced KAFKA-138

[jira] [Comment Edited] (KAFKA-14016) Revoke more partitions than expected in Cooperative rebalance

[ https://issues.apache.org/jira/browse/KAFKA-14016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625187#comment-17625187 ] Shawn Wang edited comment on KAFKA-14016 at 10/27/22 4:08 PM:

[jira] [Commented] (KAFKA-14016) Revoke more partitions than expected in Cooperative rebalance

[ https://issues.apache.org/jira/browse/KAFKA-14016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625192#comment-17625192 ] Shawn Wang commented on KAFKA-14016: I also vote for revertingKAFKA-13891 since that

[jira] [Comment Edited] (KAFKA-14016) Revoke more partitions than expected in Cooperative rebalance

[ https://issues.apache.org/jira/browse/KAFKA-14016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625192#comment-17625192 ] Shawn Wang edited comment on KAFKA-14016 at 10/27/22 4:13 PM:

[jira] [Comment Edited] (KAFKA-14016) Revoke more partitions than expected in Cooperative rebalance

[ https://issues.apache.org/jira/browse/KAFKA-14016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625192#comment-17625192 ] Shawn Wang edited comment on KAFKA-14016 at 10/27/22 4:13 PM:

[GitHub] [kafka] rhauch merged pull request #12621: MINOR: Migrate connect system tests to KRaft

rhauch merged PR #12621: URL: https://github.com/apache/kafka/pull/12621 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

[jira] [Comment Edited] (KAFKA-14016) Revoke more partitions than expected in Cooperative rebalance

[ https://issues.apache.org/jira/browse/KAFKA-14016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625187#comment-17625187 ] Shawn Wang edited comment on KAFKA-14016 at 10/27/22 4:20 PM:

[GitHub] [kafka] rhauch commented on pull request #12621: MINOR: Migrate connect system tests to KRaft

rhauch commented on PR #12621: URL: https://github.com/apache/kafka/pull/12621#issuecomment-1293774760 Merged to the `trunk` branch and cherry-picked to the `3.3` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] mimaison commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

mimaison commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r1007096564 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/clients/admin/FakeForwardingAdminWithLocalMetadata.java: ## @@ -0,0 +1,117 @@ +package org.apache.kafka

[GitHub] [kafka] dajac commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

dajac commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r1007133812 ## core/src/main/scala/kafka/server/ReplicaFetcherThread.scala: ## @@ -132,9 +141,17 @@ class ReplicaFetcherThread(name: String, brokerTopicStats.updateReplication

[GitHub] [kafka] mimaison commented on a diff in pull request #12769: KAFKA-14314: Add check for null upstreamTopic

mimaison commented on code in PR #12769: URL: https://github.com/apache/kafka/pull/12769#discussion_r1007143335 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorSourceConnectorTest.java: ## @@ -319,4 +320,17 @@ public void testRefreshTopicPartitionsTopicOnTa

[GitHub] [kafka] dajac commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

dajac commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r1007153544 ## core/src/main/scala/kafka/server/ReplicaFetcherThread.scala: ## @@ -132,9 +141,17 @@ class ReplicaFetcherThread(name: String, brokerTopicStats.updateReplication

[GitHub] [kafka] philipnee commented on pull request #12792: [Test]gradle oom fix

philipnee commented on PR #12792: URL: https://github.com/apache/kafka/pull/12792#issuecomment-1293833011 [0c166c0](https://github.com/apache/kafka/pull/12792/commits/0c166c0cc456619b4168736820e05b06dc7ae7ab) - no gradle oom -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] philipnee closed pull request #12038: [WIP] KAFKA-13421

philipnee closed pull request #12038: [WIP] KAFKA-13421 URL: https://github.com/apache/kafka/pull/12038 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] philipnee commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

philipnee commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1007181238 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -618,7 +618,8 @@ private TransactionManager configureTransactionState(ProducerCo

[GitHub] [kafka] philipnee commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

philipnee commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1007185990 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -155,7 +155,7 @@ private enum State { private boolean isT

[GitHub] [kafka] philipnee commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

philipnee commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1007187187 ## clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java: ## @@ -1237,6 +1238,34 @@ public void testInitTransactionWhileThrottled() {

[GitHub] [kafka] hachikuji commented on pull request #12790: KAFKA-14337: correctly remove topicsWithCollisionChars after topic deletion

hachikuji commented on PR #12790: URL: https://github.com/apache/kafka/pull/12790#issuecomment-1293873487 Great find! Agree with @dengziming that we should have a test in `ReplicationControlManagerTest`. Otherwise, LGTM. -- This is an automated message from the Apache Git Service. To resp

[GitHub] [kafka] bbejeck commented on pull request #12465: KAFKA-12950: Replace EasyMock and PowerMock with Mockito for KafkaStreamsTest

bbejeck commented on PR #12465: URL: https://github.com/apache/kafka/pull/12465#issuecomment-1293885171 Failures unrelated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

jeffkbkim commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r1007204668 ## core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala: ## @@ -1100,6 +1100,66 @@ class ReplicaFetcherThreadTest { assertEquals(Collections.sing

[GitHub] [kafka] jolshan commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

jolshan commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1007207887 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -155,7 +155,7 @@ private enum State { private boolean isTra

[GitHub] [kafka] bbejeck merged pull request #12465: KAFKA-12950: Replace EasyMock and PowerMock with Mockito for KafkaStreamsTest

bbejeck merged PR #12465: URL: https://github.com/apache/kafka/pull/12465 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] bbejeck commented on pull request #12465: KAFKA-12950: Replace EasyMock and PowerMock with Mockito for KafkaStreamsTest

bbejeck commented on PR #12465: URL: https://github.com/apache/kafka/pull/12465#issuecomment-1293889869 Merged #12465 into trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [kafka] bbejeck commented on pull request #12465: KAFKA-12950: Replace EasyMock and PowerMock with Mockito for KafkaStreamsTest

bbejeck commented on PR #12465: URL: https://github.com/apache/kafka/pull/12465#issuecomment-1293890128 Thanks for the contribution @divijvaidya ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

jeffkbkim commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r1007215458 ## core/src/main/scala/kafka/server/ReplicaFetcherThread.scala: ## @@ -132,9 +141,17 @@ class ReplicaFetcherThread(name: String, brokerTopicStats.updateReplica

[jira] [Commented] (KAFKA-12950) Replace EasyMock and PowerMock with Mockito for KafkaStreamsTest

[ https://issues.apache.org/jira/browse/KAFKA-12950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625246#comment-17625246 ] Bill Bejeck commented on KAFKA-12950: - Merged into trunk > Replace EasyMock and Pow

[jira] [Updated] (KAFKA-14337) topic name with "." cannot be created after deletion

[ https://issues.apache.org/jira/browse/KAFKA-14337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-14337: --- Fix Version/s: 3.4.0 3.3.2 > topic name with "."

[GitHub] [kafka] dajac commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

dajac commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r1007243383 ## core/src/main/scala/kafka/server/ReplicaFetcherThread.scala: ## @@ -132,9 +141,17 @@ class ReplicaFetcherThread(name: String, brokerTopicStats.updateReplication

[GitHub] [kafka] dajac commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

dajac commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r1007243845 ## core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala: ## @@ -1100,6 +1100,66 @@ class ReplicaFetcherThreadTest { assertEquals(Collections.singleto

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12793: [KAFKA-14328]: KafkaAdminClient should be Changing the exception level …

guozhangwang commented on code in PR #12793: URL: https://github.com/apache/kafka/pull/12793#discussion_r1007251372 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -835,6 +836,10 @@ final void fail(long now, Throwable throwable) {

[jira] [Commented] (KAFKA-14328) KafkaAdminClient should be Changing the exception level When an exception occurs

[ https://issues.apache.org/jira/browse/KAFKA-14328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625256#comment-17625256 ] Guozhang Wang commented on KAFKA-14328: --- Hello [~shizhenzhen] sorry for the late r

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

jeffkbkim commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r1007253784 ## core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala: ## @@ -0,0 +1,97 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

jeffkbkim commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r1007253784 ## core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala: ## @@ -0,0 +1,97 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] guozhangwang commented on pull request #12793: [KAFKA-14328]: KafkaAdminClient should be Changing the exception level …

guozhangwang commented on PR #12793: URL: https://github.com/apache/kafka/pull/12793#issuecomment-1293946483 @shirenchuang the checkstyle failures are related to the coding styles in the PR, you can run the commands locally (there's instructions in `README.md`) to check again when you updat

[GitHub] [kafka] cowlike commented on a diff in pull request #12769: KAFKA-14314: Add check for null upstreamTopic

cowlike commented on code in PR #12769: URL: https://github.com/apache/kafka/pull/12769#discussion_r1007313398 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorSourceConnectorTest.java: ## @@ -319,4 +320,17 @@ public void testRefreshTopicPartitionsTopicOnTar

[GitHub] [kafka] cowlike commented on a diff in pull request #12769: KAFKA-14314: Add check for null upstreamTopic

cowlike commented on code in PR #12769: URL: https://github.com/apache/kafka/pull/12769#discussion_r1007313398 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorSourceConnectorTest.java: ## @@ -319,4 +320,17 @@ public void testRefreshTopicPartitionsTopicOnTar

[GitHub] [kafka] OmniaGM commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

OmniaGM commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r1007411497 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/clients/admin/FakeLocalMetadataStore.java: ## @@ -0,0 +1,15 @@ +package org.apache.kafka.connect.mirror.

[GitHub] [kafka] OmniaGM commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

OmniaGM commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r1007412233 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsWithCustomForwardingAdminIntegrationTest.java: ## @@ -0,0 +1,596 @@ +/* Rev

[GitHub] [kafka] OmniaGM commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

OmniaGM commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r1007412233 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsWithCustomForwardingAdminIntegrationTest.java: ## @@ -0,0 +1,596 @@ +/* Rev

[GitHub] [kafka] OmniaGM commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

OmniaGM commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r1007424805 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsWithCustomForwardingAdminIntegrationTest.java: ## @@ -0,0 +1,596 @@ +/* + *

[GitHub] [kafka] OmniaGM commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

OmniaGM commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r1007434322 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsWithCustomForwardingAdminIntegrationTest.java: ## @@ -0,0 +1,596 @@ +/* + *

[jira] [Commented] (KAFKA-14016) Revoke more partitions than expected in Cooperative rebalance

[ https://issues.apache.org/jira/browse/KAFKA-14016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625360#comment-17625360 ] A. Sophie Blee-Goldman commented on KAFKA-14016: [~aiquestion] would you

[GitHub] [kafka] Scanteianu commented on pull request #12753: MINOR: Document Offset and Partition 0-indexing, fix typo

Scanteianu commented on PR #12753: URL: https://github.com/apache/kafka/pull/12753#issuecomment-1294252160 > @Scanteianu , thanks for the update, but there is still something wrong. For the test, I don't think another tests in MockConsumer is needed and correct. After all, MockConsumer is a

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

jeffkbkim commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r1007536584 ## core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala: ## @@ -0,0 +1,97 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

jeffkbkim commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r1007544878 ## core/src/main/scala/kafka/server/ReplicaFetcherThread.scala: ## @@ -132,9 +141,17 @@ class ReplicaFetcherThread(name: String, brokerTopicStats.updateReplica

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

jeffkbkim commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r1007253784 ## core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala: ## @@ -0,0 +1,97 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

jeffkbkim commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r1007549176 ## core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala: ## @@ -0,0 +1,97 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] opencmit2 commented on pull request #12788: [Test]Testing Gradle OOM

opencmit2 commented on PR #12788: URL: https://github.com/apache/kafka/pull/12788#issuecomment-1294428194 Note: DefaultCachedClasspathTransformer, The latest code has been modified to limit the number of threads. It is changed to be linked to the number of CPU cores. Limit the

  1   2   >