mimaison commented on code in PR #12544:
URL: https://github.com/apache/kafka/pull/12544#discussion_r1007088373
##########
connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectDistributed.java:
##########
@@ -106,6 +108,7 @@ public Connect startConnect(Map<String, String>
workerProps) {
// Create the admin client to be shared by all backing stores.
Map<String, Object> adminProps = new HashMap<>(config.originals());
ConnectUtils.addMetricsContextProperties(adminProps, config,
kafkaClusterId);
+ adminProps.putIfAbsent(CLIENT_ID_CONFIG, "connect-cluster-" +
config.groupId());
Review Comment:
Yeah the advertised URL is the only identifier we have for a unique worker
but it could be "ugly" and pretty long.
Ideally users would provide a unique identifier (like the pod name) as the
client.id and we would prefix/suffix it with the groupId and a short name like
`shared-admin`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
