[
https://issues.apache.org/jira/browse/KAFKA-7883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17574079#comment-17574079
]
Michael Negodaev commented on KAFKA-7883:
-
Hi all,
I've created KIP-855 for this
mdedetrich commented on PR #11478:
URL: https://github.com/apache/kafka/pull/11478#issuecomment-1202139295
Actually following on from my previous comment (assuming its correct), the
currently existing `MultipleListenersWithSameSecurityProtocolBaseTest ` tests
are already covering what would
devdavidkarlsson opened a new pull request, #12470:
URL: https://github.com/apache/kafka/pull/12470
Update documentation comments in the demo code, after switch to the newer
processor API (replacing the TransformerDemo)
### Committer Checklist (excluded from commit message)
- [ x]
[
https://issues.apache.org/jira/browse/KAFKA-13530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17574099#comment-17574099
]
Matthew de Detrich commented on KAFKA-13530:
Okay so I have done some testin
mdedetrich opened a new pull request, #12471:
URL: https://github.com/apache/kafka/pull/12471
In Scala its standard practice to use _ whenever you are initializing
variables. In regards to implementation, for object references
_ initialization maps to null so there is no chance in behav
dengziming commented on code in PR #12467:
URL: https://github.com/apache/kafka/pull/12467#discussion_r935283700
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -81,6 +81,8 @@ class BrokerServer(
val controllerQuorumVotersFuture: CompletableFuture[util.Map[Integ
[
https://issues.apache.org/jira/browse/KAFKA-9837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17574156#comment-17574156
]
Igor Soarez commented on KAFKA-9837:
I've put together a proposal to associate partit
kkolyan commented on PR #7670:
URL: https://github.com/apache/kafka/pull/7670#issuecomment-1202250617
what's up with this PR? it seems easy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
[
https://issues.apache.org/jira/browse/KAFKA-13995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17574163#comment-17574163
]
Devarshi Shah commented on KAFKA-13995:
---
Yes, we are also having similar kind of s
[
https://issues.apache.org/jira/browse/KAFKA-14014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthew de Detrich reassigned KAFKA-14014:
--
Assignee: Matthew de Detrich
> Flaky test
> NamedTopologyIntegrationTest.sho
[
https://issues.apache.org/jira/browse/KAFKA-13513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthew de Detrich reassigned KAFKA-13513:
--
Assignee: Matthew de Detrich
> Flaky test AdjustStreamThreadCountTest
> -
divijvaidya commented on PR #12471:
URL: https://github.com/apache/kafka/pull/12471#issuecomment-1202378703
Thank you for the review. Looks good. One question though (which does not
have to be addressed part of this PR), do we have a linter for scala that can
enforce such best practices?
divijvaidya commented on PR #12452:
URL: https://github.com/apache/kafka/pull/12452#issuecomment-1202383303
@guozhangwang please take a look into this flaky test fix if you get a
chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
mdedetrich commented on PR #12471:
URL: https://github.com/apache/kafka/pull/12471#issuecomment-1202384578
Yes there is, its called scalafix. Would just have to integrate it into
gradle. There is also scalafix which works on the context free grammar linting
fixes, I noticed there is a confi
jsancio merged PR #12236:
URL: https://github.com/apache/kafka/pull/12236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
Christo Lolov created KAFKA-14132:
-
Summary: Remaining PowerMock to Mockito tests
Key: KAFKA-14132
URL: https://issues.apache.org/jira/browse/KAFKA-14132
Project: Kafka
Issue Type: Sub-task
Christo Lolov created KAFKA-14133:
-
Summary: Remaining EasyMock to Mockito tests
Key: KAFKA-14133
URL: https://issues.apache.org/jira/browse/KAFKA-14133
Project: Kafka
Issue Type: Sub-task
divijvaidya commented on code in PR #12459:
URL: https://github.com/apache/kafka/pull/12459#discussion_r935547915
##
streams/src/test/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetricsRecorderTest.java:
##
@@ -36,22 +38,23 @@
import org.rocksdb.StatsLevel;
im
divijvaidya commented on code in PR #12459:
URL: https://github.com/apache/kafka/pull/12459#discussion_r935548150
##
streams/src/test/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetricsRecorderTest.java:
##
@@ -279,449 +310,335 @@ public void
shouldThrowIfDbToA
[
https://issues.apache.org/jira/browse/KAFKA-14122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17574223#comment-17574223
]
Divij Vaidya commented on KAFKA-14122:
--
Another build failure:
[https://ci-builds.
[
https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14132:
--
Description:
A list of tests which still require to be moved from PowerMock to Mockito as of
[
https://issues.apache.org/jira/browse/KAFKA-14122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17574225#comment-17574225
]
Divij Vaidya commented on KAFKA-14122:
--
[~showuon] please review...this flaky test
[
https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14132:
--
Description:
A list of tests which still require to be moved from PowerMock to Mockito as of
[
https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14132:
--
Description:
A list of tests which still require to be moved from PowerMock to Mockito as of
[
https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14132:
--
Description:
A list of tests which still require to be moved from PowerMock to Mockito as of
showuon commented on PR #12452:
URL: https://github.com/apache/kafka/pull/12452#issuecomment-1202503504
Sorry, was quite busy recently. I'll take a look this week. Thanks for
helping fix it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
Yash Mayya created KAFKA-14134:
--
Summary: Replace EasyMock with Mockito for WorkerConnectorTest
Key: KAFKA-14134
URL: https://issues.apache.org/jira/browse/KAFKA-14134
Project: Kafka
Issue Type:
[
https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14133:
--
Description:
A list of tests which still require to be moved from EasyMock to Mockito as of
2
[
https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14133:
--
Description:
A list of tests which still require to be moved from EasyMock to Mockito as of
2
[
https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14133:
--
Description:
*There are tests which use both PowerMock and EasyMock. I have put those in
http
[
https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14133:
--
Description:
{color:#DE350B}*There are tests which use both PowerMock and EasyMock. I have
pu
[
https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14133:
--
Description:
*There are tests which use both PowerMock and EasyMock. I have put those in
http
[
https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14132:
--
Description:
{color:#DE350B}Some of the tests below use EasyMock as well. For those migrate
b
[
https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14133:
--
Description:
{color:#DE350B}There are tests which use both PowerMock and EasyMock. I have
put
[
https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14132:
--
Description:
{color:#DE350B}Some of the tests below use EasyMock as well. For those migrate
b
[
https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14132:
--
Description:
{color:#DE350B}Some of the tests below use EasyMock as well. For those migrate
b
[
https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14132:
--
Description:
{color:#DE350B}Some of the tests below use EasyMock as well. For those migrate
b
[
https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14132:
--
Description:
{color:#DE350B}Some of the tests below use EasyMock as well. For those migrate
b
yashmayya opened a new pull request, #12472:
URL: https://github.com/apache/kafka/pull/12472
https://issues.apache.org/jira/browse/KAFKA-14134
From https://issues.apache.org/jira/browse/KAFKA-7438:
> Development of EasyMock and PowerMock has stagnated while Mockito
continues to
yashmayya commented on PR #12472:
URL: https://github.com/apache/kafka/pull/12472#issuecomment-1202563314
@mimaison or @C0urante could you please take a look? The changes are fairly
straightforward for this one.
--
This is an automated message from the Apache Git Service.
To respond to th
[
https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14132:
--
Description:
{color:#DE350B}Some of the tests below use EasyMock as well. For those migrate
b
[
https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14133:
--
Description:
{color:#DE350B}There are tests which use both PowerMock and EasyMock. I have
put
[
https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14133:
--
Description:
{color:#DE350B}There are tests which use both PowerMock and EasyMock. I have
put
[
https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14133:
--
Description:
{color:#DE350B}There are tests which use both PowerMock and EasyMock. I have
put
[
https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14132:
--
Description:
{color:#DE350B}Some of the tests below use EasyMock as well. For those migrate
b
[
https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14132:
--
Description:
{color:#DE350B}Some of the tests below use EasyMock as well. For those migrate
b
divijvaidya commented on code in PR #12472:
URL: https://github.com/apache/kafka/pull/12472#discussion_r935609616
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConnectorTest.java:
##
@@ -60,15 +64,15 @@ public class WorkerConnectorTest extends EasyMockS
divijvaidya commented on code in PR #12472:
URL: https://github.com/apache/kafka/pull/12472#discussion_r935646206
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConnectorTest.java:
##
@@ -26,28 +26,32 @@
import org.apache.kafka.connect.source.SourceConn
[
https://issues.apache.org/jira/browse/KAFKA-13065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17574257#comment-17574257
]
Divij Vaidya commented on KAFKA-13065:
--
Note that this test `BasicAuthSecurityRestE
[
https://issues.apache.org/jira/browse/KAFKA-13065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya reassigned KAFKA-13065:
Assignee: dengziming (was: Chun-Hao Tang)
Resolution: Fixed
> Replace EasyMock wit
[
https://issues.apache.org/jira/browse/KAFKA-13840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17574260#comment-17574260
]
Martijn Visser commented on KAFKA-13840:
Is there any progress to report on this
[
https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov reassigned KAFKA-14133:
-
Assignee: Christo Lolov
> Remaining EasyMock to Mockito tests
> ---
[
https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov reassigned KAFKA-14132:
-
Assignee: Christo Lolov
> Remaining PowerMock to Mockito tests
> --
divijvaidya commented on code in PR #11137:
URL: https://github.com/apache/kafka/pull/11137#discussion_r935719219
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractHerderTest.java:
##
@@ -135,90 +133,75 @@
private final int generation = 5;
priva
[
https://issues.apache.org/jira/browse/KAFKA-13133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya reassigned KAFKA-13133:
Assignee: Divij Vaidya (was: YI-CHEN WANG)
> Replace EasyMock and PowerMock with Mockito
divijvaidya commented on PR #12459:
URL: https://github.com/apache/kafka/pull/12459#issuecomment-1202942487
@dplavcic I have added the test coverage report to the description of this
ticket. This revision is ready for your review now. Thanks again for your
patience and spending time in revi
[
https://issues.apache.org/jira/browse/KAFKA-13840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17574313#comment-17574313
]
Kyle R Stehbens commented on KAFKA-13840:
-
Hi, we rolled back our Kafka client t
divijvaidya commented on PR #12465:
URL: https://github.com/apache/kafka/pull/12465#issuecomment-1202976734
@ijuma Please review when you get a chance. This would help us take a step
forward in getting rid of easymock/powermock dependency.
--
This is an automated message from the Apache G
divijvaidya opened a new pull request, #12473:
URL: https://github.com/apache/kafka/pull/12473
This PR is created on top of abandoned PR
https://github.com/apache/kafka/pull/11137. I have added the previous author's
comment in this PR for attribution. I have also addressed the pending comme
[
https://issues.apache.org/jira/browse/KAFKA-13133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17574323#comment-17574323
]
Divij Vaidya commented on KAFKA-13133:
--
[~ijuma] I have created a new PR on top of
divijvaidya commented on code in PR #12473:
URL: https://github.com/apache/kafka/pull/12473#discussion_r935831882
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractHerderTest.java:
##
@@ -141,89 +141,51 @@ public class AbstractHerderTest {
private fi
[
https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17574326#comment-17574326
]
Divij Vaidya commented on KAFKA-14132:
--
[~christo_lolov] I am picking up tests 1-5
C0urante commented on code in PR #12418:
URL: https://github.com/apache/kafka/pull/12418#discussion_r934915520
##
connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStoreTest.java:
##
@@ -142,97 +163,90 @@ public void testStartStop() throws Exceptio
mimaison merged PR #12452:
URL: https://github.com/apache/kafka/pull/12452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-14122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison resolved KAFKA-14122.
Resolution: Fixed
> Flaky test DynamicBrokerReconfigurationTest.testKeyStoreAlter
> --
C0urante merged PR #11615:
URL: https://github.com/apache/kafka/pull/11615
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
C0urante commented on code in PR #12472:
URL: https://github.com/apache/kafka/pull/12472#discussion_r935923454
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConnectorTest.java:
##
@@ -120,43 +101,26 @@ public void testInitializeFailure() {
work
cmccabe commented on code in PR #12467:
URL: https://github.com/apache/kafka/pull/12467#discussion_r935931468
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -81,6 +81,8 @@ class BrokerServer(
val controllerQuorumVotersFuture: CompletableFuture[util.Map[Integer,
dplavcic commented on code in PR #12449:
URL: https://github.com/apache/kafka/pull/12449#discussion_r935981217
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImplTest.java:
##
@@ -192,23 +180,23 @@ public boolean matches(final Object
dplavcic commented on code in PR #12449:
URL: https://github.com/apache/kafka/pull/12449#discussion_r935986979
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/graph/TableSourceNodeTest.java:
##
@@ -23,41 +23,39 @@
import org.apache.kafka.streams.kstream.inte
dplavcic commented on code in PR #12449:
URL: https://github.com/apache/kafka/pull/12449#discussion_r935983777
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImplTest.java:
##
@@ -736,42 +705,34 @@ public void shouldProvideCorrectStri
dplavcic commented on code in PR #12449:
URL: https://github.com/apache/kafka/pull/12449#discussion_r935984902
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImplTest.java:
##
@@ -1293,43 +1252,41 @@ private void verifyMetric(final St
yashmayya opened a new pull request, #12474:
URL: https://github.com/apache/kafka/pull/12474
- Builds on top off https://github.com/apache/kafka/pull/11137 by @wycc
which seems to have gone stale (so they should be credited as a co-author if
this PR is merged)
- Rebased onto latest `
mdedetrich opened a new pull request, #12475:
URL: https://github.com/apache/kafka/pull/12475
Updates scalafmt to the latest version. This not only means migrating
the checkstyle/.scalafmt.conf file but updating spotless as well. Due
to improvements in the new version of scalafmt, it no
mdedetrich commented on code in PR #12475:
URL: https://github.com/apache/kafka/pull/12475#discussion_r936005663
##
build.gradle:
##
@@ -30,7 +30,7 @@ buildscript {
}
plugins {
- id 'com.diffplug.spotless' version '5.12.5'
+ id 'com.diffplug.spotless' version '6.9.0'
Revi
yashmayya commented on PR #12474:
URL: https://github.com/apache/kafka/pull/12474#issuecomment-1203190905
https://github.com/apache/kafka/pull/12473 got here first, closing this one
:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
yashmayya closed pull request #12474: KAFKA-13133 Replace EasyMock and
PowerMock with Mockito for AbstractHerderTest
URL: https://github.com/apache/kafka/pull/12474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
mdedetrich commented on code in PR #12475:
URL: https://github.com/apache/kafka/pull/12475#discussion_r936006142
##
checkstyle/.scalafmt.conf:
##
@@ -12,7 +12,10 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific
mdedetrich commented on code in PR #12475:
URL: https://github.com/apache/kafka/pull/12475#discussion_r936009435
##
checkstyle/.scalafmt.conf:
##
@@ -12,7 +12,10 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific
yashmayya commented on code in PR #12473:
URL: https://github.com/apache/kafka/pull/12473#discussion_r936007323
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractHerderTest.java:
##
@@ -141,89 +141,51 @@ public class AbstractHerderTest {
private fina
dplavcic commented on code in PR #12449:
URL: https://github.com/apache/kafka/pull/12449#discussion_r936038290
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImplTest.java:
##
@@ -1293,43 +1259,42 @@ private void verifyMetric(final St
[
https://issues.apache.org/jira/browse/KAFKA-13187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dalibor Plavcic reassigned KAFKA-13187:
---
Assignee: Dalibor Plavcic (was: YI-CHEN WANG)
> Replace EasyMock and PowerMock wit
cmccabe commented on PR #12400:
URL: https://github.com/apache/kafka/pull/12400#issuecomment-1203275395
This does look right to me but let me check with @mumrah . Thanks, @blcksrx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
cmccabe merged PR #12467:
URL: https://github.com/apache/kafka/pull/12467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
niket-goel closed pull request #12457: WIP -- added some CRC checking
URL: https://github.com/apache/kafka/pull/12457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
[
https://issues.apache.org/jira/browse/KAFKA-14104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17574434#comment-17574434
]
Niket Goel commented on KAFKA-14104:
PR here – https://github.com/apache/kafka/pull/
guozhangwang opened a new pull request, #12476:
URL: https://github.com/apache/kafka/pull/12476
While working on
[KAFKA-13877](https://issues.apache.org/jira/browse/KAFKA-13877), I feel it's
an overkill to introduce the whole test class as an integration test, since all
we need is to just
guozhangwang commented on PR #12476:
URL: https://github.com/apache/kafka/pull/12476#issuecomment-1203398110
ping @vvcephei for a quick review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
guozhangwang commented on PR #12468:
URL: https://github.com/apache/kafka/pull/12468#issuecomment-1203477606
Thanks @divijvaidya , I've fixed the mistakenly modified code logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
showuon commented on PR #12452:
URL: https://github.com/apache/kafka/pull/12452#issuecomment-1203545154
Thanks @divijvaidya for fixing it! Thanks for @mimaison 's review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
mdedetrich commented on PR #12475:
URL: https://github.com/apache/kafka/pull/12475#issuecomment-1203547014
@divijvaidya This is one of the first PR's in adding the linting/formatting
using scalafmt/scalafix for the Scala sources within Kafka if you want to have
a look. @cadonna Do you want
91 matches
Mail list logo
