guozhangwang opened a new pull request, #12476:
URL: https://github.com/apache/kafka/pull/12476

   While working on 
[KAFKA-13877](https://issues.apache.org/jira/browse/KAFKA-13877), I feel it's 
an overkill to introduce the whole test class as an integration test, since all 
we need is to just test the assignor itself which could be a unit test. Running 
this suite with 9+ instances takes long time and is still vulnerable to all 
kinds of timing based flakiness. A better choice is to reduce it as a unit 
test, similar to HighAvailabilityStreamsPartitionAssignorTest that just test 
the behavior of the assignor itself, rather than creating many instances hence 
depend on various timing bombs to not explode.
   
   Since we mock everything, there's no flakiness anymore. Plus we greatly 
reduced the test runtime (on my local machine, the old integration takes about 
35 secs to run the whole suite, while the new one take 20ms on average).
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to