[GitHub] [kafka] showuon commented on a diff in pull request #11983: KAFKA-13763 (2): Refactor IncrementalCooperativeAssignor for improved unit testing

2022-04-28 Thread GitBox
showuon commented on code in PR #11983: URL: https://github.com/apache/kafka/pull/11983#discussion_r860546268 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java: ## @@ -298,20 +329,21 @@ protected Map performTaskAss

[GitHub] [kafka] karuturi commented on a diff in pull request #11955: KAFKA-12380 Executor in Connect's Worker is not shut down when the worker is

2022-04-28 Thread GitBox
karuturi commented on code in PR #11955: URL: https://github.com/apache/kafka/pull/11955#discussion_r860568585 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -222,6 +223,20 @@ public void stop() { connectorStatusMetricsGroup.close()

[GitHub] [kafka] karuturi commented on a diff in pull request #11955: KAFKA-12380 Executor in Connect's Worker is not shut down when the worker is

2022-04-28 Thread GitBox
karuturi commented on code in PR #11955: URL: https://github.com/apache/kafka/pull/11955#discussion_r860568585 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -222,6 +223,20 @@ public void stop() { connectorStatusMetricsGroup.close()

[GitHub] [kafka] dengziming commented on a diff in pull request #12104: KAFKA-13746: Attempt to fix flaky test by waiting to fetch 2 topics f…

2022-04-28 Thread GitBox
dengziming commented on code in PR #12104: URL: https://github.com/apache/kafka/pull/12104#discussion_r860568828 ## core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala: ## @@ -733,12 +733,18 @@ class TopicCommandIntegrationTest extends KafkaServerTestH

[jira] [Commented] (KAFKA-13745) Flaky kafka.network.SocketServerTest.testNoOpActionResponseWithThrottledChannelWhereThrottlingAlreadyDone

2022-04-28 Thread lqjacklee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529252#comment-17529252 ] lqjacklee commented on KAFKA-13745: --- [~sagarrao] I want to add the log warning to catc

[GitHub] [kafka] dengziming opened a new pull request, #12105: KAFKA-13859: Disable idempotence on SCRAM authentication

2022-04-28 Thread GitBox
dengziming opened a new pull request, #12105: URL: https://github.com/apache/kafka/pull/12105 *More detailed description of your change* After upgrading from 2.X to 3.0.1 we set "enable.idempotence"=true by default, but the `InitProducerIdRequest` involves the `TRANSACTIONAL_ID` are aut

[GitHub] [kafka] dengziming commented on pull request #12105: KAFKA-13859: Disable idempotence on SCRAM authentication

2022-04-28 Thread GitBox
dengziming commented on PR #12105: URL: https://github.com/apache/kafka/pull/12105#issuecomment-852288 Hello @showuon @ijuma @hachikuji , This problem is similar to what we fixed in #11788, however, it's more subtle. And I'm not sure whether we should try a different approach, what's yo

[GitHub] [kafka] dengziming commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-28 Thread GitBox
dengziming commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r860599232 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [kafka] showuon commented on pull request #12105: KAFKA-13859: Disable idempotence on SCRAM authentication

2022-04-28 Thread GitBox
showuon commented on PR #12105: URL: https://github.com/apache/kafka/pull/12105#issuecomment-878830 @dengziming , thanks for the quick investigation! Nice finding! Yes, once idempotent producer is enabled, the transactionManager will be created. And in Sender run loop [here](https://gi

[jira] [Commented] (KAFKA-13859) SCRAM authentication issues with kafka-clients 3.0.1

2022-04-28 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529293#comment-17529293 ] Luke Chen commented on KAFKA-13859: --- [~dengziming] , Nice finding! [~opayne] , thank

[jira] [Comment Edited] (KAFKA-13859) SCRAM authentication issues with kafka-clients 3.0.1

2022-04-28 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529293#comment-17529293 ] Luke Chen edited comment on KAFKA-13859 at 4/28/22 8:18 AM:

[GitHub] [kafka] showuon commented on pull request #12105: KAFKA-13859: Disable idempotence on SCRAM authentication

2022-04-28 Thread GitBox
showuon commented on PR #12105: URL: https://github.com/apache/kafka/pull/12105#issuecomment-907646 @dengziming , have a 2nd look, I found it's not right. [Here](https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/KafkaApis.scala#L2185-L2194), we won't check the

[GitHub] [kafka] mimaison commented on pull request #11492: KAFKA-13452: MM2 shouldn't checkpoint when offset mapping is unavailable

2022-04-28 Thread GitBox
mimaison commented on PR #11492: URL: https://github.com/apache/kafka/pull/11492#issuecomment-916235 Thanks @viktorsomogyi for the PR. If I understand correctly, this an alternative to https://github.com/apache/kafka/pull/11748? -- This is an automated message from the Apache Git Serv

[GitHub] [kafka] vamossagar12 commented on pull request #12104: KAFKA-13746: Attempt to fix flaky test by waiting to fetch 2 topics f…

2022-04-28 Thread GitBox
vamossagar12 commented on PR #12104: URL: https://github.com/apache/kafka/pull/12104#issuecomment-920255 > Thank you for this PR, in fact, I haven't seen this flaky test happen, however, it's worth fixing it, left a minor comment. @dengziming , thanks for the review. Actually I sa

[GitHub] [kafka] dengziming commented on pull request #12105: KAFKA-13859: Disable idempotence on SCRAM authentication

2022-04-28 Thread GitBox
dengziming commented on PR #12105: URL: https://github.com/apache/kafka/pull/12105#issuecomment-924359 @showuon Yeah, you are right, Here is the log of clients when I reproduce this error with the 3.0.1 client, it shows we are failing the `IDEMPOTENT_WRITE` permission. ``` [20

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #12104: KAFKA-13746: Attempt to fix flaky test by waiting to fetch 2 topics f…

2022-04-28 Thread GitBox
vamossagar12 commented on code in PR #12104: URL: https://github.com/apache/kafka/pull/12104#discussion_r860646773 ## core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala: ## @@ -733,12 +733,18 @@ class TopicCommandIntegrationTest extends KafkaServerTes

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #12104: KAFKA-13746: Attempt to fix flaky test by waiting to fetch 2 topics f…

2022-04-28 Thread GitBox
vamossagar12 commented on code in PR #12104: URL: https://github.com/apache/kafka/pull/12104#discussion_r860648137 ## core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala: ## @@ -733,12 +733,18 @@ class TopicCommandIntegrationTest extends KafkaServerTes

[GitHub] [kafka] showuon commented on pull request #12105: KAFKA-13859: Disable idempotence on SCRAM authentication

2022-04-28 Thread GitBox
showuon commented on PR #12105: URL: https://github.com/apache/kafka/pull/12105#issuecomment-942909 Thanks @dengziming . I checked the [KIP-679](https://cwiki.apache.org/confluence/display/KAFKA/KIP-679%3A+Producer+will+enable+the+strongest+delivery+guarantee+by+default#KIP679:Producerwi

[GitHub] [kafka] cadonna commented on pull request #12102: HOTFIX: Only measure in nano when producer metadata refresh is required

2022-04-28 Thread GitBox
cadonna commented on PR #12102: URL: https://github.com/apache/kafka/pull/12102#issuecomment-981605 @guozhangwang I do not think we need this hotfix on 3.2 since https://github.com/apache/kafka/pull/11805 is not present on the 3.2 branch. -- This is an automated message from the Apach

[GitHub] [kafka] dengziming commented on pull request #12105: KAFKA-13859: Disable idempotence on SCRAM authentication

2022-04-28 Thread GitBox
dengziming commented on PR #12105: URL: https://github.com/apache/kafka/pull/12105#issuecomment-990594 > I checked the [KIP-679](https://cwiki.apache.org/confluence/display/KAFKA/KIP-679%3A+Producer+will+enable+the+strongest+delivery+guarantee+by+default#KIP679:Producerwillenablethestron

[GitHub] [kafka] notme159 commented on pull request #9947: KAFKA-12190: Fix setting of file permissions on non-POSIX filesystems

2022-04-28 Thread GitBox
notme159 commented on PR #9947: URL: https://github.com/apache/kafka/pull/9947#issuecomment-1112119696 @aybefox Well the folder permissions are correct (it is writable), it just logs error when the setWritable is called. So I just suppress the StateDirectory log in log4j config using FATAL

[GitHub] [kafka] ijuma merged pull request #12096: KAFKA-13794: Fix comparator of inflightBatchesBySequence in TransactionsManager (round 3)

2022-04-28 Thread GitBox
ijuma merged PR #12096: URL: https://github.com/apache/kafka/pull/12096 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] ijuma commented on a diff in pull request #12096: KAFKA-13794: Fix comparator of inflightBatchesBySequence in TransactionsManager (round 3)

2022-04-28 Thread GitBox
ijuma commented on code in PR #12096: URL: https://github.com/apache/kafka/pull/12096#discussion_r860883998 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -175,11 +175,14 @@ private static class TopicPartitionEntry {

[GitHub] [kafka] ijuma commented on pull request #12096: KAFKA-13794: Fix comparator of inflightBatchesBySequence in TransactionsManager (round 3)

2022-04-28 Thread GitBox
ijuma commented on PR #12096: URL: https://github.com/apache/kafka/pull/12096#issuecomment-1112200623 Merged to master and cherry-picked to 3.1 and 3.2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] ijuma commented on pull request #12006: KAFKA-13794: Follow up to fix comparator

2022-04-28 Thread GitBox
ijuma commented on PR #12006: URL: https://github.com/apache/kafka/pull/12006#issuecomment-1112200967 @tombentley See #12096. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] ijuma commented on a diff in pull request #12006: KAFKA-13794: Follow up to fix comparator

2022-04-28 Thread GitBox
ijuma commented on code in PR #12006: URL: https://github.com/apache/kafka/pull/12006#discussion_r860887484 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -187,7 +187,7 @@ private void startSequencesAtBeginning(TopicPartition

[GitHub] [kafka] viktorsomogyi closed pull request #11492: KAFKA-13452: MM2 shouldn't checkpoint when offset mapping is unavailable

2022-04-28 Thread GitBox
viktorsomogyi closed pull request #11492: KAFKA-13452: MM2 shouldn't checkpoint when offset mapping is unavailable URL: https://github.com/apache/kafka/pull/11492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [kafka] viktorsomogyi commented on pull request #11492: KAFKA-13452: MM2 shouldn't checkpoint when offset mapping is unavailable

2022-04-28 Thread GitBox
viktorsomogyi commented on PR #11492: URL: https://github.com/apache/kafka/pull/11492#issuecomment-1112206001 @mimaison yes, it is, if you see something, feel free to incorporate it into yours. Also I didn't want to ping you on this one but a different one :). Sorry. Once I have that up her

[jira] [Commented] (KAFKA-13859) SCRAM authentication issues with kafka-clients 3.0.1

2022-04-28 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529441#comment-17529441 ] Luke Chen commented on KAFKA-13859: --- [~opayne] , we want to know the version of kafka

[GitHub] [kafka] dajac commented on a diff in pull request #12029: KAFKA-13815: Avoid reinitialization for a replica that is being deleted

2022-04-28 Thread GitBox
dajac commented on code in PR #12029: URL: https://github.com/apache/kafka/pull/12029#discussion_r860897319 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -674,21 +682,29 @@ class UnifiedLog(@volatile var logStartOffset: Long, } /** - * Rename the directory o

[jira] [Resolved] (KAFKA-13452) MM2 creates invalid checkpoint when offset mapping is not available

2022-04-28 Thread Viktor Somogyi-Vass (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass resolved KAFKA-13452. - Resolution: Duplicate > MM2 creates invalid checkpoint when offset mapping is no

[jira] [Commented] (KAFKA-7988) Flaky Test DynamicBrokerReconfigurationTest#testThreadPoolResize

2022-04-28 Thread lqjacklee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529449#comment-17529449 ] lqjacklee commented on KAFKA-7988: -- why exist the same thread name ? {code:java} Invali

[jira] [Assigned] (KAFKA-13504) Retry connect internal topics' creation in case of InvalidReplicationFactorException

2022-04-28 Thread Viktor Somogyi-Vass (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass reassigned KAFKA-13504: --- Assignee: Viktor Somogyi-Vass (was: Andras Katona) > Retry connect interna

[jira] [Resolved] (KAFKA-13442) REST API endpoint for fetching a connector's config definition

2022-04-28 Thread Viktor Somogyi-Vass (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass resolved KAFKA-13442. - Resolution: Duplicate > REST API endpoint for fetching a connector's config defi

[jira] [Resolved] (KAFKA-6084) ReassignPartitionsCommand should propagate JSON parsing failures

2022-04-28 Thread Viktor Somogyi-Vass (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass resolved KAFKA-6084. Fix Version/s: 2.8.0 Resolution: Fixed > ReassignPartitionsCommand should pr

[jira] [Updated] (KAFKA-13240) HTTP TRACE should be disabled in Connect

2022-04-28 Thread Viktor Somogyi-Vass (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass updated KAFKA-13240: Labels: cloudera (was: ) > HTTP TRACE should be disabled in Connect > ---

[jira] [Updated] (KAFKA-8468) AdminClient.deleteTopics doesn't wait until topic is deleted

2022-04-28 Thread Viktor Somogyi-Vass (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass updated KAFKA-8468: --- Labels: cloudera (was: ) > AdminClient.deleteTopics doesn't wait until topic is dele

[jira] [Updated] (KAFKA-1774) REPL and Shell Client for Admin Message RQ/RP

2022-04-28 Thread Viktor Somogyi-Vass (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass updated KAFKA-1774: --- Priority: Minor (was: Major) > REPL and Shell Client for Admin Message RQ/RP > -

[jira] [Updated] (KAFKA-6187) Remove the Logging class in favor of LazyLogging in scala-logging

2022-04-28 Thread Viktor Somogyi-Vass (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass updated KAFKA-6187: --- Priority: Minor (was: Major) > Remove the Logging class in favor of LazyLogging in s

[jira] [Updated] (KAFKA-10586) Full support for distributed mode in dedicated MirrorMaker 2.0 clusters

2022-04-28 Thread Viktor Somogyi-Vass (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass updated KAFKA-10586: Labels: cloudera (was: ) > Full support for distributed mode in dedicated MirrorM

[jira] [Updated] (KAFKA-13504) Retry connect internal topics' creation in case of InvalidReplicationFactorException

2022-04-28 Thread Viktor Somogyi-Vass (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass updated KAFKA-13504: Labels: cloudera (was: ) > Retry connect internal topics' creation in case of >

[jira] [Updated] (KAFKA-10650) Use Murmur3 hashing instead of MD5 in SkimpyOffsetMap

2022-04-28 Thread Viktor Somogyi-Vass (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass updated KAFKA-10650: Labels: cloudera (was: ) > Use Murmur3 hashing instead of MD5 in SkimpyOffsetMap

[jira] [Assigned] (KAFKA-8195) Unstable Producer After Send Failure in Transaction

2022-04-28 Thread Viktor Somogyi-Vass (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass reassigned KAFKA-8195: -- Assignee: (was: Viktor Somogyi-Vass) > Unstable Producer After Send Failur

[jira] [Updated] (KAFKA-10430) Hook support

2022-04-28 Thread Viktor Somogyi-Vass (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass updated KAFKA-10430: Priority: Critical (was: Major) > Hook support > > >

[jira] [Updated] (KAFKA-10430) Hook support

2022-04-28 Thread Viktor Somogyi-Vass (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass updated KAFKA-10430: Labels: cloudera (was: ) > Hook support > > > Key: K

[jira] [Created] (KAFKA-13860) add Decommissioning feature to kafka-reassign-partitions.sh

2022-04-28 Thread lqjacklee (Jira)
lqjacklee created KAFKA-13860: - Summary: add Decommissioning feature to kafka-reassign-partitions.sh Key: KAFKA-13860 URL: https://issues.apache.org/jira/browse/KAFKA-13860 Project: Kafka Issue

[jira] [Updated] (KAFKA-13860) add Decommissioning feature to kafka-reassign-partitions.sh

2022-04-28 Thread lqjacklee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lqjacklee updated KAFKA-13860: -- Description: try to replay the issue * 1, startup cluster with broker 1, 2 * 2, create topic a which

[jira] [Commented] (KAFKA-13255) Mirrormaker config property config.properties.exclude is not working as expected

2022-04-28 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529541#comment-17529541 ] Edoardo Comar commented on KAFKA-13255: --- Would have been really nice to have this

[GitHub] [kafka] artemlivshits commented on a diff in pull request #12049: KAFKA-10888: Sticky partition leads to uneven produce msg

2022-04-28 Thread GitBox
artemlivshits commented on code in PR #12049: URL: https://github.com/apache/kafka/pull/12049#discussion_r861185234 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/BuiltInPartitioner.java: ## @@ -0,0 +1,334 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [kafka] artemlivshits commented on a diff in pull request #12096: KAFKA-13794: Fix comparator of inflightBatchesBySequence in TransactionsManager (round 3)

2022-04-28 Thread GitBox
artemlivshits commented on code in PR #12096: URL: https://github.com/apache/kafka/pull/12096#discussion_r861204817 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -175,11 +175,8 @@ private static class TopicPartitionEntry {

[GitHub] [kafka] ijuma commented on a diff in pull request #12096: KAFKA-13794: Fix comparator of inflightBatchesBySequence in TransactionsManager (round 3)

2022-04-28 Thread GitBox
ijuma commented on code in PR #12096: URL: https://github.com/apache/kafka/pull/12096#discussion_r861287962 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -175,11 +175,8 @@ private static class TopicPartitionEntry { /

[GitHub] [kafka] ijuma commented on a diff in pull request #12096: KAFKA-13794: Fix comparator of inflightBatchesBySequence in TransactionsManager (round 3)

2022-04-28 Thread GitBox
ijuma commented on code in PR #12096: URL: https://github.com/apache/kafka/pull/12096#discussion_r861287962 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -175,11 +175,8 @@ private static class TopicPartitionEntry { /

[GitHub] [kafka] gitlw commented on a diff in pull request #12029: KAFKA-13815: Avoid reinitialization for a replica that is being deleted

2022-04-28 Thread GitBox
gitlw commented on code in PR #12029: URL: https://github.com/apache/kafka/pull/12029#discussion_r861303845 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -674,21 +682,29 @@ class UnifiedLog(@volatile var logStartOffset: Long, } /** - * Rename the directory o

[GitHub] [kafka] gitlw commented on a diff in pull request #12029: KAFKA-13815: Avoid reinitialization for a replica that is being deleted

2022-04-28 Thread GitBox
gitlw commented on code in PR #12029: URL: https://github.com/apache/kafka/pull/12029#discussion_r861304743 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2615,7 +2615,10 @@ class ReplicaManagerTest { @Test def testStopReplicaWithDeletePartiti

[GitHub] [kafka] ahuang98 commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-28 Thread GitBox
ahuang98 commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r861323350 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] guozhangwang commented on pull request #12102: HOTFIX: Only measure in nano when producer metadata refresh is required

2022-04-28 Thread GitBox
guozhangwang commented on PR #12102: URL: https://github.com/apache/kafka/pull/12102#issuecomment-1112679677 Ah yes :) my bad. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [kafka] junrao commented on a diff in pull request #12049: KAFKA-10888: Sticky partition leads to uneven produce msg

2022-04-28 Thread GitBox
junrao commented on code in PR #12049: URL: https://github.com/apache/kafka/pull/12049#discussion_r861165914 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -160,91 +218,156 @@ public double measure(MetricConfig config, long now

[jira] [Created] (KAFKA-13861) validateOnly request field does not work for CreatePartition requests in Kraft mode.

2022-04-28 Thread Akhilesh Chaganti (Jira)
Akhilesh Chaganti created KAFKA-13861: - Summary: validateOnly request field does not work for CreatePartition requests in Kraft mode. Key: KAFKA-13861 URL: https://issues.apache.org/jira/browse/KAFKA-13861

[GitHub] [kafka] C0urante commented on a diff in pull request #11983: KAFKA-13763 (2): Refactor IncrementalCooperativeAssignor for improved unit testing

2022-04-28 Thread GitBox
C0urante commented on code in PR #11983: URL: https://github.com/apache/kafka/pull/11983#discussion_r861366648 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignorTest.java: ## @@ -1142,107 +982,65 @@ private void removeCon

[GitHub] [kafka] C0urante commented on a diff in pull request #11983: KAFKA-13763 (2): Refactor IncrementalCooperativeAssignor for improved unit testing

2022-04-28 Thread GitBox
C0urante commented on code in PR #11983: URL: https://github.com/apache/kafka/pull/11983#discussion_r861366880 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignorTest.java: ## @@ -44,93 +35,49 @@ import java.util.HashSet;

[GitHub] [kafka] C0urante commented on pull request #11983: KAFKA-13763 (2): Refactor IncrementalCooperativeAssignor for improved unit testing

2022-04-28 Thread GitBox
C0urante commented on PR #11983: URL: https://github.com/apache/kafka/pull/11983#issuecomment-1112729047 Thanks @showuon, pushed the requested changes 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] akhileshchg opened a new pull request, #12106: KAFKA-13861: Fix the validateOnly behavior for CreatePartitions requests in KRaft mode

2022-04-28 Thread GitBox
akhileshchg opened a new pull request, #12106: URL: https://github.com/apache/kafka/pull/12106 KAFKA-13861: Fix the validateOnly behavior for `CreatePartitions` requests in KRaft mode The KRaft implementation of the `CreatePartitions` ignores the `validateOnly` flag in the request

[GitHub] [kafka] cmccabe commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-28 Thread GitBox
cmccabe commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r861398133 ## clients/src/main/java/org/apache/kafka/common/requests/ApiVersionsResponse.java: ## @@ -271,4 +273,48 @@ public static ApiVersion toApiVersion(ApiKeys apiKey) {

[GitHub] [kafka] cmccabe commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-28 Thread GitBox
cmccabe commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r861399365 ## clients/src/main/java/org/apache/kafka/common/requests/ApiVersionsResponse.java: ## @@ -271,4 +273,48 @@ public static ApiVersion toApiVersion(ApiKeys apiKey) {

[GitHub] [kafka] cmccabe commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-28 Thread GitBox
cmccabe commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r861399496 ## clients/src/main/java/org/apache/kafka/common/requests/ApiVersionsResponse.java: ## @@ -271,4 +273,48 @@ public static ApiVersion toApiVersion(ApiKeys apiKey) {

[GitHub] [kafka] cmccabe commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-28 Thread GitBox
cmccabe commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r861400780 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -0,0 +1,296 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] cmccabe commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-28 Thread GitBox
cmccabe commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r861401469 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -0,0 +1,296 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] cmccabe commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-28 Thread GitBox
cmccabe commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r861401814 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -0,0 +1,296 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] cmccabe commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-28 Thread GitBox
cmccabe commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r861402035 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -0,0 +1,296 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] cmccabe commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-28 Thread GitBox
cmccabe commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r861402357 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -0,0 +1,296 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] cmccabe commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-28 Thread GitBox
cmccabe commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r861404104 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -0,0 +1,296 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] cmccabe commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-28 Thread GitBox
cmccabe commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r861404608 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -0,0 +1,296 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] cmccabe commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-28 Thread GitBox
cmccabe commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r861404993 ## server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java: ## @@ -0,0 +1,330 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [kafka] cmccabe commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-28 Thread GitBox
cmccabe commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r861405580 ## core/src/test/scala/unit/kafka/security/authorizer/AclAuthorizerTest.scala: ## @@ -714,7 +716,7 @@ class AclAuthorizerTest extends QuorumTestHarness with BaseAuthori

[GitHub] [kafka] cmccabe commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-28 Thread GitBox
cmccabe commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r861406780 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] cmccabe commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-28 Thread GitBox
cmccabe commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r861406780 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] cmccabe commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-28 Thread GitBox
cmccabe commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r861406780 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] cmccabe commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-28 Thread GitBox
cmccabe commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r861406780 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] cmccabe commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-28 Thread GitBox
cmccabe commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r861400780 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -0,0 +1,296 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[jira] [Updated] (KAFKA-13860) add Decommissioning feature to kafka-reassign-partitions.sh

2022-04-28 Thread lqjacklee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lqjacklee updated KAFKA-13860: -- Description: try to replay the issue * 1, startup cluster with broker 1, 2 * 2, create topic a which

[GitHub] [kafka] dengziming commented on a diff in pull request #12106: KAFKA-13861: Fix the validateOnly behavior for CreatePartitions requests in KRaft mode

2022-04-28 Thread GitBox
dengziming commented on code in PR #12106: URL: https://github.com/apache/kafka/pull/12106#discussion_r861427340 ## core/src/main/scala/kafka/server/ControllerApis.scala: ## @@ -767,7 +767,7 @@ class ControllerApis(val requestChannel: RequestChannel, setErrorCode(TOPI

[GitHub] [kafka] dengziming commented on a diff in pull request #12106: KAFKA-13861: Fix the validateOnly behavior for CreatePartitions requests in KRaft mode

2022-04-28 Thread GitBox
dengziming commented on code in PR #12106: URL: https://github.com/apache/kafka/pull/12106#discussion_r861427340 ## core/src/main/scala/kafka/server/ControllerApis.scala: ## @@ -767,7 +767,7 @@ class ControllerApis(val requestChannel: RequestChannel, setErrorCode(TOPI

[GitHub] [kafka] dengziming commented on pull request #12105: KAFKA-13859: Disable idempotence on SCRAM authentication

2022-04-28 Thread GitBox
dengziming commented on PR #12105: URL: https://github.com/apache/kafka/pull/12105#issuecomment-1112825596 Close this since this is designed intentionally, we should help the users to make this change. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] dengziming closed pull request #12105: KAFKA-13859: Disable idempotence on SCRAM authentication

2022-04-28 Thread GitBox
dengziming closed pull request #12105: KAFKA-13859: Disable idempotence on SCRAM authentication URL: https://github.com/apache/kafka/pull/12105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [kafka] dengziming commented on a diff in pull request #12104: KAFKA-13746: Attempt to fix flaky test by waiting to fetch 2 topics f…

2022-04-28 Thread GitBox
dengziming commented on code in PR #12104: URL: https://github.com/apache/kafka/pull/12104#discussion_r861428332 ## core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala: ## @@ -733,12 +733,18 @@ class TopicCommandIntegrationTest extends KafkaServerTestH

[GitHub] [kafka] showuon commented on pull request #12105: KAFKA-13859: Disable idempotence on SCRAM authentication

2022-04-28 Thread GitBox
showuon commented on PR #12105: URL: https://github.com/apache/kafka/pull/12105#issuecomment-1112827223 Thanks @dengziming ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Resolved] (KAFKA-13859) SCRAM authentication issues with kafka-clients 3.0.1

2022-04-28 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming resolved KAFKA-13859. Resolution: Not A Problem In [KIP-679]([https://cwiki.apache.org/confluence/display/KAFKA/KIP-679

[GitHub] [kafka] dengziming commented on a diff in pull request #12106: KAFKA-13861: Fix the validateOnly behavior for CreatePartitions requests in KRaft mode

2022-04-28 Thread GitBox
dengziming commented on code in PR #12106: URL: https://github.com/apache/kafka/pull/12106#discussion_r861427340 ## core/src/main/scala/kafka/server/ControllerApis.scala: ## @@ -767,7 +767,7 @@ class ControllerApis(val requestChannel: RequestChannel, setErrorCode(TOPI

[GitHub] [kafka] karuturi commented on pull request #11955: KAFKA-12380 Executor in Connect's Worker is not shut down when the worker is

2022-04-28 Thread GitBox
karuturi commented on PR #11955: URL: https://github.com/apache/kafka/pull/11955#issuecomment-1112871477 > Jenkins has failures unrelated to this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] showuon commented on pull request #11955: KAFKA-12380 Executor in Connect's Worker is not shut down when the worker is

2022-04-28 Thread GitBox
showuon commented on PR #11955: URL: https://github.com/apache/kafka/pull/11955#issuecomment-1112891047 Failed tests are unrelated: ``` Build / JDK 8 and Scala 2.12 / kafka.network.ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit() ``` -- This is an au

[GitHub] [kafka] showuon commented on pull request #11955: KAFKA-12380 Executor in Connect's Worker is not shut down when the worker is

2022-04-28 Thread GitBox
showuon commented on PR #11955: URL: https://github.com/apache/kafka/pull/11955#issuecomment-1112892566 @karuturi , thanks for the contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] showuon merged pull request #11955: KAFKA-12380 Executor in Connect's Worker is not shut down when the worker is

2022-04-28 Thread GitBox
showuon merged PR #11955: URL: https://github.com/apache/kafka/pull/11955 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] showuon commented on pull request #10337: KAFKA-12380: Executor in Connect's Worker is not shut down when the worker is

2022-04-28 Thread GitBox
showuon commented on PR #10337: URL: https://github.com/apache/kafka/pull/10337#issuecomment-1112892966 Close this PR because it's pending for a long time, and another [PR](https://github.com/apache/kafka/pull/11955) already addressed this issue. -- This is an automated message from the A

[GitHub] [kafka] showuon closed pull request #10337: KAFKA-12380: Executor in Connect's Worker is not shut down when the worker is

2022-04-28 Thread GitBox
showuon closed pull request #10337: KAFKA-12380: Executor in Connect's Worker is not shut down when the worker is URL: https://github.com/apache/kafka/pull/10337 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[jira] [Resolved] (KAFKA-12380) Executor in Connect's Worker is not shut down when the worker is

2022-04-28 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-12380. --- Fix Version/s: 3.3.0 Resolution: Fixed > Executor in Connect's Worker is not shut down when t

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #12104: KAFKA-13746: Attempt to fix flaky test by waiting to fetch 2 topics f…

2022-04-28 Thread GitBox
vamossagar12 commented on code in PR #12104: URL: https://github.com/apache/kafka/pull/12104#discussion_r861479117 ## core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala: ## @@ -733,12 +733,18 @@ class TopicCommandIntegrationTest extends KafkaServerTes