[GitHub] [kafka] cmccabe commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

[GitBox]

cmccabe commented on code in PR #12072:
URL: https://github.com/apache/kafka/pull/12072#discussion_r861398133


##########
clients/src/main/java/org/apache/kafka/common/requests/ApiVersionsResponse.java:
##########
@@ -271,4 +273,48 @@ public static ApiVersion toApiVersion(ApiKeys apiKey) {
             .setMinVersion(apiKey.oldestVersion())
             .setMaxVersion(apiKey.latestVersion());
     }
+
+    public static ApiVersionsResponse apiVersionsResponse(
+        Integer throttleTimeMs,

Review Comment:
   This is a small thing, I guess, but why `Integer` and not `int`? This cannot 
be null, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org