[GitHub] [kafka] showuon commented on a diff in pull request #11438: KAFKA-13403 Fix KafkaServer crashes when deleting topics due to the race in log deletion

2022-04-26 Thread GitBox
showuon commented on code in PR #11438: URL: https://github.com/apache/kafka/pull/11438#discussion_r858349721 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -853,15 +853,21 @@ public static void delete(final File rootFile) throws IOException {

[jira] [Commented] (KAFKA-13855) FileNotFoundException: Error while rolling log segment for topic partition in dir

2022-04-26 Thread Haruki Okada (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527961#comment-17527961 ] Haruki Okada commented on KAFKA-13855: -- H-mm sorry, sounds like I just overstepped.

[jira] [Comment Edited] (KAFKA-13403) KafkaServer crashes when deleting topics due to the race in log deletion

2022-04-26 Thread Haruki Okada (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17527800#comment-17527800 ] Haruki Okada edited comment on KAFKA-13403 at 4/26/22 7:35 AM: ---

[jira] [Assigned] (KAFKA-13459) MM2 should be able to add the source offset to the record header

2022-04-26 Thread Viktor Somogyi-Vass (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass reassigned KAFKA-13459: --- Assignee: Viktor Somogyi-Vass > MM2 should be able to add the source offset

[jira] [Assigned] (KAFKA-10586) Full support for distributed mode in dedicated MirrorMaker 2.0 clusters

2022-04-26 Thread Viktor Somogyi-Vass (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass reassigned KAFKA-10586: --- Assignee: Viktor Somogyi-Vass (was: Daniel Urban) > Full support for distr

[GitHub] [kafka] vamossagar12 commented on pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

2022-04-26 Thread GitBox
vamossagar12 commented on PR #11211: URL: https://github.com/apache/kafka/pull/11211#issuecomment-1109503519 Thanks @showuon ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

2022-04-26 Thread GitBox
vamossagar12 commented on code in PR #11433: URL: https://github.com/apache/kafka/pull/11433#discussion_r858432879 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -262,6 +262,42 @@ private void closeDirtyAndRevive(final Collection t

[GitHub] [kafka] showuon commented on a diff in pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

2022-04-26 Thread GitBox
showuon commented on code in PR #11433: URL: https://github.com/apache/kafka/pull/11433#discussion_r858437939 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -262,6 +262,42 @@ private void closeDirtyAndRevive(final Collection taskWi

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

2022-04-26 Thread GitBox
vamossagar12 commented on code in PR #11433: URL: https://github.com/apache/kafka/pull/11433#discussion_r858441929 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -262,6 +262,42 @@ private void closeDirtyAndRevive(final Collection t

[GitHub] [kafka] cadonna commented on pull request #12064: KAFKA-12841: Remove an additional call of onAcknowledgement

2022-04-26 Thread GitBox
cadonna commented on PR #12064: URL: https://github.com/apache/kafka/pull/12064#issuecomment-1109538143 @junrao @philipnee Thank you for pinging me! Since I have already created RC0 which is under voting I actually only accept regressions and exceptionally severe bugs that justify the cr

[GitHub] [kafka] dengziming commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-26 Thread GitBox
dengziming commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r858479425 ## core/src/main/scala/kafka/api/ApiVersion.scala: ## @@ -1,500 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor lic

[jira] [Commented] (KAFKA-13716) add tests for `DeleteRecordsCommand` class

2022-04-26 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528047#comment-17528047 ] Divij Vaidya commented on KAFKA-13716: -- Hey folks [https://github.com/apache/kafka

[GitHub] [kafka] LatentLag opened a new pull request, #12095: MINOR: Adding client Base64 serializer and deserializer

2022-04-26 Thread GitBox
LatentLag opened a new pull request, #12095: URL: https://github.com/apache/kafka/pull/12095 Adding client serialization for Base64 which enables two use cases. First, these allow messages encoded in base64 to not incur the encoding penalty of a larger file size. Second, binary encoded mess

[GitHub] [kafka] aybefox commented on pull request #9947: KAFKA-12190: Fix setting of file permissions on non-POSIX filesystems

2022-04-26 Thread GitBox
aybefox commented on PR #9947: URL: https://github.com/apache/kafka/pull/9947#issuecomment-1109626111 @notme159 Same here :( Did you find out something? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] dajac commented on pull request #12095: MINOR: Adding client Base64 serializer and deserializer

2022-04-26 Thread GitBox
dajac commented on PR #12095: URL: https://github.com/apache/kafka/pull/12095#issuecomment-1109648747 @LatentLag Thanks for the PR. I think that we would need a KIP for adding those because I suppose that we consider them as public interfaces. The process is described here: https://cwiki.

[GitHub] [kafka] viktorsomogyi commented on pull request #11492: KAFKA-13452: MM2 shouldn't checkpoint when offset mapping is unavailable

2022-04-26 Thread GitBox
viktorsomogyi commented on PR #11492: URL: https://github.com/apache/kafka/pull/11492#issuecomment-1109725104 @mimaison would you please review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Created] (KAFKA-13857) The listOffsets method of KafkaAdminClient should support returning logEndOffset of topicPartition

2022-04-26 Thread RivenSun (Jira)
RivenSun created KAFKA-13857: Summary: The listOffsets method of KafkaAdminClient should support returning logEndOffset of topicPartition Key: KAFKA-13857 URL: https://issues.apache.org/jira/browse/KAFKA-13857

[jira] [Updated] (KAFKA-13857) The listOffsets method of KafkaAdminClient should support returning logEndOffset of topicPartition

2022-04-26 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] RivenSun updated KAFKA-13857: - Description: The server side currently handles the LIST_OFFSETS request process as follows: {code:java}

[jira] [Commented] (KAFKA-13857) The listOffsets method of KafkaAdminClient should support returning logEndOffset of topicPartition

2022-04-26 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528170#comment-17528170 ] RivenSun commented on KAFKA-13857: -- Hi [~guozhang]  [~showuon] Could you give some sugg

[jira] [Commented] (KAFKA-13716) add tests for `DeleteRecordsCommand` class

2022-04-26 Thread Richard Joerger (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528174#comment-17528174 ] Richard Joerger commented on KAFKA-13716: - [~divijvaidya] , that clears that up

[GitHub] [kafka] ijuma opened a new pull request, #12096: KAFKA-13794: Fix comparator of inflightBatchesBySequence in TransactionsManager (round 3)

2022-04-26 Thread GitBox
ijuma opened a new pull request, #12096: URL: https://github.com/apache/kafka/pull/12096 Conceptually, the ordering is defined by the producer id, producer epoch and the sequence number. A given `TopicPartitionEntry` has a single producer id and hence we only need to compare the other t

[jira] [Updated] (KAFKA-13857) The listOffsets method of KafkaAdminClient should support returning logEndOffset of topicPartition

2022-04-26 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] RivenSun updated KAFKA-13857: - Description: The server side currently handles the LIST_OFFSETS request process as follows: {code:java}

[GitHub] [kafka] dengziming commented on a diff in pull request #11951: KAFKA-13836: Improve KRaft broker heartbeat logic

2022-04-26 Thread GitBox
dengziming commented on code in PR #11951: URL: https://github.com/apache/kafka/pull/11951#discussion_r858760908 ## core/src/main/scala/kafka/server/BrokerLifecycleManager.scala: ## @@ -333,7 +353,11 @@ class BrokerLifecycleManager(val config: KafkaConfig, } private def

[GitHub] [kafka] mumrah commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-26 Thread GitBox
mumrah commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r858801361 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersionValidator.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] mumrah commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-26 Thread GitBox
mumrah commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r858801361 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersionValidator.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] joel-hamill commented on pull request #12094: MINOR: fix html generation syntax errors

2022-04-26 Thread GitBox
joel-hamill commented on PR #12094: URL: https://github.com/apache/kafka/pull/12094#issuecomment-1109970872 cc @ijuma @guozhangwang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [kafka] joel-hamill commented on pull request #11874: Fix typos in configuration docs

2022-04-26 Thread GitBox
joel-hamill commented on PR #11874: URL: https://github.com/apache/kafka/pull/11874#issuecomment-1109972244 cc @ijuma -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [kafka] ijuma opened a new pull request, #12097: MINOR: Make TopicPartitionBookkeeper and TopicPartitionEntry top level

2022-04-26 Thread GitBox
ijuma opened a new pull request, #12097: URL: https://github.com/apache/kafka/pull/12097 This is the first step towards refactoring the `TransactionManager` so that it's easier to understand and test. The high level idea is to push down behavior to `TopicPartitionEntry` and `TopicPartit

[GitHub] [kafka] junrao commented on pull request #12064: KAFKA-12841: Remove an additional call of onAcknowledgement

2022-04-26 Thread GitBox
junrao commented on PR #12064: URL: https://github.com/apache/kafka/pull/12064#issuecomment-1109979635 @cadonna : Thanks for the response. This bug was actually introduced in 3.2.0. I will ping the mailing list. -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [kafka] hachikuji merged pull request #12089: MINOR: Rename `AlterIsrManager` to `AlterPartitionManager`

2022-04-26 Thread GitBox
hachikuji merged PR #12089: URL: https://github.com/apache/kafka/pull/12089 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

[jira] [Commented] (KAFKA-13647) RocksDb metrics 'number-open-files' is not correct

2022-04-26 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528288#comment-17528288 ] Matthias J. Sax commented on KAFKA-13647: - Should we close this ticket? \cc [~gu

[jira] [Commented] (KAFKA-13840) KafkaConsumer is unable to recover connection to group coordinator after commitOffsetsAsync exception

2022-04-26 Thread Kyle R Stehbens (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528300#comment-17528300 ] Kyle R Stehbens commented on KAFKA-13840: - Gotcha, i'll give these new versions

[GitHub] [kafka] cadonna commented on pull request #12064: KAFKA-12841: Remove an additional call of onAcknowledgement

2022-04-26 Thread GitBox
cadonna commented on PR #12064: URL: https://github.com/apache/kafka/pull/12064#issuecomment-1110039917 @junrao Now I see how this issue was introduced in 3.2.0. The fix for the bug described in KAFKA-12841 introduced it, right? I initially understood that this PR is the fix for the bug des

[GitHub] [kafka] ijuma commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-26 Thread GitBox
ijuma commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r858974266 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] ijuma commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-26 Thread GitBox
ijuma commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r858975278 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] ijuma commented on a diff in pull request #12052: KAFKA-13799: Improve documentation for Kafka zero-copy

2022-04-26 Thread GitBox
ijuma commented on code in PR #12052: URL: https://github.com/apache/kafka/pull/12052#discussion_r858994743 ## docs/design.html: ## @@ -125,6 +125,9 @@ This combination of pagecache and sendfile means that on a Kafka cluster where the consumers are mostly caught up

[GitHub] [kafka] junrao commented on pull request #12064: KAFKA-12841: Remove an additional call of onAcknowledgement

2022-04-26 Thread GitBox
junrao commented on PR #12064: URL: https://github.com/apache/kafka/pull/12064#issuecomment-1110094353 Thanks, @cadonna. I will mark the jira as fixed in 3.2.0 then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Resolved] (KAFKA-13448) Kafka Producer Client Callback behaviour does not align with Javadoc

2022-04-26 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-13448. - Fix Version/s: 3.2.0 Assignee: Philip Nee Resolution: Fixed merged [https://github.com/a

[jira] [Assigned] (KAFKA-12841) NPE from the provided metadata in client callback in case of ApiException

2022-04-26 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao reassigned KAFKA-12841: --- Fix Version/s: 3.2.0 Assignee: Philip Nee (was: Kirk True) Resolution: Fixed merge

[GitHub] [kafka] ahuang98 commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-26 Thread GitBox
ahuang98 commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r859016703 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Resolved] (KAFKA-13647) RocksDb metrics 'number-open-files' is not correct

2022-04-26 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-13647. --- Resolution: Incomplete I resolved the ticket for now as incomplete, since the streams code c

[GitHub] [kafka] mumrah commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-26 Thread GitBox
mumrah commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r859055329 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [kafka] ijuma commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-26 Thread GitBox
ijuma commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r859091472 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] junrao commented on a diff in pull request #12029: KAFKA-13815: Avoid reinitialization for a replica that is being deleted

2022-04-26 Thread GitBox
junrao commented on code in PR #12029: URL: https://github.com/apache/kafka/pull/12029#discussion_r859114446 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -674,21 +682,29 @@ class UnifiedLog(@volatile var logStartOffset: Long, } /** - * Rename the directory

[jira] [Created] (KAFKA-13858) Kraft should not shutdown metadata listener until controller shutdown is finished

2022-04-26 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-13858: --- Summary: Kraft should not shutdown metadata listener until controller shutdown is finished Key: KAFKA-13858 URL: https://issues.apache.org/jira/browse/KAFKA-13858

[jira] [Updated] (KAFKA-13858) Kraft should not shutdown metadata listener until controller shutdown is finished

2022-04-26 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-13858: Description: When the kraft broker begins controlled shutdown, it immediately disables the

[GitHub] [kafka] ahuang98 commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-26 Thread GitBox
ahuang98 commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r859155538 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] hachikuji opened a new pull request, #12098: MINOR: Fix event output inconsistencies in TransactionalMessageCopier

2022-04-26 Thread GitBox
hachikuji opened a new pull request, #12098: URL: https://github.com/apache/kafka/pull/12098 There is some strangeness and inconsistencies in the messages written by `TransactionalMessageCopier` to stdout. Here is a sample of two messages. Progress message: ``` {"consumed":3300

[GitHub] [kafka] ahuang98 commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-26 Thread GitBox
ahuang98 commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r859155538 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -0,0 +1,316 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Updated] (KAFKA-13858) Kraft should not shutdown metadata listener until controller shutdown is finished

2022-04-26 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-13858: Labels: kip-500 (was: ) > Kraft should not shutdown metadata listener until controller sh

[GitHub] [kafka] ijuma commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-26 Thread GitBox
ijuma commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r859163758 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -0,0 +1,334 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] guozhangwang merged pull request #12094: MINOR: fix html generation syntax errors

2022-04-26 Thread GitBox
guozhangwang merged PR #12094: URL: https://github.com/apache/kafka/pull/12094 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12052: KAFKA-13799: Improve documentation for Kafka zero-copy

2022-04-26 Thread GitBox
RivenSun2 commented on code in PR #12052: URL: https://github.com/apache/kafka/pull/12052#discussion_r859296011 ## docs/design.html: ## @@ -125,6 +125,9 @@ This combination of pagecache and sendfile means that on a Kafka cluster where the consumers are mostly caught

[GitHub] [kafka] ijuma commented on a diff in pull request #12052: KAFKA-13799: Improve documentation for Kafka zero-copy

2022-04-26 Thread GitBox
ijuma commented on code in PR #12052: URL: https://github.com/apache/kafka/pull/12052#discussion_r859326941 ## docs/design.html: ## @@ -125,6 +125,9 @@ This combination of pagecache and sendfile means that on a Kafka cluster where the consumers are mostly caught up

[jira] [Updated] (KAFKA-13824) Pass time object from constructor so that we can mock it if needed

2022-04-26 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-13824: -- Description: (was: In [https://github.com/apache/kafka/pull/11896,] for streams/src/main/j

[jira] [Updated] (KAFKA-13824) Pass time object from constructor so that we can mock it if needed

2022-04-26 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-13824: -- Labels: test (was: ) > Pass time object from constructor so that we can mock it if needed > -

[jira] [Updated] (KAFKA-13824) Pass time object from constructor so that we can mock it if needed

2022-04-26 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-13824: -- Description: We pass in the {{Time}} object in the StreamThread, which is used to measure var

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12052: KAFKA-13799: Improve documentation for Kafka zero-copy

2022-04-26 Thread GitBox
RivenSun2 commented on code in PR #12052: URL: https://github.com/apache/kafka/pull/12052#discussion_r859353961 ## docs/design.html: ## @@ -125,6 +125,9 @@ This combination of pagecache and sendfile means that on a Kafka cluster where the consumers are mostly caught

[GitHub] [kafka] RivenSun2 opened a new pull request, #12099: MINOR: Improve ssl description in zero-copy docs

2022-04-26 Thread GitBox
RivenSun2 opened a new pull request, #12099: URL: https://github.com/apache/kafka/pull/12099 Improvements to PR #12052, improve ssl description in zero-copy docs ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test cover

[GitHub] [kafka] guozhangwang commented on a diff in pull request #11896: KAFKA-13785: [6/N][Emit final] emit final for TimeWindowedKStreamImpl

2022-04-26 Thread GitBox
guozhangwang commented on code in PR #11896: URL: https://github.com/apache/kafka/pull/11896#discussion_r859364452 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamWindowAggregate.java: ## @@ -184,6 +247,78 @@ public void process(final Record record) {

[GitHub] [kafka] guozhangwang opened a new pull request, #12100: KAFKA-13785: [6/N][Emit final] Copy: Emit final for TimeWindowedKStreamImpl

2022-04-26 Thread GitBox
guozhangwang opened a new pull request, #12100: URL: https://github.com/apache/kafka/pull/12100 This is a copy PR of https://github.com/apache/kafka/pull/11896. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test covera

[GitHub] [kafka] guozhangwang commented on pull request #12100: KAFKA-13785: [6/N][Emit final] Copy: Emit final for TimeWindowedKStreamImpl

2022-04-26 Thread GitBox
guozhangwang commented on PR #12100: URL: https://github.com/apache/kafka/pull/12100#issuecomment-1110551346 The only differences between this copy PR and the original ones are 1) resolved conflicts, 2) incorporated latest comments. cc @mjsax -- This is an automated message from the

[GitHub] [kafka] showuon commented on a diff in pull request #11955: KAFKA-12380 Executor in Connect's Worker is not shut down when the worker is

2022-04-26 Thread GitBox
showuon commented on code in PR #11955: URL: https://github.com/apache/kafka/pull/11955#discussion_r859425060 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -222,6 +223,14 @@ public void stop() { connectorStatusMetricsGroup.close();