hachikuji opened a new pull request, #12098:
URL: https://github.com/apache/kafka/pull/12098

   There is some strangeness and inconsistencies in the messages written by 
`TransactionalMessageCopier` to stdout. Here is a sample of two messages.
   
   Progress message:
   ```
   
{"consumed":33000,"stage":"ProcessLoop","totalProcessed":33000,"progress":"copier-0","time":"2022/04/24
 05:40:31:649","remaining":333}
   ```
   The `transactionalId` is set to the value of the `progress` key.
   
   And a shutdown message:
   ```
   
{"consumed":33333,"shutdown_complete":"copier-0","totalProcessed":33333,"time":"2022/04/24
 05:40:31:937","remaining":0}
   ```
   The `transactionalId` this time is set to the `shutdown_complete` key.
   
   This patch fixes these issues with the following:
   
   1. Use a separate key for the `transactionalId`.
   2. Drop the `progress` and `shutdown_complete` fields.
   3. Use `stage=ShutdownComplete` in the shutdown message.
   
   
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to