[GitHub] [kafka] showuon opened a new pull request #11705: [WIP] KAFKA-9847: add config to set default store type

showuon opened a new pull request #11705: URL: https://github.com/apache/kafka/pull/11705 WIP ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including up

[GitHub] [kafka] satishd commented on pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

satishd commented on pull request #11390: URL: https://github.com/apache/kafka/pull/11390#issuecomment-1019966726 @junrao : Thanks for the review. Addressed your comments with the latest commits. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [kafka] dajac opened a new pull request #11706: MINOR: Upgrade netty to 4.1.73.Final

dajac opened a new pull request #11706: URL: https://github.com/apache/kafka/pull/11706 Changelog: https://github.com/netty/netty/issues?q=is%3Aclosed+milestone%3A4.1.73.Final ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] V

[GitHub] [kafka] patrickstuedi commented on a change in pull request #11676: KAFKA-13605: checkpoint position in state stores

patrickstuedi commented on a change in pull request #11676: URL: https://github.com/apache/kafka/pull/11676#discussion_r790728519 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBWindowStore.java ## @@ -52,10 +52,12 @@ @Override pub

[jira] [Created] (KAFKA-13613) Kafka Connect has a hard dependency on KeyGenerator.HmacSHA256

Guy Pascarella created KAFKA-13613: -- Summary: Kafka Connect has a hard dependency on KeyGenerator.HmacSHA256 Key: KAFKA-13613 URL: https://issues.apache.org/jira/browse/KAFKA-13613 Project: Kafka

[GitHub] [kafka] Kvicii commented on pull request #11704: KAFKA-13590: rename InternalTopologyBuilder#topicGroups

Kvicii commented on pull request #11704: URL: https://github.com/apache/kafka/pull/11704#issuecomment-1020117719 @sayantanu-dey hi, I wonder where the name came from, it's really a good name in context. -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [kafka] bfncs commented on pull request #7082: KAFKA-8659: SetSchemaMetadata SMT fails on records with null value and schema

bfncs commented on pull request #7082: URL: https://github.com/apache/kafka/pull/7082#issuecomment-1020120686 Does anyone have a pointer how we can proceed here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] sayantanu-dey commented on a change in pull request #11703: KAFKA-13588: consolidate `changelogFor` methods to simplify the generation of internal topic names

sayantanu-dey commented on a change in pull request #11703: URL: https://github.com/apache/kafka/pull/11703#discussion_r790776516 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -171,42 +169,24 @@ private void regist

[GitHub] [kafka] sayantanu-dey commented on pull request #11704: KAFKA-13590: rename InternalTopologyBuilder#topicGroups

sayantanu-dey commented on pull request #11704: URL: https://github.com/apache/kafka/pull/11704#issuecomment-1020145591 > @sayantanu-dey hi, I wonder where the name came from, it's really a good name in context. @Kvicii hi, thanks, I just saw that the function was returning the Map o

[GitHub] [kafka] sayantanu-dey edited a comment on pull request #11704: KAFKA-13590: rename InternalTopologyBuilder#topicGroups

sayantanu-dey edited a comment on pull request #11704: URL: https://github.com/apache/kafka/pull/11704#issuecomment-1020145591 > @sayantanu-dey hi, I wonder where the name came from, it's really a good name in context. @Kvicii hi, thanks, I just saw that the function was returning th

[jira] [Created] (KAFKA-13614) Leader replication quota is applied to consumer fetches

David Mao created KAFKA-13614: - Summary: Leader replication quota is applied to consumer fetches Key: KAFKA-13614 URL: https://issues.apache.org/jira/browse/KAFKA-13614 Project: Kafka Issue Type:

[GitHub] [kafka] hartmut-co-uk commented on pull request #7082: KAFKA-8659: SetSchemaMetadata SMT fails on records with null value and schema

hartmut-co-uk commented on pull request #7082: URL: https://github.com/apache/kafka/pull/7082#issuecomment-1020213068 the changes are small enough... but looking at other PRs seems they all are failing, too... -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] dajac merged pull request #11706: MINOR: Upgrade netty to 4.1.73.Final

dajac merged pull request #11706: URL: https://github.com/apache/kafka/pull/11706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] piotrsmolinski opened a new pull request #11707: KAFKA-13607 Fix of the empty values to be treated as if they were absent

piotrsmolinski opened a new pull request #11707: URL: https://github.com/apache/kafka/pull/11707 Added normalization to the input parameters of the createKeystore and createTruststore After the change the empty string values of path and passwords are treated as null. The change a

[GitHub] [kafka] dajac commented on pull request #11701: MINOR: Add 3.0 and 3.1 to broker and client compatibility tests

dajac commented on pull request #11701: URL: https://github.com/apache/kafka/pull/11701#issuecomment-1020351046 There are failures in the system tests but they are not related to this change. All the tests changed in this PR have passed. http://confluent-kafka-branch-builder-system-test-re

[GitHub] [kafka] dajac opened a new pull request #11708: MINOR: Upgrade netty to 4.1.73.Final

dajac opened a new pull request #11708: URL: https://github.com/apache/kafka/pull/11708 Changelog: https://github.com/netty/netty/issues?q=is%3Aclosed+milestone%3A4.1.73.Final Reviewers: Manikumar Reddy ### Committer Checklist (excluded from commit message) - [ ] Verify de

[GitHub] [kafka] dajac commented on pull request #11708: MINOR: Upgrade netty to 4.1.73.Final (3.0 branch)

dajac commented on pull request #11708: URL: https://github.com/apache/kafka/pull/11708#issuecomment-1020369488 @omkreddy This is the cherry-pick for https://github.com/apache/kafka/pull/11706 for 3.0. The cherry-pick was not clean. Could you take a look please? -- This is an automated

[jira] [Commented] (KAFKA-13612) internal topics won't be created in metadataRequest when auto.create.topics.enable=false

[ https://issues.apache.org/jira/browse/KAFKA-13612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17481329#comment-17481329 ] Jason Gustafson commented on KAFKA-13612: - [~showuon] Thanks for filing the JIRA

[GitHub] [kafka] ableegoldman commented on a change in pull request #11609: KAFKA-12648: fixes for query APIs with named topologies

ableegoldman commented on a change in pull request #11609: URL: https://github.com/apache/kafka/pull/11609#discussion_r791115535 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -1140,6 +1140,11 @@ private void completeSh

[GitHub] [kafka] ableegoldman commented on a change in pull request #11609: KAFKA-12648: fixes for query APIs with named topologies

ableegoldman commented on a change in pull request #11609: URL: https://github.com/apache/kafka/pull/11609#discussion_r791121073 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java ## @@ -138,6 +138,7 @@ public void registerTh

[GitHub] [kafka] ableegoldman commented on a change in pull request #11609: KAFKA-12648: fixes for query APIs with named topologies

ableegoldman commented on a change in pull request #11609: URL: https://github.com/apache/kafka/pull/11609#discussion_r791123644 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java ## @@ -224,6 +225,7 @@ public void maybeWaitF

[GitHub] [kafka] ccding opened a new pull request #11709: MINOR: fix testDescribeUnderMinIsrPartitionsMixed

ccding opened a new pull request #11709: URL: https://github.com/apache/kafka/pull/11709 We should assert row.length before reading row(0) and row(1); Otherwise we could get an ArrayIndexOutOfBoundsException out of blue which is not easy to read -- This is an automated message from

[GitHub] [kafka] patrickstuedi commented on a change in pull request #11676: KAFKA-13605: checkpoint position in state stores

patrickstuedi commented on a change in pull request #11676: URL: https://github.com/apache/kafka/pull/11676#discussion_r791157542 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/ProcessorContext.java ## @@ -85,8 +85,23 @@ * @throws IllegalStateExce

[jira] [Commented] (KAFKA-13612) internal topics won't be created in metadataRequest when auto.create.topics.enable=false

[ https://issues.apache.org/jira/browse/KAFKA-13612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17481400#comment-17481400 ] Dominic Evans commented on KAFKA-13612: --- [~hachikuji] for context, it was first re

[GitHub] [kafka] kowshik commented on a change in pull request #11345: KAFKA-13603: Allow the empty active segment to have missing offset index during recovery

kowshik commented on a change in pull request #11345: URL: https://github.com/apache/kafka/pull/11345#discussion_r791176937 ## File path: core/src/main/scala/kafka/log/UnifiedLog.scala ## @@ -1498,28 +1498,48 @@ class UnifiedLog(@volatile var logStartOffset: Long, producer

[GitHub] [kafka] mjsax commented on a change in pull request #11675: KAFKA-12648: POC for committing tasks on error

mjsax commented on a change in pull request #11675: URL: https://github.com/apache/kafka/pull/11675#discussion_r79115 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -1321,11 +1322,22 @@ int process(final int maxNumRe

[jira] [Created] (KAFKA-13615) Kafka Streams does not transition state on LeaveGroup due to poll interval being exceeded

Tim Costa created KAFKA-13615: - Summary: Kafka Streams does not transition state on LeaveGroup due to poll interval being exceeded Key: KAFKA-13615 URL: https://issues.apache.org/jira/browse/KAFKA-13615 P

[jira] [Updated] (KAFKA-13615) Kafka Streams does not transition state on LeaveGroup due to poll interval being exceeded

[ https://issues.apache.org/jira/browse/KAFKA-13615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Costa updated KAFKA-13615: -- Description: We are running a KafkaStreams application with largely default settings. Occasionally on

[jira] [Updated] (KAFKA-13615) Kafka Streams does not transition state on LeaveGroup due to poll interval being exceeded

[ https://issues.apache.org/jira/browse/KAFKA-13615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Costa updated KAFKA-13615: -- Description: We are running a KafkaStreams application with largely default settings. Occasionally on

[GitHub] [kafka] guozhangwang commented on pull request #11686: KAFKA-12648: invoke exception handler for MissingSourceTopicException with named topologies

guozhangwang commented on pull request #11686: URL: https://github.com/apache/kafka/pull/11686#issuecomment-1020665875 Made a final pass on the latest commits. LGTM! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [kafka] lbradstreet opened a new pull request #11710: MINOR: MiniTrogdorCluster mutates objects from other threads

lbradstreet opened a new pull request #11710: URL: https://github.com/apache/kafka/pull/11710 MiniTrogdorCluster spins up agents from a different thread when scheduling them, but does not use volatiles in these objects. It's not clear that the updated fields are visible. The hop

[GitHub] [kafka] cmccabe commented on pull request #11710: MINOR: MiniTrogdorCluster mutates objects from other threads

cmccabe commented on pull request #11710: URL: https://github.com/apache/kafka/pull/11710#issuecomment-1020677668 It would be nice to redo this without the volatiles, but for now, LGTM. Thanks, @lbradstreet . -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] ccding closed pull request #11709: MINOR: fix testDescribeUnderMinIsrPartitionsMixed

ccding closed pull request #11709: URL: https://github.com/apache/kafka/pull/11709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr..

[GitHub] [kafka] ccding commented on pull request #11709: MINOR: fix testDescribeUnderMinIsrPartitionsMixed

ccding commented on pull request #11709: URL: https://github.com/apache/kafka/pull/11709#issuecomment-1020679187 Dropping this. Lucas will bring more fixes together. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] guozhangwang commented on a change in pull request #11609: KAFKA-12648: fixes for query APIs with named topologies

guozhangwang commented on a change in pull request #11609: URL: https://github.com/apache/kafka/pull/11609#discussion_r791262134 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/NamedTopologyIntegrationTest.java ## @@ -635,6 +710,19 @@ public void shoul

[GitHub] [kafka] guozhangwang commented on a change in pull request #11609: KAFKA-12648: fixes for query APIs with named topologies

guozhangwang commented on a change in pull request #11609: URL: https://github.com/apache/kafka/pull/11609#discussion_r791262134 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/NamedTopologyIntegrationTest.java ## @@ -635,6 +710,19 @@ public void shoul

[GitHub] [kafka] guozhangwang commented on pull request #11609: KAFKA-12648: fixes for query APIs with named topologies

guozhangwang commented on pull request #11609: URL: https://github.com/apache/kafka/pull/11609#issuecomment-1020690230 LGTM! Jenkins failed on compilation (checkstyle). Please feel free to merge after addressing the nit comments and green build. -- This is an automated message from the A

[GitHub] [kafka] vvcephei commented on pull request #11702: MINOR: fix NPE in iqv2

vvcephei commented on pull request #11702: URL: https://github.com/apache/kafka/pull/11702#issuecomment-1020723191 Test failures were unrelated: ``` Build / JDK 11 and Scala 2.13 / integration.kafka.server.FetchRequestBetweenDifferentIbpTest.testControllerOldToNewIBP()

[jira] [Commented] (KAFKA-13612) internal topics won't be created in metadataRequest when auto.create.topics.enable=false

[ https://issues.apache.org/jira/browse/KAFKA-13612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17481500#comment-17481500 ] Luke Chen commented on KAFKA-13612: --- [~hachikuji] , I agree with [~dnwe] , we can work

[GitHub] [kafka] satishd commented on a change in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

satishd commented on a change in pull request #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r791322611 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -715,6 +727,58 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] satishd commented on a change in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

satishd commented on a change in pull request #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r791322611 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -715,6 +727,58 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] mjsax commented on a change in pull request #11455: KAFKA-13423: GlobalThread should not log ERROR on clean shutdown

mjsax commented on a change in pull request #11455: URL: https://github.com/apache/kafka/pull/11455#discussion_r791323385 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/GlobalKTableIntegrationTest.java ## @@ -176,7 +177,9 @@ public void shouldKStreamG

[GitHub] [kafka] mjsax commented on a change in pull request #11455: KAFKA-13423: GlobalThread should not log ERROR on clean shutdown

mjsax commented on a change in pull request #11455: URL: https://github.com/apache/kafka/pull/11455#discussion_r791324561 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -668,8 +669,10 @@ public synchronized void onChange(final Thread thread

[GitHub] [kafka] mjsax commented on a change in pull request #11455: KAFKA-13423: GlobalThread should not log ERROR on clean shutdown

mjsax commented on a change in pull request #11455: URL: https://github.com/apache/kafka/pull/11455#discussion_r791324669 ## File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java ## @@ -459,12 +462,15 @@ public void shouldCleanupResourcesOnCloseWithou

[GitHub] [kafka] mjsax commented on pull request #11584: MINOR: improve logging

mjsax commented on pull request #11584: URL: https://github.com/apache/kafka/pull/11584#issuecomment-1020784877 Finally updated this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [kafka] cmccabe opened a new pull request #11711: MINOR: handle appending to configuration values that are empty better

cmccabe opened a new pull request #11711: URL: https://github.com/apache/kafka/pull/11711 If a configuration value is empty or contains only whitespace, appending to it should not result in a comma getting added to the configuration value. So, for example, adding "first" to " " should

[GitHub] [kafka] vvcephei commented on a change in pull request #11676: KAFKA-13605: checkpoint position in state stores

vvcephei commented on a change in pull request #11676: URL: https://github.com/apache/kafka/pull/11676#discussion_r791343342 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/PositionCheckpointIntegrationTest.java ## @@ -0,0 +1,777 @@ +/* + * Licensed to

[GitHub] [kafka] vvcephei commented on a change in pull request #11676: KAFKA-13605: checkpoint position in state stores

vvcephei commented on a change in pull request #11676: URL: https://github.com/apache/kafka/pull/11676#discussion_r791344228 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/ProcessorContext.java ## @@ -85,8 +85,23 @@ * @throws IllegalStateException

[GitHub] [kafka] sayantanu-dey commented on pull request #11703: KAFKA-13588: consolidate `changelogFor` methods to simplify the generation of internal topic names

sayantanu-dey commented on pull request #11703: URL: https://github.com/apache/kafka/pull/11703#issuecomment-1020797877 > One meta comment regarding consolidating the functions: we have `getPrefix` in multiple classes (and thanks @sayantanu-dey your PRs remove some already), but there are

[GitHub] [kafka] ableegoldman commented on a change in pull request #11609: KAFKA-12648: fixes for query APIs with named topologies

ableegoldman commented on a change in pull request #11609: URL: https://github.com/apache/kafka/pull/11609#discussion_r791355579 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/KafkaStreamsNamedTopologyWrapper.java ## @@ -319,6 +3

[GitHub] [kafka] ableegoldman merged pull request #11704: KAFKA-13590: rename InternalTopologyBuilder#topicGroups

ableegoldman merged pull request #11704: URL: https://github.com/apache/kafka/pull/11704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[jira] [Updated] (KAFKA-13590) Rename InternalTopologyBuilder's #topicGroups method to be more descriptive

[ https://issues.apache.org/jira/browse/KAFKA-13590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-13590: --- Fix Version/s: 3.2.0 > Rename InternalTopologyBuilder's #topicGroups method

[GitHub] [kafka] ableegoldman commented on pull request #11702: MINOR: fix NPE in iqv2

ableegoldman commented on pull request #11702: URL: https://github.com/apache/kafka/pull/11702#issuecomment-1020816735 compiler error, fyi thanks for the fix though! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] dengziming commented on pull request #10830: KAFKA-12902: Add unit32 type in generator

dengziming commented on pull request #10830: URL: https://github.com/apache/kafka/pull/10830#issuecomment-1020819384 ping @cmccabe -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [kafka] dengziming commented on pull request #10500: MINOR: Move envelop body request serialize code to RequestContext

dengziming commented on pull request #10500: URL: https://github.com/apache/kafka/pull/10500#issuecomment-1020820360 ping @abbccdda @hachikuji to have a look when you are free. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] dengziming commented on pull request #11677: KAFKA-13410 Add KRaft metadata.version for KIP-778

dengziming commented on pull request #11677: URL: https://github.com/apache/kafka/pull/11677#issuecomment-1020850019 I have some questions concerning the `VersionRange` entity. In zk-related classes we use FinalizedVersionRange and SupportedVersionRange whereas in kraft-related code we use

[GitHub] [kafka] mattwong949 commented on a change in pull request #11694: MINOR: deleteHorizonMs update to documentation and DumpLogSegments tool

mattwong949 commented on a change in pull request #11694: URL: https://github.com/apache/kafka/pull/11694#discussion_r791420348 ## File path: clients/src/main/java/org/apache/kafka/common/record/DefaultRecordBatch.java ## @@ -82,9 +82,9 @@ * are retained only until either a

[GitHub] [kafka] showuon commented on pull request #11242: [WIP] MINOR: POC for KIP-591: Add config to set default store impl class

showuon commented on pull request #11242: URL: https://github.com/apache/kafka/pull/11242#issuecomment-1020885807 PR for the implementation: https://github.com/apache/kafka/pull/11705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] showuon closed pull request #11242: [WIP] MINOR: POC for KIP-591: Add config to set default store impl class

showuon closed pull request #11242: URL: https://github.com/apache/kafka/pull/11242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[GitHub] [kafka] mjsax commented on a change in pull request #11584: MINOR: improve logging

mjsax commented on a change in pull request #11584: URL: https://github.com/apache/kafka/pull/11584#discussion_r791429259 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -1516,4 +1527,20 @@ RebalanceProtocol getPro