mattwong949 commented on a change in pull request #11694:
URL: https://github.com/apache/kafka/pull/11694#discussion_r791420348
##########
File path:
clients/src/main/java/org/apache/kafka/common/record/DefaultRecordBatch.java
##########
@@ -82,9 +82,9 @@
* are retained only until either a new sequence number is written by the
corresponding producer or the producerId
* is expired from lack of activity.
*
- * There is no similar need to preserve the timestamp from the original batch
after compaction. The FirstTimestamp
+ * There is no similar need to preserve the timestamp from the original batch
after compaction. The BaseTimestamp
* field therefore always reflects the timestamp of the first record in the
batch. If the batch is empty, the
- * FirstTimestamp will be set to -1 (NO_TIMESTAMP).
+ * BaseTimestamp will be set to -1 (NO_TIMESTAMP).
Review comment:
you are right, I've revised the comments to be accurate about
BaseTimestamp after compaction.
##########
File path:
clients/src/main/java/org/apache/kafka/common/record/DefaultRecordBatch.java
##########
@@ -82,9 +82,9 @@
* are retained only until either a new sequence number is written by the
corresponding producer or the producerId
* is expired from lack of activity.
*
- * There is no similar need to preserve the timestamp from the original batch
after compaction. The FirstTimestamp
+ * There is no similar need to preserve the timestamp from the original batch
after compaction. The BaseTimestamp
* field therefore always reflects the timestamp of the first record in the
batch. If the batch is empty, the
- * FirstTimestamp will be set to -1 (NO_TIMESTAMP).
+ * BaseTimestamp will be set to -1 (NO_TIMESTAMP).
Review comment:
you are right, thanks for the catch. I've revised the comments to be
accurate about BaseTimestamp after compaction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
