dajac merged pull request #11679:
URL: https://github.com/apache/kafka/pull/11679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...
dajac commented on pull request #11679:
URL: https://github.com/apache/kafka/pull/11679#issuecomment-1012953994
I merged the PR to trunk to fix the issue. We can follow up with another PR
to add a unit test.
--
This is an automated message from the Apache Git Service.
To respond to the m
dajac commented on a change in pull request #11456:
URL: https://github.com/apache/kafka/pull/11456#discussion_r784701638
##
File path: core/src/main/scala/kafka/tools/ConsoleProducer.scala
##
@@ -264,39 +278,92 @@ object ConsoleProducer {
var reader: BufferedReader = null
dajac commented on a change in pull request #11173:
URL: https://github.com/apache/kafka/pull/11173#discussion_r784713919
##
File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala
##
@@ -72,10 +73,10 @@ object GetOffsetShell {
.ofType(classO
satishd commented on a change in pull request #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r784750507
##
File path: core/src/main/scala/kafka/log/UnifiedLog.scala
##
@@ -288,13 +294,24 @@ class UnifiedLog(@volatile var logStartOffset: Long,
@volatile
satishd commented on a change in pull request #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r784751134
##
File path:
core/src/main/scala/kafka/log/remote/ClassLoaderAwareRemoteStorageManager.scala
##
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software
satishd commented on a change in pull request #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r784753702
##
File path: core/src/main/scala/kafka/log/remote/RemoteIndexCache.scala
##
@@ -0,0 +1,225 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) u
satishd commented on a change in pull request #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r784764008
##
File path: core/src/main/scala/kafka/log/remote/RemoteIndexCache.scala
##
@@ -0,0 +1,225 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) u
satishd commented on a change in pull request #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r784768268
##
File path: core/src/main/scala/kafka/log/remote/RemoteIndexCache.scala
##
@@ -0,0 +1,225 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) u
satishd commented on a change in pull request #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r784770314
##
File path: core/src/main/scala/kafka/log/remote/RemoteLogManager.scala
##
@@ -0,0 +1,287 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) u
satishd commented on a change in pull request #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r784772939
##
File path: core/src/main/scala/kafka/log/remote/RemoteLogManager.scala
##
@@ -0,0 +1,287 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) u
[
https://issues.apache.org/jira/browse/KAFKA-5072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476089#comment-17476089
]
Florian Albrecht commented on KAFKA-5072:
-
Really would like to see this implemen
satishd commented on a change in pull request #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r784793287
##
File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala
##
@@ -386,11 +397,109 @@ class ReplicaFetcherThread(name: String,
}
/**
satishd commented on a change in pull request #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r784793923
##
File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala
##
@@ -386,11 +396,76 @@ class ReplicaFetcherThread(name: String,
}
/**
satishd commented on a change in pull request #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r784793287
##
File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala
##
@@ -386,11 +397,109 @@ class ReplicaFetcherThread(name: String,
}
/**
satishd commented on a change in pull request #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r784801502
##
File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala
##
@@ -386,11 +397,109 @@ class ReplicaFetcherThread(name: String,
}
/**
satishd commented on a change in pull request #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r784813247
##
File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala
##
@@ -386,11 +397,109 @@ class ReplicaFetcherThread(name: String,
}
/**
satishd commented on a change in pull request #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r784817355
##
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##
@@ -715,6 +727,58 @@ abstract class AbstractFetcherThread(name: String,
[
https://issues.apache.org/jira/browse/KAFKA-13594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476142#comment-17476142
]
Waseem commented on KAFKA-13594:
In our project we have separate installation of project
dengziming commented on a change in pull request #11173:
URL: https://github.com/apache/kafka/pull/11173#discussion_r784854500
##
File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala
##
@@ -72,10 +73,10 @@ object GetOffsetShell {
.ofType(c
soarez commented on pull request #9577:
URL: https://github.com/apache/kafka/pull/9577#issuecomment-1013132683
@mumrah @hachikuji @bbejeck could someone have a look at this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/KAFKA-12689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476157#comment-17476157
]
Kvicii.Yu commented on KAFKA-12689:
---
[~loboxu] could i close this?
> Remove deprecate
[ https://issues.apache.org/jira/browse/KAFKA-12689 ]
Kvicii.Yu deleted comment on KAFKA-12689:
---
was (Author: JIRAUSER283467):
[~loboxu] could i close this?
> Remove deprecated EOS configs
> -
>
> Key:
satishd commented on a change in pull request #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r784813247
##
File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala
##
@@ -386,11 +397,109 @@ class ReplicaFetcherThread(name: String,
}
/**
[
https://issues.apache.org/jira/browse/KAFKA-13592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476165#comment-17476165
]
Kvicii.Yu commented on KAFKA-13592:
---
Can you provide a kafka version?
> Fix flaky tes
[ https://issues.apache.org/jira/browse/KAFKA-13592 ]
Kvicii.Yu deleted comment on KAFKA-13592:
---
was (Author: JIRAUSER283467):
Can you provide a kafka version?
> Fix flaky test
> ControllerIntegrationTest.testTopicIdUpgradeAfterReassigningPartit
[
https://issues.apache.org/jira/browse/KAFKA-13592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476170#comment-17476170
]
Kvicii.Yu commented on KAFKA-13592:
---
[~dajac] hello, can i do this?
> Fix flaky test
jeffkbkim opened a new pull request #11680:
URL: https://github.com/apache/kafka/pull/11680
set reason field for all api versions in `JOIN_GROUP` and `LEAVE_GROUP` to
test cases where newer clients speak with older brokers.
### Committer Checklist (excluded from commit message)
[
https://issues.apache.org/jira/browse/KAFKA-13590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476271#comment-17476271
]
Kvicii.Yu commented on KAFKA-13590:
---
rename is a problem.But what is more appropriate?
[
https://issues.apache.org/jira/browse/KAFKA-13588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476360#comment-17476360
]
Saad Ur Rahman commented on KAFKA-13588:
I would like to give this a go so that
[
https://issues.apache.org/jira/browse/KAFKA-7809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476413#comment-17476413
]
Patrick McEvoy edited comment on KAFKA-7809 at 1/14/22, 8:40 PM:
--
[
https://issues.apache.org/jira/browse/KAFKA-7809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476413#comment-17476413
]
Patrick McEvoy commented on KAFKA-7809:
---
I am seeing a similar issue and stack trac
[
https://issues.apache.org/jira/browse/KAFKA-13594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476483#comment-17476483
]
Jun Rao commented on KAFKA-13594:
-
[~Waseem_bhura] : Once you remove JMSAppender, it sho
[
https://issues.apache.org/jira/browse/KAFKA-13588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476360#comment-17476360
]
Saad Ur Rahman edited comment on KAFKA-13588 at 1/15/22, 12:36 AM:
---
showuon commented on pull request #11631:
URL: https://github.com/apache/kafka/pull/11631#issuecomment-1013598333
@guozhangwang @ableegoldman , please take a look when available. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
showuon commented on pull request #11616:
URL: https://github.com/apache/kafka/pull/11616#issuecomment-1013601840
@rondagostino , thanks for the comments. I've updated the PR in this commit:
https://github.com/apache/kafka/pull/11616/commits/4b1363c01641a5f77d1f54b26286800818e98da9.
Please
[
https://issues.apache.org/jira/browse/KAFKA-8541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-8541:
Assignee: Luke Chen
> Flakey test LeaderElectionCommandTest#testTopicPartition
> -
showuon opened a new pull request #11681:
URL: https://github.com/apache/kafka/pull/11681
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgra
38 matches
Mail list logo