dajac commented on a change in pull request #11173:
URL: https://github.com/apache/kafka/pull/11173#discussion_r784713919
##########
File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala
##########
@@ -72,10 +73,10 @@ object GetOffsetShell {
.ofType(classOf[String])
val timeOpt = parser.accepts("time", "timestamp of the offsets before
that. [Note: No offset is returned, if the timestamp greater than recently
committed record timestamp is given.]")
.withRequiredArg
- .describedAs("timestamp/-1(latest)/-2(earliest)")
+
.describedAs("timestamp/-1(latest)/-2(earliest)/-3(max timestamp)")
.ofType(classOf[java.lang.Long])
.defaultsTo(-1L)
- val commandConfigOpt = parser.accepts("command-config", s"Property file
containing configs to be passed to Consumer Client.")
+ val commandConfigOpt = parser.accepts("command-config", s"Property file
containing configs to be passed to Admin Client.")
Review comment:
@dengziming @showuon Good point. Using an addendum to KIP-734 will
likely be unnoticed in the mailing list so having a small KIP might be
preferable here. @dengziming Are you willing to do it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
