showuon commented on pull request #11656:
URL: https://github.com/apache/kafka/pull/11656#issuecomment-1007907007
@dajac @ijuma , please take a look. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
[
https://issues.apache.org/jira/browse/KAFKA-8785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-8785:
Assignee: Luke Chen
> Flakey test LeaderElectionCommandTest#testPathToJsonFile
> -
showuon opened a new pull request #11658:
URL: https://github.com/apache/kafka/pull/11658
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
florin-akermann commented on pull request #11456:
URL: https://github.com/apache/kafka/pull/11456#issuecomment-1007314312
Hi again @dajac @mimaison,
Thanks again for all the great input.
I believe the current version has taken into account all your comments.
I am in no hurry
vbsiegem commented on pull request #7898:
URL: https://github.com/apache/kafka/pull/7898#issuecomment-1007353055
> @vbsiegem @diegoazevedo
>
> > Are there any firm plans at this time for when log4j v2 support in Kafka
will be released, and in what release(s)?
>
> I hope AK 3.2
guozhangwang commented on pull request #11611:
URL: https://github.com/apache/kafka/pull/11611#issuecomment-1007795951
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
YeonCheolGit commented on a change in pull request #11649:
URL: https://github.com/apache/kafka/pull/11649#discussion_r780354832
##
File path:
metadata/src/main/java/org/apache/kafka/metadata/authorizer/ClusterMetadataAuthorizer.java
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to th
florin-akermann commented on a change in pull request #11456:
URL: https://github.com/apache/kafka/pull/11456#discussion_r764457132
##
File path: core/src/main/scala/kafka/tools/ConsoleProducer.scala
##
@@ -206,11 +210,25 @@ object ConsoleProducer {
.describedAs("size")
showuon commented on pull request #11656:
URL: https://github.com/apache/kafka/pull/11656#issuecomment-1007907007
@dajac @ijuma , please take a look. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
wcarlson5 commented on a change in pull request #11611:
URL: https://github.com/apache/kafka/pull/11611#discussion_r780402975
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/CachingWindowStore.java
##
@@ -85,8 +86,13 @@ public void init(final State
kirktrue commented on a change in pull request #9584:
URL: https://github.com/apache/kafka/pull/9584#discussion_r780603531
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java
##
@@ -858,14 +862,23 @@ public KafkaConsumer(Map configs,
guozhangwang commented on a change in pull request #11611:
URL: https://github.com/apache/kafka/pull/11611#discussion_r780568663
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/CachingWindowStore.java
##
@@ -85,8 +86,13 @@ public void init(final St
jeffkbkim commented on pull request #11571:
URL: https://github.com/apache/kafka/pull/11571#issuecomment-1007608090
@dajac please take another pass when you get the chance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
wcarlson5 commented on pull request #11611:
URL: https://github.com/apache/kafka/pull/11611#issuecomment-1007578613
@guozhangwang yes that is a good point. When we go to use this we will have
to set the config and we can updated the clean up logic then
--
This is an automated message fro
showuon commented on pull request #11566:
URL: https://github.com/apache/kafka/pull/11566#issuecomment-1007872330
@jeffkbkim , `KafkaApisTest` is still failed some tests. Please take a look.
Thanks.
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-11566/6/#showFailuresLink
dongjinleekr commented on a change in pull request #7898:
URL: https://github.com/apache/kafka/pull/7898#discussion_r780114085
##
File path: gradle/dependencies.gradle
##
@@ -75,6 +75,7 @@ versions += [
jmh: "1.32",
hamcrest: "2.2",
log4j: "1.2.17",
+ log4j2: "2.17.0"
RivenSun2 commented on pull request #11461:
URL: https://github.com/apache/kafka/pull/11461#issuecomment-1007403812
@ijuma @rajinisivaram @guozhangwang
can you help to check this PR and related JIRA?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond t
showuon commented on pull request #11571:
URL: https://github.com/apache/kafka/pull/11571#issuecomment-1007872215
@jeffkbkim , this tests `testRemoveMembersFromGroupReason()` is still
failed. Please help fix it. Thanks.
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-1157
dongjinleekr commented on pull request #7898:
URL: https://github.com/apache/kafka/pull/7898#issuecomment-1007242660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
jeffkbkim commented on pull request #11566:
URL: https://github.com/apache/kafka/pull/11566#issuecomment-1007607617
@dajac gentle reminder to take another pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
rhauch commented on a change in pull request #10907:
URL: https://github.com/apache/kafka/pull/10907#discussion_r779947401
##
File path:
connect/api/src/main/java/org/apache/kafka/connect/source/SourceTaskContext.java
##
@@ -38,4 +38,29 @@
* Get the OffsetStorageReader f
dengziming opened a new pull request #11659:
URL: https://github.com/apache/kafka/pull/11659
*More detailed description of your change*
Validate broker configs for KRaft
*Summary of testing strategy (including rationale)*
QA
### Committer Checklist (excluded from commit m
dengziming commented on a change in pull request #11638:
URL: https://github.com/apache/kafka/pull/11638#discussion_r780680670
##
File path:
core/src/test/scala/unit/kafka/server/AbstractCreateTopicsRequestTest.scala
##
@@ -162,7 +162,7 @@ abstract class AbstractCreateTopicsRe
[
https://issues.apache.org/jira/browse/KAFKA-7575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17471267#comment-17471267
]
Ivan Sager commented on KAFKA-7575:
---
Has anyone figure out a work around for now? I ran
YeonCheolGit commented on a change in pull request #11649:
URL: https://github.com/apache/kafka/pull/11649#discussion_r780354832
##
File path:
metadata/src/main/java/org/apache/kafka/metadata/authorizer/ClusterMetadataAuthorizer.java
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to th
YeonCheolGit opened a new pull request #11660:
URL: https://github.com/apache/kafka/pull/11660
Found minor typo in ClusterConnectionStates.java
### More detailed description of your change,
`iff` --> `if`
### Committer Checklist (excluded from commit message)
- [ ] Verify
YeonCheolGit commented on pull request #11660:
URL: https://github.com/apache/kafka/pull/11660#issuecomment-1008242993
Call for review @dajac @junrao @guozhangwang @ijuma
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
vamossagar12 edited a comment on pull request #11424:
URL: https://github.com/apache/kafka/pull/11424#issuecomment-1006767050
> hey @guozhangwang , For `CACHE_MAX_BYTES_BUFFERING_CONFIG` , I can replace
but as per one of the comments here => [#11424
(comment)](https://github.com/apache/kaf
28 matches
Mail list logo
