vamossagar12 edited a comment on pull request #11424: URL: https://github.com/apache/kafka/pull/11424#issuecomment-1006767050
> hey @guozhangwang , For `CACHE_MAX_BYTES_BUFFERING_CONFIG` , I can replace but as per one of the comments here => [#11424 (comment)](https://github.com/apache/kafka/pull/11424#discussion_r740701956) we wanted to check if the deprecated config (BUFFERED_RECORDS_PER_PARTITION_CONFIG) has been set or otherwise set it to -1. For setting it to -1, I am also checking if it's a user supplied value or a default one and that's where the need to use this config in TopologyConfig class. @guozhangwang , i tried to address this again, but what I see is that since the 2 deprecated configs are topology level configs, they are being set/checked in TopologyConfig. As I said, for backward compatibility reasons, we are checking if it has been set by the user or not. Looks like the values being set here are further being used for getting/setting task level configs.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
