[GitHub] [kafka] dajac merged pull request #11622: MINOR: Update LICENSE for 3.1

2021-12-22 Thread GitBox
dajac merged pull request #11622: URL: https://github.com/apache/kafka/pull/11622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] rohitagl91 commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2021-12-22 Thread GitBox
rohitagl91 commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-999408465 can this be updated to 2.17.0 as 2.16.0 also have a CVE of 7.5 score? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] satishd opened a new pull request #11623: Added checkpoint truncation utility with inmemory writers instead of temporary files in RemoteLogManager.

2021-12-22 Thread GitBox
satishd opened a new pull request #11623: URL: https://github.com/apache/kafka/pull/11623 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[GitHub] [kafka] rohitagl91 removed a comment on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2021-12-22 Thread GitBox
rohitagl91 removed a comment on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-999408465 can this be updated to 2.17.0 as 2.16.0 also have a CVE of 7.5 score? -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] patrickstuedi commented on a change in pull request #11567: WindowKeyQuery and WindowRangeQuery

2021-12-22 Thread GitBox
patrickstuedi commented on a change in pull request #11567: URL: https://github.com/apache/kafka/pull/11567#discussion_r773760885 ## File path: streams/src/main/java/org/apache/kafka/streams/query/WindowRangeQuery.java ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [kafka] notme159 commented on pull request #9947: KAFKA-12190: Fix setting of file permissions on non-POSIX filesystems

2021-12-22 Thread GitBox
notme159 commented on pull request #9947: URL: https://github.com/apache/kafka/pull/9947#issuecomment-999476678 @wilkinsona Hello thank you for the fix, I still have an issue, using KeyValueStore and getting org.apache.kafka.streams.processor.internals.StateDirectory - Failed to change

[GitHub] [kafka] patrickstuedi commented on a change in pull request #11567: WindowKeyQuery and WindowRangeQuery

2021-12-22 Thread GitBox
patrickstuedi commented on a change in pull request #11567: URL: https://github.com/apache/kafka/pull/11567#discussion_r773792800 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/InMemorySessionStore.java ## @@ -317,14 +318,31 @@ public boolean isOp

[GitHub] [kafka] patrickstuedi commented on a change in pull request #11567: WindowKeyQuery and WindowRangeQuery

2021-12-22 Thread GitBox
patrickstuedi commented on a change in pull request #11567: URL: https://github.com/apache/kafka/pull/11567#discussion_r773792800 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/InMemorySessionStore.java ## @@ -317,14 +318,31 @@ public boolean isOp

[GitHub] [kafka] richard-axual commented on a change in pull request #11535: KAFKA-13476: Increase resilience timestamp decoding Kafka Streams

2021-12-22 Thread GitBox
richard-axual commented on a change in pull request #11535: URL: https://github.com/apache/kafka/pull/11535#discussion_r773828829 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -1097,15 +1097,20 @@ long decodeTimestamp(fi

[jira] [Commented] (KAFKA-13556) Kafka cluster loses the controller

2021-12-22 Thread joecqupt (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463773#comment-17463773 ] joecqupt commented on KAFKA-13556: -- this problem has been reported    [KAFKA-13461|ht

[jira] [Comment Edited] (KAFKA-13556) Kafka cluster loses the controller

2021-12-22 Thread joecqupt (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463773#comment-17463773 ] joecqupt edited comment on KAFKA-13556 at 12/22/21, 12:27 PM:

[jira] [Commented] (KAFKA-12522) Cast SMT should allow null value records to pass through

2021-12-22 Thread Kunal Gupta (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463795#comment-17463795 ] Kunal Gupta commented on KAFKA-12522: - Can anyone please paste here the final resolv

[jira] [Created] (KAFKA-13563) Consumer failure after rolling Broker upgrade

2021-12-22 Thread Luke Chen (Jira)
Luke Chen created KAFKA-13563: - Summary: Consumer failure after rolling Broker upgrade Key: KAFKA-13563 URL: https://issues.apache.org/jira/browse/KAFKA-13563 Project: Kafka Issue Type: Bug

[GitHub] [kafka] vamossagar12 commented on a change in pull request #11424: KAFKA-13152: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2021-12-22 Thread GitBox
vamossagar12 commented on a change in pull request #11424: URL: https://github.com/apache/kafka/pull/11424#discussion_r774024121 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -1224,17 +1248,20 @@ private int getNextThreadIndex() {

[GitHub] [kafka] vamossagar12 commented on a change in pull request #11424: KAFKA-13152: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2021-12-22 Thread GitBox
vamossagar12 commented on a change in pull request #11424: URL: https://github.com/apache/kafka/pull/11424#discussion_r774025067 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -967,6 +980,17 @@ private long pollPhase()

[GitHub] [kafka] vamossagar12 commented on pull request #11424: KAFKA-13152: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2021-12-22 Thread GitBox
vamossagar12 commented on pull request #11424: URL: https://github.com/apache/kafka/pull/11424#issuecomment-999716272 https://github.com/apache/kafka/pull/11424#discussion_r773499306 This is being used now. StreamThread delegates to this function to get the totalBytesBuffered. --

[GitHub] [kafka] JoeCqupt commented on pull request #10056: KAFKA-12293: remove JCenter and Bintray repositories mentions out of build gradle scripts (sunset is announced for those repositories)

2021-12-22 Thread GitBox
JoeCqupt commented on pull request #10056: URL: https://github.com/apache/kafka/pull/10056#issuecomment-999717832 > I tried backporting to 2.8 and the older Gradle plugin versions in that branch were not available in Maven central. We should probably wait a few months and see how things de

[GitHub] [kafka] xdgrulez commented on pull request #10897: MINOR: Reduced severity for "skipping records" falling out of time windows

2021-12-22 Thread GitBox
xdgrulez commented on pull request #10897: URL: https://github.com/apache/kafka/pull/10897#issuecomment-999729900 Hi @ableegoldman I think it would be good to have a less frequent output on e.g. INFO :) I won't have a lot of time to look into this in the near future, so please take this ov

[GitHub] [kafka] vamossagar12 commented on pull request #11424: KAFKA-13152: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2021-12-22 Thread GitBox
vamossagar12 commented on pull request #11424: URL: https://github.com/apache/kafka/pull/11424#issuecomment-999731311 > Thanks @vamossagar12 , I've made a second pass and left some more comments. > > Regarding the metric name, I will ping @ableegoldman and @cadonna again and get back

[GitHub] [kafka] vamossagar12 commented on a change in pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

2021-12-22 Thread GitBox
vamossagar12 commented on a change in pull request #11433: URL: https://github.com/apache/kafka/pull/11433#discussion_r774050815 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -292,12 +327,20 @@ public void handleAssignm

[GitHub] [kafka] guozhangwang commented on a change in pull request #11424: KAFKA-13152: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2021-12-22 Thread GitBox
guozhangwang commented on a change in pull request #11424: URL: https://github.com/apache/kafka/pull/11424#discussion_r774058848 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -1224,17 +1248,20 @@ private int getNextThreadIndex() {

[GitHub] [kafka] guozhangwang commented on pull request #11424: KAFKA-13152: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2021-12-22 Thread GitBox
guozhangwang commented on pull request #11424: URL: https://github.com/apache/kafka/pull/11424#issuecomment-999751461 > Thanks @guozhangwang . I had one question on the changes suggested by you. Just replied on your question. LMK if that works or not. -- This is an automated messag

[GitHub] [kafka] vvcephei opened a new pull request #11624: MINOR: add PAPI KV store tests for IQv2

2021-12-22 Thread GitBox
vvcephei opened a new pull request #11624: URL: https://github.com/apache/kafka/pull/11624 During some recent reviews, @mjsax pointed out that StateStore layers are constructed differently the stores are added via the PAPI vs. the DSL. This PR adds PAPI construction to the IQv2Stor

[GitHub] [kafka] vvcephei commented on a change in pull request #11624: MINOR: add PAPI KV store tests for IQv2

2021-12-22 Thread GitBox
vvcephei commented on a change in pull request #11624: URL: https://github.com/apache/kafka/pull/11624#discussion_r774097786 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java ## @@ -287,31 +306,42 @@ public boolean keyValue(

[GitHub] [kafka] vvcephei commented on a change in pull request #11624: MINOR: add PAPI KV store tests for IQv2

2021-12-22 Thread GitBox
vvcephei commented on a change in pull request #11624: URL: https://github.com/apache/kafka/pull/11624#discussion_r774098263 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java ## @@ -365,109 +395,200 @@ public void beforeTest

[GitHub] [kafka] vvcephei commented on a change in pull request #11624: MINOR: add PAPI KV store tests for IQv2

2021-12-22 Thread GitBox
vvcephei commented on a change in pull request #11624: URL: https://github.com/apache/kafka/pull/11624#discussion_r774098354 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java ## @@ -365,109 +395,200 @@ public void beforeTest

[GitHub] [kafka] vvcephei commented on a change in pull request #11624: MINOR: add PAPI KV store tests for IQv2

2021-12-22 Thread GitBox
vvcephei commented on a change in pull request #11624: URL: https://github.com/apache/kafka/pull/11624#discussion_r774098877 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java ## @@ -365,109 +395,200 @@ public void beforeTest

[GitHub] [kafka] guozhangwang commented on pull request #11611: MINOR: prefix topics if internal config is set

2021-12-22 Thread GitBox
guozhangwang commented on pull request #11611: URL: https://github.com/apache/kafka/pull/11611#issuecomment-999794655 Though this comment is not for AK, I'd have to raise to our attention: in ksql we have hard-coded rules to detect internal topics to be cleaned when terminating a query, wh

[GitHub] [kafka] junrao commented on pull request #11607: KAFKA-13544: fix FinalizedFeatureChangeListener deadlock

2021-12-22 Thread GitBox
junrao commented on pull request #11607: URL: https://github.com/apache/kafka/pull/11607#issuecomment-999825371 @dajac : Since this is a really small fix for a potential deadlock, I merged it to 3.1 branch. -- This is an automated message from the Apache Git Service. To respond to the me

[jira] [Updated] (KAFKA-13544) Deadlock during shutting down kafka broker because of connectivity problem with zookeeper

2021-12-22 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-13544: Fix Version/s: 3.1.0 3.0.1 2.8.2 [~andrei-vlg] : I merged the PR to

[jira] [Updated] (KAFKA-13544) Deadlock during shutting down kafka broker because of connectivity problem with zookeeper

2021-12-22 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-13544: Fix Version/s: (was: 3.2.0) > Deadlock during shutting down kafka broker because of connectivity probl

[jira] [Commented] (KAFKA-13544) Deadlock during shutting down kafka broker because of connectivity problem with zookeeper

2021-12-22 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464090#comment-17464090 ] Guozhang Wang commented on KAFKA-13544: --- Hi @joecqupt thanks for pinging me on sla

[jira] [Assigned] (KAFKA-13544) Deadlock during shutting down kafka broker because of connectivity problem with zookeeper

2021-12-22 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang reassigned KAFKA-13544: - Assignee: joecqupt > Deadlock during shutting down kafka broker because of connectivity

[GitHub] [kafka] dajac opened a new pull request #11625: MINOR: Fix malformed html in javadoc of `ScramMechanism`

2021-12-22 Thread GitBox
dajac opened a new pull request #11625: URL: https://github.com/apache/kafka/pull/11625 `./gradlew clean aggregatedJavadoc` with JDK 17 fails without this fix. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test covera

[jira] [Updated] (KAFKA-13418) Brokers disconnect intermittently with TLS1.3

2021-12-22 Thread shylaja kokoori (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shylaja kokoori updated KAFKA-13418: Attachment: tls1_3.patch > Brokers disconnect intermittently with TLS1.3 > ---

[jira] [Commented] (KAFKA-13418) Brokers disconnect intermittently with TLS1.3

2021-12-22 Thread shylaja kokoori (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464190#comment-17464190 ] shylaja kokoori commented on KAFKA-13418: - After enabling SSL logging (javax.net

[jira] [Comment Edited] (KAFKA-13289) Bulk processing correctly ordered input data through a join with kafka-streams results in `Skipping record for expired segment`

2021-12-22 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447678#comment-17447678 ] Eugen Dück edited comment on KAFKA-13289 at 12/23/21, 2:01 AM: ---

[jira] [Commented] (KAFKA-13559) The broker's ProduceResponse may be delayed for 300ms

2021-12-22 Thread frankshi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464212#comment-17464212 ] frankshi commented on KAFKA-13559: -- [~ijuma] Thanks! How do you think about changing t

[GitHub] [kafka] JoeCqupt edited a comment on pull request #10056: KAFKA-12293: remove JCenter and Bintray repositories mentions out of build gradle scripts (sunset is announced for those repositories

2021-12-22 Thread GitBox
JoeCqupt edited a comment on pull request #10056: URL: https://github.com/apache/kafka/pull/10056#issuecomment-999717832 > I tried backporting to 2.8 and the older Gradle plugin versions in that branch were not available in Maven central. We should probably wait a few months and see how th

[jira] [Commented] (KAFKA-13289) Bulk processing correctly ordered input data through a join with kafka-streams results in `Skipping record for expired segment`

2021-12-22 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464274#comment-17464274 ] Eugen Dück commented on KAFKA-13289: As the "Skipping record for expired segment" lo

[jira] (KAFKA-13289) Bulk processing correctly ordered input data through a join with kafka-streams results in `Skipping record for expired segment`

2021-12-22 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-13289 ] Eugen Dück deleted comment on KAFKA-13289: was (Author: eugendueck): As the "Skipping record for expired segment" log indicates the possibility of message loss, and we have now confirmed mes

[jira] [Commented] (KAFKA-13289) Bulk processing correctly ordered input data through a join with kafka-streams results in `Skipping record for expired segment`

2021-12-22 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464313#comment-17464313 ] Eugen Dück commented on KAFKA-13289: As the "Skipping record for expired segment" lo

[GitHub] [kafka] RivenSun2 commented on a change in pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-12-22 Thread GitBox
RivenSun2 commented on a change in pull request #11340: URL: https://github.com/apache/kafka/pull/11340#discussion_r774350403 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -1073,22 +1084,14 @@ private void doAuto

[jira] [Created] (KAFKA-13564) Kafka keep print NOT_LEADER_OR_FOLLOWER in log file after one broker dropped, and the producer can not work.

2021-12-22 Thread ZhenChun Pan (Jira)
ZhenChun Pan created KAFKA-13564: Summary: Kafka keep print NOT_LEADER_OR_FOLLOWER in log file after one broker dropped, and the producer can not work. Key: KAFKA-13564 URL: https://issues.apache.org/jira/browse/K

[GitHub] [kafka] RivenSun2 commented on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-12-22 Thread GitBox
RivenSun2 commented on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-196049 @guozhangwang @showuon Thanks for your review, I just submitted some changes. please help check again when available. Thank you. -- This is an automated message from

[GitHub] [kafka] showuon commented on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-12-22 Thread GitBox
showuon commented on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-1000109303 Let's see the jenkins test results. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo