vamossagar12 commented on a change in pull request #11424:
URL: https://github.com/apache/kafka/pull/11424#discussion_r774024121
##########
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##########
@@ -1224,17 +1248,20 @@ private int getNextThreadIndex() {
}
}
- private long getCacheSizePerThread(final int numStreamThreads) {
+ private long getMemorySizePerThread(final int numStreamThreads, final
boolean resizeCache) {
Review comment:
@guozhangwang , For the most part this should work. However, in
`addStreamThread` , when we need to add a new StreamThread, then at that point,
the `createAndAddStreamThread` method expects the newly computed cache size and
the new logic for max buffer size. With the consolidated logic and
getMemorySizePerThread being converted to return a string to be used for
logging purpose only, getting this value to be passed to the constructor might
become difficult. Or am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
