showuon commented on pull request #11564:
URL: https://github.com/apache/kafka/pull/11564#issuecomment-998618980
@mimaison , Thanks for the comment. I've updated the PR. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
florin-akermann commented on a change in pull request #11456:
URL: https://github.com/apache/kafka/pull/11456#discussion_r773067418
##
File path: core/src/main/scala/kafka/tools/ConsoleProducer.scala
##
@@ -29,8 +25,16 @@ import kafka.utils.{CommandDefaultOptions, CommandLineUt
florin-akermann commented on a change in pull request #11456:
URL: https://github.com/apache/kafka/pull/11456#discussion_r773067418
##
File path: core/src/main/scala/kafka/tools/ConsoleProducer.scala
##
@@ -29,8 +25,16 @@ import kafka.utils.{CommandDefaultOptions, CommandLineUt
satishd commented on a change in pull request #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r773121075
##
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##
@@ -396,7 +399,12 @@ abstract class AbstractFetcherThread(name: String,
satishd commented on a change in pull request #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r773121400
##
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##
@@ -715,6 +725,58 @@ abstract class AbstractFetcherThread(name: String,
satishd commented on a change in pull request #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r773121903
##
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##
@@ -715,6 +726,57 @@ abstract class AbstractFetcherThread(name: String,
satishd commented on a change in pull request #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r773122505
##
File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala
##
@@ -386,11 +396,76 @@ class ReplicaFetcherThread(name: String,
}
/**
satishd commented on a change in pull request #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r773123927
##
File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala
##
@@ -386,11 +396,76 @@ class ReplicaFetcherThread(name: String,
}
/**
Satish Duggana created KAFKA-13560:
--
Summary: Load indexes and data in async manner in the critical
path of replica fetcher threads.
Key: KAFKA-13560
URL: https://issues.apache.org/jira/browse/KAFKA-13560
satishd commented on a change in pull request #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r773143045
##
File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala
##
@@ -386,11 +396,76 @@ class ReplicaFetcherThread(name: String,
}
/**
florin-akermann commented on pull request #11456:
URL: https://github.com/apache/kafka/pull/11456#issuecomment-998809284
> A point that was raised in the discussion on KIP-810 is whether we should
prevent setting `headers.delimiter`, `headers.separator` and
`headers.key.separator` to colli
satishd commented on pull request #11390:
URL: https://github.com/apache/kafka/pull/11390#issuecomment-998818025
@junrao : Thanks for the review. Please find inline replies, updated the PR
addressing them with the latest commit.
--
This is an automated message from the Apache Git Service
[
https://issues.apache.org/jira/browse/KAFKA-13560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana reassigned KAFKA-13560:
--
Assignee: Kamal Chandraprakash
> Load indexes and data in async manner in the critica
[
https://issues.apache.org/jira/browse/KAFKA-13559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463360#comment-17463360
]
Ismael Juma commented on KAFKA-13559:
-
Great investigation, thanks!
> The broker's
[
https://issues.apache.org/jira/browse/KAFKA-13559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463367#comment-17463367
]
Ismael Juma commented on KAFKA-13559:
-
Regarding the total time, yes it doesn't incl
lbradstreet opened a new pull request #11619:
URL: https://github.com/apache/kafka/pull/11619
EmbeddedKafkaCluster in other projects use 2MB for their offset map to
reduce memory consumption in test runs.
--
This is an automated message from the Apache Git Service.
To respond to the me
[
https://issues.apache.org/jira/browse/KAFKA-13549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-13549:
Description:
KIP-811:
[https://cwiki.apache.org/confluence/display/KAFKA/KIP-811%3A+Add+s
[
https://issues.apache.org/jira/browse/KAFKA-13549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-13549:
---
Assignee: Nicholas Telford
> Add "delete interval" config
> ---
[
https://issues.apache.org/jira/browse/KAFKA-13549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-13549:
Labels: kip (was: needs-kip)
> Add "delete interval" config
> ---
lbradstreet opened a new pull request #11620:
URL: https://github.com/apache/kafka/pull/11620
Checks that any threads with `raft` in their name do not become stray.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
kehuum opened a new pull request #11621:
URL: https://github.com/apache/kafka/pull/11621
[LI-HOTFIX] Resolve the bootstrap server when cluster metadata hasn't been
refreshed for a long time
This patch adds a config li.client.cluster.metadata.expire.time.ms which
controls the max
kehuum closed pull request #11621:
URL: https://github.com/apache/kafka/pull/11621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr..
Guozhang Wang created KAFKA-13561:
-
Summary: Consider deprecating `StreamsBuilder#build(props)`
function
Key: KAFKA-13561
URL: https://issues.apache.org/jira/browse/KAFKA-13561
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-13561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463436#comment-17463436
]
Matthias J. Sax commented on KAFKA-13561:
-
My personal idea was actually to depr
[
https://issues.apache.org/jira/browse/KAFKA-13561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-13561:
Component/s: streams
> Consider deprecating `StreamsBuilder#build(props)` function
> -
[
https://issues.apache.org/jira/browse/KAFKA-13561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-13561:
Labels: needs-kip (was: )
> Consider deprecating `StreamsBuilder#build(props)` function
>
[
https://issues.apache.org/jira/browse/KAFKA-13561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463438#comment-17463438
]
Guozhang Wang commented on KAFKA-13561:
---
Our lessons learned from a couple on-goin
[
https://issues.apache.org/jira/browse/KAFKA-13561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463439#comment-17463439
]
Matthias J. Sax commented on KAFKA-13561:
-
Thanks for the details.
> Consider d
David Urton created KAFKA-13562:
---
Summary: Mirror Maker 2 Negative Offsets
Key: KAFKA-13562
URL: https://issues.apache.org/jira/browse/KAFKA-13562
Project: Kafka
Issue Type: Bug
Compo
dajac opened a new pull request #11622:
URL: https://github.com/apache/kafka/pull/11622
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade not
guozhangwang commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r773470459
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -1073,22 +1084,14 @@ private void doA
vvcephei commented on a change in pull request #11567:
URL: https://github.com/apache/kafka/pull/11567#discussion_r773472551
##
File path:
streams/src/main/java/org/apache/kafka/streams/query/WindowKeyQuery.java
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Found
guozhangwang commented on a change in pull request #11424:
URL: https://github.com/apache/kafka/pull/11424#discussion_r773490666
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -1074,9 +1083,22 @@ private static Metrics getMetrics(final Stre
wyuka commented on a change in pull request #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r773499214
##
File path: core/src/main/java/kafka/server/builders/ReplicaManagerBuilder.java
##
@@ -85,6 +87,11 @@ public ReplicaManagerBuilder setLogManager(LogManage
jeffkbkim commented on pull request #11566:
URL: https://github.com/apache/kafka/pull/11566#issuecomment-999175470
@dajac @showuon i reverted to using `reason: Option[String]` for
`handleJoinGroup()`. KafkaApi always pass in a `reason` which could be `null`
so we would see "null" as the re
[
https://issues.apache.org/jira/browse/KAFKA-13561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-13561:
-
Assignee: Luke Chen
> Consider deprecating `StreamsBuilder#build(props)` function
> ---
ccding commented on pull request #11345:
URL: https://github.com/apache/kafka/pull/11345#issuecomment-999311076
@kowshik @junrao @hachikuji I have addressed the review comments and please
take a look. thanks
--
This is an automated message from the Apache Git Service.
To respond to the m
37 matches
Mail list logo
