kowshik commented on a change in pull request #11345:
URL: https://github.com/apache/kafka/pull/11345#discussion_r759942807
##
File path: core/src/main/scala/kafka/log/UnifiedLog.scala
##
@@ -1498,25 +1498,25 @@ class UnifiedLog(@volatile var logStartOffset: Long,
producer
[
https://issues.apache.org/jira/browse/KAFKA-13435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451661#comment-17451661
]
David Jacot commented on KAFKA-13435:
-
[~rleslie] I understand your point. Manually
vpapavas commented on a change in pull request #11541:
URL: https://github.com/apache/kafka/pull/11541#discussion_r760015271
##
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/InMemorySessionStoreTest.java
##
@@ -83,4 +88,31 @@ public void shouldNotEx
vpapavas commented on a change in pull request #11541:
URL: https://github.com/apache/kafka/pull/11541#discussion_r760015599
##
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractSessionBytesStoreTest.java
##
@@ -77,7 +77,7 @@
private Mock
Patrick Stuedi created KAFKA-13493:
--
Summary: Session and Window Queries for IQv2
Key: KAFKA-13493
URL: https://issues.apache.org/jira/browse/KAFKA-13493
Project: Kafka
Issue Type: Improveme
Patrick Stuedi created KAFKA-13494:
--
Summary: Session and Window Queries for IQv2
Key: KAFKA-13494
URL: https://issues.apache.org/jira/browse/KAFKA-13494
Project: Kafka
Issue Type: Sub-task
vpapavas commented on a change in pull request #11513:
URL: https://github.com/apache/kafka/pull/11513#discussion_r760099865
##
File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
##
@@ -947,6 +947,11 @@
// Private API used to control the emit
vpapavas commented on a change in pull request #11513:
URL: https://github.com/apache/kafka/pull/11513#discussion_r755096395
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ChangelogRecordDeserializationHelper.java
##
@@ -0,0 +1,38 @@
+/*
+ * L
vpapavas commented on a change in pull request #11513:
URL: https://github.com/apache/kafka/pull/11513#discussion_r755096395
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ChangelogRecordDeserializationHelper.java
##
@@ -0,0 +1,38 @@
+/*
+ * L
vpapavas commented on a change in pull request #11513:
URL: https://github.com/apache/kafka/pull/11513#discussion_r755099262
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/CachingKeyValueStore.java
##
@@ -155,6 +169,11 @@ private void putInternal(
vpapavas commented on a change in pull request #11513:
URL: https://github.com/apache/kafka/pull/11513#discussion_r760111821
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/ChangeLoggingSessionBytesStore.java
##
@@ -79,15 +94,21 @@ public void init
vpapavas commented on a change in pull request #11513:
URL: https://github.com/apache/kafka/pull/11513#discussion_r760111821
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/ChangeLoggingSessionBytesStore.java
##
@@ -79,15 +94,21 @@ public void init
vpapavas commented on a change in pull request #11513:
URL: https://github.com/apache/kafka/pull/11513#discussion_r760121526
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/Position.java
##
@@ -27,6 +30,8 @@
import java.util.function.BiConsumer;
vpapavas commented on a change in pull request #11513:
URL: https://github.com/apache/kafka/pull/11513#discussion_r760111821
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/ChangeLoggingSessionBytesStore.java
##
@@ -79,15 +94,21 @@ public void init
[
https://issues.apache.org/jira/browse/KAFKA-13451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-13451:
Summary: Add reason to JoinGroupRequest and LeaveGroupRequest (was: Add
reason to LeaveGroupReque
David Jacot created KAFKA-13495:
---
Summary: Add reason to JoinGroupRequest
Key: KAFKA-13495
URL: https://issues.apache.org/jira/browse/KAFKA-13495
Project: Kafka
Issue Type: Sub-task
David Jacot created KAFKA-13496:
---
Summary: Add reason to LeaveGroupRequest
Key: KAFKA-13496
URL: https://issues.apache.org/jira/browse/KAFKA-13496
Project: Kafka
Issue Type: Sub-task
patrickstuedi commented on a change in pull request #11557:
URL: https://github.com/apache/kafka/pull/11557#discussion_r76021
##
File path: streams/src/main/java/org/apache/kafka/streams/query/Position.java
##
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Software Founda
vpapavas commented on a change in pull request #11557:
URL: https://github.com/apache/kafka/pull/11557#discussion_r760231430
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -1716,4 +1725,100 @@ protected void processStreamThread(final
Consu
vpapavas commented on a change in pull request #11557:
URL: https://github.com/apache/kafka/pull/11557#discussion_r760233137
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -1716,4 +1725,100 @@ protected void processStreamThread(final
Consu
patrickstuedi commented on a change in pull request #11557:
URL: https://github.com/apache/kafka/pull/11557#discussion_r76021
##
File path: streams/src/main/java/org/apache/kafka/streams/query/Position.java
##
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Software Founda
vpapavas commented on a change in pull request #11557:
URL: https://github.com/apache/kafka/pull/11557#discussion_r760231430
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -1716,4 +1725,100 @@ protected void processStreamThread(final
Consu
vijaykriishna opened a new pull request #11558:
URL: https://github.com/apache/kafka/pull/11558
KAFKA-13323 Fixed variable name in KafkaConsumer
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build
vpapavas commented on a change in pull request #11557:
URL: https://github.com/apache/kafka/pull/11557#discussion_r760254988
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/TimestampedKeyValueStoreBuilder.java
##
@@ -184,6 +187,20 @@ public boolean
dajac opened a new pull request #11559:
URL: https://github.com/apache/kafka/pull/11559
TODO
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upg
C0urante commented on a change in pull request #10910:
URL: https://github.com/apache/kafka/pull/10910#discussion_r760307980
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java
##
@@ -113,6 +113,7 @@
private final ConcurrentMap conne
[
https://issues.apache.org/jira/browse/KAFKA-12703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451134#comment-17451134
]
Ville Valtonen edited comment on KAFKA-12703 at 12/1/21, 3:44 PM:
[
https://issues.apache.org/jira/browse/KAFKA-13435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451896#comment-17451896
]
David Jacot commented on KAFKA-13435:
-
I have put a bit more thoughts into this and
dajac commented on pull request #11539:
URL: https://github.com/apache/kafka/pull/11539#issuecomment-983787420
@showuon Thanks, good catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
Spencer Carlson created KAFKA-13497:
---
Summary: Debug Log RegexRouter transform
Key: KAFKA-13497
URL: https://issues.apache.org/jira/browse/KAFKA-13497
Project: Kafka
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/KAFKA-6995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451907#comment-17451907
]
Jørgen commented on KAFKA-6995:
---
Are there any other ways to proactively leave the group wh
vamossagar12 commented on a change in pull request #11424:
URL: https://github.com/apache/kafka/pull/11424#discussion_r760368431
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/TaskMetrics.java
##
@@ -128,6 +131,22 @@ public static Sens
vamossagar12 commented on pull request #11211:
URL: https://github.com/apache/kafka/pull/11211#issuecomment-983825844
> @mjsax @ableegoldman could you chime in here?
> @mjsax @ableegoldman could you chime in here?
hi.. bumping this thread again..
--
This is an automa
vamossagar12 commented on a change in pull request #11433:
URL: https://github.com/apache/kafka/pull/11433#discussion_r760369366
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -292,12 +327,20 @@ public void handleAssignm
[
https://issues.apache.org/jira/browse/KAFKA-13435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451922#comment-17451922
]
Ryan Leslie commented on KAFKA-13435:
-
[~dajac] Yes, I was going to suggest somethin
vvcephei commented on a change in pull request #11557:
URL: https://github.com/apache/kafka/pull/11557#discussion_r760395779
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -1716,4 +1725,100 @@ protected void processStreamThread(final
Consu
vvcephei commented on a change in pull request #11557:
URL: https://github.com/apache/kafka/pull/11557#discussion_r760404989
##
File path: streams/src/main/java/org/apache/kafka/streams/query/Position.java
##
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Software Foundation
vvcephei commented on a change in pull request #11557:
URL: https://github.com/apache/kafka/pull/11557#discussion_r760406552
##
File path: streams/src/main/java/org/apache/kafka/streams/query/Position.java
##
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Software Foundation
mimaison opened a new pull request #11560:
URL: https://github.com/apache/kafka/pull/11560
Implements KIP-788. The number of network threads can be set per listener
using the following syntax:
listener.name..num.network.threads=
It's currently a draft PR, there are still a bunch o
[
https://issues.apache.org/jira/browse/KAFKA-13451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeff Kim reassigned KAFKA-13451:
Assignee: Jeff Kim (was: David Jacot)
> Add reason to JoinGroupRequest and LeaveGroupRequest
> -
[
https://issues.apache.org/jira/browse/KAFKA-13495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeff Kim reassigned KAFKA-13495:
Assignee: Jeff Kim (was: David Jacot)
> Add reason to JoinGroupRequest
> ---
[
https://issues.apache.org/jira/browse/KAFKA-13496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeff Kim reassigned KAFKA-13496:
Assignee: Jeff Kim (was: David Jacot)
> Add reason to LeaveGroupRequest
> --
mimaison commented on pull request #11560:
URL: https://github.com/apache/kafka/pull/11560#issuecomment-983865906
cc @rajinisivaram @tombentley @dajac
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
florin-akermann commented on pull request #11456:
URL: https://github.com/apache/kafka/pull/11456#issuecomment-983876161
@dajac i dare to nag :) or shall I nag on d...@kafka.apache.org instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
jsancio edited a comment on pull request #11556:
URL: https://github.com/apache/kafka/pull/11556#issuecomment-982933214
This hasn't cause further issues because we haven't fully implemented
compression for KRaft. Created
https://issues.apache.org/jira/browse/KAFKA-13489 track this and add
John Roesler created KAFKA-13498:
Summary: IQv2: Track Position in remaining stores
Key: KAFKA-13498
URL: https://issues.apache.org/jira/browse/KAFKA-13498
Project: Kafka
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/KAFKA-13498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler reassigned KAFKA-13498:
Assignee: Patrick Stuedi
> IQv2: Track Position in remaining stores
> ---
vvcephei commented on pull request #11541:
URL: https://github.com/apache/kafka/pull/11541#issuecomment-983881235
The test failures were known-flaky, unrelated tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
vvcephei commented on a change in pull request #11541:
URL: https://github.com/apache/kafka/pull/11541#discussion_r760433645
##
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractSessionBytesStoreTest.java
##
@@ -77,7 +77,7 @@
private Mock
vvcephei merged pull request #11541:
URL: https://github.com/apache/kafka/pull/11541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr
[
https://issues.apache.org/jira/browse/KAFKA-13498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler resolved KAFKA-13498.
--
Resolution: Fixed
> IQv2: Track Position in remaining stores
> ---
[
https://issues.apache.org/jira/browse/KAFKA-13498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler closed KAFKA-13498.
> IQv2: Track Position in remaining stores
>
>
>
vvcephei commented on pull request #11557:
URL: https://github.com/apache/kafka/pull/11557#issuecomment-983926936
Rebased to resolve conflicts with #11541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/KAFKA-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451957#comment-17451957
]
Walker Carlson commented on KAFKA-13281:
[~showuon] We haven't drafted a KIP yet
[
https://issues.apache.org/jira/browse/KAFKA-12377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451961#comment-17451961
]
Matthias J. Sax commented on KAFKA-12377:
-
Failed again.
> Flaky Test SaslAuthe
[
https://issues.apache.org/jira/browse/KAFKA-12377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451962#comment-17451962
]
Matthias J. Sax commented on KAFKA-12377:
-
And one more (different stack trace)
junrao commented on a change in pull request #11345:
URL: https://github.com/apache/kafka/pull/11345#discussion_r760483493
##
File path: core/src/main/scala/kafka/log/UnifiedLog.scala
##
@@ -1498,28 +1498,44 @@ class UnifiedLog(@volatile var logStartOffset: Long,
producerS
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-983959899
Hi @cadonna ,
Will you have time to look at this PR again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
hachikuji commented on a change in pull request #11345:
URL: https://github.com/apache/kafka/pull/11345#discussion_r760521586
##
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##
@@ -443,7 +443,7 @@ private void onBecomeLeader(long currentTimeMs) {
[
https://issues.apache.org/jira/browse/KAFKA-12377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17452038#comment-17452038
]
Matthias J. Sax commented on KAFKA-12377:
-
And one more.
> Flaky Test SaslAuthe
rondagostino commented on a change in pull request #11503:
URL: https://github.com/apache/kafka/pull/11503#discussion_r760615477
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -1960,9 +1962,16 @@ class KafkaConfig private(doLog: Boolean, val props:
java
rondagostino commented on a change in pull request #11503:
URL: https://github.com/apache/kafka/pull/11503#discussion_r760626984
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -2018,12 +2015,104 @@ class KafkaConfig private(doLog: Boolean, val props:
ja
cmccabe commented on a change in pull request #11503:
URL: https://github.com/apache/kafka/pull/11503#discussion_r760628258
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -1960,9 +1962,16 @@ class KafkaConfig private(doLog: Boolean, val props:
java.util
rondagostino commented on a change in pull request #11503:
URL: https://github.com/apache/kafka/pull/11503#discussion_r760632090
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -1960,9 +1962,16 @@ class KafkaConfig private(doLog: Boolean, val props:
java
hachikuji commented on a change in pull request #11503:
URL: https://github.com/apache/kafka/pull/11503#discussion_r760634593
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -1960,9 +1962,16 @@ class KafkaConfig private(doLog: Boolean, val props:
java.ut
hachikuji commented on a change in pull request #11503:
URL: https://github.com/apache/kafka/pull/11503#discussion_r760636630
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -2018,12 +2015,104 @@ class KafkaConfig private(doLog: Boolean, val props:
java.
ccding commented on a change in pull request #11345:
URL: https://github.com/apache/kafka/pull/11345#discussion_r760640970
##
File path: core/src/main/scala/kafka/log/UnifiedLog.scala
##
@@ -1498,28 +1498,44 @@ class UnifiedLog(@volatile var logStartOffset: Long,
producerS
HyunSangHan commented on a change in pull request #11418:
URL: https://github.com/apache/kafka/pull/11418#discussion_r760666349
##
File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java
##
@@ -1080,8 +1080,13 @@ public void handleSuccessfulResponse(Request
[
https://issues.apache.org/jira/browse/KAFKA-13458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17452111#comment-17452111
]
Matthias J. Sax commented on KAFKA-13458:
-
[~marathed] You are using the Java co
mjsax commented on a change in pull request #11455:
URL: https://github.com/apache/kafka/pull/11455#discussion_r760703870
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/GlobalKTableIntegrationTest.java
##
@@ -337,7 +341,18 @@ public void shouldGetToRu
showuon commented on pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#issuecomment-984230083
@ctan888, Sorry again, but I'd really like to have this KIP to get
implemented in Kafka. I've been waiting for your reply for more than a month
(from github and direct email). Jus
[
https://issues.apache.org/jira/browse/KAFKA-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17452128#comment-17452128
]
Aditya Upadhyaya commented on KAFKA-12559:
--
[~ableegoldman]: I have a fair bit
[
https://issues.apache.org/jira/browse/KAFKA-13281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17452134#comment-17452134
]
Luke Chen commented on KAFKA-13281:
---
[~wcarlson5] , thank you!
[KIP-591|https://cwiki
[
https://issues.apache.org/jira/browse/KAFKA-13474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17452158#comment-17452158
]
Igor Shipenkov commented on KAFKA-13474:
Tried to reproduce problen on kafka 2.8
[
https://issues.apache.org/jira/browse/KAFKA-13474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Shipenkov updated KAFKA-13474:
---
Affects Version/s: 2.8.1
> Regression in dynamic update of broker client-side SSL factory
>
kowshik commented on a change in pull request #11345:
URL: https://github.com/apache/kafka/pull/11345#discussion_r760752732
##
File path: core/src/main/scala/kafka/log/UnifiedLog.scala
##
@@ -1498,28 +1498,44 @@ class UnifiedLog(@volatile var logStartOffset: Long,
producer
kowshik commented on a change in pull request #11345:
URL: https://github.com/apache/kafka/pull/11345#discussion_r760752732
##
File path: core/src/main/scala/kafka/log/UnifiedLog.scala
##
@@ -1498,28 +1498,44 @@ class UnifiedLog(@volatile var logStartOffset: Long,
producer
[
https://issues.apache.org/jira/browse/KAFKA-13474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Shipenkov updated KAFKA-13474:
---
Affects Version/s: 3.0.0
> Regression in dynamic update of broker client-side SSL factory
>
[
https://issues.apache.org/jira/browse/KAFKA-13474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17452200#comment-17452200
]
Igor Shipenkov commented on KAFKA-13474:
Well, I tried version 3.0.0 and I can r
dajac commented on pull request #11456:
URL: https://github.com/apache/kafka/pull/11456#issuecomment-984375239
@florin-akermann Sorry for the delay... Your PR is still in my review queue.
I've been quite busy with the AK 3.1 release (blockers, validation, and co).
--
This is an automated
showuon commented on pull request #11451:
URL: https://github.com/apache/kafka/pull/11451#issuecomment-984376524
@dajac , please have a 2nd review when available. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
81 matches
Mail list logo