mjsax commented on a change in pull request #11455:
URL: https://github.com/apache/kafka/pull/11455#discussion_r760703870
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/GlobalKTableIntegrationTest.java
##########
@@ -337,7 +341,18 @@ public void shouldGetToRunningWithOnlyGlobalTopology()
throws Exception {
startStreams();
waitForApplicationState(singletonList(kafkaStreams), State.RUNNING,
Duration.ofSeconds(30));
- kafkaStreams.close();
Review comment:
>But it also seems like we are missing tests for the error case where
the state of the Streams client closes to ERROR.
Not sure what this test should verify exactly? The final state of the
client? Some log messages?
> However, then we need a separate PR for the missing test or a ticket that
documents that a test is missing.
Happy to do a follow up PR.
> Have you had a look into GlobalStreamThreadTest? Could we add something
there?
I don't think that `GlobalStreamThreadTest` works, because it tests the
thread in isolation, while we want to test the interaction with `KafkaStream`
client? (At least from my current understanding from you comment above). Maybe
we could add a test to `KafkaStreamsTest` though?
Let me update this PR removing this test change so we can merge it, and work
on a follow up PR afterwards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
