[jira] [Created] (KAFKA-13424) Redundant cleanup operations in TopicChangeHandler or TopicDeletionManager

2021-10-31 Thread Xiaobing Fang (Jira)
Xiaobing Fang created KAFKA-13424: - Summary: Redundant cleanup operations in TopicChangeHandler or TopicDeletionManager Key: KAFKA-13424 URL: https://issues.apache.org/jira/browse/KAFKA-13424 Project:

[jira] [Updated] (KAFKA-13424) Redundant cleanup operations in TopicChangeHandler or TopicDeletionManager

2021-10-31 Thread Xiaobing Fang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaobing Fang updated KAFKA-13424: -- Description: In ```TopicDeletionManager.completeDeleteTopic()```, `controllerContext.removeTo

[jira] [Updated] (KAFKA-13424) Redundant cleanup operations in TopicChangeHandler or TopicDeletionManager

2021-10-31 Thread Xiaobing Fang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaobing Fang updated KAFKA-13424: -- Description: In `*TopicDeletionManager.completeDeleteTopic()*`, `*controllerContext.removeTop

[jira] [Updated] (KAFKA-13424) Redundant cleanup operations in TopicChangeHandler or TopicDeletionManager

2021-10-31 Thread Xiaobing Fang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaobing Fang updated KAFKA-13424: -- Description: In `*TopicDeletionManager.completeDeleteTopic()*`, `*controllerContext.removeTop

[GitHub] [kafka] dongjinleekr commented on pull request #11454: KAFKA-13341: Quotas are not applied to requests with null clientId

2021-10-31 Thread GitBox
dongjinleekr commented on pull request #11454: URL: https://github.com/apache/kafka/pull/11454#issuecomment-955650953 Hi @splett2, It seems like this issue is somewhat overlapped one, like: 1. Null client IDs were being improperly propagated (addressed by #11385.) 2. `Clien

[GitHub] [kafka] dongjinleekr commented on a change in pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-10-31 Thread GitBox
dongjinleekr commented on a change in pull request #11431: URL: https://github.com/apache/kafka/pull/11431#discussion_r73941 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java ## @@ -183,12 +187,18 @@ public MirrorClientConfig

[GitHub] [kafka] dongjinleekr commented on pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-10-31 Thread GitBox
dongjinleekr commented on pull request #11431: URL: https://github.com/apache/kafka/pull/11431#issuecomment-955660566 So, We can now organize the issues like the following: 1. Preventing the malfunctioning (i.e., replication of MM2 internal topics) 2. Keeping consistency (as far as

[GitHub] [kafka] florin-akermann opened a new pull request #11456: KAFKA-13351: Add possibility to write kafka headers in Kafka Console Producer

2021-10-31 Thread GitBox
florin-akermann opened a new pull request #11456: URL: https://github.com/apache/kafka/pull/11456 Adding: --property parse.headers=true to cmdl enabled header parsing. Just like with the ConsoleConsumer, tif headers and/or key enabled then the order is "headers key value". The separat

[jira] [Commented] (KAFKA-13351) Add possibility to write kafka headers in Kafka Console Producer

2021-10-31 Thread Florin Akermann (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436525#comment-17436525 ] Florin Akermann commented on KAFKA-13351: - Hi, I made a PR for it. However I can

[GitHub] [kafka] florin-akermann commented on pull request #11456: KAFKA-13351: Add possibility to write kafka headers in Kafka Console Producer

2021-10-31 Thread GitBox
florin-akermann commented on pull request #11456: URL: https://github.com/apache/kafka/pull/11456#issuecomment-955775367 @cmccabe -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [kafka] florin-akermann edited a comment on pull request #11456: KAFKA-13351: Add possibility to write kafka headers in Kafka Console Producer

2021-10-31 Thread GitBox
florin-akermann edited a comment on pull request #11456: URL: https://github.com/apache/kafka/pull/11456#issuecomment-955775367 @cmccabe Assuming you have the privileges for it, please could you trigger a build and assign me to the ticket https://issues.apache.org/jira/browse/KAFKA-13351

[GitHub] [kafka] OmniaGM commented on a change in pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-10-31 Thread GitBox
OmniaGM commented on a change in pull request #11431: URL: https://github.com/apache/kafka/pull/11431#discussion_r739869555 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java ## @@ -183,12 +187,18 @@ public MirrorClientConfig clie

[GitHub] [kafka] OmniaGM commented on a change in pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-10-31 Thread GitBox
OmniaGM commented on a change in pull request #11431: URL: https://github.com/apache/kafka/pull/11431#discussion_r739869555 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java ## @@ -183,12 +187,18 @@ public MirrorClientConfig clie

[GitHub] [kafka] OmniaGM commented on a change in pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-10-31 Thread GitBox
OmniaGM commented on a change in pull request #11431: URL: https://github.com/apache/kafka/pull/11431#discussion_r739869555 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java ## @@ -183,12 +187,18 @@ public MirrorClientConfig clie

[GitHub] [kafka] OmniaGM commented on a change in pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-10-31 Thread GitBox
OmniaGM commented on a change in pull request #11431: URL: https://github.com/apache/kafka/pull/11431#discussion_r739870251 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java ## @@ -183,12 +187,18 @@ public MirrorClientConfig clie

[GitHub] [kafka] OmniaGM commented on a change in pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-10-31 Thread GitBox
OmniaGM commented on a change in pull request #11431: URL: https://github.com/apache/kafka/pull/11431#discussion_r739870251 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java ## @@ -183,12 +187,18 @@ public MirrorClientConfig clie

[GitHub] [kafka] OmniaGM commented on a change in pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-10-31 Thread GitBox
OmniaGM commented on a change in pull request #11431: URL: https://github.com/apache/kafka/pull/11431#discussion_r739870251 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java ## @@ -183,12 +187,18 @@ public MirrorClientConfig clie

[GitHub] [kafka] OmniaGM commented on a change in pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-10-31 Thread GitBox
OmniaGM commented on a change in pull request #11431: URL: https://github.com/apache/kafka/pull/11431#discussion_r739870251 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java ## @@ -183,12 +187,18 @@ public MirrorClientConfig clie

[GitHub] [kafka] OmniaGM commented on a change in pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-10-31 Thread GitBox
OmniaGM commented on a change in pull request #11431: URL: https://github.com/apache/kafka/pull/11431#discussion_r739870251 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java ## @@ -183,12 +187,18 @@ public MirrorClientConfig clie

[GitHub] [kafka] OmniaGM commented on a change in pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-10-31 Thread GitBox
OmniaGM commented on a change in pull request #11431: URL: https://github.com/apache/kafka/pull/11431#discussion_r739870251 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java ## @@ -183,12 +187,18 @@ public MirrorClientConfig clie

[GitHub] [kafka] OmniaGM commented on a change in pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-10-31 Thread GitBox
OmniaGM commented on a change in pull request #11431: URL: https://github.com/apache/kafka/pull/11431#discussion_r739870251 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java ## @@ -183,12 +187,18 @@ public MirrorClientConfig clie

[GitHub] [kafka] OmniaGM commented on a change in pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-10-31 Thread GitBox
OmniaGM commented on a change in pull request #11431: URL: https://github.com/apache/kafka/pull/11431#discussion_r739870251 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java ## @@ -183,12 +187,18 @@ public MirrorClientConfig clie

[GitHub] [kafka] OmniaGM commented on a change in pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-10-31 Thread GitBox
OmniaGM commented on a change in pull request #11431: URL: https://github.com/apache/kafka/pull/11431#discussion_r739870251 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java ## @@ -183,12 +187,18 @@ public MirrorClientConfig clie

[GitHub] [kafka] Luizfrf3 edited a comment on pull request #11441: KAFKA-8941: Add RocksDB Metrics that Could not be Added due to RocksD…

2021-10-31 Thread GitBox
Luizfrf3 edited a comment on pull request #11441: URL: https://github.com/apache/kafka/pull/11441#issuecomment-954094430 Hello @cadonna, @ableegoldman and @mjsax. The pull request is ready to be reviewed. Best regards, -- This is an automated message from the Apache Git Serv

[GitHub] [kafka] florin-akermann commented on pull request #11456: KAFKA-13351: Add possibility to write kafka headers in Kafka Console Producer

2021-10-31 Thread GitBox
florin-akermann commented on pull request #11456: URL: https://github.com/apache/kafka/pull/11456#issuecomment-955804300 Hi, Regarding the failing tests: I think the kafka.admin.LeaderElectionCommandTest might contain flaky tests. They pass locally. See image. Could you trigger a re

[jira] [Comment Edited] (KAFKA-13226) Partition expansion may cause uneven distribution

2021-10-31 Thread shizhenzhen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17435380#comment-17435380 ] shizhenzhen edited comment on KAFKA-13226 at 11/1/21, 2:40 AM: ---

[jira] [Updated] (KAFKA-13370) Offset commit failure percentage metric is not computed correctly (regression)

2021-10-31 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-13370: -- Priority: Blocker (was: Minor) > Offset commit failure percentage metric is not computed correctly (r

[jira] [Updated] (KAFKA-13370) Offset commit failure percentage metric is not computed correctly (regression)

2021-10-31 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-13370: -- Fix Version/s: (was: 2.8.0) 3.0.1 3.1.0 > Offset commit fail

[jira] [Commented] (KAFKA-13370) Offset commit failure percentage metric is not computed correctly (regression)

2021-10-31 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436624#comment-17436624 ] Luke Chen commented on KAFKA-13370: --- Set this issue as blocker for v3.0.1/v3.1.0 since

[jira] [Updated] (KAFKA-13396) kafka-topics.sh --create should not require the partitions/replication-factor argument

2021-10-31 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-13396: -- Priority: Blocker (was: Major) > kafka-topics.sh --create should not require the partitions/replicati

[jira] [Updated] (KAFKA-13396) kafka-topics.sh --create should not require the partitions/replication-factor argument

2021-10-31 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-13396: -- Fix Version/s: 3.0.1 3.1.0 > kafka-topics.sh --create should not require the partit

[jira] [Commented] (KAFKA-13396) kafka-topics.sh --create should not require the partitions/replication-factor argument

2021-10-31 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436625#comment-17436625 ] Luke Chen commented on KAFKA-13396: --- Set this issue as blocker for v3.0.1/v3.1.0 since