[GitHub] [kafka] showuon opened a new pull request #11413: KAFKA-13370: add errors when commit offsets failed and add tests

showuon opened a new pull request #11413: URL: https://github.com/apache/kafka/pull/11413 In https://github.com/apache/kafka/pull/9642, we removed the unnecessary `success` parameter, and use the `error` as the key to identify if the commit successfully or failed. However, there are some c

[GitHub] [kafka] showuon commented on a change in pull request #11413: KAFKA-13370: add errors when commit offsets failed and add tests

showuon commented on a change in pull request #11413: URL: https://github.com/apache/kafka/pull/11413#discussion_r731645529 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java ## @@ -514,9 +514,11 @@ public boolean commitOffsets()

[GitHub] [kafka] showuon commented on a change in pull request #11413: KAFKA-13370: add errors when commit offsets failed and add tests

showuon commented on a change in pull request #11413: URL: https://github.com/apache/kafka/pull/11413#discussion_r731647369 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java ## @@ -550,16 +552,16 @@ public boolean commitOffsets(

[GitHub] [kafka] showuon commented on a change in pull request #11413: KAFKA-13370: add errors when commit offsets failed and add tests

showuon commented on a change in pull request #11413: URL: https://github.com/apache/kafka/pull/11413#discussion_r731648129 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSourceTaskTest.java ## @@ -129,6 +129,7 @@ // is used in the righ

[GitHub] [kafka] showuon commented on a change in pull request #11413: KAFKA-13370: add errors when commit offsets failed and add tests

showuon commented on a change in pull request #11413: URL: https://github.com/apache/kafka/pull/11413#discussion_r731649801 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSourceTaskTest.java ## @@ -1580,9 +1652,22 @@ private void assertPollM

[GitHub] [kafka] showuon commented on pull request #11413: KAFKA-13370: add errors when commit offsets failed and add tests

showuon commented on pull request #11413: URL: https://github.com/apache/kafka/pull/11413#issuecomment-946513668 @chia7712 , could you please take a look? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[jira] [Commented] (KAFKA-13370) Offset commit failure percentage metric is not computed correctly (regression)

[ https://issues.apache.org/jira/browse/KAFKA-13370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430429#comment-17430429 ] Luke Chen commented on KAFKA-13370: --- [~20100g], thanks for reporting the issue. PR is

[jira] [Commented] (KAFKA-13043) Add Admin API for batched offset fetch requests (KIP-709)

[ https://issues.apache.org/jira/browse/KAFKA-13043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430444#comment-17430444 ] David Jacot commented on KAFKA-13043: - Moving this feature to 3.2.0 as [~skaundinya]

[jira] [Updated] (KAFKA-13043) Add Admin API for batched offset fetch requests (KIP-709)

[ https://issues.apache.org/jira/browse/KAFKA-13043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-13043: Fix Version/s: (was: 3.1.0) 3.2.0 > Add Admin API for batched offset fetch

[jira] [Commented] (KAFKA-13374) [Docs] - All reads from the leader of the partition even after KIP-392?

[ https://issues.apache.org/jira/browse/KAFKA-13374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430448#comment-17430448 ] Luke Chen commented on KAFKA-13374: --- Thank you for reporting and confirming, [~rmoff]

[GitHub] [kafka] satishd opened a new pull request #11414: MINOR: Renamed a few record definition files with the existing convention.

satishd opened a new pull request #11414: URL: https://github.com/apache/kafka/pull/11414 MINOR: Renamed a few record definition files with the existing convention. - Throwing an error message while reading LeaderEpochCheckpoint file with an unsupported version. ### Committer Che

[GitHub] [kafka] satishd commented on pull request #11414: MINOR: Renamed a few record definition files with the existing convention.

satishd commented on pull request #11414: URL: https://github.com/apache/kafka/pull/11414#issuecomment-946647417 @junrao This is a minor PR with the existing file name conventions and throwing a proper error message while reading LeaderEpochCache with an unsupported version. -- This is

[jira] [Resolved] (KAFKA-10539) Convert KStreamImpl joins to new PAPI

[ https://issues.apache.org/jira/browse/KAFKA-10539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Esteban Quilcate Otoya resolved KAFKA-10539. -- Resolution: Fixed https://github.com/apache/kafka/pull/11356

[jira] [Resolved] (KAFKA-10540) Convert KStream aggregations to new PAPI

[ https://issues.apache.org/jira/browse/KAFKA-10540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Esteban Quilcate Otoya resolved KAFKA-10540. -- Resolution: Fixed https://github.com/apache/kafka/pull/11315

[jira] [Commented] (KAFKA-10543) Convert KTable joins to new PAPI

[ https://issues.apache.org/jira/browse/KAFKA-10543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430507#comment-17430507 ] Jorge Esteban Quilcate Otoya commented on KAFKA-10543: -- WIP: [https

[GitHub] [kafka] jeqo opened a new pull request #11415: chore: ignore bin on new modules

jeqo opened a new pull request #11415: URL: https://github.com/apache/kafka/pull/11415 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes)

[jira] [Created] (KAFKA-13384) FailedPartitionsCount metric is not updated if a partition log file was corrupted

Alexander created KAFKA-13384: - Summary: FailedPartitionsCount metric is not updated if a partition log file was corrupted Key: KAFKA-13384 URL: https://issues.apache.org/jira/browse/KAFKA-13384 Project:

[jira] [Updated] (KAFKA-13384) FailedPartitionsCount metric is not updated if a partition log file was corrupted

[ https://issues.apache.org/jira/browse/KAFKA-13384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander updated KAFKA-13384: -- Description: We found a misbehavior on our Kafka cluster (version: 2.6.2 (Commit:da65af02e5856e34)), 

[jira] [Updated] (KAFKA-13384) FailedPartitionsCount metric is not updated if a partition log file was corrupted

[ https://issues.apache.org/jira/browse/KAFKA-13384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander updated KAFKA-13384: -- Description: We found a misbehavior on our Kafka cluster (version: 2.6.2 (Commit:da65af02e5856e34)), 

[jira] [Updated] (KAFKA-13384) FailedPartitionsCount metric is not updated if a partition log file was corrupted

[ https://issues.apache.org/jira/browse/KAFKA-13384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander updated KAFKA-13384: -- Description: We found a misbehavior on our Kafka cluster - version: 2.6.2 (Commit:da65af02e5856e34))

[GitHub] [kafka] jeqo closed pull request #10507: KAFKA-8410: Migrating stateful operators to new Processor API

jeqo closed pull request #10507: URL: https://github.com/apache/kafka/pull/10507 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@

[jira] [Commented] (KAFKA-13374) [Docs] - All reads from the leader of the partition even after KIP-392?

[ https://issues.apache.org/jira/browse/KAFKA-13374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430590#comment-17430590 ] Robin Moffatt commented on KAFKA-13374: --- Looks good to me as a layperson - thanks

[GitHub] [kafka] cmccabe opened a new pull request #11416: MINOR: Improve createTopics and incrementalAlterConfigs in KRaft

cmccabe opened a new pull request #11416: URL: https://github.com/apache/kafka/pull/11416 For CreateTopics, fix a bug where if one createTopics in a batch failed, they would all fail with the same error code. Make the error message for TOPIC_ALREADY_EXISTS consistent with the ZK-based

[GitHub] [kafka] cmccabe commented on pull request #11410: MINOR: Make TestUtils usable for KRaft mode

cmccabe commented on pull request #11410: URL: https://github.com/apache/kafka/pull/11410#issuecomment-946860744 Test failures seem like flakes (they pass locally) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [kafka] cmccabe commented on a change in pull request #10772: KAFKA-12697: Add FencedBrokerCount and ActiveBrokerCount metrics to the QuorumController

cmccabe commented on a change in pull request #10772: URL: https://github.com/apache/kafka/pull/10772#discussion_r732036343 ## File path: metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java ## @@ -249,6 +256,10 @@ public void replay(RegisterBrokerReco

[GitHub] [kafka] cmccabe commented on a change in pull request #10772: KAFKA-12697: Add FencedBrokerCount and ActiveBrokerCount metrics to the QuorumController

cmccabe commented on a change in pull request #10772: URL: https://github.com/apache/kafka/pull/10772#discussion_r732036343 ## File path: metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java ## @@ -249,6 +256,10 @@ public void replay(RegisterBrokerReco

[GitHub] [kafka] cmccabe commented on a change in pull request #10772: KAFKA-12697: Add FencedBrokerCount and ActiveBrokerCount metrics to the QuorumController

cmccabe commented on a change in pull request #10772: URL: https://github.com/apache/kafka/pull/10772#discussion_r732038559 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumControllerMetrics.java ## @@ -26,28 +26,36 @@ import java.util.Objects; public

[GitHub] [kafka] cmccabe commented on pull request #10772: KAFKA-12697: Add FencedBrokerCount and ActiveBrokerCount metrics to the QuorumController

cmccabe commented on pull request #10772: URL: https://github.com/apache/kafka/pull/10772#issuecomment-946887188 thanks for this, @dielhennr. I left some comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[jira] [Updated] (KAFKA-13373) ValueTransformerWithKeySupplier doesn't work with store()

[ https://issues.apache.org/jira/browse/KAFKA-13373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Victoria Xia updated KAFKA-13373: - Labels: newbie (was: ) > ValueTransformerWithKeySupplier doesn't work with store() > --

[jira] [Created] (KAFKA-13385) In the KRPC request header, translate null clientID to empty

Colin McCabe created KAFKA-13385: Summary: In the KRPC request header, translate null clientID to empty Key: KAFKA-13385 URL: https://issues.apache.org/jira/browse/KAFKA-13385 Project: Kafka

[GitHub] [kafka] YiDing-Duke commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

YiDing-Duke commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r732068187 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/OAuthBearerLoginCallbackHandler.java ## @@ -0,0 +1,188 @@ +/

[GitHub] [kafka] YiDing-Duke commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

YiDing-Duke commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r732068749 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/OAuthBearerLoginCallbackHandler.java ## @@ -0,0 +1,188 @@ +/

[GitHub] [kafka] vamossagar12 commented on pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

vamossagar12 commented on pull request #11211: URL: https://github.com/apache/kafka/pull/11211#issuecomment-946918369 Thanks Sophie for that. @showuon , I think your concern about persistent stores and custom stores is still valid. The reason why I don't want to add the getObservedStream

[GitHub] [kafka] vamossagar12 edited a comment on pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

vamossagar12 edited a comment on pull request #11211: URL: https://github.com/apache/kafka/pull/11211#issuecomment-946918369 Thanks Sophie for that. @showuon , I think your concern about persistent stores and custom stores is still valid. The reason why I don't want to add the getObserve

[GitHub] [kafka] hachikuji commented on a change in pull request #11410: MINOR: Make TestUtils usable for KRaft mode

hachikuji commented on a change in pull request #11410: URL: https://github.com/apache/kafka/pull/11410#discussion_r732060868 ## File path: core/src/test/scala/unit/kafka/utils/TestUtils.scala ## @@ -346,6 +367,97 @@ object TestUtils extends Logging { config.setProperty(

[jira] [Commented] (KAFKA-13373) ValueTransformerWithKeySupplier doesn't work with store()

[ https://issues.apache.org/jira/browse/KAFKA-13373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430650#comment-17430650 ] Matthias J. Sax commented on KAFKA-13373: - I did not look into it too deeply, bu

[GitHub] [kafka] cmccabe commented on a change in pull request #11410: MINOR: Make TestUtils usable for KRaft mode

cmccabe commented on a change in pull request #11410: URL: https://github.com/apache/kafka/pull/11410#discussion_r732087662 ## File path: core/src/test/scala/unit/kafka/utils/TestUtils.scala ## @@ -1220,37 +1348,42 @@ object TestUtils extends Logging { } } - - def ve

[GitHub] [kafka] YiDing-Duke commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

YiDing-Duke commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r732088424 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/OAuthBearerValidatorCallbackHandler.java ## @@ -0,0 +1,112 @

[GitHub] [kafka] YiDing-Duke commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

YiDing-Duke commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r732088812 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/OAuthBearerValidatorCallbackHandler.java ## @@ -0,0 +1,112 @

[GitHub] [kafka] cmccabe commented on a change in pull request #11410: MINOR: Make TestUtils usable for KRaft mode

cmccabe commented on a change in pull request #11410: URL: https://github.com/apache/kafka/pull/11410#discussion_r732089124 ## File path: core/src/test/scala/unit/kafka/utils/TestUtils.scala ## @@ -1640,6 +1800,37 @@ object TestUtils extends Logging { }, s"Timed out waitin

[GitHub] [kafka] cmccabe commented on a change in pull request #11410: MINOR: Make TestUtils usable for KRaft mode

cmccabe commented on a change in pull request #11410: URL: https://github.com/apache/kafka/pull/11410#discussion_r732090271 ## File path: core/src/test/scala/unit/kafka/utils/TestUtils.scala ## @@ -346,6 +367,97 @@ object TestUtils extends Logging { config.setProperty(Ka

[GitHub] [kafka] cmccabe commented on a change in pull request #11410: MINOR: Make TestUtils usable for KRaft mode

cmccabe commented on a change in pull request #11410: URL: https://github.com/apache/kafka/pull/11410#discussion_r732092038 ## File path: core/src/test/scala/unit/kafka/utils/TestUtils.scala ## @@ -346,6 +367,97 @@ object TestUtils extends Logging { config.setProperty(Ka

[GitHub] [kafka] YiDing-Duke commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

YiDing-Duke commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r732092804 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/OAuthBearerValidatorCallbackHandler.java ## @@ -0,0 +1,112 @

[GitHub] [kafka] dielhennr commented on a change in pull request #10772: KAFKA-12697: Add FencedBrokerCount and ActiveBrokerCount metrics to the QuorumController

dielhennr commented on a change in pull request #10772: URL: https://github.com/apache/kafka/pull/10772#discussion_r732112282 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumControllerMetrics.java ## @@ -26,28 +26,36 @@ import java.util.Objects; publ

[GitHub] [kafka] ableegoldman commented on a change in pull request #11411: MINOR: Clarify acceptable recovery lag config doc

ableegoldman commented on a change in pull request #11411: URL: https://github.com/apache/kafka/pull/11411#discussion_r732203571 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -329,8 +329,10 @@ /** {@code acceptable.recovery.lag} */

[GitHub] [kafka] ableegoldman commented on pull request #11411: MINOR: Clarify acceptable recovery lag config doc

ableegoldman commented on pull request #11411: URL: https://github.com/apache/kafka/pull/11411#issuecomment-947064999 Thanks for the update. I've had some users hit upon the same misunderstanding that I'm guessing sparked this -- This is an automated message from the Apache Git Service.

[GitHub] [kafka] ableegoldman commented on pull request #11405: KAFKA-12648: Wrap all exceptions thrown to handler as StreamsException & add TaskId field

ableegoldman commented on pull request #11405: URL: https://github.com/apache/kafka/pull/11405#issuecomment-947065671 All tests passed, but for two unrelated flaky test failures of: `kafka.admin.LeaderElectionCommandTest.[1] Type=Raft, Name=testTopicPartition, Security=PLAINTEXT` --

[GitHub] [kafka] C0urante commented on a change in pull request #10907: KAFKA-10000: Exactly-once support for source connectors (KIP-618)

C0urante commented on a change in pull request #10907: URL: https://github.com/apache/kafka/pull/10907#discussion_r732231269 ## File path: connect/api/src/main/java/org/apache/kafka/connect/source/SourceTaskContext.java ## @@ -38,4 +38,30 @@ * Get the OffsetStorageReader

[GitHub] [kafka] C0urante commented on a change in pull request #10907: KAFKA-10000: Exactly-once support for source connectors (KIP-618)

C0urante commented on a change in pull request #10907: URL: https://github.com/apache/kafka/pull/10907#discussion_r732231502 ## File path: connect/api/src/main/java/org/apache/kafka/connect/source/SourceConnector.java ## @@ -28,4 +30,31 @@ protected SourceConnectorContext

[GitHub] [kafka] C0urante commented on a change in pull request #10907: KAFKA-10000: Exactly-once support for source connectors (KIP-618)

C0urante commented on a change in pull request #10907: URL: https://github.com/apache/kafka/pull/10907#discussion_r732232701 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/storage/OffsetStorageWriter.java ## @@ -163,13 +181,24 @@ public synchronized boole

[GitHub] [kafka] C0urante commented on a change in pull request #10907: KAFKA-10000: Exactly-once support for source connectors (KIP-618)

C0urante commented on a change in pull request #10907: URL: https://github.com/apache/kafka/pull/10907#discussion_r73227 ## File path: connect/api/src/main/java/org/apache/kafka/connect/source/TransactionContext.java ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Softw

[GitHub] [kafka] vvcephei commented on pull request #11411: MINOR: Clarify acceptable recovery lag config doc

vvcephei commented on pull request #11411: URL: https://github.com/apache/kafka/pull/11411#issuecomment-947102353 Thanks, @ableegoldman ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [kafka] vvcephei commented on a change in pull request #11405: KAFKA-12648: Wrap all exceptions thrown to handler as StreamsException & add TaskId field

vvcephei commented on a change in pull request #11405: URL: https://github.com/apache/kafka/pull/11405#discussion_r732245277 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java ## @@ -2203,7 +2203,7 @@ public void shouldInitTask

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r732251460 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/HttpAccessTokenRetriever.java ## @@ -0,0 +1,325 @@ +/* + * Lice

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r732251460 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/HttpAccessTokenRetriever.java ## @@ -0,0 +1,325 @@ +/* + * Lice

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r732257932 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/HttpAccessTokenRetriever.java ## @@ -0,0 +1,325 @@ +/* + * Lice

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r732258128 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/Retry.java ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r732258376 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/OAuthBearerLoginCallbackHandler.java ## @@ -0,0 +1,188 @@ +/* +

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r732258641 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/OAuthBearerLoginCallbackHandler.java ## @@ -0,0 +1,188 @@ +/* +

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r732258747 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/OAuthBearerValidatorCallbackHandler.java ## @@ -0,0 +1,112 @@ +

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r732259126 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/OAuthBearerValidatorCallbackHandler.java ## @@ -0,0 +1,112 @@ +

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r732259427 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/OAuthBearerValidatorCallbackHandler.java ## @@ -0,0 +1,112 @@ +

[GitHub] [kafka] kirktrue commented on pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

kirktrue commented on pull request #11284: URL: https://github.com/apache/kafka/pull/11284#issuecomment-947122444 Thanks for the feedback, @YiDing-Duke! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] cmccabe commented on pull request #11410: MINOR: Make TestUtils usable for KRaft mode

cmccabe commented on pull request #11410: URL: https://github.com/apache/kafka/pull/11410#issuecomment-947161702 I reran `ConnectorRestartApiIntegrationTest` and didn't see a failure locally. Will commit -- This is an automated message from the Apache Git Service. To respond to the messa

[jira] [Comment Edited] (KAFKA-13289) Bulk processing correctly ordered input data through a join with kafka-streams results in `Skipping record for expired segment`

[ https://issues.apache.org/jira/browse/KAFKA-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430275#comment-17430275 ] Eugen Dück edited comment on KAFKA-13289 at 10/19/21, 10:47 PM: --

[GitHub] [kafka] cmccabe merged pull request #11410: MINOR: Make TestUtils usable for KRaft mode

cmccabe merged pull request #11410: URL: https://github.com/apache/kafka/pull/11410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[GitHub] [kafka] ableegoldman commented on a change in pull request #11405: KAFKA-12648: Wrap all exceptions thrown to handler as StreamsException & add TaskId field

ableegoldman commented on a change in pull request #11405: URL: https://github.com/apache/kafka/pull/11405#discussion_r732310453 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java ## @@ -2203,7 +2203,7 @@ public void shouldInit

[GitHub] [kafka] cmccabe opened a new pull request #11417: KAFKA-13340: Change ZooKeeperTestHarness to QuorumTestHarness

cmccabe opened a new pull request #11417: URL: https://github.com/apache/kafka/pull/11417 Change ZooKeeperTestHarness to QuorumTestHarness so that integration tests which inherit from this class can test both ZK and KRaft mode. Test cases which do this can specify the modes they support

[GitHub] [kafka] YiDing-Duke commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

YiDing-Duke commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r732339345 ## File path: clients/src/test/java/org/apache/kafka/common/security/oauthbearer/secured/AccessTokenValidatorFactoryTest.java ## @@ -0,0 +1,77 @@ +/*

[GitHub] [kafka] YiDing-Duke commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

YiDing-Duke commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r732341161 ## File path: clients/src/test/java/org/apache/kafka/common/security/oauthbearer/secured/AccessTokenValidatorFactoryTest.java ## @@ -0,0 +1,77 @@ +/*

[GitHub] [kafka] vamossagar12 edited a comment on pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

vamossagar12 edited a comment on pull request #11211: URL: https://github.com/apache/kafka/pull/11211#issuecomment-946918369 Thanks Sophie for that. @showuon , I think your concern about persistent stores and custom stores is still valid. The reason why I don't want to add the getObserve

[jira] [Created] (KAFKA-13386) Foreign Key Join filtering valid records after a code change / schema evolved

Sergio Duran Vegas created KAFKA-13386: -- Summary: Foreign Key Join filtering valid records after a code change / schema evolved Key: KAFKA-13386 URL: https://issues.apache.org/jira/browse/KAFKA-13386

[jira] [Updated] (KAFKA-13386) Foreign Key Join filtering out valid records after a code change / schema evolved

[ https://issues.apache.org/jira/browse/KAFKA-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergio Duran Vegas updated KAFKA-13386: --- Summary: Foreign Key Join filtering out valid records after a code change / schema e

[jira] [Updated] (KAFKA-13386) Foreign Key Join filtering out valid records after a code change / schema evolved

[ https://issues.apache.org/jira/browse/KAFKA-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergio Duran Vegas updated KAFKA-13386: --- Description: The join optimization assumes the serializer is deterministic and invar

[jira] [Commented] (KAFKA-12438) MirrorMaker 2: Not able to make it work for kerberized clusters ( bothe source and target are kerberized )

[ https://issues.apache.org/jira/browse/KAFKA-12438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430989#comment-17430989 ] felixzh commented on KAFKA-12438: - first, you need to learn kafka documention about Sec

[GitHub] [kafka] dajac merged pull request #11395: MINOR; Add a replication system test which simulates a slow replica

dajac merged pull request #11395: URL: https://github.com/apache/kafka/pull/11395 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] showuon commented on a change in pull request #11405: KAFKA-12648: Wrap all exceptions thrown to handler as StreamsException & add TaskId field

showuon commented on a change in pull request #11405: URL: https://github.com/apache/kafka/pull/11405#discussion_r732434973 ## File path: streams/src/main/java/org/apache/kafka/streams/errors/StreamsException.java ## @@ -25,15 +28,45 @@ private final static long serialV

[GitHub] [kafka] showuon commented on pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

showuon commented on pull request #11211: URL: https://github.com/apache/kafka/pull/11211#issuecomment-947381718 @vamossagar12 , I'm fine that we can merge the Persistent StateStores improvement first, and think about custom state store later. But I'm not the one have the right to merge yo