[GitHub] [kafka] vvcephei commented on a change in pull request #11405: KAFKA-12648: Wrap all exceptions thrown to handler as StreamsException & add TaskId field

[GitBox]

vvcephei commented on a change in pull request #11405:
URL: https://github.com/apache/kafka/pull/11405#discussion_r732245277



##########
File path: 
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java
##########
@@ -2203,7 +2203,7 @@ public void shouldInitTaskTimeoutAndEventuallyThrow() {
         task.maybeInitTaskTimeoutOrThrow(Duration.ofMinutes(5).toMillis(), 
null);
 
         assertThrows(
-            TimeoutException.class,
+            StreamsException.class,

Review comment:
       Up to you, but if it's semantically important for this to wrap a 
TimeoutException, then maybe we should assert the cause is TimeoutException.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org