showuon commented on a change in pull request #11211:
URL: https://github.com/apache/kafka/pull/11211#discussion_r730618511
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredSessionStore.java
##
@@ -239,9 +254,31 @@ public V fetchSession(final
[
https://issues.apache.org/jira/browse/KAFKA-12606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-12606:
-
Assignee: Luke Chen
> Some improvements for produce record validation
> ---
[
https://issues.apache.org/jira/browse/KAFKA-12473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429853#comment-17429853
]
David Jacot commented on KAFKA-12473:
-
[~showuon] [~ableegoldman] I am triaging the
[
https://issues.apache.org/jira/browse/KAFKA-10733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429856#comment-17429856
]
David Jacot commented on KAFKA-10733:
-
[~bchen225242] Do we plan to get this on in 3
[
https://issues.apache.org/jira/browse/KAFKA-7632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429860#comment-17429860
]
David Jacot commented on KAFKA-7632:
[~dongjin] Why do we consider this issue as a bl
[
https://issues.apache.org/jira/browse/KAFKA-12473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429861#comment-17429861
]
Luke Chen commented on KAFKA-12473:
---
[~ableegoldman], I think we should remove the tar
mimaison merged pull request #11394:
URL: https://github.com/apache/kafka/pull/11394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr
[
https://issues.apache.org/jira/browse/KAFKA-13284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison resolved KAFKA-13284.
Resolution: Fixed
> Use sftp protocol in release.py to upload release candidate artifacts
mimaison merged pull request #11407:
URL: https://github.com/apache/kafka/pull/11407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr
mimaison commented on pull request #11377:
URL: https://github.com/apache/kafka/pull/11377#issuecomment-945495489
Thanks for the PR but it looks like this has already been fixed in
https://github.com/apache/kafka/pull/11397
--
This is an automated message from the Apache Git Service.
To
mimaison commented on pull request #11322:
URL: https://github.com/apache/kafka/pull/11322#issuecomment-945507100
Thanks @msillence for this PR.
As this is adding a new SMT, you need to submit a
[KIP](https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals).
mimaison commented on pull request #11277:
URL: https://github.com/apache/kafka/pull/11277#issuecomment-945527467
Thanks @mjaschob-twilio for the PR.
As this is adding new configurations and interfaces, this requires a
[KIP](https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Imp
mimaison merged pull request #11282:
URL: https://github.com/apache/kafka/pull/11282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr
mimaison merged pull request #11298:
URL: https://github.com/apache/kafka/pull/11298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr
showuon commented on a change in pull request #11404:
URL: https://github.com/apache/kafka/pull/11404#discussion_r730742444
##
File path: docs/streams/developer-guide/config-streams.html
##
@@ -1025,12 +1034,19 @@ acksreplication.factor
See the descript
showuon commented on a change in pull request #11403:
URL: https://github.com/apache/kafka/pull/11403#discussion_r730753939
##
File path: clients/src/main/java/org/apache/kafka/common/TopicIdPartition.java
##
@@ -47,7 +58,7 @@ public Uuid topicId() {
}
/**
- * @
vamossagar12 commented on pull request #11211:
URL: https://github.com/apache/kafka/pull/11211#issuecomment-945605092
1) That's correct @showuon, the `wrapped().persistent()` may not apply to
custom in-memory stores. The only reason that check's there is that the
InMemoryStateStore already
showuon commented on a change in pull request #11393:
URL: https://github.com/apache/kafka/pull/11393#discussion_r730765761
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/DescribeUserScramCredentialsRequest.java
##
@@ -66,8 +66,15 @@ public DescribeUserSc
astubbs commented on a change in pull request #11404:
URL: https://github.com/apache/kafka/pull/11404#discussion_r730827598
##
File path: docs/streams/developer-guide/config-streams.html
##
@@ -680,14 +680,18 @@ default.windowed.value.serde.innerState section.
+
+
astubbs commented on pull request #11404:
URL: https://github.com/apache/kafka/pull/11404#issuecomment-945675007
Only other suggestion would be to actually reference / mention the section
for resiliency at the top of the page? So that people know it exists. People
don't typically read an e
showuon commented on pull request #11242:
URL: https://github.com/apache/kafka/pull/11242#issuecomment-945709251
@mjsax @vvcephei , please take a look when available and let us know your
thoughts. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the m
[
https://issues.apache.org/jira/browse/KAFKA-13374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-13374:
-
Assignee: Luke Chen
> [Docs] - All reads from the leader of the partition even after KIP-392?
>
showuon opened a new pull request #11408:
URL: https://github.com/apache/kafka/pull/11408
After KIP-392, we allow consumers to fetch data from leader or followers.
Update the doc.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [
showuon commented on pull request #11408:
URL: https://github.com/apache/kafka/pull/11408#issuecomment-945725487
@mumrah @hachikuji , please take a look at the 1 line change PR. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
[
https://issues.apache.org/jira/browse/KAFKA-13372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen resolved KAFKA-13372.
---
Resolution: Resolved
> failed authentication due to: SSL handshake failed
>
[
https://issues.apache.org/jira/browse/KAFKA-13370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-13370:
-
Assignee: Luke Chen
> Offset commit failure percentage metric is not computed correctly (regres
patrickstuedi commented on a change in pull request #11406:
URL: https://github.com/apache/kafka/pull/11406#discussion_r730851673
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -40,64 +71,41 @@
import org.apache.kafka.common.utils.LogConte
Igor Soarez created KAFKA-13382:
---
Summary: Automatic storage formatting
Key: KAFKA-13382
URL: https://issues.apache.org/jira/browse/KAFKA-13382
Project: Kafka
Issue Type: Improvement
viktorsomogyi opened a new pull request #11409:
URL: https://github.com/apache/kafka/pull/11409
Jacoco plugin in our CI fails because LeaderChangeBatch is present
in both the main and test sources so this commit renames it to
TestLeaderChangeBatch.
### Committer Checklist (exclu
C0urante commented on a change in pull request #10907:
URL: https://github.com/apache/kafka/pull/10907#discussion_r730964164
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedConfig.java
##
@@ -192,6 +198,19 @@
public stat
viktorsomogyi commented on pull request #11409:
URL: https://github.com/apache/kafka/pull/11409#issuecomment-945814292
The exception that failed our CI for reference:
```
03:27:58 [JaCoCo plugin] Loading inclusions files..
03:27:58 [JaCoCo plugin] inclusions: [**/*.class]
03:27:5
vvcephei commented on a change in pull request #11356:
URL: https://github.com/apache/kafka/pull/11356#discussion_r730987030
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java
##
@@ -200,11 +217,11 @@ private void emitNonJoin
[
https://issues.apache.org/jira/browse/KAFKA-7632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430082#comment-17430082
]
Dongjin Lee commented on KAFKA-7632:
[~dajac] Agree. It seems like it was mistakenly
[
https://issues.apache.org/jira/browse/KAFKA-12473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-12473:
---
Fix Version/s: (was: 3.1.0)
> Make the "cooperative-sticky, range" as th
[
https://issues.apache.org/jira/browse/KAFKA-12477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-12477:
---
Fix Version/s: (was: 3.1.0)
> Smart rebalancing with dynamic protocol se
vvcephei opened a new pull request #11411:
URL: https://github.com/apache/kafka/pull/11411
Clarify a misleading config description.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
-
vvcephei commented on a change in pull request #11405:
URL: https://github.com/apache/kafka/pull/11405#discussion_r731235333
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractTask.java
##
@@ -168,11 +167,15 @@ public void maybeInitTaskTim
ableegoldman commented on pull request #11381:
URL: https://github.com/apache/kafka/pull/11381#issuecomment-946108493
Closing in favor of https://github.com/apache/kafka/pull/11405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
ableegoldman closed pull request #11381:
URL: https://github.com/apache/kafka/pull/11381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsu
vvcephei commented on a change in pull request #11405:
URL: https://github.com/apache/kafka/pull/11405#discussion_r731269776
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractTask.java
##
@@ -168,11 +167,15 @@ public void maybeInitTaskTim
vvcephei commented on pull request #11356:
URL: https://github.com/apache/kafka/pull/11356#issuecomment-946141243
Test failure was unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ableegoldman commented on pull request #11211:
URL: https://github.com/apache/kafka/pull/11211#issuecomment-946147359
Yeah, any change to the public interface is going to require a KIP. And tbh
the state store interface is already messy enough, I think we should try to
avoid adding anythin
vvcephei merged pull request #11356:
URL: https://github.com/apache/kafka/pull/11356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr
[
https://issues.apache.org/jira/browse/KAFKA-12473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430218#comment-17430218
]
A. Sophie Blee-Goldman commented on KAFKA-12473:
Yeah, that's been put o
vvcephei commented on a change in pull request #11406:
URL: https://github.com/apache/kafka/pull/11406#discussion_r731303102
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -40,64 +71,41 @@
import org.apache.kafka.common.utils.LogContext;
vvcephei commented on a change in pull request #11406:
URL: https://github.com/apache/kafka/pull/11406#discussion_r731304471
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -1715,4 +1723,93 @@ protected void processStreamThread(final
Consum
vvcephei commented on a change in pull request #11406:
URL: https://github.com/apache/kafka/pull/11406#discussion_r731304826
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/StateStore.java
##
@@ -119,4 +122,8 @@ default void init(final StateStoreContext
vvcephei commented on a change in pull request #11406:
URL: https://github.com/apache/kafka/pull/11406#discussion_r731305800
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java
##
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Sof
vvcephei commented on a change in pull request #11406:
URL: https://github.com/apache/kafka/pull/11406#discussion_r731306180
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryKeyValueStore.java
##
@@ -72,6 +74,11 @@ public boolean isOpen() {
vvcephei commented on a change in pull request #11406:
URL: https://github.com/apache/kafka/pull/11406#discussion_r731306798
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryKeyValueStore.java
##
@@ -72,6 +74,11 @@ public boolean isOpen() {
C0urante commented on a change in pull request #11369:
URL: https://github.com/apache/kafka/pull/11369#discussion_r718557792
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SinkConnectorConfig.java
##
@@ -70,60 +73,105 @@
"keys, all er
ableegoldman commented on pull request #11405:
URL: https://github.com/apache/kafka/pull/11405#issuecomment-946191903
FYI this is now fully ready for review -- cc @vvcephei @guozhangwang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
[
https://issues.apache.org/jira/browse/KAFKA-13381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-13381:
Description:
KIP-783:
[https://cwiki.apache.org/confluence/display/KAFKA/KIP-783%3A+Add+T
[
https://issues.apache.org/jira/browse/KAFKA-13381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-13381:
Labels: kip (was: needs-kip)
> Wrap all uncaught exceptions as StreamsException with Task
jeqo opened a new pull request #11412:
URL: https://github.com/apache/kafka/pull/11412
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing st
NEERAJ VAIDYA created KAFKA-13383:
-
Summary: Consumer Group partition management across clusters
(Active-Active)
Key: KAFKA-13383
URL: https://issues.apache.org/jira/browse/KAFKA-13383
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430275#comment-17430275
]
Eugen Dück commented on KAFKA-13289:
We are running into similar issues:
* lots of
[
https://issues.apache.org/jira/browse/KAFKA-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430275#comment-17430275
]
Eugen Dück edited comment on KAFKA-13289 at 10/19/21, 4:51 AM:
---
YiDing-Duke commented on a change in pull request #11284:
URL: https://github.com/apache/kafka/pull/11284#discussion_r731496881
##
File path:
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/HttpAccessTokenRetriever.java
##
@@ -0,0 +1,325 @@
+/*
+ * L
YiDing-Duke commented on a change in pull request #11284:
URL: https://github.com/apache/kafka/pull/11284#discussion_r731507827
##
File path:
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/HttpAccessTokenRetriever.java
##
@@ -0,0 +1,325 @@
+/*
+ * L
YiDing-Duke commented on a change in pull request #11284:
URL: https://github.com/apache/kafka/pull/11284#discussion_r731524967
##
File path:
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/Retry.java
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apac
[
https://issues.apache.org/jira/browse/KAFKA-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430275#comment-17430275
]
Eugen Dück edited comment on KAFKA-13289 at 10/19/21, 6:33 AM:
---
[
https://issues.apache.org/jira/browse/KAFKA-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430335#comment-17430335
]
Aditya Upadhyaya commented on KAFKA-12559:
--
[~ableegoldman] I'd like to pick u
63 matches
Mail list logo
