vamossagar12 commented on pull request #11211: URL: https://github.com/apache/kafka/pull/11211#issuecomment-945605092
1) That's correct @showuon, the `wrapped().persistent()` may not apply to custom in-memory stores. The only reason that check's there is that the InMemoryStateStore already does filtering, so I didn't want to include that as part of this change. 2) From my knowledge, any new public interface addition needs a KIP. Since this is going to be an internal interface, I didn't think we need a KIP. Infact, I think, if I were to add it to `WindowStore` or `SessionStore` then I believe we would need a KIP and I didn't do it for that reason. What do you think? Maybe @ableegoldman can also chime in on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
