showuon commented on a change in pull request #11362:
URL: https://github.com/apache/kafka/pull/11362#discussion_r719115383
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java
##
@@ -735,7 +735,6 @@ public void
shouldCommitNon
showuon commented on pull request #11234:
URL: https://github.com/apache/kafka/pull/11234#issuecomment-930892210
@patrickstuedi @vvcephei @guozhangwang , please help review the PR for
session store part. Thank you.
--
This is an automated message from the Apache Git Service.
To respond t
kowshik commented on a change in pull request #11345:
URL: https://github.com/apache/kafka/pull/11345#discussion_r719132048
##
File path: core/src/main/scala/kafka/log/LogSegment.scala
##
@@ -77,8 +77,9 @@ class LogSegment private[log] (val log: FileRecords,
timeIndex.resi
showuon opened a new pull request #11370:
URL: https://github.com/apache/kafka/pull/11370
In https://github.com/apache/kafka/pull/7212, we reverted the change to use
`TreeMap` instead of `ConcurrentSkipListMap`, but we forgot to remove the
`size` computing codes.
Also, I found the `
showuon commented on pull request #11370:
URL: https://github.com/apache/kafka/pull/11370#issuecomment-930998456
@mjsax @ableegoldman @guozhangwang , please help review this small PR.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
satishd commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r719224916
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java
##
@@ -39,6 +41,7 @@
satishd commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r719225490
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataSnapshotFile.java
##
@@ -0,0 +1,252 @@
+/*
+ * L
satishd commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r719224916
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java
##
@@ -39,6 +41,7 @@
satishd commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r719226435
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataSnapshotFile.java
##
@@ -0,0 +1,239 @@
+/*
+ * L
showuon commented on a change in pull request #11211:
URL: https://github.com/apache/kafka/pull/11211#discussion_r719264146
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/WindowedKeyValueIterator.java
##
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Ap
showuon commented on a change in pull request #11211:
URL: https://github.com/apache/kafka/pull/11211#discussion_r719265099
##
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBSessionStoreTest.java
##
@@ -60,7 +103,8 @@ public void shouldRemoveE
satishd commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r719282244
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java
##
@@ -85,32 +90,78 @@
// Map of remote lo
satishd commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r719295072
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java
##
@@ -120,6 +171,37 @@ public void run() {
[
https://issues.apache.org/jira/browse/KAFKA-13334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Udaya Kumar updated KAFKA-13334:
Priority: Blocker (was: Critical)
> ERROR Failed to clean up log for __consumer_offsets
> ---
vvcephei commented on pull request #11315:
URL: https://github.com/apache/kafka/pull/11315#issuecomment-931374193
Actually, I just looked at the results, and I don't think I'll bother
re-triggering the tests. None of those are possibly related:
Test Name | Duration | Age
-- | -- |
satishd commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r719511498
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java
##
@@ -161,77 +161,73 @@ public void
satishd commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r719512519
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java
##
@@ -240,6 +323,11 @@ public void close() {
satishd commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r719512519
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java
##
@@ -240,6 +323,11 @@ public void close() {
satishd commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r719295072
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java
##
@@ -120,6 +171,37 @@ public void run() {
satishd commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r719516930
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogSegmentMetadataSnapshot.java
##
@@ -0,0 +1,201 @@
+/*
+
satishd commented on pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#issuecomment-931422554
Thanks @junrao for the review. Addressed them with the replies and with the
latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the mess
Tamás Héri created KAFKA-13337:
--
Summary: Scanning for Connect plugins can fail with
AccessDeniedException
Key: KAFKA-13337
URL: https://issues.apache.org/jira/browse/KAFKA-13337
Project: Kafka
heritamas opened a new pull request #11371:
URL: https://github.com/apache/kafka/pull/11371
…nect plugin directory scan
org.apache.kafka.connect.runtime.isolation.PluginUtils.pluginUrls scans a
path and collects plugin candidates from there. However, if a directory is not
readable,
junrao commented on a change in pull request #11345:
URL: https://github.com/apache/kafka/pull/11345#discussion_r719567378
##
File path: core/src/main/scala/kafka/log/LogSegment.scala
##
@@ -77,8 +77,9 @@ class LogSegment private[log] (val log: FileRecords,
timeIndex.resiz
vvcephei merged pull request #11315:
URL: https://github.com/apache/kafka/pull/11315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr
vvcephei commented on pull request #11315:
URL: https://github.com/apache/kafka/pull/11315#issuecomment-931487033
I ran the tests locally and got a pass: `./gradlew clean :streams:testAll`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
guozhangwang opened a new pull request #11372:
URL: https://github.com/apache/kafka/pull/11372
We forbid sending produce request before adding partitions in the txn in the
following way:
* In `Sender#runOnce`, we would not continue to `sendProducerData` as long
as `maybeSendAndPollT
guozhangwang commented on pull request #11372:
URL: https://github.com/apache/kafka/pull/11372#issuecomment-931536992
If this is indeed an issue, then I think the simple fix should be changing
the `hasFatalError` to `hasError`.
--
This is an automated message from the Apache Git Service.
guozhangwang commented on pull request #11283:
URL: https://github.com/apache/kafka/pull/11283#issuecomment-931541107
SG, will cherry-pick.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
guozhangwang commented on pull request #11372:
URL: https://github.com/apache/kafka/pull/11372#issuecomment-931541497
cc @hachikuji @dajac WDYT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
[
https://issues.apache.org/jira/browse/KAFKA-13249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-13249:
--
Fix Version/s: (was: 3.1.0)
> Checkpoints do not contain latest offsets on shutdown when u
[
https://issues.apache.org/jira/browse/KAFKA-13249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-13249:
--
Fix Version/s: 3.0.0
> Checkpoints do not contain latest offsets on shutdown when using EOS
>
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r719649068
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -870,12 +868,14 @@ class KafkaApis(val requestChannel: RequestChannel,
//
[
https://issues.apache.org/jira/browse/KAFKA-13164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422961#comment-17422961
]
Guozhang Wang commented on KAFKA-13164:
---
Adding some thoughts here:
1. With topol
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r719668223
##
File path: core/src/main/scala/kafka/server/FetchSession.scala
##
@@ -378,53 +378,47 @@ class SessionlessFetchContext(val fetchData:
util.Map[TopicPar
kowshik commented on a change in pull request #11345:
URL: https://github.com/apache/kafka/pull/11345#discussion_r719669247
##
File path: core/src/main/scala/kafka/log/LogSegment.scala
##
@@ -77,8 +77,9 @@ class LogSegment private[log] (val log: FileRecords,
timeIndex.resi
junrao commented on a change in pull request #11345:
URL: https://github.com/apache/kafka/pull/11345#discussion_r719672498
##
File path: core/src/main/scala/kafka/log/LogSegment.scala
##
@@ -77,8 +77,9 @@ class LogSegment private[log] (val log: FileRecords,
timeIndex.resiz
guozhangwang commented on a change in pull request #11367:
URL: https://github.com/apache/kafka/pull/11367#discussion_r718905933
##
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/ListValueStoreTest.java
##
@@ -136,8 +138,9 @@ public void shouldGetAll
ccding commented on a change in pull request #11345:
URL: https://github.com/apache/kafka/pull/11345#discussion_r719690581
##
File path: core/src/main/scala/kafka/log/LogSegment.scala
##
@@ -77,8 +77,9 @@ class LogSegment private[log] (val log: FileRecords,
timeIndex.resiz
junrao commented on a change in pull request #11345:
URL: https://github.com/apache/kafka/pull/11345#discussion_r719715401
##
File path: core/src/main/scala/kafka/log/LogSegment.scala
##
@@ -77,8 +77,9 @@ class LogSegment private[log] (val log: FileRecords,
timeIndex.resiz
ijuma merged pull request #11359:
URL: https://github.com/apache/kafka/pull/11359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...
kowshik commented on a change in pull request #11345:
URL: https://github.com/apache/kafka/pull/11345#discussion_r71977
##
File path: core/src/main/scala/kafka/log/LogSegment.scala
##
@@ -77,8 +77,9 @@ class LogSegment private[log] (val log: FileRecords,
timeIndex.resi
kowshik commented on a change in pull request #11345:
URL: https://github.com/apache/kafka/pull/11345#discussion_r71977
##
File path: core/src/main/scala/kafka/log/LogSegment.scala
##
@@ -77,8 +77,9 @@ class LogSegment private[log] (val log: FileRecords,
timeIndex.resi
ccding commented on a change in pull request #11345:
URL: https://github.com/apache/kafka/pull/11345#discussion_r719741487
##
File path: core/src/main/scala/kafka/log/LogSegment.scala
##
@@ -77,8 +77,9 @@ class LogSegment private[log] (val log: FileRecords,
timeIndex.resiz
C0urante commented on pull request #10907:
URL: https://github.com/apache/kafka/pull/10907#issuecomment-931698206
Resolved merge conflicts. Will try to address review comments soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
kowshik commented on a change in pull request #11345:
URL: https://github.com/apache/kafka/pull/11345#discussion_r719800036
##
File path: core/src/main/scala/kafka/log/LogSegment.scala
##
@@ -77,8 +77,9 @@ class LogSegment private[log] (val log: FileRecords,
timeIndex.resi
gharris1727 commented on a change in pull request #11369:
URL: https://github.com/apache/kafka/pull/11369#discussion_r719774645
##
File path: clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java
##
@@ -1116,11 +1119,79 @@ public void ensureValid(String name, Obje
junrao commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r719825981
##
File path:
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerRestartTest.java
##
@@ -0,0 +1,1
junrao commented on a change in pull request #11345:
URL: https://github.com/apache/kafka/pull/11345#discussion_r719837715
##
File path: core/src/main/scala/kafka/log/LogSegment.scala
##
@@ -77,8 +77,9 @@ class LogSegment private[log] (val log: FileRecords,
timeIndex.resiz
kowshik commented on a change in pull request #11345:
URL: https://github.com/apache/kafka/pull/11345#discussion_r719860600
##
File path: core/src/main/scala/kafka/log/LogSegment.scala
##
@@ -77,8 +77,9 @@ class LogSegment private[log] (val log: FileRecords,
timeIndex.resi
ccding commented on a change in pull request #11345:
URL: https://github.com/apache/kafka/pull/11345#discussion_r719866902
##
File path: core/src/main/scala/kafka/log/LogSegment.scala
##
@@ -77,8 +77,9 @@ class LogSegment private[log] (val log: FileRecords,
timeIndex.resiz
RivenSun2 commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r719888357
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -1016,6 +1018,9 @@ public boolean commit
RivenSun2 commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r719890048
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -1069,6 +1075,37 @@ private void maybeAu
[
https://issues.apache.org/jira/browse/KAFKA-13336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423072#comment-17423072
]
Guozhang Wang commented on KAFKA-13336:
---
[~ableegoldman] Thanks for the proposal!
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-931848494
@showuon thanks for your review, i commit new change codes.
The test of code changes, I passed the end-to-end test, the consumer is
running normally, and the bug has been r
satishd commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r719940964
##
File path:
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataSnapshotFileTest.java
##
@@ -0,0 +1,82 @@
+/*
+
satishd commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r719950502
##
File path:
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerRestartTest.java
##
@@ -0,0 +1,
satishd commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r719951352
##
File path:
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerRestartTest.java
##
@@ -0,0 +1,
satishd commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r719960058
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java
##
@@ -82,44 +87,148 @@
// User topic part
59 matches
Mail list logo