satishd commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r719282244



##########
File path: 
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java
##########
@@ -85,32 +90,78 @@
     // Map of remote log metadata topic partition to consumed offsets.
     private final Map<Integer, Long> partitionToConsumedOffsets = new 
ConcurrentHashMap<>();
 
+    private Map<Integer, Long> committedPartitionToConsumedOffsets = 
Collections.emptyMap();

Review comment:
       This logic is slightly changed in the latest commit for easy to reason 
about. Below are the updated maps to track. 
   
   ```
       // Map of remote log metadata topic partition to consumed offsets. 
Received consumer records
       // may or may not have been processed based on the assigned topic 
partitions.
       private final Map<Integer, Long> partitionToConsumedOffsets = new 
ConcurrentHashMap<>();
   
       // Map of remote log metadata topic partition to processed offsets. 
Received consumer record is
       // processed as the remote log metadata record's topic partition exists 
in assigned topic partitions.
       private final Map<Integer, Long> partitionToProcessedOffsets = new 
ConcurrentHashMap<>();
   
       // Map of remote log metadata topic partition to processed offsets that 
were synced in committedOffsetsFile.
       private Map<Integer, Long> lastSyncedPartitionToConsumedOffsets = 
Collections.emptyMap();
   ``` 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to