showuon commented on a change in pull request #11227:
URL: https://github.com/apache/kafka/pull/11227#discussion_r713675491
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/RangeQueryForWindowStoreIntegrationTest.java
##
@@ -0,0 +1,338 @@
+/*
+ * Licens
showuon commented on a change in pull request #11227:
URL: https://github.com/apache/kafka/pull/11227#discussion_r713675956
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryWindowStore.java
##
@@ -462,14 +460,34 @@ public boolean hasNext() {
showuon commented on a change in pull request #11347:
URL: https://github.com/apache/kafka/pull/11347#discussion_r713720965
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -351,6 +351,17 @@ public GroupAssign
showuon commented on a change in pull request #11347:
URL: https://github.com/apache/kafka/pull/11347#discussion_r713720965
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -351,6 +351,17 @@ public GroupAssign
showuon commented on a change in pull request #11347:
URL: https://github.com/apache/kafka/pull/11347#discussion_r713725768
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -351,6 +351,17 @@ public GroupAssign
showuon commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r713737164
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -66,15 +66,7 @@
import org.slf4j.Logger;
RivenSun2 commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r713793616
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -66,15 +66,7 @@
import org.slf4j.Logger
RivenSun2 commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r713800603
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -505,7 +497,7 @@ public boolean poll(Tim
RivenSun2 commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r713805122
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -670,10 +662,11 @@ private void validate
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-924798121
Thanks for your review @showuon
I will re-commit code later. Hope you can continue to give advice
--
This is an automated message from the Apache Git Service.
To respond
RivenSun2 commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r713805122
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -670,10 +662,11 @@ private void validate
RivenSun2 commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r713805122
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -670,10 +662,11 @@ private void validate
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-924807334
@showuon
The latest code changes have been committed, if you have time, please review
it.
Thanks.
--
This is an automated message from the Apache Git Service.
To resp
RivenSun2 commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r713843300
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -670,10 +662,11 @@ private void validate
RivenSun2 commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r713843300
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -670,10 +662,11 @@ private void validate
RivenSun2 commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r713843300
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -670,10 +662,11 @@ private void validate
[
https://issues.apache.org/jira/browse/KAFKA-13302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nikolay Izhikov resolved KAFKA-13302.
-
Resolution: Invalid
Sorry for any inconvinience. This issue should go to Ignite project.
RivenSun2 commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r713800603
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -505,7 +497,7 @@ public boolean poll(Tim
RivenSun2 commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r713800603
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -505,7 +497,7 @@ public boolean poll(Tim
dengziming commented on pull request #11339:
URL: https://github.com/apache/kafka/pull/11339#issuecomment-924890352
Hello, @cmccabe @mumrah PTAL. thank you 🤝.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
ijuma commented on pull request #11345:
URL: https://github.com/apache/kafka/pull/11345#issuecomment-924899752
@ccding the PR does have unit tests though, so we should update that part of
the PR message.
--
This is an automated message from the Apache Git Service.
To respond to the messa
[
https://issues.apache.org/jira/browse/KAFKA-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17418584#comment-17418584
]
Amar Bogari commented on KAFKA-7870:
We are running kafka 2.4.0 and see similar issue
dajac commented on a change in pull request #11170:
URL: https://github.com/apache/kafka/pull/11170#discussion_r713916798
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -1424,6 +1428,21 @@ class ReplicaManager(val config: KafkaConfig,
val f
[
https://issues.apache.org/jira/browse/KAFKA-13293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliot West updated KAFKA-13293:
Summary: Support client reload of JKS/PEM certificates (was: Support
client reload of PEM certifi
[
https://issues.apache.org/jira/browse/KAFKA-13293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliot West updated KAFKA-13293:
Description:
Producer/Consumer clients do not currently automatically reload certificates
when th
dengziming created KAFKA-13316:
--
Summary: Convert CreateTopicsRequestWithPolicyTest to use
ClusterTest
Key: KAFKA-13316
URL: https://issues.apache.org/jira/browse/KAFKA-13316
Project: Kafka
Iss
scholzj opened a new pull request #11352:
URL: https://github.com/apache/kafka/pull/11352
Following the discussion in confluentinc/kafka-images#102, it seems that the
`DirectoryConfigProvider` should be also listed in the list of the service
providers.
CC: @C0urante
### Commi
vijaykriishna edited a comment on pull request #10873:
URL: https://github.com/apache/kafka/pull/10873#issuecomment-922391928
@junrao Please review the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
ccding commented on pull request #11345:
URL: https://github.com/apache/kafka/pull/11345#issuecomment-924981747
Updated the Test section
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
vijaykriishna commented on pull request #10873:
URL: https://github.com/apache/kafka/pull/10873#issuecomment-924982174
@junrao Please review the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
vijaykriishna removed a comment on pull request #10873:
URL: https://github.com/apache/kafka/pull/10873#issuecomment-922391928
@junrao Please review the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
mprusakov opened a new pull request #11353:
URL: https://github.com/apache/kafka/pull/11353
Presently KafkaConsumer creates an enourmous amount of garbage during a
poll. Polls are generaly very frequent and so allocations during a poll
decrease efficiency of the overall solution. This comm
priya Vijay created KAFKA-13317:
---
Summary: Kafka brokers can't communicate with each other, reports
Error sending fetch request , java.io.IOException: Connection to 2 was
disconnected before the response was read
Key: KAFKA-13317
ccding commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r708590530
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/CommittedOffsetsFile.java
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to
ijuma commented on a change in pull request #11351:
URL: https://github.com/apache/kafka/pull/11351#discussion_r714082956
##
File path: core/src/main/scala/kafka/server/BrokerServer.scala
##
@@ -499,12 +499,13 @@ class BrokerServer(
if (clientToControllerChannelManager !
guozhangwang merged pull request #11227:
URL: https://github.com/apache/kafka/pull/11227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsu
guozhangwang commented on pull request #11227:
URL: https://github.com/apache/kafka/pull/11227#issuecomment-925079657
LGTM! Merged to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
Colin McCabe created KAFKA-13318:
Summary: Add jmh benchmarks for MetadataCache#topicNamesToIds
Key: KAFKA-13318
URL: https://issues.apache.org/jira/browse/KAFKA-13318
Project: Kafka
Issue Ty
cmccabe commented on pull request #11311:
URL: https://github.com/apache/kafka/pull/11311#issuecomment-925086878
I filed https://issues.apache.org/jira/browse/KAFKA-13318 to create JMH
benchmarks for this and other cache operations. For now, I think we should
commit this to fix the O(N) be
[
https://issues.apache.org/jira/browse/KAFKA-13239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17418705#comment-17418705
]
Guozhang Wang commented on KAFKA-13239:
---
{quote} What does this mean/how do memtab
ccding commented on a change in pull request #11351:
URL: https://github.com/apache/kafka/pull/11351#discussion_r714121176
##
File path: core/src/main/scala/kafka/server/BrokerServer.scala
##
@@ -499,12 +499,13 @@ class BrokerServer(
if (clientToControllerChannelManager
[
https://issues.apache.org/jira/browse/KAFKA-13239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17418705#comment-17418705
]
Guozhang Wang edited comment on KAFKA-13239 at 9/22/21, 4:39 PM:
-
jolshan commented on a change in pull request #11170:
URL: https://github.com/apache/kafka/pull/11170#discussion_r714133543
##
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##
@@ -491,6 +491,21 @@ abstract class AbstractFetcherThread(name: String,
jolshan commented on a change in pull request #11170:
URL: https://github.com/apache/kafka/pull/11170#discussion_r714134701
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -1424,6 +1428,21 @@ class ReplicaManager(val config: KafkaConfig,
val
jolshan commented on a change in pull request #11170:
URL: https://github.com/apache/kafka/pull/11170#discussion_r714140053
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -1739,6 +1758,37 @@ class ReplicaManager(val config: KafkaConfig,
partition
jolshan commented on a change in pull request #11170:
URL: https://github.com/apache/kafka/pull/11170#discussion_r714152192
##
File path:
core/src/test/scala/unit/kafka/server/AbstractFetcherManagerTest.scala
##
@@ -133,4 +137,75 @@ class AbstractFetcherManagerTest {
asse
jolshan commented on a change in pull request #11170:
URL: https://github.com/apache/kafka/pull/11170#discussion_r714153185
##
File path:
core/src/test/scala/unit/kafka/server/AbstractFetcherManagerTest.scala
##
@@ -133,4 +137,75 @@ class AbstractFetcherManagerTest {
asse
ccding closed pull request #11269:
URL: https://github.com/apache/kafka/pull/11269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr..
ccding closed pull request #11270:
URL: https://github.com/apache/kafka/pull/11270
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr..
jolshan commented on a change in pull request #11170:
URL: https://github.com/apache/kafka/pull/11170#discussion_r714195204
##
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##
@@ -491,6 +491,21 @@ abstract class AbstractFetcherThread(name: String,
junrao commented on a change in pull request #11351:
URL: https://github.com/apache/kafka/pull/11351#discussion_r714188175
##
File path: core/src/main/scala/kafka/server/BrokerServer.scala
##
@@ -482,6 +482,20 @@ class BrokerServer(
}
metadataSnapshotter.foreach(s
junrao commented on a change in pull request #11351:
URL: https://github.com/apache/kafka/pull/11351#discussion_r714188175
##
File path: core/src/main/scala/kafka/server/BrokerServer.scala
##
@@ -482,6 +482,20 @@ class BrokerServer(
}
metadataSnapshotter.foreach(s
junrao commented on a change in pull request #11351:
URL: https://github.com/apache/kafka/pull/11351#discussion_r714186270
##
File path: core/src/main/scala/kafka/utils/KafkaScheduler.scala
##
@@ -107,7 +107,10 @@ class KafkaScheduler(val threads: Int,
debug("Scheduling ta
junrao commented on pull request #11351:
URL: https://github.com/apache/kafka/pull/11351#issuecomment-925172265
@ccding : For the side effect that you mentioned, a segment to be renamed to
.delete, but won't be physically deleted. This seems fine since on broker
restart, we have the logic
ccding commented on a change in pull request #11351:
URL: https://github.com/apache/kafka/pull/11351#discussion_r714216176
##
File path: core/src/main/scala/kafka/server/BrokerServer.scala
##
@@ -499,12 +499,13 @@ class BrokerServer(
if (clientToControllerChannelManager
ccding commented on pull request #11351:
URL: https://github.com/apache/kafka/pull/11351#issuecomment-925201730
@junrao for the side effect, I am mainly saying
```
sortedNewSegments.foreach(_.changeFileSuffixes(SwapFileSuffix, ""))
```
will execute. #10763 mainly targets the cas
ccding edited a comment on pull request #11351:
URL: https://github.com/apache/kafka/pull/11351#issuecomment-925201730
@junrao for the side effect, I am saying
```
sortedNewSegments.foreach(_.changeFileSuffixes(SwapFileSuffix, ""))
```
will execute. #10763 mainly targets the cas
vvcephei commented on a change in pull request #11315:
URL: https://github.com/apache/kafka/pull/11315#discussion_r714207540
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamAggregate.java
##
@@ -77,43 +83,51 @@ public void init(final
org.
ccding commented on pull request #11351:
URL: https://github.com/apache/kafka/pull/11351#issuecomment-925205714
Addressed all comments above. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jolshan commented on a change in pull request #11170:
URL: https://github.com/apache/kafka/pull/11170#discussion_r714226694
##
File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala
##
@@ -2810,4 +2811,132 @@ class ReplicaManagerTest {
Replicas.NON
vvcephei commented on a change in pull request #11336:
URL: https://github.com/apache/kafka/pull/11336#discussion_r714232901
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/api/ProcessorContext.java
##
@@ -247,4 +251,45 @@ Cancellable schedule(final Dura
jeqo commented on a change in pull request #11315:
URL: https://github.com/apache/kafka/pull/11315#discussion_r714236064
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSessionWindowAggregate.java
##
@@ -74,92 +79,118 @@ public void enable
vvcephei commented on a change in pull request #11336:
URL: https://github.com/apache/kafka/pull/11336#discussion_r714237174
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalProcessorContextImpl.java
##
@@ -110,6 +112,11 @@ public long cur
vvcephei commented on pull request #11336:
URL: https://github.com/apache/kafka/pull/11336#issuecomment-925238816
Thanks for taking a look @guozhangwang and @mjsax !
You're both right about the missing time methods. I'll just send an update
to that KIP and send a separate PR.
--
T
vvcephei commented on pull request #11316:
URL: https://github.com/apache/kafka/pull/11316#issuecomment-925249710
I just merged in trunk and re-ran `./gradlew clean :streams:testAll` and it
passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
vvcephei merged pull request #11316:
URL: https://github.com/apache/kafka/pull/11316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr
stephan-mohn commented on pull request #11254:
URL: https://github.com/apache/kafka/pull/11254#issuecomment-925266540
Aiven Inc - https://aiven.io/ is misusing of Apache Kafka trademark as
'Aiven Kafka' [1] and violates Apache trademarks. See - [1]
https://help.aiven.io/en/?q=%22aiven+kafk
stephan-mohn edited a comment on pull request #11254:
URL: https://github.com/apache/kafka/pull/11254#issuecomment-925266540
Aiven Inc - https://aiven.io/ is misusing of Apache Kafka trademark as
'Aiven Kafka' [1] and violates Apache trademarks. See - [1]
https://help.aiven.io/en/?q=%22aiv
stephan-mohn edited a comment on pull request #11254:
URL: https://github.com/apache/kafka/pull/11254#issuecomment-925266540
Aiven Inc - https://aiven.io/ is misusing of Apache Kafka trademark as
'Aiven Kafka' [1] and violates Apache trademarks. See - [1]
https://help.aiven.io/en/?q=%22aiv
stephan-mohn edited a comment on pull request #11254:
URL: https://github.com/apache/kafka/pull/11254#issuecomment-925266540
Aiven Inc - https://aiven.io/ is misusing of Apache Kafka trademark as
'Aiven Kafka' [1] and violates Apache trademarks. See - [1]
https://help.aiven.io/en/?q=%22aiv
cmccabe merged pull request #11310:
URL: https://github.com/apache/kafka/pull/11310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr.
junrao commented on a change in pull request #11351:
URL: https://github.com/apache/kafka/pull/11351#discussion_r714283329
##
File path: core/src/main/scala/kafka/utils/KafkaScheduler.scala
##
@@ -53,7 +53,7 @@ trait Scheduler {
* @param unit The unit for the preceding time
jolshan commented on a change in pull request #11170:
URL: https://github.com/apache/kafka/pull/11170#discussion_r714299871
##
File path: core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala
##
@@ -929,6 +929,29 @@ class AbstractFetcherThreadTest {
fetcher
jolshan commented on a change in pull request #11170:
URL: https://github.com/apache/kafka/pull/11170#discussion_r714300664
##
File path: core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala
##
@@ -929,6 +929,29 @@ class AbstractFetcherThreadTest {
fetcher
jolshan commented on pull request #11170:
URL: https://github.com/apache/kafka/pull/11170#issuecomment-925320746
I was thinking a bit about this and the downgrade path and I realized that
we never remove the topic ID from the state. I think this is ok because a
downgrade will no longer use
junrao commented on a change in pull request #11327:
URL: https://github.com/apache/kafka/pull/11327#discussion_r714305801
##
File path: core/src/main/scala/kafka/log/LogCleanerManager.scala
##
@@ -512,6 +514,27 @@ private[log] class LogCleanerManager(val logDirs:
Seq[File],
ccding commented on pull request #11351:
URL: https://github.com/apache/kafka/pull/11351#issuecomment-925334750
I pushed twice with the two commits. It appears Jenkins is currently running
on the first commit, and the second one is pending. Unfortunately, I don't have
permission to stop it
[
https://issues.apache.org/jira/browse/KAFKA-13255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17418867#comment-17418867
]
Anamika Nadkarni commented on KAFKA-13255:
--
[~ryannedolan] How much time usuall
ijuma commented on a change in pull request #11351:
URL: https://github.com/apache/kafka/pull/11351#discussion_r714375625
##
File path: core/src/main/scala/kafka/utils/KafkaScheduler.scala
##
@@ -53,7 +53,7 @@ trait Scheduler {
* @param unit The unit for the preceding times
ccding commented on a change in pull request #11351:
URL: https://github.com/apache/kafka/pull/11351#discussion_r714377435
##
File path: core/src/main/scala/kafka/utils/KafkaScheduler.scala
##
@@ -53,7 +53,7 @@ trait Scheduler {
* @param unit The unit for the preceding time
hachikuji opened a new pull request #11354:
URL: https://github.com/apache/kafka/pull/11354
The `LastTimestamp` field is useful because its value is present even when
there are no data batches written by a given producerId.
### Committer Checklist (excluded from commit message)
-
ijuma commented on a change in pull request #11351:
URL: https://github.com/apache/kafka/pull/11351#discussion_r714391884
##
File path: core/src/main/scala/kafka/utils/KafkaScheduler.scala
##
@@ -53,7 +53,7 @@ trait Scheduler {
* @param unit The unit for the preceding times
Jason Gustafson created KAFKA-13319:
---
Summary: Do not send AddOffsetsToTxn/TxnOffsetCommit if offsets
map is empty
Key: KAFKA-13319
URL: https://issues.apache.org/jira/browse/KAFKA-13319
Project: Ka
kowshik commented on a change in pull request #11351:
URL: https://github.com/apache/kafka/pull/11351#discussion_r714401442
##
File path: core/src/main/scala/kafka/utils/KafkaScheduler.scala
##
@@ -103,11 +103,14 @@ class KafkaScheduler(val threads: Int,
schedule(name, fun
ccding commented on a change in pull request #11351:
URL: https://github.com/apache/kafka/pull/11351#discussion_r714410283
##
File path: core/src/main/scala/kafka/utils/KafkaScheduler.scala
##
@@ -103,11 +103,14 @@ class KafkaScheduler(val threads: Int,
schedule(name, fun,
[
https://issues.apache.org/jira/browse/KAFKA-13070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cong Ding reassigned KAFKA-13070:
-
Assignee: Cong Ding (was: Manasvi Gupta)
> LogManager shutdown races with periodic work schedu
ccding commented on pull request #11345:
URL: https://github.com/apache/kafka/pull/11345#issuecomment-925468033
@kowshik Thanks for the code review. Updated your email in the PR
description as well as in the commit message.
--
This is an automated message from the Apache Git Service.
To
ccding commented on a change in pull request #11351:
URL: https://github.com/apache/kafka/pull/11351#discussion_r714439705
##
File path: core/src/main/scala/kafka/utils/KafkaScheduler.scala
##
@@ -53,7 +53,7 @@ trait Scheduler {
* @param unit The unit for the preceding time
[
https://issues.apache.org/jira/browse/KAFKA-13070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17418918#comment-17418918
]
Cong Ding commented on KAFKA-13070:
---
I created a PR for this: https://github.com/apach
ijuma commented on a change in pull request #11351:
URL: https://github.com/apache/kafka/pull/11351#discussion_r714467779
##
File path: core/src/main/scala/kafka/utils/KafkaScheduler.scala
##
@@ -53,7 +53,7 @@ trait Scheduler {
* @param unit The unit for the preceding times
90 matches
Mail list logo
