showuon commented on a change in pull request #11347:
URL: https://github.com/apache/kafka/pull/11347#discussion_r713725768
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##########
@@ -351,6 +351,17 @@ public GroupAssignment assign(final Cluster metadata,
final GroupSubscription gr
// add the consumer and any info in its subscription to the client
clientMetadata.addConsumer(consumerId,
subscription.ownedPartitions());
+ if (allOwnedPartitions.stream().anyMatch(t ->
subscription.ownedPartitions().contains(t))) {
Review comment:
That is, in this way, it makes the check lightweight, and if we want to
find out which partition cause the issue, we can "lazily" iterate them after
the size check failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
