[GitHub] [kafka] rajinisivaram merged pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

2021-08-28 Thread GitBox
rajinisivaram merged pull request #9769: URL: https://github.com/apache/kafka/pull/9769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsub

[jira] [Resolved] (KAFKA-10774) Support Describe topic using topic IDs

2021-08-28 Thread Rajini Sivaram (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram resolved KAFKA-10774. Fix Version/s: 3.1.0 Reviewer: Rajini Sivaram Resolution: Fixed > Support

[GitHub] [kafka] dengziming removed a comment on pull request #9577: KAFKA-9837: KIP-589 new RPC for notifying controller log dir failure

2021-08-28 Thread GitBox
dengziming removed a comment on pull request #9577: URL: https://github.com/apache/kafka/pull/9577#issuecomment-834218869 The flaky test is so annoying: ``` WARN [RequestSendThread controllerId=0] Controller 0 epoch 1 fails to send request (type=LeaderAndIsRequest, controllerId=0, con

[jira] [Created] (KAFKA-13247) Adding functionality for loading private key entry by alias from the keystore

2021-08-28 Thread Tigran Margaryan (Jira)
Tigran Margaryan created KAFKA-13247: Summary: Adding functionality for loading private key entry by alias from the keystore Key: KAFKA-13247 URL: https://issues.apache.org/jira/browse/KAFKA-13247

[GitHub] [kafka] satishd commented on pull request #11060: MINOR Refactored the existing CheckpointFile in core module, moved to server-common module and introduced it as SnapshotFile.

2021-08-28 Thread GitBox
satishd commented on pull request #11060: URL: https://github.com/apache/kafka/pull/11060#issuecomment-907635550 Thanks @junrao for pointing that out. Earlier test failure is fixed with the latest commit and we do not see that failure now. The latest run failures are not related to the cha

[GitHub] [kafka] keepal7 opened a new pull request #11280: MINOR:When rebalance times out, print the member's clientHost in the …

2021-08-28 Thread GitBox
keepal7 opened a new pull request #11280: URL: https://github.com/apache/kafka/pull/11280 During the operation and maintenance of Kafka cluster, the rebalance timeout is a very serious case, hope to add a clientHost information to help quickly locate which member has a problem. -- This

[GitHub] [kafka] vamossagar12 commented on pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

2021-08-28 Thread GitBox
vamossagar12 commented on pull request #11211: URL: https://github.com/apache/kafka/pull/11211#issuecomment-907658860 > @vamossagar12 , thanks for the PR. Have a quick look, and left some comments. But most importantly, the test coverage is not enough. I saw you changed `RocksDBWindowStore

[GitHub] [kafka] vamossagar12 commented on pull request #10798: KAFKA-9168: Adding direct byte buffer support to rocksdb state store

2021-08-28 Thread GitBox
vamossagar12 commented on pull request #10798: URL: https://github.com/apache/kafka/pull/10798#issuecomment-907668633 Thanks @guozhangwang , I have made changes to the PR. I think it could be reviewed now and hence moved the PR from draft to Ready to Review. -- This is an automated messa

[GitHub] [kafka] jsancio commented on a change in pull request #11186: KAFKA-13162: Ensure ElectLeaders is properly handled in KRaft

2021-08-28 Thread GitBox
jsancio commented on a change in pull request #11186: URL: https://github.com/apache/kafka/pull/11186#discussion_r697544035 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -856,21 +867,24 @@ ApiError electLeader(String topi

[GitHub] [kafka] thomaslee closed pull request #9111: KAFKA-10337: await async commits in commitSync even if no offsets given

2021-08-28 Thread GitBox
thomaslee closed pull request #9111: URL: https://github.com/apache/kafka/pull/9111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[GitHub] [kafka] showuon commented on pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

2021-08-28 Thread GitBox
showuon commented on pull request #11211: URL: https://github.com/apache/kafka/pull/11211#issuecomment-907700293 > so I thought we won't need unit tests for RocksDBWindowStore and RocksDBSessionStore. WDYT? Make sense to me. -- This is an automated message from the Apache Git Serv

[GitHub] [kafka] dielhennr opened a new pull request #11281: KAFKA-12886: Enable request forwarding to the controller by default for zookeeper mutation protocols [REWRITE]

2021-08-28 Thread GitBox
dielhennr opened a new pull request #11281: URL: https://github.com/apache/kafka/pull/11281 A rewrite of KAFKA-12886. This PR does: 1. Enables request forwarding to the controller by default for zookeeper mutation protocols. 2. Since only the broker that a dynamic config a

[GitHub] [kafka] dielhennr commented on a change in pull request #11281: KAFKA-12886: Enable request forwarding to the controller by default for zookeeper mutation protocols [REWRITE]

2021-08-28 Thread GitBox
dielhennr commented on a change in pull request #11281: URL: https://github.com/apache/kafka/pull/11281#discussion_r697942506 ## File path: core/src/main/scala/kafka/server/ConfigHelper.scala ## @@ -22,20 +22,127 @@ import java.util.{Collections, Properties} import kafka.log.L

[GitHub] [kafka] dielhennr commented on a change in pull request #11281: KAFKA-12886: Enable request forwarding to the controller by default for zookeeper mutation protocols in IBP 3.1 and higher [REW

2021-08-28 Thread GitBox
dielhennr commented on a change in pull request #11281: URL: https://github.com/apache/kafka/pull/11281#discussion_r697942602 ## File path: core/src/main/scala/kafka/server/ConfigHelper.scala ## @@ -22,20 +22,127 @@ import java.util.{Collections, Properties} import kafka.log.L

[jira] [Created] (KAFKA-13248) Class name mismatch for LoggerFactory.getLogger method in TimeOrderedWindowStoreBuilder.java

2021-08-28 Thread S. B. Hunter (Jira)
S. B. Hunter created KAFKA-13248: Summary: Class name mismatch for LoggerFactory.getLogger method in TimeOrderedWindowStoreBuilder.java Key: KAFKA-13248 URL: https://issues.apache.org/jira/browse/KAFKA-13248

[jira] [Updated] (KAFKA-13248) Class name mismatch for LoggerFactory.getLogger method in TimeOrderedWindowStoreBuilder.java

2021-08-28 Thread S. B. Hunter (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] S. B. Hunter updated KAFKA-13248: - Attachment: KAFKA-13248.1.patch > Class name mismatch for LoggerFactory.getLogger method in > T

[GitHub] [kafka] dielhennr commented on a change in pull request #11281: KAFKA-12886: Enable request forwarding to the controller by default for zookeeper mutation protocols in IBP 3.1 and higher [REW

2021-08-28 Thread GitBox
dielhennr commented on a change in pull request #11281: URL: https://github.com/apache/kafka/pull/11281#discussion_r697942051 ## File path: core/src/main/scala/kafka/server/ZkAdminManager.scala ## @@ -531,24 +518,21 @@ class ZkAdminManager(val config: KafkaConfig, reso

[jira] [Assigned] (KAFKA-13227) Cancel pending AlterIsr requests after receiving LeaderAndIsr

2021-08-28 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov reassigned KAFKA-13227: - Assignee: Christo Lolov > Cancel pending AlterIsr requests after receiving LeaderAndIsr

[GitHub] [kafka] dielhennr commented on a change in pull request #11281: KAFKA-12886: Enable request forwarding to the controller by default for zookeeper mutation protocols in IBP 3.1 and higher [REW

2021-08-28 Thread GitBox
dielhennr commented on a change in pull request #11281: URL: https://github.com/apache/kafka/pull/11281#discussion_r697964085 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -2622,6 +2623,32 @@ class KafkaApis(val requestChannel: RequestChannel, .s