dielhennr commented on a change in pull request #11281:
URL: https://github.com/apache/kafka/pull/11281#discussion_r697942051
##########
File path: core/src/main/scala/kafka/server/ZkAdminManager.scala
##########
@@ -531,24 +518,21 @@ class ZkAdminManager(val config: KafkaConfig,
resource.`type` match {
case ConfigResource.Type.TOPIC =>
val configProps =
adminZkClient.fetchEntityConfig(ConfigType.Topic, resource.name)
- prepareIncrementalConfigs(alterConfigOps, configProps,
LogConfig.configKeys)
+ configHelper.prepareIncrementalConfigs(alterConfigOps,
configProps, LogConfig.configKeys)
alterTopicConfigs(resource, validateOnly, configProps,
configEntriesMap)
case ConfigResource.Type.BROKER =>
- val brokerId = getBrokerId(resource)
+ val brokerId = configHelper.getBrokerId(resource)
val perBrokerConfig = brokerId.nonEmpty
val persistentProps = if (perBrokerConfig)
adminZkClient.fetchEntityConfig(ConfigType.Broker, brokerId.get.toString)
else adminZkClient.fetchEntityConfig(ConfigType.Broker,
ConfigEntityName.Default)
val configProps =
this.config.dynamicConfig.fromPersistentProps(persistentProps, perBrokerConfig)
- prepareIncrementalConfigs(alterConfigOps, configProps,
KafkaConfig.configKeys)
+ configHelper.prepareIncrementalConfigs(alterConfigOps,
configProps, KafkaConfig.configKeys)
alterBrokerConfigs(resource, validateOnly, configProps,
configEntriesMap)
case ConfigResource.Type.BROKER_LOGGER =>
- getBrokerId(resource)
- validateLogLevelConfigs(alterConfigOps)
Review comment:
The Zk Controller node will be the only one calling the method
`incrementalAlterConfigs` base on the new logic in `handleDynamicConfigs.` This
validation step is being removed since it is being done on the brokers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
