dajac merged pull request #11243:
URL: https://github.com/apache/kafka/pull/11243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...
dajac commented on pull request #11243:
URL: https://github.com/apache/kafka/pull/11243#issuecomment-903501151
@scholzj Thanks for the patch! Merged to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
[
https://issues.apache.org/jira/browse/KAFKA-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17402997#comment-17402997
]
Bruno Cadonna commented on KAFKA-12766:
---
Hi [~TomerWizman]!
Thank you for your in
hojongs opened a new pull request #11249:
URL: https://github.com/apache/kafka/pull/11249
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
cadonna commented on a change in pull request #11149:
URL: https://github.com/apache/kafka/pull/11149#discussion_r693747330
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/ThreadMetricsTest.java
##
@@ -387,4 +393,51 @@ public void shoul
[
https://issues.apache.org/jira/browse/KAFKA-10313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17403089#comment-17403089
]
qiang Liu commented on KAFKA-10313:
---
I am using 1.1.1, likely encounter the same issue
dajac commented on a change in pull request #11170:
URL: https://github.com/apache/kafka/pull/11170#discussion_r693835412
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -1755,6 +1765,78 @@ class ReplicaManager(val config: KafkaConfig,
partitionsT
dajac commented on a change in pull request #11170:
URL: https://github.com/apache/kafka/pull/11170#discussion_r693836229
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -1755,6 +1765,78 @@ class ReplicaManager(val config: KafkaConfig,
partitionsT
dajac commented on a change in pull request #11246:
URL: https://github.com/apache/kafka/pull/11246#discussion_r693852187
##
File path: core/src/main/scala/kafka/server/KafkaServer.scala
##
@@ -611,7 +619,7 @@ class KafkaServer(
// ignore and try again
dajac commented on a change in pull request #11246:
URL: https://github.com/apache/kafka/pull/11246#discussion_r693852543
##
File path: core/src/main/scala/kafka/server/KafkaServer.scala
##
@@ -594,13 +594,21 @@ class KafkaServer(
val clientResponse =
NetworkCli
dajac commented on a change in pull request #11225:
URL: https://github.com/apache/kafka/pull/11225#discussion_r693973004
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -1436,17 +1438,15 @@ class ReplicaManager(val config: KafkaConfig,
le
dajac commented on a change in pull request #11225:
URL: https://github.com/apache/kafka/pull/11225#discussion_r693979039
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -1436,17 +1438,15 @@ class ReplicaManager(val config: KafkaConfig,
le
OmniaGM commented on pull request #11220:
URL: https://github.com/apache/kafka/pull/11220#issuecomment-903794123
@ryannedolan & @mimaison can I get a review on this, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
guozhangwang commented on a change in pull request #11231:
URL: https://github.com/apache/kafka/pull/11231#discussion_r694136745
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -476,7 +476,6 @@ boolean joinGroupIfN
guozhangwang merged pull request #11233:
URL: https://github.com/apache/kafka/pull/11233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsu
Laurynas Butkus created KAFKA-13223:
---
Summary: Idempotent producer error with Kraft
Key: KAFKA-13223
URL: https://issues.apache.org/jira/browse/KAFKA-13223
Project: Kafka
Issue Type: Bug
hachikuji merged pull request #11245:
URL: https://github.com/apache/kafka/pull/11245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubsc
[
https://issues.apache.org/jira/browse/KAFKA-13091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-13091.
-
Fix Version/s: 3.0.1
Resolution: Fixed
> Increment HW after shrinking ISR through
jolshan commented on a change in pull request #11170:
URL: https://github.com/apache/kafka/pull/11170#discussion_r694206981
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -1755,6 +1765,78 @@ class ReplicaManager(val config: KafkaConfig,
partition
[
https://issues.apache.org/jira/browse/KAFKA-13223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1740#comment-1740
]
Colin McCabe commented on KAFKA-13223:
--
Thanks for trying this out. EOS + kraft was
ijuma commented on pull request #11133:
URL: https://github.com/apache/kafka/pull/11133#issuecomment-904014137
I am not sure we should expose controller metrics for brokers that don't
have the controller role.
--
This is an automated message from the Apache Git Service.
To respond to the
hachikuji commented on a change in pull request #11246:
URL: https://github.com/apache/kafka/pull/11246#discussion_r694219292
##
File path: core/src/main/scala/kafka/server/KafkaServer.scala
##
@@ -594,13 +594,21 @@ class KafkaServer(
val clientResponse =
Networ
rondagostino commented on pull request #11133:
URL: https://github.com/apache/kafka/pull/11133#issuecomment-904022863
> I am not sure we should expose controller metrics for brokers that don't
have the controller role.
I agree it is a bit counter-intuitive. Now that you bring up thi
hachikuji commented on a change in pull request #11246:
URL: https://github.com/apache/kafka/pull/11246#discussion_r694226505
##
File path: core/src/main/scala/kafka/server/KafkaServer.scala
##
@@ -611,7 +619,7 @@ class KafkaServer(
// ignore and try again
hachikuji commented on a change in pull request #11231:
URL: https://github.com/apache/kafka/pull/11231#discussion_r694230654
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -476,7 +476,6 @@ boolean joinGroupIfNeed
guozhangwang commented on pull request #11247:
URL: https://github.com/apache/kafka/pull/11247#issuecomment-904029498
LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
guozhangwang merged pull request #11247:
URL: https://github.com/apache/kafka/pull/11247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsu
TomerWizman opened a new pull request #11250:
URL: https://github.com/apache/kafka/pull/11250
**description**
Streams disables the write-ahead log (WAL) provided by RocksDB since it
replicates the data in changelog topics. Hence, it does not make much sense to
set WAL-related configs fo
[
https://issues.apache.org/jira/browse/KAFKA-13223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17403344#comment-17403344
]
Laurynas Butkus commented on KAFKA-13223:
-
Hi Colin, thank you for the clarifica
[
https://issues.apache.org/jira/browse/KAFKA-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17403346#comment-17403346
]
Tomer Wizman commented on KAFKA-12766:
--
[~cadonna] thanks!
PR ready to review - ht
kirktrue opened a new pull request #11251:
URL: https://github.com/apache/kafka/pull/11251
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testin
[
https://issues.apache.org/jira/browse/KAFKA-13223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Laurynas Butkus resolved KAFKA-13223.
-
Fix Version/s: 3.0.0
Resolution: Fixed
> Idempotent producer error with Kraft
>
[
https://issues.apache.org/jira/browse/KAFKA-13223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Laurynas Butkus reopened KAFKA-13223:
-
> Idempotent producer error with Kraft
> -
>
>
[
https://issues.apache.org/jira/browse/KAFKA-13223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Laurynas Butkus resolved KAFKA-13223.
-
Resolution: Information Provided
> Idempotent producer error with Kraft
> -
kirktrue closed pull request #11251:
URL: https://github.com/apache/kafka/pull/11251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr
hachikuji commented on a change in pull request #11225:
URL: https://github.com/apache/kafka/pull/11225#discussion_r694260532
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -2207,15 +2198,28 @@ class ReplicaManager(val config: KafkaConfig,
hachikuji commented on a change in pull request #11225:
URL: https://github.com/apache/kafka/pull/11225#discussion_r694260532
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -2207,15 +2198,28 @@ class ReplicaManager(val config: KafkaConfig,
ableegoldman merged pull request #11248:
URL: https://github.com/apache/kafka/pull/11248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsu
ableegoldman commented on pull request #11248:
URL: https://github.com/apache/kafka/pull/11248#issuecomment-904101598
Merged to trunk and cherrypicked to 2.8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
rondagostino commented on pull request #11239:
URL: https://github.com/apache/kafka/pull/11239#issuecomment-904109913
The Scala 2.12 build keeps failing. Here's what the output says:
```
[2021-08-21T22:09:17.177Z] Starting build with version 3.1.0-SNAPSHOT using
Gradle 7.1.1, Jav
rondagostino edited a comment on pull request #11239:
URL: https://github.com/apache/kafka/pull/11239#issuecomment-904109913
The Scala 2.12 build keeps failing. Here's what the output says:
```
[2021-08-21T22:09:17.177Z] Starting build with version 3.1.0-SNAPSHOT using
Gradle 7.1
ijuma commented on pull request #11239:
URL: https://github.com/apache/kafka/pull/11239#issuecomment-904114131
Thanks for checking @rondagostino. Maybe we're being unlucky with the Java
8/Scala 2.12 host.
--
This is an automated message from the Apache Git Service.
To respond to the mess
ijuma commented on pull request #11239:
URL: https://github.com/apache/kafka/pull/11239#issuecomment-904114828
Looks like the last build passed with JDK 8 and Scala 2.12. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
kkonstantine commented on pull request #11248:
URL: https://github.com/apache/kafka/pull/11248#issuecomment-904115427
Approved for 3.0 as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
ijuma merged pull request #11239:
URL: https://github.com/apache/kafka/pull/11239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...
guozhangwang commented on a change in pull request #11231:
URL: https://github.com/apache/kafka/pull/11231#discussion_r694304664
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -476,7 +476,6 @@ boolean joinGroupIfN
[
https://issues.apache.org/jira/browse/KAFKA-13219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ron Dagostino updated KAFKA-13219:
--
Fix Version/s: 3.0.0
> BrokerState metric not working for KRaft clusters
> ---
[
https://issues.apache.org/jira/browse/KAFKA-13219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ron Dagostino updated KAFKA-13219:
--
Priority: Blocker (was: Major)
> BrokerState metric not working for KRaft clusters
>
ijuma commented on pull request #11239:
URL: https://github.com/apache/kafka/pull/11239#issuecomment-904142660
Cherry-picked to 3.0 as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
ijuma commented on pull request #11244:
URL: https://github.com/apache/kafka/pull/11244#issuecomment-904147744
Some builds exited before completion, one completed successfully. Since this
PR only removed a test assertion, we know they're unrelated. Merging to trunk
and cherry-picking to 3.
ijuma merged pull request #11244:
URL: https://github.com/apache/kafka/pull/11244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...
ableegoldman commented on pull request #11248:
URL: https://github.com/apache/kafka/pull/11248#issuecomment-904161738
Cherrypicked to 3.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
dielhennr commented on a change in pull request #11141:
URL: https://github.com/apache/kafka/pull/11141#discussion_r694353729
##
File path: core/src/main/scala/kafka/server/ConfigHelper.scala
##
@@ -22,20 +22,125 @@ import java.util.{Collections, Properties}
import kafka.log.L
Ron Dagostino created KAFKA-13224:
-
Summary: broker.id does not appear in config's originals map when
setting just node.id
Key: KAFKA-13224
URL: https://issues.apache.org/jira/browse/KAFKA-13224
Proje
dielhennr commented on a change in pull request #11141:
URL: https://github.com/apache/kafka/pull/11141#discussion_r694355602
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -2599,36 +2600,97 @@ class KafkaApis(val requestChannel: RequestChannel,
}
dielhennr commented on a change in pull request #11141:
URL: https://github.com/apache/kafka/pull/11141#discussion_r694355602
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -2599,36 +2600,97 @@ class KafkaApis(val requestChannel: RequestChannel,
}
ableegoldman commented on pull request #11124:
URL: https://github.com/apache/kafka/pull/11124#issuecomment-904197111
@dajac No, we're not aiming to get the fix into 2.8.1 -- no need to block on
this
--
This is an automated message from the Apache Git Service.
To respond to the message,
abbccdda commented on a change in pull request #11250:
URL: https://github.com/apache/kafka/pull/11250#discussion_r694372189
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java
##
@@ -61,1
hachikuji commented on a change in pull request #11231:
URL: https://github.com/apache/kafka/pull/11231#discussion_r694374001
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -476,7 +476,6 @@ boolean joinGroupIfNeed
hachikuji commented on a change in pull request #11231:
URL: https://github.com/apache/kafka/pull/11231#discussion_r694414167
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -476,7 +476,6 @@ boolean joinGroupIfNeed
guozhangwang commented on a change in pull request #11231:
URL: https://github.com/apache/kafka/pull/11231#discussion_r694477094
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -476,7 +476,6 @@ boolean joinGroupIfN
guozhangwang opened a new pull request #11252:
URL: https://github.com/apache/kafka/pull/11252
This is an alternative approach in parallel to #11235. After several
unsuccessful trials to improve its efficiency i've come up with a "slightly"
larger approach, which is to use a kv-store inste
guozhangwang commented on pull request #11252:
URL: https://github.com/apache/kafka/pull/11252#issuecomment-904313218
ping @mjsax @spena
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
rodesai commented on a change in pull request #11149:
URL: https://github.com/apache/kafka/pull/11149#discussion_r694522888
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsProducer.java
##
@@ -67,22 +69,35 @@
private final Map eosV2
TomerWizman commented on a change in pull request #11250:
URL: https://github.com/apache/kafka/pull/11250#discussion_r694529457
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java
##
@@ -3
TomerWizman commented on a change in pull request #11250:
URL: https://github.com/apache/kafka/pull/11250#discussion_r694530218
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##
@@ -178,15 +178,15 @@ void openDB(final Map configs
David Mao created KAFKA-13225:
-
Summary: Controller skips sending UpdateMetadataRequest when
shutting down broker doesnt host partitions
Key: KAFKA-13225
URL: https://issues.apache.org/jira/browse/KAFKA-13225
67 matches
Mail list logo