dajac commented on a change in pull request #11246:
URL: https://github.com/apache/kafka/pull/11246#discussion_r693852187
##########
File path: core/src/main/scala/kafka/server/KafkaServer.scala
##########
@@ -611,7 +619,7 @@ class KafkaServer(
// ignore and try again
}
}
- if (!shutdownSucceeded) {
+ if (!shutdownSucceeded && remainingRetries > 0) {
Thread.sleep(config.controlledShutdownRetryBackoffMs)
warn("Retrying controlled shutdown after the previous attempt
failed...")
Review comment:
I do agree that the information is a bit redundant here. I was also
wondering if we could combine this one into the previous ones. For instance, we
could say: `Controlled shutdown request returned after XXXms with error ERROR.
Retrying in XXXms ($remainingRetries retries left).`. The new part would be
printed out only if remainingRetries > 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
