[GitHub] [kafka] rajinisivaram commented on a change in pull request #11002: KAFKA-13026: Idempotent producer (KAFKA-10619) follow-up testings

2021-07-19 Thread GitBox
rajinisivaram commented on a change in pull request #11002: URL: https://github.com/apache/kafka/pull/11002#discussion_r672047056 ## File path: clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java ## @@ -172,6 +172,88 @@ public void testOverwriteAcks

[GitHub] [kafka] rackom commented on pull request #10824: KAFKA-12718: SessionWindows are closed too early

2021-07-19 Thread GitBox
rackom commented on pull request #10824: URL: https://github.com/apache/kafka/pull/10824#issuecomment-882348752 Hello, is there any way how to fix it in version 2.5.0? Because this is causing us some issues with very short window + gap combinations (window: 10sec, grace: 5sec). It is not a

[GitHub] [kafka] rajinisivaram commented on a change in pull request #11016: KAFKA-13058; AlterConsumerGroupOffsetsHandler does not handle partition errors correctly.

2021-07-19 Thread GitBox
rajinisivaram commented on a change in pull request #11016: URL: https://github.com/apache/kafka/pull/11016#discussion_r672176498 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java ## @@ -73,29 +75,40 @@ public St

[GitHub] [kafka] showuon commented on pull request #10884: MINOR: replace deprecated exactly_once_beta into exactly_once_v2

2021-07-19 Thread GitBox
showuon commented on pull request #10884: URL: https://github.com/apache/kafka/pull/10884#issuecomment-882474964 @cadonna , sorry, it turns out the version `LATEST_3_0` cannot be tested yet. Remove it to make it work. Thank you. ``` SESSION REPORT (ALL TESTS) ducktape version:

[GitHub] [kafka] dajac commented on a change in pull request #11016: KAFKA-13058; AlterConsumerGroupOffsetsHandler does not handle partition errors correctly.

2021-07-19 Thread GitBox
dajac commented on a change in pull request #11016: URL: https://github.com/apache/kafka/pull/11016#discussion_r672231624 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java ## @@ -105,53 +118,96 @@ public String a

[GitHub] [kafka] jlprat commented on pull request #11025: Scala 3 Compilation with 2.12 support

2021-07-19 Thread GitBox
jlprat commented on pull request #11025: URL: https://github.com/apache/kafka/pull/11025#issuecomment-882487321 I will close this PR as this is not really compiling in Scala3 as Gradle's scala plugin somehow still attempts to compile in Scala 2. -- This is an automated message from the A

[GitHub] [kafka] jlprat closed pull request #11025: Scala 3 Compilation with 2.12 support

2021-07-19 Thread GitBox
jlprat closed pull request #11025: URL: https://github.com/apache/kafka/pull/11025 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr..

[GitHub] [kafka] dajac commented on a change in pull request #11016: KAFKA-13058; AlterConsumerGroupOffsetsHandler does not handle partition errors correctly.

2021-07-19 Thread GitBox
dajac commented on a change in pull request #11016: URL: https://github.com/apache/kafka/pull/11016#discussion_r672233510 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java ## @@ -105,53 +118,96 @@ public String a

[GitHub] [kafka] dajac commented on pull request #11016: KAFKA-13058; AlterConsumerGroupOffsetsHandler does not handle partition errors correctly.

2021-07-19 Thread GitBox
dajac commented on pull request #11016: URL: https://github.com/apache/kafka/pull/11016#issuecomment-882493385 @rajinisivaram Thanks for your comments. I have replied to them add/or addressed them. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kafka] rajinisivaram commented on a change in pull request #11016: KAFKA-13058; AlterConsumerGroupOffsetsHandler does not handle partition errors correctly.

2021-07-19 Thread GitBox
rajinisivaram commented on a change in pull request #11016: URL: https://github.com/apache/kafka/pull/11016#discussion_r672241651 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java ## @@ -105,53 +118,96 @@ public

[GitHub] [kafka] showuon commented on pull request #11057: KAFKA-13008: Try to refresh end offset when partitionLag returns empty

2021-07-19 Thread GitBox
showuon commented on pull request #11057: URL: https://github.com/apache/kafka/pull/11057#issuecomment-882498141 After test, **I confirmed that this fix can resolve the issue**. Just that it might be more eager than before, to fetch the offset. But, looks like we need those "fetch" to fix

[GitHub] [kafka] showuon edited a comment on pull request #11057: KAFKA-13008: Try to refresh end offset when partitionLag returns empty

2021-07-19 Thread GitBox
showuon edited a comment on pull request #11057: URL: https://github.com/apache/kafka/pull/11057#issuecomment-882498141 After test, **I confirmed that this fix can resolve the issue**. Just that it might be a little more eager than before, to fetch the offset. But, looks like we need those

[GitHub] [kafka] dajac commented on a change in pull request #11036: KAFKA-12944: Assume message format version is 3.0 when inter-broker protocol is 3.0 or higher (KIP-724)

2021-07-19 Thread GitBox
dajac commented on a change in pull request #11036: URL: https://github.com/apache/kafka/pull/11036#discussion_r672245627 ## File path: core/src/main/scala/kafka/log/LogConfig.scala ## @@ -479,4 +501,31 @@ object LogConfig { logProps.put(MessageDownConversionEnableProp, k

[GitHub] [kafka] dajac commented on a change in pull request #11036: KAFKA-12944: Assume message format version is 3.0 when inter-broker protocol is 3.0 or higher (KIP-724)

2021-07-19 Thread GitBox
dajac commented on a change in pull request #11036: URL: https://github.com/apache/kafka/pull/11036#discussion_r672250729 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -403,27 +411,49 @@ class LogManager(logDirs: Seq[File], * Start the background threa

[jira] [Created] (KAFKA-13103) Should group admin handlers consider REBALANCE_IN_PROGRESS and GROUP_AUTHORIZATION_FAILED as retryable errors?

2021-07-19 Thread David Jacot (Jira)
David Jacot created KAFKA-13103: --- Summary: Should group admin handlers consider REBALANCE_IN_PROGRESS and GROUP_AUTHORIZATION_FAILED as retryable errors? Key: KAFKA-13103 URL: https://issues.apache.org/jira/browse/K

[GitHub] [kafka] dajac commented on a change in pull request #11016: KAFKA-13058; AlterConsumerGroupOffsetsHandler does not handle partition errors correctly.

2021-07-19 Thread GitBox
dajac commented on a change in pull request #11016: URL: https://github.com/apache/kafka/pull/11016#discussion_r672252610 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java ## @@ -105,53 +118,96 @@ public String a

[GitHub] [kafka] ijuma commented on a change in pull request #11036: KAFKA-12944: Assume message format version is 3.0 when inter-broker protocol is 3.0 or higher (KIP-724)

2021-07-19 Thread GitBox
ijuma commented on a change in pull request #11036: URL: https://github.com/apache/kafka/pull/11036#discussion_r672253775 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -403,27 +411,49 @@ class LogManager(logDirs: Seq[File], * Start the background threa

[GitHub] [kafka] ijuma commented on a change in pull request #11036: KAFKA-12944: Assume message format version is 3.0 when inter-broker protocol is 3.0 or higher (KIP-724)

2021-07-19 Thread GitBox
ijuma commented on a change in pull request #11036: URL: https://github.com/apache/kafka/pull/11036#discussion_r672255739 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -403,27 +411,49 @@ class LogManager(logDirs: Seq[File], * Start the background threa

[GitHub] [kafka] ijuma commented on pull request #11036: KAFKA-12944: Assume message format version is 3.0 when inter-broker protocol is 3.0 or higher (KIP-724)

2021-07-19 Thread GitBox
ijuma commented on pull request #11036: URL: https://github.com/apache/kafka/pull/11036#issuecomment-882511896 I'll go ahead and merge. If there are further comments from @mumrah or @hachikuji, I'll address in a follow up. -- This is an automated message from the Apache Git Service. To r

[GitHub] [kafka] ijuma merged pull request #11036: KAFKA-12944: Assume message format version is 3.0 when inter-broker protocol is 3.0 or higher (KIP-724)

2021-07-19 Thread GitBox
ijuma merged pull request #11036: URL: https://github.com/apache/kafka/pull/11036 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[jira] [Resolved] (KAFKA-13055) Security without JAAS configuration

2021-07-19 Thread Alexey Kashavkin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexey Kashavkin resolved KAFKA-13055. -- Resolution: Workaround I did it like this: {code:bash} listener.name.clients.scram-sha

[jira] [Assigned] (KAFKA-13103) Should group admin handlers consider REBALANCE_IN_PROGRESS and GROUP_AUTHORIZATION_FAILED as retryable errors?

2021-07-19 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-13103: - Assignee: Luke Chen > Should group admin handlers consider REBALANCE_IN_PROGRESS and > GROUP_A

[GitHub] [kafka] ijuma opened a new pull request #11078: KAFKA-12944: Assume message format version is 3.0 when inter-broker protocol is 3.0 or higher (KIP-724)

2021-07-19 Thread GitBox
ijuma opened a new pull request #11078: URL: https://github.com/apache/kafka/pull/11078 Also: * Deprecate `log.message.format.version` and `message.format.version`. * Log broker warning if the deprecated config values are ignored due to the inter-broker protocol version. * Log wa

[GitHub] [kafka] ijuma commented on pull request #11078: KAFKA-12944: Assume message format version is 3.0 when inter-broker protocol is 3.0 or higher (KIP-724)

2021-07-19 Thread GitBox
ijuma commented on pull request #11078: URL: https://github.com/apache/kafka/pull/11078#issuecomment-882544244 There were a few mechanical conflicts I had to resolve. No re-review required, but worth running the PR build before merging. -- This is an automated message from the Apache Git

[GitHub] [kafka] ijuma commented on pull request #11036: KAFKA-12944: Assume message format version is 3.0 when inter-broker protocol is 3.0 or higher (KIP-724)

2021-07-19 Thread GitBox
ijuma commented on pull request #11036: URL: https://github.com/apache/kafka/pull/11036#issuecomment-882544788 Cherry-pick for 3.0: https://github.com/apache/kafka/pull/11078 (no re-review required, but running the PR build due to conflicts) -- This is an automated message from the Apach

[jira] [Commented] (KAFKA-13103) Should group admin handlers consider REBALANCE_IN_PROGRESS and GROUP_AUTHORIZATION_FAILED as retryable errors?

2021-07-19 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383338#comment-17383338 ] Ismael Juma commented on KAFKA-13103: - What would be the justification for `GROUP_AU

[GitHub] [kafka] ijuma commented on pull request #11036: KAFKA-12944: Assume message format version is 3.0 when inter-broker protocol is 3.0 or higher (KIP-724)

2021-07-19 Thread GitBox
ijuma commented on pull request #11036: URL: https://github.com/apache/kafka/pull/11036#issuecomment-882554954 It occurred to me that some system tests may require changes. I'll check the nightly results and submit a follow-up PR. -- This is an automated message from the Apache Git Servi

[GitHub] [kafka] rondagostino commented on pull request #11064: MINOR: enable reassign_partitions_test.py for kraft

2021-07-19 Thread GitBox
rondagostino commented on pull request #11064: URL: https://github.com/apache/kafka/pull/11064#issuecomment-882573376 LGTM > How is `metadata_quorum` used? `KafkaService` uses the value of `metadata_quorum` to determine what type of metadata quorum the test should use, and the

[GitHub] [kafka] rondagostino commented on pull request #11064: MINOR: enable reassign_partitions_test.py for kraft

2021-07-19 Thread GitBox
rondagostino commented on pull request #11064: URL: https://github.com/apache/kafka/pull/11064#issuecomment-882577262 > `KafkaService` uses the value of `metadata_quorum` to determine what type of metadata quorum the test should use On more thing: the code assumes `quorum.ZK` if no v

[GitHub] [kafka] ijuma commented on pull request #11064: MINOR: enable reassign_partitions_test.py for kraft

2021-07-19 Thread GitBox
ijuma commented on pull request #11064: URL: https://github.com/apache/kafka/pull/11064#issuecomment-882580369 Thanks for the explanation @rondagostino. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (KAFKA-3539) KafkaProducer.send() may block even though it returns the Future

2021-07-19 Thread Moses Nakamura (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383368#comment-17383368 ] Moses Nakamura commented on KAFKA-3539: --- Looks likeĀ KafkaProducerTest is the main o

[GitHub] [kafka] mumrah commented on pull request #11036: KAFKA-12944: Assume message format version is 3.0 when inter-broker protocol is 3.0 or higher (KIP-724)

2021-07-19 Thread GitBox
mumrah commented on pull request #11036: URL: https://github.com/apache/kafka/pull/11036#issuecomment-882589793 Thanks @ijuma, I don't have any more questions or follow-ups šŸ‘ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [kafka] dajac commented on pull request #11016: KAFKA-13058; AlterConsumerGroupOffsetsHandler does not handle partition errors correctly.

2021-07-19 Thread GitBox
dajac commented on pull request #11016: URL: https://github.com/apache/kafka/pull/11016#issuecomment-882608400 Failed tests are not related: ``` Build / ARM / org.apache.kafka.clients.ClientUtilsTest.testResolveDnsLookup() Build / ARM / org.apache.kafka.clients.ClientUtilsTest.testR

[GitHub] [kafka] dajac merged pull request #11016: KAFKA-13058; AlterConsumerGroupOffsetsHandler does not handle partition errors correctly.

2021-07-19 Thread GitBox
dajac merged pull request #11016: URL: https://github.com/apache/kafka/pull/11016 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] dajac commented on pull request #11016: KAFKA-13058; AlterConsumerGroupOffsetsHandler does not handle partition errors correctly.

2021-07-19 Thread GitBox
dajac commented on pull request #11016: URL: https://github.com/apache/kafka/pull/11016#issuecomment-882610943 Merged to trunk and 3.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[jira] [Resolved] (KAFKA-13058) `AlterConsumerGroupOffsetsHandler` does not handle partition errors correctly.

2021-07-19 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-13058. - Reviewer: Rajini Sivaram Resolution: Fixed > `AlterConsumerGroupOffsetsHandler` does not h

[GitHub] [kafka] jolshan commented on a change in pull request #11075: MINOR: Move off deprecated APIs in StreamsResetter

2021-07-19 Thread GitBox
jolshan commented on a change in pull request #11075: URL: https://github.com/apache/kafka/pull/11075#discussion_r672384414 ## File path: core/src/main/scala/kafka/tools/StreamsResetter.java ## @@ -655,7 +655,7 @@ public void doDelete(final List topicsToDelete,

[GitHub] [kafka] dajac opened a new pull request #11079: MINOR: Small refactoring in admin group handlers

2021-07-19 Thread GitBox
dajac opened a new pull request #11079: URL: https://github.com/apache/kafka/pull/11079 Small refactoring to make the code uniform across the newly introduced admin group handlers. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation -

[GitHub] [kafka] mumrah commented on a change in pull request #11070: Validate the controllerListener config on startup

2021-07-19 Thread GitBox
mumrah commented on a change in pull request #11070: URL: https://github.com/apache/kafka/pull/11070#discussion_r672407194 ## File path: core/src/main/scala/kafka/server/ControllerServer.scala ## @@ -137,8 +137,14 @@ class ControllerServer( credentialProvider,

[GitHub] [kafka] junrao merged pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

2021-07-19 Thread GitBox
junrao merged pull request #10579: URL: https://github.com/apache/kafka/pull/10579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr..

[jira] [Resolved] (KAFKA-9555) Topic-based implementation for the RemoteLogMetadataManager

2021-07-19 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-9555. Resolution: Fixed merged the PR to trunk. > Topic-based implementation for the RemoteLogMetadataManager >

[GitHub] [kafka] cmccabe merged pull request #11064: MINOR: enable reassign_partitions_test.py for kraft

2021-07-19 Thread GitBox
cmccabe merged pull request #11064: URL: https://github.com/apache/kafka/pull/11064 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[GitHub] [kafka] mjsax commented on a change in pull request #11075: MINOR: Move off deprecated APIs in StreamsResetter

2021-07-19 Thread GitBox
mjsax commented on a change in pull request #11075: URL: https://github.com/apache/kafka/pull/11075#discussion_r672438866 ## File path: core/src/main/scala/kafka/tools/StreamsResetter.java ## @@ -655,7 +655,7 @@ public void doDelete(final List topicsToDelete,

[jira] [Updated] (KAFKA-13100) Controller cannot revert to an in-memory snapshot

2021-07-19 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-13100: - Priority: Blocker (was: Major) > Controller cannot revert to an in-memory snapshot > --

[jira] [Commented] (KAFKA-13010) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation()

2021-07-19 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383431#comment-17383431 ] Walker Carlson commented on KAFKA-13010: This failure should will effect both te

[jira] [Assigned] (KAFKA-13010) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation()

2021-07-19 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson reassigned KAFKA-13010: -- Assignee: Walker Carlson > Flaky test > org.apache.kafka.streams.integration.TaskMet

[GitHub] [kafka] jolshan commented on a change in pull request #11075: MINOR: Move off deprecated APIs in StreamsResetter

2021-07-19 Thread GitBox
jolshan commented on a change in pull request #11075: URL: https://github.com/apache/kafka/pull/11075#discussion_r672445518 ## File path: core/src/main/scala/kafka/tools/StreamsResetter.java ## @@ -655,7 +655,7 @@ public void doDelete(final List topicsToDelete,

[jira] [Updated] (KAFKA-8872) Improvements to controller "deleting" state / topic Identifiers

2021-07-19 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-8872: -- Description: Kafka currently uniquely identifies a topic by its name. This is generally suffic

[jira] [Updated] (KAFKA-13011) Update deleteTopics Admin API

2021-07-19 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-13011: --- Description: Implement the new deleteTopics apis as described in the KIP. KIP-516:Ā  https:/

[jira] [Updated] (KAFKA-13011) Update deleteTopics Admin API

2021-07-19 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-13011: --- Description: Implement the new deleteTopics apis as described in the KIP. KIP-516:Ā  was:

[GitHub] [kafka] mjsax commented on a change in pull request #11075: MINOR: Move off deprecated APIs in StreamsResetter

2021-07-19 Thread GitBox
mjsax commented on a change in pull request #11075: URL: https://github.com/apache/kafka/pull/11075#discussion_r672448120 ## File path: core/src/main/scala/kafka/tools/StreamsResetter.java ## @@ -655,7 +655,7 @@ public void doDelete(final List topicsToDelete,

[jira] [Commented] (KAFKA-13010) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation()

2021-07-19 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383445#comment-17383445 ] A. Sophie Blee-Goldman commented on KAFKA-13010: It's worth noting that

[jira] [Commented] (KAFKA-13100) Controller cannot revert to an in-memory snapshot

2021-07-19 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383453#comment-17383453 ] Jose Armando Garcia Sancio commented on KAFKA-13100: Here is an exam

[jira] [Commented] (KAFKA-13010) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation()

2021-07-19 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383474#comment-17383474 ] Walker Carlson commented on KAFKA-13010: It is possible. I ran till failure (75

[jira] [Comment Edited] (KAFKA-13010) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation()

2021-07-19 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383474#comment-17383474 ] Walker Carlson edited comment on KAFKA-13010 at 7/19/21, 5:20 PM:

[GitHub] [kafka] ijuma merged pull request #11078: KAFKA-12944: Assume message format version is 3.0 when inter-broker protocol is 3.0 or higher (KIP-724)

2021-07-19 Thread GitBox
ijuma merged pull request #11078: URL: https://github.com/apache/kafka/pull/11078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] ijuma commented on pull request #11078: KAFKA-12944: Assume message format version is 3.0 when inter-broker protocol is 3.0 or higher (KIP-724)

2021-07-19 Thread GitBox
ijuma commented on pull request #11078: URL: https://github.com/apache/kafka/pull/11078#issuecomment-882723123 Test failures are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[jira] [Created] (KAFKA-13104) Controller should notify the RaftClient when it resigns

2021-07-19 Thread Jose Armando Garcia Sancio (Jira)
Jose Armando Garcia Sancio created KAFKA-13104: -- Summary: Controller should notify the RaftClient when it resigns Key: KAFKA-13104 URL: https://issues.apache.org/jira/browse/KAFKA-13104 Pr

[GitHub] [kafka] ccding opened a new pull request #11080: [WIP] fix NPE when record==null in append

2021-07-19 Thread GitBox
ccding opened a new pull request #11080: URL: https://github.com/apache/kafka/pull/11080 This code https://github.com/apache/kafka/blob/bfc57aa4ddcd719fc4a646c2ac09d4979c076455/clients/src/main/java/org/apache/kafka/common/record/DefaultRecord.java#L294-L296 returns record=null, and c

[GitHub] [kafka] rhauch commented on pull request #10978: MINOR: Use time constant algorithms when comparing passwords or keys

2021-07-19 Thread GitBox
rhauch commented on pull request #10978: URL: https://github.com/apache/kafka/pull/10978#issuecomment-882731540 Thanks for the review, folks. @omkreddy, I renamed the new utility method as you suggested, and updated the JavaDocs as well. Hopefully the purpose and behavior is more clear.

[jira] [Commented] (KAFKA-13010) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation()

2021-07-19 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383484#comment-17383484 ] Josep Prat commented on KAFKA-13010: If it happened after KIP-744 probably I introdu

[GitHub] [kafka] cmccabe commented on a change in pull request #11067: MINOR: log broker configs in KRaft mode

2021-07-19 Thread GitBox
cmccabe commented on a change in pull request #11067: URL: https://github.com/apache/kafka/pull/11067#discussion_r672512638 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -389,6 +389,9 @@ class BrokerServer( // a potentially lengthy recovery-from

[GitHub] [kafka] cmccabe commented on a change in pull request #11067: MINOR: log broker configs in KRaft mode

2021-07-19 Thread GitBox
cmccabe commented on a change in pull request #11067: URL: https://github.com/apache/kafka/pull/11067#discussion_r672512638 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -389,6 +389,9 @@ class BrokerServer( // a potentially lengthy recovery-from

[jira] [Assigned] (KAFKA-13104) Controller should notify the RaftClient when it resigns

2021-07-19 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn reassigned KAFKA-13104: - Assignee: Ryan Dielhenn > Controller should notify the RaftClient when it resigns > ---

[GitHub] [kafka] ijuma commented on a change in pull request #11067: MINOR: log broker configs in KRaft mode

2021-07-19 Thread GitBox
ijuma commented on a change in pull request #11067: URL: https://github.com/apache/kafka/pull/11067#discussion_r672525835 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -389,6 +389,9 @@ class BrokerServer( // a potentially lengthy recovery-from-u

[GitHub] [kafka] ijuma commented on a change in pull request #11067: MINOR: log broker configs in KRaft mode

2021-07-19 Thread GitBox
ijuma commented on a change in pull request #11067: URL: https://github.com/apache/kafka/pull/11067#discussion_r672532721 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -389,6 +389,9 @@ class BrokerServer( // a potentially lengthy recovery-from-u

[jira] [Commented] (KAFKA-13010) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation()

2021-07-19 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383504#comment-17383504 ] A. Sophie Blee-Goldman commented on KAFKA-13010: Yeah it's honestly pret

[jira] [Commented] (KAFKA-13010) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation()

2021-07-19 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383513#comment-17383513 ] Josep Prat commented on KAFKA-13010: To add more to the mystery, I'm running the tes

[GitHub] [kafka] niket-goel commented on pull request #11070: Validate the controllerListener config on startup

2021-07-19 Thread GitBox
niket-goel commented on pull request #11070: URL: https://github.com/apache/kafka/pull/11070#issuecomment-882782314 This PR ends up failing a bunch of existing unit tests. Taking a look at the failures. Will update the PR. List of failed tests ``` ConnectionQuotasTest. tes

[jira] [Commented] (KAFKA-13010) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation()

2021-07-19 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383516#comment-17383516 ] Walker Carlson commented on KAFKA-13010: That does seem to be the case. I think

[GitHub] [kafka] ccding commented on pull request #11080: fix NPE when record==null in append

2021-07-19 Thread GitBox
ccding commented on pull request #11080: URL: https://github.com/apache/kafka/pull/11080#issuecomment-882800476 This PR is ready for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[jira] [Commented] (KAFKA-13010) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation()

2021-07-19 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383531#comment-17383531 ] Josep Prat commented on KAFKA-13010: One thing that was modified under that PR that

[jira] [Commented] (KAFKA-13010) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation()

2021-07-19 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383533#comment-17383533 ] Walker Carlson commented on KAFKA-13010: That sounds likely as the ThreadMetadat

[jira] [Created] (KAFKA-13105) Expose a method in KafkaConfig to write the configs to a logger

2021-07-19 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-13105: Summary: Expose a method in KafkaConfig to write the configs to a logger Key: KAFKA-13105 URL: https://issues.apache.org/jira/browse/KAFKA-13105 Project: Kafka

[GitHub] [kafka] cmccabe commented on a change in pull request #11067: MINOR: log broker configs in KRaft mode

2021-07-19 Thread GitBox
cmccabe commented on a change in pull request #11067: URL: https://github.com/apache/kafka/pull/11067#discussion_r672574835 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -389,6 +389,9 @@ class BrokerServer( // a potentially lengthy recovery-from

[GitHub] [kafka] cmccabe merged pull request #11067: MINOR: log broker configs in KRaft mode

2021-07-19 Thread GitBox
cmccabe merged pull request #11067: URL: https://github.com/apache/kafka/pull/11067 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[jira] [Updated] (KAFKA-13105) Expose a method in KafkaConfig to write the configs to a logger

2021-07-19 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-13105: - Issue Type: Improvement (was: Bug) > Expose a method in KafkaConfig to write the configs to a l

[jira] [Commented] (KAFKA-13010) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation()

2021-07-19 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383537#comment-17383537 ] Josep Prat commented on KAFKA-13010: If this is the reason why we are seeing this bu

[jira] [Comment Edited] (KAFKA-13010) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation()

2021-07-19 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383537#comment-17383537 ] Josep Prat edited comment on KAFKA-13010 at 7/19/21, 7:40 PM:

[jira] [Commented] (KAFKA-13105) Expose a method in KafkaConfig to write the configs to a logger

2021-07-19 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383550#comment-17383550 ] Ismael Juma commented on KAFKA-13105: - I think we should make this Jira about includ

[jira] [Commented] (KAFKA-13010) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation()

2021-07-19 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383553#comment-17383553 ] Walker Carlson commented on KAFKA-13010: it took about 126 runs but it still fai

[jira] [Commented] (KAFKA-13010) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation()

2021-07-19 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383557#comment-17383557 ] Josep Prat commented on KAFKA-13010: The only other difference left now is in Stream

[jira] [Commented] (KAFKA-13010) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation()

2021-07-19 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383560#comment-17383560 ] Walker Carlson commented on KAFKA-13010: This doesn't use the StreamsMetadata so

[GitHub] [kafka] ijuma commented on a change in pull request #11080: fix NPE when record==null in append

2021-07-19 Thread GitBox
ijuma commented on a change in pull request #11080: URL: https://github.com/apache/kafka/pull/11080#discussion_r672610426 ## File path: clients/src/main/java/org/apache/kafka/common/record/DefaultRecord.java ## @@ -293,7 +293,9 @@ public static DefaultRecord readFrom(ByteBuffe

[jira] [Commented] (KAFKA-13010) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation()

2021-07-19 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383564#comment-17383564 ] Josep Prat commented on KAFKA-13010: I only mentioned because it seems to be the onl

[GitHub] [kafka] dielhennr opened a new pull request #11081: MINOR: Typo in RaftClient Javadoc

2021-07-19 Thread GitBox
dielhennr opened a new pull request #11081: URL: https://github.com/apache/kafka/pull/11081 Small typo in RaftClient javadoc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[jira] [Resolved] (KAFKA-13090) Improve cluster snapshot integration test

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-13090. Resolution: Fixed Resolving given that the PR got merged and cherry-picked

[jira] [Resolved] (KAFKA-12803) Support reassigning partitions when in KRaft mode

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-12803. Resolution: Fixed Resolving as Fixed given that the PR got merged and cher

[jira] [Updated] (KAFKA-9910) Implement new transaction timed out error

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-9910: -- Fix Version/s: (was: 3.0.0) 3.1.0 > Implement new transa

[jira] [Commented] (KAFKA-9910) Implement new transaction timed out error

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383573#comment-17383573 ] Konstantine Karantasis commented on KAFKA-9910: --- Postponing to the subseque

[jira] [Assigned] (KAFKA-12842) Failing test: org.apache.kafka.connect.integration.ConnectWorkerIntegrationTest.testSourceTaskNotBlockedOnShutdownWithNonExistentTopic

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis reassigned KAFKA-12842: -- Assignee: Konstantine Karantasis > Failing test: > org.apache.kafka.

[jira] [Updated] (KAFKA-12842) Failing test: org.apache.kafka.connect.integration.ConnectWorkerIntegrationTest.testSourceTaskNotBlockedOnShutdownWithNonExistentTopic

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-12842: --- Fix Version/s: (was: 3.0.0) 3.1.0 > Failing test: >

[jira] [Assigned] (KAFKA-12842) Failing test: org.apache.kafka.connect.integration.ConnectWorkerIntegrationTest.testSourceTaskNotBlockedOnShutdownWithNonExistentTopic

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis reassigned KAFKA-12842: -- Assignee: (was: Konstantine Karantasis) > Failing test: > org.ap

[jira] [Commented] (KAFKA-12842) Failing test: org.apache.kafka.connect.integration.ConnectWorkerIntegrationTest.testSourceTaskNotBlockedOnShutdownWithNonExistentTopic

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383575#comment-17383575 ] Konstantine Karantasis commented on KAFKA-12842: This is an infrequent f

[jira] [Commented] (KAFKA-9803) Allow producers to recover gracefully from transaction timeouts

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383576#comment-17383576 ] Konstantine Karantasis commented on KAFKA-9803: --- Postponing to the subseque

[jira] [Updated] (KAFKA-9803) Allow producers to recover gracefully from transaction timeouts

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-9803: -- Fix Version/s: (was: 3.0.0) 3.1.0 > Allow producers to r

[jira] [Updated] (KAFKA-12899) Support --bootstrap-server in ReplicaVerificationTool

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-12899: --- Fix Version/s: (was: 3.0.0) > Support --bootstrap-server in ReplicaVerif

[jira] [Commented] (KAFKA-12899) Support --bootstrap-server in ReplicaVerificationTool

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383577#comment-17383577 ] Konstantine Karantasis commented on KAFKA-12899: KIP freeze has past a w

[jira] [Comment Edited] (KAFKA-13010) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation()

2021-07-19 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383564#comment-17383564 ] Josep Prat edited comment on KAFKA-13010 at 7/19/21, 9:02 PM:

[jira] [Updated] (KAFKA-10642) Expose the real stack trace if any exception occurred during SSL Client Trust Verification in extension

2021-07-19 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-10642: --- Fix Version/s: (was: 3.0.0) 3.1.0 > Expose the real s

  1   2   >