rajinisivaram commented on a change in pull request #11002:
URL: https://github.com/apache/kafka/pull/11002#discussion_r672047056
##########
File path:
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java
##########
@@ -172,6 +172,88 @@ public void
testOverwriteAcksAndRetriesForIdempotentProducers() {
config.getString(ProducerConfig.TRANSACTIONAL_ID_CONFIG)));
}
+ @Test
+ public void testAcksAndIdempotenceForIdempotentProducers() {
+ Properties baseProps = new Properties() {{
+ setProperty(
+ ProducerConfig.BOOTSTRAP_SERVERS_CONFIG, "localhost:9999");
+ setProperty(
+ ProducerConfig.KEY_SERIALIZER_CLASS_CONFIG,
StringSerializer.class.getName());
+ setProperty(
+ ProducerConfig.VALUE_SERIALIZER_CLASS_CONFIG,
StringSerializer.class.getName());
+ }};
+
+ Properties validProps = new Properties() {{
+ putAll(baseProps);
+ setProperty(ProducerConfig.ACKS_CONFIG, "0");
+ setProperty(ProducerConfig.ENABLE_IDEMPOTENCE_CONFIG, "false");
+ }};
+ ProducerConfig config = new ProducerConfig(validProps);
+ assertFalse(
+ config.getBoolean(ProducerConfig.ENABLE_IDEMPOTENCE_CONFIG),
+ "idempotence should be overwritten");
+ assertEquals(
+ config.getString(ProducerConfig.ACKS_CONFIG),
+ "0",
+ "acks should be overwritten");
+
+ Properties validProps2 = new Properties() {{
+ putAll(baseProps);
+ setProperty(ProducerConfig.TRANSACTIONAL_ID_CONFIG,
"transactionalId");
+ }};
+ config = new ProducerConfig(validProps2);
+ assertTrue(
+ config.getBoolean(ProducerConfig.ENABLE_IDEMPOTENCE_CONFIG),
+ "idempotence should be set with the default value");
+ assertEquals(
+ config.getString(ProducerConfig.ACKS_CONFIG),
+ "-1",
Review comment:
As before, "-1" is the first arg
##########
File path:
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java
##########
@@ -172,6 +172,88 @@ public void
testOverwriteAcksAndRetriesForIdempotentProducers() {
config.getString(ProducerConfig.TRANSACTIONAL_ID_CONFIG)));
}
+ @Test
+ public void testAcksAndIdempotenceForIdempotentProducers() {
+ Properties baseProps = new Properties() {{
+ setProperty(
+ ProducerConfig.BOOTSTRAP_SERVERS_CONFIG, "localhost:9999");
+ setProperty(
+ ProducerConfig.KEY_SERIALIZER_CLASS_CONFIG,
StringSerializer.class.getName());
+ setProperty(
+ ProducerConfig.VALUE_SERIALIZER_CLASS_CONFIG,
StringSerializer.class.getName());
+ }};
+
+ Properties validProps = new Properties() {{
+ putAll(baseProps);
+ setProperty(ProducerConfig.ACKS_CONFIG, "0");
+ setProperty(ProducerConfig.ENABLE_IDEMPOTENCE_CONFIG, "false");
+ }};
+ ProducerConfig config = new ProducerConfig(validProps);
+ assertFalse(
+ config.getBoolean(ProducerConfig.ENABLE_IDEMPOTENCE_CONFIG),
+ "idempotence should be overwritten");
+ assertEquals(
+ config.getString(ProducerConfig.ACKS_CONFIG),
+ "0",
+ "acks should be overwritten");
+
+ Properties validProps2 = new Properties() {{
+ putAll(baseProps);
+ setProperty(ProducerConfig.TRANSACTIONAL_ID_CONFIG,
"transactionalId");
+ }};
+ config = new ProducerConfig(validProps2);
+ assertTrue(
+ config.getBoolean(ProducerConfig.ENABLE_IDEMPOTENCE_CONFIG),
+ "idempotence should be set with the default value");
+ assertEquals(
+ config.getString(ProducerConfig.ACKS_CONFIG),
+ "-1",
+ "acks should be set with the default value");
+
+ Properties validProps3 = new Properties() {{
+ putAll(baseProps);
+ setProperty(ProducerConfig.ACKS_CONFIG, "all");
+ setProperty(ProducerConfig.ENABLE_IDEMPOTENCE_CONFIG, "false");
+ }};
+ config = new ProducerConfig(validProps3);
+
assertFalse(config.getBoolean(ProducerConfig.ENABLE_IDEMPOTENCE_CONFIG),
+ "idempotence should be overwritten");
+ assertEquals(config.getString(ProducerConfig.ACKS_CONFIG),
+ "-1",
Review comment:
As before, "-1" first arg
##########
File path:
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java
##########
@@ -172,6 +172,88 @@ public void
testOverwriteAcksAndRetriesForIdempotentProducers() {
config.getString(ProducerConfig.TRANSACTIONAL_ID_CONFIG)));
}
+ @Test
+ public void testAcksAndIdempotenceForIdempotentProducers() {
+ Properties baseProps = new Properties() {{
+ setProperty(
+ ProducerConfig.BOOTSTRAP_SERVERS_CONFIG, "localhost:9999");
+ setProperty(
+ ProducerConfig.KEY_SERIALIZER_CLASS_CONFIG,
StringSerializer.class.getName());
+ setProperty(
+ ProducerConfig.VALUE_SERIALIZER_CLASS_CONFIG,
StringSerializer.class.getName());
+ }};
+
+ Properties validProps = new Properties() {{
+ putAll(baseProps);
+ setProperty(ProducerConfig.ACKS_CONFIG, "0");
+ setProperty(ProducerConfig.ENABLE_IDEMPOTENCE_CONFIG, "false");
+ }};
+ ProducerConfig config = new ProducerConfig(validProps);
+ assertFalse(
+ config.getBoolean(ProducerConfig.ENABLE_IDEMPOTENCE_CONFIG),
+ "idempotence should be overwritten");
+ assertEquals(
+ config.getString(ProducerConfig.ACKS_CONFIG),
+ "0",
Review comment:
reverse the two args (expectedValue followed by actualValue for
assertEquals)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
