[jira] [Created] (KAFKA-13042) Flaky test KafkaMetadataLogTest.testDeleteSnapshots()

2021-07-07 Thread dengziming (Jira)
dengziming created KAFKA-13042: -- Summary: Flaky test KafkaMetadataLogTest.testDeleteSnapshots() Key: KAFKA-13042 URL: https://issues.apache.org/jira/browse/KAFKA-13042 Project: Kafka Issue Type:

[GitHub] [kafka] skaundinya15 commented on a change in pull request #10973: KAFKA-13033: COORDINATOR_NOT_AVAILABLE should be unmapped

2021-07-07 Thread GitBox
skaundinya15 commented on a change in pull request #10973: URL: https://github.com/apache/kafka/pull/10973#discussion_r665108901 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java ## @@ -141,9 +147,16 @@ private v

[jira] [Resolved] (KAFKA-13029) FindCoordinators batching can break consumers during rolling upgrade

2021-07-07 Thread Rajini Sivaram (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram resolved KAFKA-13029. Resolution: Fixed > FindCoordinators batching can break consumers during rolling upgrade >

[GitHub] [kafka] showuon commented on a change in pull request #10973: KAFKA-13033: COORDINATOR_NOT_AVAILABLE should be unmapped

2021-07-07 Thread GitBox
showuon commented on a change in pull request #10973: URL: https://github.com/apache/kafka/pull/10973#discussion_r665173709 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java ## @@ -141,9 +147,16 @@ private void h

[GitHub] [kafka] showuon commented on a change in pull request #10973: KAFKA-13033: COORDINATOR_NOT_AVAILABLE should be unmapped

2021-07-07 Thread GitBox
showuon commented on a change in pull request #10973: URL: https://github.com/apache/kafka/pull/10973#discussion_r665176116 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java ## @@ -141,9 +147,16 @@ private void h

[jira] [Resolved] (KAFKA-13000) Improve handling of UnsupportedVersionException in MockClient

2021-07-07 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-13000. Fix Version/s: 3.0.0 Assignee: (was: Kirk True) Resolution: Fixed > Im

[jira] [Commented] (KAFKA-13000) Improve handling of UnsupportedVersionException in MockClient

2021-07-07 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376414#comment-17376414 ] Mickael Maison commented on KAFKA-13000: [~kirktrue] Sorry it looks like this ha

[GitHub] [kafka] showuon opened a new pull request #10987: MINOR: improve the partitioner.class doc

2021-07-07 Thread GitBox
showuon opened a new pull request #10987: URL: https://github.com/apache/kafka/pull/10987 Before the PR, the `partitioner.class` config doesn't describe what the config is use for, and what options user can choose. ![image](https://user-images.githubusercontent.com/43372967/124742380-3a

[GitHub] [kafka] ableegoldman commented on a change in pull request #10985: KAFKA-12984: make AbstractStickyAssignor resilient to invalid input, utilize generation in cooperative, and fix assignment b

2021-07-07 Thread GitBox
ableegoldman commented on a change in pull request #10985: URL: https://github.com/apache/kafka/pull/10985#discussion_r665240093 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignorTest.java ## @@ -555,7 +558,7 @@ public void

[GitHub] [kafka] omkreddy commented on a change in pull request #10978: MINOR: Use time constant algorithms when comparing passwords or keys

2021-07-07 Thread GitBox
omkreddy commented on a change in pull request #10978: URL: https://github.com/apache/kafka/pull/10978#discussion_r665251346 ## File path: clients/src/main/java/org/apache/kafka/common/security/plain/internals/PlainServerCallbackHandler.java ## @@ -65,7 +65,7 @@ protected bool

[GitHub] [kafka] satishd commented on a change in pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

2021-07-07 Thread GitBox
satishd commented on a change in pull request #10579: URL: https://github.com/apache/kafka/pull/10579#discussion_r665259927 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java ## @@ -0,0 +1,432 @@ +/*

[GitHub] [kafka] rajinisivaram commented on pull request #10962: KIP-709: Implement request/response for offsetFetch batching

2021-07-07 Thread GitBox
rajinisivaram commented on pull request #10962: URL: https://github.com/apache/kafka/pull/10962#issuecomment-875502747 @skaundinya15 Thanks for the PR. Test failures (KafkaMetadataLogTest.testDeleteSnapshots, RaftClusterTest.testCreateClusterAndCreateAndManyTopicsWithManyPartitions, Query

[GitHub] [kafka] rajinisivaram merged pull request #10962: KAFKA-12234: Implement request/response for offsetFetch batching (KIP-709)

2021-07-07 Thread GitBox
rajinisivaram merged pull request #10962: URL: https://github.com/apache/kafka/pull/10962 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-uns

[jira] [Resolved] (KAFKA-12234) Extend OffsetFetch requests to accept multiple group ids.

2021-07-07 Thread Rajini Sivaram (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram resolved KAFKA-12234. Reviewer: Rajini Sivaram Resolution: Fixed > Extend OffsetFetch requests to accept m

[jira] [Created] (KAFKA-13043) Add Admin API for batched offset fetch requests (KIP-709)

2021-07-07 Thread Rajini Sivaram (Jira)
Rajini Sivaram created KAFKA-13043: -- Summary: Add Admin API for batched offset fetch requests (KIP-709) Key: KAFKA-13043 URL: https://issues.apache.org/jira/browse/KAFKA-13043 Project: Kafka

[jira] [Updated] (KAFKA-10675) Error message from ConnectSchema.validateValue() should include the name of the schema.

2021-07-07 Thread Alexander Iskuskov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Iskuskov updated KAFKA-10675: --- Fix Version/s: 3.0.0 > Error message from ConnectSchema.validateValue() should inclu

[jira] [Updated] (KAFKA-10675) Error message from ConnectSchema.validateValue() should include the name of the schema.

2021-07-07 Thread Alexander Iskuskov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Iskuskov updated KAFKA-10675: --- Fix Version/s: 2.8.1 > Error message from ConnectSchema.validateValue() should inclu

[jira] [Updated] (KAFKA-10675) Error message from ConnectSchema.validateValue() should include the name of the schema.

2021-07-07 Thread Alexander Iskuskov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Iskuskov updated KAFKA-10675: --- Reviewer: Randall Hauch > Error message from ConnectSchema.validateValue() should in

[GitHub] [kafka] rajinisivaram commented on a change in pull request #10978: MINOR: Use time constant algorithms when comparing passwords or keys

2021-07-07 Thread GitBox
rajinisivaram commented on a change in pull request #10978: URL: https://github.com/apache/kafka/pull/10978#discussion_r665288314 ## File path: clients/src/main/java/org/apache/kafka/common/security/plain/internals/PlainServerCallbackHandler.java ## @@ -65,7 +65,7 @@ protected

[GitHub] [kafka] mimaison commented on a change in pull request #10978: MINOR: Use time constant algorithms when comparing passwords or keys

2021-07-07 Thread GitBox
mimaison commented on a change in pull request #10978: URL: https://github.com/apache/kafka/pull/10978#discussion_r665293815 ## File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java ## @@ -331,6 +331,41 @@ public static ByteBuffer wrapNullable(byte[] array)

[GitHub] [kafka] satishd commented on a change in pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

2021-07-07 Thread GitBox
satishd commented on a change in pull request #10579: URL: https://github.com/apache/kafka/pull/10579#discussion_r665299398 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerConfig.java ## @@ -0,0 +1,197 @

[GitHub] [kafka] rajinisivaram commented on a change in pull request #10978: MINOR: Use time constant algorithms when comparing passwords or keys

2021-07-07 Thread GitBox
rajinisivaram commented on a change in pull request #10978: URL: https://github.com/apache/kafka/pull/10978#discussion_r665302911 ## File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java ## @@ -331,6 +331,41 @@ public static ByteBuffer wrapNullable(byte[] ar

[GitHub] [kafka] showuon commented on a change in pull request #10985: KAFKA-12984: make AbstractStickyAssignor resilient to invalid input, utilize generation in cooperative, and fix assignment bug

2021-07-07 Thread GitBox
showuon commented on a change in pull request #10985: URL: https://github.com/apache/kafka/pull/10985#discussion_r665314091 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignorTest.java ## @@ -555,7 +558,7 @@ public void testL

[GitHub] [kafka] mimaison commented on a change in pull request #10978: MINOR: Use time constant algorithms when comparing passwords or keys

2021-07-07 Thread GitBox
mimaison commented on a change in pull request #10978: URL: https://github.com/apache/kafka/pull/10978#discussion_r665322579 ## File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java ## @@ -331,6 +331,41 @@ public static ByteBuffer wrapNullable(byte[] array)

[GitHub] [kafka] mimaison commented on a change in pull request #10978: MINOR: Use time constant algorithms when comparing passwords or keys

2021-07-07 Thread GitBox
mimaison commented on a change in pull request #10978: URL: https://github.com/apache/kafka/pull/10978#discussion_r665292916 ## File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java ## @@ -331,6 +331,41 @@ public static ByteBuffer wrapNullable(byte[] array)

[GitHub] [kafka] chia7712 commented on a change in pull request #10943: Fix verification of version probing

2021-07-07 Thread GitBox
chia7712 commented on a change in pull request #10943: URL: https://github.com/apache/kafka/pull/10943#discussion_r665323302 ## File path: tests/kafkatest/tests/streams/streams_upgrade_test.py ## @@ -474,8 +474,9 @@ def do_rolling_bounce(self, processor, counter, current_gener

[GitHub] [kafka] showuon commented on a change in pull request #10985: KAFKA-12984: make AbstractStickyAssignor resilient to invalid input, utilize generation in cooperative, and fix assignment bug

2021-07-07 Thread GitBox
showuon commented on a change in pull request #10985: URL: https://github.com/apache/kafka/pull/10985#discussion_r665328864 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -122,6 +131,13 @@ private boolean allSu

[GitHub] [kafka] lct45 opened a new pull request #10988: [KAFKA-9559] add docs for changing default serde to null

2021-07-07 Thread GitBox
lct45 opened a new pull request #10988: URL: https://github.com/apache/kafka/pull/10988 https://github.com/apache/kafka/pull/10813 changed the default serde from ByteArraySerde as discussed in [KIP-741](https://cwiki.apache.org/confluence/display/KAFKA/KIP-741%3A+Change+default+serde+to+be

[GitHub] [kafka] lct45 commented on pull request #10988: [KAFKA-9559] add docs for changing default serde to null

2021-07-07 Thread GitBox
lct45 commented on pull request #10988: URL: https://github.com/apache/kafka/pull/10988#issuecomment-875584527 cc @ableegoldman @mjsax @wcarlson5 for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [kafka] ijuma commented on a change in pull request #10978: MINOR: Use time constant algorithms when comparing passwords or keys

2021-07-07 Thread GitBox
ijuma commented on a change in pull request #10978: URL: https://github.com/apache/kafka/pull/10978#discussion_r665362085 ## File path: clients/src/main/java/org/apache/kafka/common/security/plain/internals/PlainServerCallbackHandler.java ## @@ -65,7 +65,7 @@ protected boolean

[jira] [Created] (KAFKA-13044) __consumer_offsets corruption

2021-07-07 Thread Nanda Kishore M S (Jira)
Nanda Kishore M S created KAFKA-13044: - Summary: __consumer_offsets corruption Key: KAFKA-13044 URL: https://issues.apache.org/jira/browse/KAFKA-13044 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-13044) __consumer_offsets corruption

2021-07-07 Thread Nanda Kishore M S (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nanda Kishore M S updated KAFKA-13044: -- Description: We had an issue where clients are not able to discover a group coordinato

[jira] [Updated] (KAFKA-13044) __consumer_offsets corruption

2021-07-07 Thread Nanda Kishore M S (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nanda Kishore M S updated KAFKA-13044: -- Description: We had an issue where clients are not able to discover a group coordinato

[jira] [Updated] (KAFKA-13044) __consumer_offsets corruption

2021-07-07 Thread Nanda Kishore M S (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nanda Kishore M S updated KAFKA-13044: -- Description: We had an issue where clients are not able to discover a group coordinato

[jira] [Updated] (KAFKA-13044) __consumer_offsets corruption

2021-07-07 Thread Nanda Kishore M S (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nanda Kishore M S updated KAFKA-13044: -- Description: We had an issue where clients are not able to discover a group coordinato

[jira] [Updated] (KAFKA-13044) __consumer_offsets corruption

2021-07-07 Thread Nanda Kishore M S (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nanda Kishore M S updated KAFKA-13044: -- Environment: Amazon Linux Kafka Server: 2.5.0, scala version - 2.12 Cluster of 6 EC2 N

[jira] [Updated] (KAFKA-13044) __consumer_offsets corruption

2021-07-07 Thread Nanda Kishore M S (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nanda Kishore M S updated KAFKA-13044: -- Description: We had an issue where clients are not able to discover a group coordinato

[jira] [Updated] (KAFKA-13044) __consumer_offsets corruption

2021-07-07 Thread Nanda Kishore M S (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nanda Kishore M S updated KAFKA-13044: -- Description: We had an issue where clients are not able to discover a group coordinato

[jira] [Updated] (KAFKA-13044) __consumer_offsets corruption

2021-07-07 Thread Nanda Kishore M S (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nanda Kishore M S updated KAFKA-13044: -- Description: We had an issue where clients are not able to discover a group coordinato

[jira] [Updated] (KAFKA-13044) __consumer_offsets corruption

2021-07-07 Thread Nanda Kishore M S (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nanda Kishore M S updated KAFKA-13044: -- Description: We had an issue where clients are not able to discover a group coordinato

[jira] [Updated] (KAFKA-13044) __consumer_offsets corruption

2021-07-07 Thread Nanda Kishore M S (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nanda Kishore M S updated KAFKA-13044: -- Description: We had an issue where clients are not able to discover a group coordinato

[GitHub] [kafka] showuon commented on a change in pull request #10985: KAFKA-12984: make AbstractStickyAssignor resilient to invalid input, utilize generation in cooperative, and fix assignment bug

2021-07-07 Thread GitBox
showuon commented on a change in pull request #10985: URL: https://github.com/apache/kafka/pull/10985#discussion_r665386121 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -130,19 +146,26 @@ private boolean allS

[GitHub] [kafka] rajinisivaram commented on a change in pull request #10978: MINOR: Use time constant algorithms when comparing passwords or keys

2021-07-07 Thread GitBox
rajinisivaram commented on a change in pull request #10978: URL: https://github.com/apache/kafka/pull/10978#discussion_r665403838 ## File path: clients/src/main/java/org/apache/kafka/common/security/plain/internals/PlainServerCallbackHandler.java ## @@ -65,7 +65,7 @@ protected

[GitHub] [kafka] jacky1193610322 commented on a change in pull request #10985: KAFKA-12984: make AbstractStickyAssignor resilient to invalid input, utilize generation in cooperative, and fix assignmen

2021-07-07 Thread GitBox
jacky1193610322 commented on a change in pull request #10985: URL: https://github.com/apache/kafka/pull/10985#discussion_r665433621 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/CooperativeStickyAssignor.java ## @@ -53,9 +56,34 @@ public String name() {

[GitHub] [kafka] tombentley commented on pull request #8259: KAFKA-7421: Ensure Connect's PluginClassLoader is truly parallel capable and resolve deadlock occurrences

2021-07-07 Thread GitBox
tombentley commented on pull request #8259: URL: https://github.com/apache/kafka/pull/8259#issuecomment-875682628 @rhauch @kkonstantine Any chance we could get this into 3.0? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [kafka] satishd commented on a change in pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

2021-07-07 Thread GitBox
satishd commented on a change in pull request #10579: URL: https://github.com/apache/kafka/pull/10579#discussion_r665259927 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java ## @@ -0,0 +1,432 @@ +/*

[jira] [Commented] (KAFKA-12992) Make kraft configuration properties public

2021-07-07 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376635#comment-17376635 ] David Arthur commented on KAFKA-12992: -- Some additional properties were added as pa

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

2021-07-07 Thread GitBox
jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r665476219 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java ## @@ -303,7 +303,33 @@ default DescribeTopicsResult describeTopics(Collectio

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

2021-07-07 Thread GitBox
jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r665479977 ## File path: core/src/test/scala/integration/kafka/server/MetadataRequestBetweenDifferentIbpTest.scala ## @@ -0,0 +1,103 @@ +/** + * Licensed to the Apac

[GitHub] [kafka] wcarlson5 commented on a change in pull request #10988: [KAFKA-9559] add docs for changing default serde to null

2021-07-07 Thread GitBox
wcarlson5 commented on a change in pull request #10988: URL: https://github.com/apache/kafka/pull/10988#discussion_r665519455 ## File path: docs/streams/developer-guide/config-streams.html ## @@ -211,8 +211,9 @@ bootstrap.serversdefault.key.serde Medium -

[GitHub] [kafka] C0urante commented on a change in pull request #10907: KAFKA-10000: Exactly-once support for source connectors (KIP-618)

2021-07-07 Thread GitBox
C0urante commented on a change in pull request #10907: URL: https://github.com/apache/kafka/pull/10907#discussion_r665526680 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/util/KafkaBasedLog.java ## @@ -337,15 +353,29 @@ private void readToLogEnd() {

[GitHub] [kafka] tombentley commented on pull request #8571: KAFKA-7613: Enable -Xlint:rawtypes for connect, fixing warnings

2021-07-07 Thread GitBox
tombentley commented on pull request #8571: URL: https://github.com/apache/kafka/pull/8571#issuecomment-875745475 CI failures are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] tombentley merged pull request #8571: KAFKA-7613: Enable -Xlint:rawtypes for connect, fixing warnings

2021-07-07 Thread GitBox
tombentley merged pull request #8571: URL: https://github.com/apache/kafka/pull/8571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr

[GitHub] [kafka] tombentley commented on pull request #8571: KAFKA-7613: Enable -Xlint:rawtypes for connect, fixing warnings

2021-07-07 Thread GitBox
tombentley commented on pull request #8571: URL: https://github.com/apache/kafka/pull/8571#issuecomment-875746579 Cherry-picked to 3.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [kafka] satishd commented on a change in pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

2021-07-07 Thread GitBox
satishd commented on a change in pull request #10579: URL: https://github.com/apache/kafka/pull/10579#discussion_r665531236 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java ## @@ -0,0 +1,432 @@ +/*

[GitHub] [kafka] satishd commented on pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

2021-07-07 Thread GitBox
satishd commented on pull request #10579: URL: https://github.com/apache/kafka/pull/10579#issuecomment-875750234 Thanks @junrao for the comments. Pl take a look at my inline replies and the latest commit. -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [kafka] lct45 commented on a change in pull request #10988: [KAFKA-9559] add docs for changing default serde to null

2021-07-07 Thread GitBox
lct45 commented on a change in pull request #10988: URL: https://github.com/apache/kafka/pull/10988#discussion_r665531990 ## File path: docs/streams/developer-guide/config-streams.html ## @@ -211,8 +211,9 @@ bootstrap.serversdefault.key.serde Medium -De

[GitHub] [kafka] kamalcph commented on a change in pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

2021-07-07 Thread GitBox
kamalcph commented on a change in pull request #10579: URL: https://github.com/apache/kafka/pull/10579#discussion_r665544995 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ProducerManager.java ## @@ -0,0 +1,120 @@ +/* + * Licensed to th

[GitHub] [kafka] vlsi commented on a change in pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2021-07-07 Thread GitBox
vlsi commented on a change in pull request #10851: URL: https://github.com/apache/kafka/pull/10851#discussion_r665553313 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientState.java ## @@ -64,6 +66,7 @@ public ClientState() {

[GitHub] [kafka] satishd commented on a change in pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

2021-07-07 Thread GitBox
satishd commented on a change in pull request #10579: URL: https://github.com/apache/kafka/pull/10579#discussion_r66878 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ProducerManager.java ## @@ -0,0 +1,120 @@ +/* + * Licensed to the

[GitHub] [kafka] satishd commented on a change in pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

2021-07-07 Thread GitBox
satishd commented on a change in pull request #10579: URL: https://github.com/apache/kafka/pull/10579#discussion_r66878 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ProducerManager.java ## @@ -0,0 +1,120 @@ +/* + * Licensed to the

[GitHub] [kafka] vlsi commented on a change in pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2021-07-07 Thread GitBox
vlsi commented on a change in pull request #10851: URL: https://github.com/apache/kafka/pull/10851#discussion_r665561377 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/StandbyTaskAssignor.java ## @@ -0,0 +1,39 @@ +/* + * Licensed to

[GitHub] [kafka] cmccabe commented on pull request #10989: MINOR: Fix a startup NPE as well as several NPEs around PartitionRegistration

2021-07-07 Thread GitBox
cmccabe commented on pull request #10989: URL: https://github.com/apache/kafka/pull/10989#issuecomment-875787445 For Replicas, that is actually what it is supposed to do. I agree that removingReplicas and addingReplicas should not be stored as null. Can you make a separate PR for tha

[GitHub] [kafka] cmccabe opened a new pull request #10990: MINOR: the broker should use metadata.log.max.record.bytes.between.snapshots

2021-07-07 Thread GitBox
cmccabe opened a new pull request #10990: URL: https://github.com/apache/kafka/pull/10990 The broker should trigger a snapshot once metadata.log.max.record.bytes.between.snapshots has been exceeded. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] hachikuji commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-07 Thread GitBox
hachikuji commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r665599081 ## File path: clients/src/main/java/org/apache/kafka/clients/Metadata.java ## @@ -316,8 +325,16 @@ private MetadataCache handleMetadataResponse(Metadat

[GitHub] [kafka] kkonstantine commented on pull request #8259: KAFKA-7421: Ensure Connect's PluginClassLoader is truly parallel capable and resolve deadlock occurrences

2021-07-07 Thread GitBox
kkonstantine commented on pull request #8259: URL: https://github.com/apache/kafka/pull/8259#issuecomment-875841425 @tombentley this is a bugfix and we are still on track to include it for 3.0 and other release branches. I've finished some analysis and I'll add the summary to the review

[GitHub] [kafka] hachikuji commented on a change in pull request #10560: KAFKA-12660: Do not update offset commit sensor after append failure

2021-07-07 Thread GitBox
hachikuji commented on a change in pull request #10560: URL: https://github.com/apache/kafka/pull/10560#discussion_r665623998 ## File path: core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala ## @@ -1349,6 +1357,10 @@ class GroupMetadataManagerTest

[GitHub] [kafka] rondagostino opened a new pull request #10991: MINOR: system test fix for 3 co-located KRaft controllers

2021-07-07 Thread GitBox
rondagostino opened a new pull request #10991: URL: https://github.com/apache/kafka/pull/10991 This patch adds a sanity-check bounce system test for the case where we have 3 co-located KRaft controllers and fixes the system test code so that this case will pass. We were not testing this c

[GitHub] [kafka] mumrah merged pull request #10989: MINOR: Fix a startup NPE in BrokerServer

2021-07-07 Thread GitBox
mumrah merged pull request #10989: URL: https://github.com/apache/kafka/pull/10989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr..

[GitHub] [kafka] mumrah opened a new pull request #10992: MINOR: Remove nullable from addingReplicas and removingReplicas

2021-07-07 Thread GitBox
mumrah opened a new pull request #10992: URL: https://github.com/apache/kafka/pull/10992 This change was discussed in KIP-746 and are actually included in #10753. I'm pulling them out here since there are NPEs on trunk as a result of the nullable fields in the PartitionRecord. -- This

[GitHub] [kafka] jgray1206 opened a new pull request #10993: KAFKA-13037: "Thread state is already PENDING_SHUTDOWN" log spam

2021-07-07 Thread GitBox
jgray1206 opened a new pull request #10993: URL: https://github.com/apache/kafka/pull/10993 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-u

[GitHub] [kafka] jolshan commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-07 Thread GitBox
jolshan commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r665649142 ## File path: clients/src/main/java/org/apache/kafka/clients/MetadataCache.java ## @@ -130,13 +150,30 @@ MetadataCache mergeWith(String newClusterId,

[GitHub] [kafka] jolshan commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-07 Thread GitBox
jolshan commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r665652021 ## File path: clients/src/main/java/org/apache/kafka/clients/MetadataCache.java ## @@ -93,6 +104,14 @@ private MetadataCache(String clusterId, re

[GitHub] [kafka] jolshan commented on a change in pull request #10952: KAFKA-12257: Consumer mishandles topics deleted and recreated with the same name

2021-07-07 Thread GitBox
jolshan commented on a change in pull request #10952: URL: https://github.com/apache/kafka/pull/10952#discussion_r665654598 ## File path: clients/src/main/java/org/apache/kafka/clients/MetadataCache.java ## @@ -93,6 +104,14 @@ private MetadataCache(String clusterId, re

[GitHub] [kafka] cmccabe commented on pull request #10992: MINOR: Remove nullable from addingReplicas and removingReplicas

2021-07-07 Thread GitBox
cmccabe commented on pull request #10992: URL: https://github.com/apache/kafka/pull/10992#issuecomment-875898150 Thanks, @mumrah ! Can you use `Replicas.EMPTY` instead of `new int[0]`? It saves an allocation. LGTM after that -- This is an automated message from the Apache Gi

[GitHub] [kafka] cmccabe edited a comment on pull request #10992: MINOR: Remove nullable from addingReplicas and removingReplicas

2021-07-07 Thread GitBox
cmccabe edited a comment on pull request #10992: URL: https://github.com/apache/kafka/pull/10992#issuecomment-875898150 Thanks, @mumrah ! Can you use `Replicas.NONE` instead of `new int[0]`? It saves an allocation. LGTM after that -- This is an automated message from the Apa

[jira] [Commented] (KAFKA-13028) AbstractConfig should allow config provider configuration to use variables referencing other config providers earlier in the list

2021-07-07 Thread Shiva Mogili (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376827#comment-17376827 ] Shiva Mogili commented on KAFKA-13028: -- Thanks [~rhauch], I think this will be quit

[GitHub] [kafka] hachikuji commented on a change in pull request #10794: KAFKA-12677: return not_controller error in envelope response itself

2021-07-07 Thread GitBox
hachikuji commented on a change in pull request #10794: URL: https://github.com/apache/kafka/pull/10794#discussion_r665698647 ## File path: clients/src/main/java/org/apache/kafka/common/requests/ApiError.java ## @@ -36,10 +37,16 @@ private final String message; publ

[GitHub] [kafka] hachikuji commented on a change in pull request #10794: KAFKA-12677: return not_controller error in envelope response itself

2021-07-07 Thread GitBox
hachikuji commented on a change in pull request #10794: URL: https://github.com/apache/kafka/pull/10794#discussion_r665696909 ## File path: core/src/main/scala/kafka/network/RequestChannel.scala ## @@ -124,8 +124,15 @@ object RequestChannel extends Logging { def buildRespo

[GitHub] [kafka] hachikuji commented on pull request #10909: KAFKA-12158: Better return type of RaftClient.scheduleAppend

2021-07-07 Thread GitBox
hachikuji commented on pull request #10909: URL: https://github.com/apache/kafka/pull/10909#issuecomment-875928094 cc @jsancio -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [kafka] ableegoldman commented on a change in pull request #10943: Fix verification of version probing

2021-07-07 Thread GitBox
ableegoldman commented on a change in pull request #10943: URL: https://github.com/apache/kafka/pull/10943#discussion_r665706575 ## File path: tests/kafkatest/tests/streams/streams_upgrade_test.py ## @@ -474,8 +474,9 @@ def do_rolling_bounce(self, processor, counter, current_g

[GitHub] [kafka] ableegoldman commented on a change in pull request #10988: [KAFKA-9559] add docs for changing default serde to null

2021-07-07 Thread GitBox
ableegoldman commented on a change in pull request #10988: URL: https://github.com/apache/kafka/pull/10988#discussion_r665708080 ## File path: docs/streams/developer-guide/config-streams.html ## @@ -549,7 +551,7 @@ acceptable.recovery.lag default.key.serde

[GitHub] [kafka] hachikuji commented on a change in pull request #10935: KAFKA-13003: In kraft mode also advertise configured advertised port instead of socket port

2021-07-07 Thread GitBox
hachikuji commented on a change in pull request #10935: URL: https://github.com/apache/kafka/pull/10935#discussion_r665713457 ## File path: core/src/test/scala/integration/kafka/server/RaftClusterTest.scala ## @@ -313,4 +318,94 @@ class RaftClusterTest { cluster.close()

[jira] [Resolved] (KAFKA-8410) Strengthen the types of Processors, at least in the DSL, maybe in the PAPI as well

2021-07-07 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler resolved KAFKA-8410. - Resolution: Fixed > Strengthen the types of Processors, at least in the DSL, maybe in the PAPI as

[GitHub] [kafka] hachikuji commented on pull request #10986: KAFKA-12983: reset needsJoinPrepare flag before rejoining the group

2021-07-07 Thread GitBox
hachikuji commented on pull request #10986: URL: https://github.com/apache/kafka/pull/10986#issuecomment-875956460 @ableegoldman Thanks for the patch. I think the original idea behind the implementation was to ensure that each rebalance triggered only one call to `onPartitionsRevoked`. It

[GitHub] [kafka] hachikuji edited a comment on pull request #10986: KAFKA-12983: reset needsJoinPrepare flag before rejoining the group

2021-07-07 Thread GitBox
hachikuji edited a comment on pull request #10986: URL: https://github.com/apache/kafka/pull/10986#issuecomment-875956460 @ableegoldman Thanks for the patch. I think the original idea behind the implementation was to ensure that each rebalance triggered only one call to `onPartitionsRevoke

[GitHub] [kafka] hachikuji commented on a change in pull request #10914: [KAKFA-8522] Streamline tombstone and transaction marker removal

2021-07-07 Thread GitBox
hachikuji commented on a change in pull request #10914: URL: https://github.com/apache/kafka/pull/10914#discussion_r665730032 ## File path: clients/src/main/java/org/apache/kafka/common/record/DefaultRecordBatch.java ## @@ -90,11 +90,15 @@ * by the broker and is preserved af

[GitHub] [kafka] hachikuji commented on a change in pull request #10914: [KAKFA-8522] Streamline tombstone and transaction marker removal

2021-07-07 Thread GitBox
hachikuji commented on a change in pull request #10914: URL: https://github.com/apache/kafka/pull/10914#discussion_r665735408 ## File path: clients/src/main/java/org/apache/kafka/common/record/DefaultRecordBatch.java ## @@ -156,13 +161,27 @@ public void ensureValid() { }

[GitHub] [kafka] vvcephei opened a new pull request #10994: KAFKA-8410: Update the docs to reference the new PAPI

2021-07-07 Thread GitBox
vvcephei opened a new pull request #10994: URL: https://github.com/apache/kafka/pull/10994 Since the old Processor API is now deprecated, we need to update the documentation to steer people to the new API. ### Committer Checklist (excluded from commit message) - [ ] Verify desig

[GitHub] [kafka] vvcephei commented on pull request #10994: KAFKA-8410: Update the docs to reference the new PAPI

2021-07-07 Thread GitBox
vvcephei commented on pull request #10994: URL: https://github.com/apache/kafka/pull/10994#issuecomment-875972075 Here are the rendered docs for the reviewers: ![dsl-api](https://user-images.githubusercontent.com/832787/124835667-4e0bcb80-df47-11eb-837a-a3f3537223cf.png) ![pr

[jira] [Commented] (KAFKA-12980) Allow consumers to return from poll when position advances due to aborted transactions

2021-07-07 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376870#comment-17376870 ] Jason Gustafson commented on KAFKA-12980: - [~ChrisEgerton] I do not think it req

[GitHub] [kafka] cmccabe merged pull request #10992: MINOR: Remove nullable from addingReplicas and removingReplicas

2021-07-07 Thread GitBox
cmccabe merged pull request #10992: URL: https://github.com/apache/kafka/pull/10992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[GitHub] [kafka] ableegoldman commented on a change in pull request #10985: KAFKA-12984: make AbstractStickyAssignor resilient to invalid input, utilize generation in cooperative, and fix assignment b

2021-07-07 Thread GitBox
ableegoldman commented on a change in pull request #10985: URL: https://github.com/apache/kafka/pull/10985#discussion_r665750661 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/CooperativeStickyAssignor.java ## @@ -53,9 +56,34 @@ public String name() {

[GitHub] [kafka] vvcephei commented on a change in pull request #10994: KAFKA-8410: Update the docs to reference the new PAPI

2021-07-07 Thread GitBox
vvcephei commented on a change in pull request #10994: URL: https://github.com/apache/kafka/pull/10994#discussion_r665744745 ## File path: docs/streams/developer-guide/processor-api.html ## @@ -86,12 +86,48 @@ Overviewclose() method. Note that Kafka Streams may re-use a single

[jira] [Commented] (KAFKA-7458) Avoid enforced processing during bootstrap phase

2021-07-07 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376886#comment-17376886 ] John Roesler commented on KAFKA-7458: - Hello again, all, this issue should be resolve

[jira] [Resolved] (KAFKA-7458) Avoid enforced processing during bootstrap phase

2021-07-07 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler resolved KAFKA-7458. - Resolution: Fixed > Avoid enforced processing during bootstrap phase > --

[jira] [Updated] (KAFKA-7458) Avoid enforced processing during bootstrap phase

2021-07-07 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-7458: Fix Version/s: 3.0.0 > Avoid enforced processing during bootstrap phase > -

[jira] [Assigned] (KAFKA-7760) Add broker configuration to set minimum value for segment.bytes and segment.ms

2021-07-07 Thread Badai Aqrandista (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Badai Aqrandista reassigned KAFKA-7760: --- Assignee: Badai Aqrandista (was: Dulvin Witharane) > Add broker configuration to se

[GitHub] [kafka] junrao merged pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-07-07 Thread GitBox
junrao merged pull request #9944: URL: https://github.com/apache/kafka/pull/9944 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@

[jira] [Resolved] (KAFKA-10580) Add topic ID support to Fetch request

2021-07-07 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-10580. - Fix Version/s: 3.1.0 Resolution: Fixed merged the PR to trunk. > Add topic ID support to Fetch r

  1   2   >