jolshan commented on a change in pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#discussion_r665476219
##########
File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java
##########
@@ -303,7 +303,33 @@ default DescribeTopicsResult
describeTopics(Collection<String> topicNames) {
* @param options The options to use when describing the topic.
* @return The DescribeTopicsResult.
*/
- DescribeTopicsResult describeTopics(Collection<String> topicNames,
DescribeTopicsOptions options);
+ default DescribeTopicsResult describeTopics(Collection<String> topicNames,
DescribeTopicsOptions options) {
+ return describeTopics(TopicCollection.ofTopicNames(topicNames),
options);
+ }
+
+ /**
+ * This is a convenience method for {@link
#describeTopics(TopicCollection, DescribeTopicsOptions)}
+ * with default options. See the overload for more details.
+ * <p>
+ * When using topic IDs, this operation is supported by brokers with
version 3.0.0 or higher.
+ *
+ * @param topics The topics to delete.
+ * @return The DescribeTopicsResult.
+ */
+ default DescribeTopicsResult describeTopics(TopicCollection topics) {
+ return describeTopics(topics, new DescribeTopicsOptions());
+ }
+
+ /**
+ * describe a batch of topics.
+ *
+ * When using topic IDs, this operation is supported by brokers with
version 3.0.0 or higher.
Review comment:
Since we are past the feature freeze date, I think this will need to be
3.1 now. Same above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
