[GitHub] [kafka] dajac merged pull request #10858: KAFKA-12926: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.sh

dajac merged pull request #10858: URL: https://github.com/apache/kafka/pull/10858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] mjsax commented on a change in pull request #10917: KAFKA-10847: improve throughput of stream-stream join with spurious left/outer join fix

mjsax commented on a change in pull request #10917: URL: https://github.com/apache/kafka/pull/10917#discussion_r660334734 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -186,12 +190,17 @@ public void process(final K

[GitHub] [kafka] dajac commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

dajac commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r660334702 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/AdminApiDriver.java ## @@ -250,6 +252,13 @@ public void onFailure(

[GitHub] [kafka] dajac commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

dajac commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r660334836 ## File path: clients/src/main/java/org/apache/kafka/common/errors/NoBatchedFindCoordinatorsException.java ## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apac

[GitHub] [kafka] mjsax commented on a change in pull request #10917: KAFKA-10847: improve throughput of stream-stream join with spurious left/outer join fix

mjsax commented on a change in pull request #10917: URL: https://github.com/apache/kafka/pull/10917#discussion_r660335277 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -186,12 +190,17 @@ public void process(final K

[jira] [Created] (KAFKA-13009) Metrics recorder is re-initialised with different task

Victor van den Hoven created KAFKA-13009: Summary: Metrics recorder is re-initialised with different task Key: KAFKA-13009 URL: https://issues.apache.org/jira/browse/KAFKA-13009 Project: Kafka

[jira] [Updated] (KAFKA-13009) Metrics recorder is re-initialised with different task

[ https://issues.apache.org/jira/browse/KAFKA-13009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Victor van den Hoven updated KAFKA-13009: - Description: When starting my Kafka Stream application, I get in the Logs:   [

[jira] [Updated] (KAFKA-13009) Metrics recorder is re-initialised with different task

[ https://issues.apache.org/jira/browse/KAFKA-13009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Victor van den Hoven updated KAFKA-13009: - Description: When starting my Kafka Stream application, I get in the Logs:   [

[jira] [Commented] (KAFKA-2729) Cached zkVersion not equal to that in zookeeper, broker not recovering.

[ https://issues.apache.org/jira/browse/KAFKA-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17371202#comment-17371202 ] l0co commented on KAFKA-2729: - [~junrao] thanks for the reply. Unfortunately from preserved l

[GitHub] [kafka] rajinisivaram commented on pull request #10930: KAFKA-12996; Return OFFSET_OUT_OF_RANGE for fetchOffset < startOffset even for diverging epochs

rajinisivaram commented on pull request #10930: URL: https://github.com/apache/kafka/pull/10930#issuecomment-870376743 @guozhangwang Yes, that's correct. Will rerun the build. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] OmniaGM opened a new pull request #10937: [WIP] KAFKA-10587 Rename kafka-mirror-maker CLI command line arguments for KIP-629

OmniaGM opened a new pull request #10937: URL: https://github.com/apache/kafka/pull/10937 [KAFKA-10587](https://issues.apache.org/jira/browse/KAFKA-10587) Rename kafka-mirror-maker CLI command line arguments for KIP-629 Remove whitelist term from kafka-mirror-maker cli command by renamin

[GitHub] [kafka] eshizhan opened a new pull request #10938: Fix StringSerializer could not be found when it not in ContextClassLoader

eshizhan opened a new pull request #10938: URL: https://github.com/apache/kafka/pull/10938 ref: https://stackoverflow.com/q/37363119/1120863 https://github.com/holgerbrandl/kscript/issues/131 `org.apache.kafka.common.serialization.StringSerializer` may be not in ContextClass

[jira] [Created] (KAFKA-13010) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation()

Bruno Cadonna created KAFKA-13010: - Summary: Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation() Key: KAFKA-13010 URL: https://issues.apache.

[jira] [Updated] (KAFKA-13010) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectCommittedOffsetInformation()

[ https://issues.apache.org/jira/browse/KAFKA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-13010: -- Labels: flaky-test (was: ) > Flaky test > org.apache.kafka.streams.integration.TaskMetadataI

[GitHub] [kafka] rajinisivaram commented on pull request #10930: KAFKA-12996; Return OFFSET_OUT_OF_RANGE for fetchOffset < startOffset even for diverging epochs

rajinisivaram commented on pull request #10930: URL: https://github.com/apache/kafka/pull/10930#issuecomment-870475481 Test failures are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kafka] cadonna commented on pull request #10920: MINOR: Improve test of log messages for dropped records

cadonna commented on pull request #10920: URL: https://github.com/apache/kafka/pull/10920#issuecomment-870493864 Test failures are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] cadonna merged pull request #10920: MINOR: Improve test of log messages for dropped records

cadonna merged pull request #10920: URL: https://github.com/apache/kafka/pull/10920 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[GitHub] [kafka] cadonna opened a new pull request #10939: Avoid increasing app ID when test is executed multiple times

cadonna opened a new pull request #10939: URL: https://github.com/apache/kafka/pull/10939 The integration test TaskMetadataIntegrationTest will increase the length of the app ID when its test methods are called multiple times in one execution. This is for example the case if you rep

[GitHub] [kafka] cadonna commented on a change in pull request #10939: Avoid increasing app ID when test is executed multiple times

cadonna commented on a change in pull request #10939: URL: https://github.com/apache/kafka/pull/10939#discussion_r660542891 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/TaskMetadataIntegrationTest.java ## @@ -77,15 +77,16 @@ public static void close

[GitHub] [kafka] cadonna commented on pull request #10939: Avoid increasing app ID when test is executed multiple times

cadonna commented on pull request #10939: URL: https://github.com/apache/kafka/pull/10939#issuecomment-870529462 Call for review: @wcarlson5 @mjsax @guozhangwang @abbccdda -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] showuon closed pull request #10816: [WIP] MINOR: acl tests

showuon closed pull request #10816: URL: https://github.com/apache/kafka/pull/10816 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[GitHub] [kafka] showuon commented on a change in pull request #10811: KAFKA-12598: remove zookeeper support on configCommand except security config

showuon commented on a change in pull request #10811: URL: https://github.com/apache/kafka/pull/10811#discussion_r660562020 ## File path: core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala ## @@ -60,6 +60,30 @@ class ConfigCommandTest extends ZooKeeperTestHarness with

[GitHub] [kafka] showuon commented on a change in pull request #10811: KAFKA-12598: remove zookeeper support on configCommand except security config

showuon commented on a change in pull request #10811: URL: https://github.com/apache/kafka/pull/10811#discussion_r660562175 ## File path: core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala ## @@ -60,6 +60,30 @@ class ConfigCommandTest extends ZooKeeperTestHarness with

[GitHub] [kafka] ijuma commented on a change in pull request #10838: MINOR: small fix and clean up for DynamicConfigManager

ijuma commented on a change in pull request #10838: URL: https://github.com/apache/kafka/pull/10838#discussion_r660562587 ## File path: core/src/main/scala/kafka/server/DynamicConfigManager.scala ## @@ -154,7 +156,7 @@ class DynamicConfigManager(private val zkClient: KafkaZkCl

[GitHub] [kafka] showuon commented on a change in pull request #10838: MINOR: small fix and clean up for DynamicConfigManager

showuon commented on a change in pull request #10838: URL: https://github.com/apache/kafka/pull/10838#discussion_r660557813 ## File path: core/src/main/scala/kafka/server/DynamicConfigManager.scala ## @@ -86,25 +88,30 @@ object ConfigEntityName { */ class DynamicConfigManage

[GitHub] [kafka] IgnacioAcunaF commented on pull request #10858: KAFKA-12926: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.sh

IgnacioAcunaF commented on pull request #10858: URL: https://github.com/apache/kafka/pull/10858#issuecomment-870568479 Thanks @dajac for review and comments. Learnt a lot :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] cmccabe commented on a change in pull request #10931: KAFKA-12998: Implement broker-side KRaft snapshots (WIP)

cmccabe commented on a change in pull request #10931: URL: https://github.com/apache/kafka/pull/10931#discussion_r659940260 ## File path: metadata/src/main/java/org/apache/kafka/image/TopicsDelta.java ## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] stan-confluent commented on a change in pull request #10915: Enable connecting VS Code remote debugger

stan-confluent commented on a change in pull request #10915: URL: https://github.com/apache/kafka/pull/10915#discussion_r660083163 ## File path: tests/README.md ## @@ -51,6 +51,40 @@ bash tests/docker/ducker-ak up -j 'openjdk:11'; tests/docker/run_tests.sh ``` REBUILD="t" ba

[GitHub] [kafka] jolshan commented on a change in pull request #10892: [WIP] New Admin API for deleteTopics

jolshan commented on a change in pull request #10892: URL: https://github.com/apache/kafka/pull/10892#discussion_r659995458 ## File path: clients/src/main/java/org/apache/kafka/common/TopicCollection.java ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [kafka] ryannedolan commented on pull request #10629: BlockingConnectorTest improvements to verify Connectors and Tasks are successfully deleted

ryannedolan commented on pull request #10629: URL: https://github.com/apache/kafka/pull/10629#issuecomment-869823002 Good point @C0urante I hadn't considered how expensive these tests can be. I'll see if I can collapse them into fewer tests. thanks. -- This is an automated message from t

[GitHub] [kafka] ijuma commented on a change in pull request #10811: KAFKA-12598: remove zookeeper support on configCommand except security config

ijuma commented on a change in pull request #10811: URL: https://github.com/apache/kafka/pull/10811#discussion_r659800702 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -68,7 +68,7 @@ object ConfigCommand extends Config { val BrokerDefaultEntityName

[GitHub] [kafka] C0urante commented on a change in pull request #10629: BlockingConnectorTest improvements to verify Connectors and Tasks are successfully deleted

C0urante commented on a change in pull request #10629: URL: https://github.com/apache/kafka/pull/10629#discussion_r659903390 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedConnectClusterAssertions.java ## @@ -392,6 +392,48 @@ protect

[GitHub] [kafka] mjsax commented on pull request #10894: KAFKA-12951: restore must terminate for tx global topic

mjsax commented on pull request #10894: URL: https://github.com/apache/kafka/pull/10894#issuecomment-870089809 Merged to `trunk` and cherry-picked to `2.8` and `2.7` branches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [kafka] mimaison commented on pull request #10652: KAFKA-9726 IdentityReplicationPolicy

mimaison commented on pull request #10652: URL: https://github.com/apache/kafka/pull/10652#issuecomment-869893715 Let's put a line in the changelog now so we're sure it's included in the release notes. I'm happy to merge once this is done. I agree the documentation can come later.

[GitHub] [kafka] omkreddy commented on pull request #10816: [WIP] MINOR: acl tests

omkreddy commented on pull request #10816: URL: https://github.com/apache/kafka/pull/10816#issuecomment-869696822 @showuon Can you close this PR, If it is not required? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [kafka] rajinisivaram commented on pull request #10930: KAFKA-12996; Return OFFSET_OUT_OF_RANGE for fetchOffset < startOffset even for diverging epochs

rajinisivaram commented on pull request #10930: URL: https://github.com/apache/kafka/pull/10930#issuecomment-869929738 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [kafka] ijuma commented on a change in pull request #10838: MINOR: small fix and clean up for DynamicConfigManager

ijuma commented on a change in pull request #10838: URL: https://github.com/apache/kafka/pull/10838#discussion_r659764053 ## File path: core/src/main/scala/kafka/server/DynamicConfigManager.scala ## @@ -86,25 +88,30 @@ object ConfigEntityName { */ class DynamicConfigManager(

[GitHub] [kafka] mjsax merged pull request #10894: KAFKA-12951: restore must terminate for tx global topic

mjsax merged pull request #10894: URL: https://github.com/apache/kafka/pull/10894 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] jsancio commented on a change in pull request #10913: KAFKA-12631; Implement `resign` API in `KafkaRaftClient`

jsancio commented on a change in pull request #10913: URL: https://github.com/apache/kafka/pull/10913#discussion_r660023057 ## File path: raft/src/main/java/org/apache/kafka/raft/QuorumState.java ## @@ -514,6 +514,16 @@ public UnattachedState unattachedStateOrThrow() {

[GitHub] [kafka] mdedetrich commented on pull request #10652: KAFKA-9726 IdentityReplicationPolicy

mdedetrich commented on pull request #10652: URL: https://github.com/apache/kafka/pull/10652#issuecomment-869693584 Is there anything left on this PR to be merged (apart from the changelog which is a nice to have) -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] niket-goel commented on a change in pull request #10899: KAFKA-12952 Adding Delimiters to Metadata Snapshot

niket-goel commented on a change in pull request #10899: URL: https://github.com/apache/kafka/pull/10899#discussion_r660133212 ## File path: clients/src/main/java/org/apache/kafka/common/record/ControlRecordUtils.java ## @@ -26,19 +28,49 @@ */ public class ControlRecordUtil

[GitHub] [kafka] junrao commented on a change in pull request #10763: KAFKA-12520: Ensure log loading does not truncate producer state unless required

junrao commented on a change in pull request #10763: URL: https://github.com/apache/kafka/pull/10763#discussion_r659914342 ## File path: core/src/main/scala/kafka/log/LogLoader.scala ## @@ -90,11 +90,63 @@ object LogLoader extends Logging { *

[GitHub] [kafka] tvainika commented on pull request #10277: KAFKA-9914: Fix replication cycle detection

tvainika commented on pull request #10277: URL: https://github.com/apache/kafka/pull/10277#issuecomment-869712376 @mimaison Have you had a time to look this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [kafka] jsancio commented on a change in pull request #10899: KAFKA-12952 Adding Delimiters to Metadata Snapshot

jsancio commented on a change in pull request #10899: URL: https://github.com/apache/kafka/pull/10899#discussion_r660032373 ## File path: clients/src/main/resources/common/message/SnapshotHeaderRecord.json ## @@ -0,0 +1,27 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] mjsax merged pull request #10893: KAFKA-12909: add missing tests

mjsax merged pull request #10893: URL: https://github.com/apache/kafka/pull/10893 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] jacky1193610322 commented on a change in pull request #10931: KAFKA-12998: Implement broker-side KRaft snapshots (WIP)

jacky1193610322 commented on a change in pull request #10931: URL: https://github.com/apache/kafka/pull/10931#discussion_r660054798 ## File path: metadata/src/main/java/org/apache/kafka/image/TopicsDelta.java ## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [kafka] jlprat commented on pull request #10934: [DO NOT MERGE] Scala3 test

jlprat commented on pull request #10934: URL: https://github.com/apache/kafka/pull/10934#issuecomment-869729338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [kafka] ijuma commented on a change in pull request #10935: KAFKA-13003: In kraft mode also advertise configured advertised port instead of socket port

ijuma commented on a change in pull request #10935: URL: https://github.com/apache/kafka/pull/10935#discussion_r659855125 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -283,7 +283,7 @@ class BrokerServer( networkListeners.add(new Listener().

[GitHub] [kafka] ijuma commented on a change in pull request #10934: [DO NOT MERGE] Scala3 test

ijuma commented on a change in pull request #10934: URL: https://github.com/apache/kafka/pull/10934#discussion_r659829361 ## File path: gradle/dependencies.gradle ## @@ -179,10 +183,10 @@ libs += [ powermockEasymock: "org.powermock:powermock-api-easymock:$versions.powermock

[GitHub] [kafka] rajinisivaram commented on pull request #10811: KAFKA-12598: remove zookeeper support on configCommand except security config

rajinisivaram commented on pull request #10811: URL: https://github.com/apache/kafka/pull/10811#issuecomment-869699660 @ijuma Yes, those two cases would still require ZooKeeper for bootstrapping broker credentials/broker configs. I think there was some discussion around bootstrapping cases

[GitHub] [kafka] ccding commented on a change in pull request #10763: KAFKA-12520: Ensure log loading does not truncate producer state unless required

ccding commented on a change in pull request #10763: URL: https://github.com/apache/kafka/pull/10763#discussion_r660039117 ## File path: core/src/main/scala/kafka/log/LogLoader.scala ## @@ -192,20 +230,10 @@ object LogLoader extends Logging { debug(s"${params.logIdenti

[GitHub] [kafka] jlprat commented on a change in pull request #10934: [DO NOT MERGE] Scala3 test

jlprat commented on a change in pull request #10934: URL: https://github.com/apache/kafka/pull/10934#discussion_r659831262 ## File path: gradle/dependencies.gradle ## @@ -179,10 +183,10 @@ libs += [ powermockEasymock: "org.powermock:powermock-api-easymock:$versions.powermoc

[GitHub] [kafka] ijuma commented on pull request #10760: KAFKA-12541; Extend ListOffset to fetch offset with max timestamp (KIP-734)

ijuma commented on pull request #10760: URL: https://github.com/apache/kafka/pull/10760#issuecomment-869730993 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [kafka] mumrah commented on a change in pull request #10913: KAFKA-12631; Implement `resign` API in `KafkaRaftClient`

mumrah commented on a change in pull request #10913: URL: https://github.com/apache/kafka/pull/10913#discussion_r659989672 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -2250,7 +2250,42 @@ private Long append(int epoch, List records, boolean

[GitHub] [kafka] mdedetrich edited a comment on pull request #10652: KAFKA-9726 IdentityReplicationPolicy

mdedetrich edited a comment on pull request #10652: URL: https://github.com/apache/kafka/pull/10652#issuecomment-869693584 Is there anything left on this PR to be merged (apart from the changelog which is a nice to have)? -- This is an automated message from the Apache Git Service. To re

[GitHub] [kafka] omkreddy commented on a change in pull request #10915: Enable connecting VS Code remote debugger

omkreddy commented on a change in pull request #10915: URL: https://github.com/apache/kafka/pull/10915#discussion_r659807251 ## File path: tests/README.md ## @@ -51,6 +51,40 @@ bash tests/docker/ducker-ak up -j 'openjdk:11'; tests/docker/run_tests.sh ``` REBUILD="t" bash tes

[GitHub] [kafka] PhilHardwick commented on pull request #10921: MINOR: Ensure queryable store providers is up to date after adding stream thread

PhilHardwick commented on pull request #10921: URL: https://github.com/apache/kafka/pull/10921#issuecomment-869736821 Please could @ableegoldman or @wcarlson5 take a look, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [kafka] showuon commented on pull request #10838: MINOR: small fix and clean up for DynamicConfigManager

showuon commented on pull request #10838: URL: https://github.com/apache/kafka/pull/10838#issuecomment-869655003 @ijuma , please help review. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] dajac commented on pull request #10760: KAFKA-12541; Extend ListOffset to fetch offset with max timestamp (KIP-734)

dajac commented on pull request #10760: URL: https://github.com/apache/kafka/pull/10760#issuecomment-869749901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [kafka] ijuma commented on pull request #10934: [DO NOT MERGE] Scala3 test

ijuma commented on pull request #10934: URL: https://github.com/apache/kafka/pull/10934#issuecomment-869727682 Thanks for the PR. If I understand correctly, this assumes we would drop Scala 2.12 compatibility. That makes sense, but it does mean waiting quite a while (12+ months). -- Thi

[GitHub] [kafka] guozhangwang commented on pull request #10930: KAFKA-12996; Return OFFSET_OUT_OF_RANGE for fetchOffset < startOffset even for diverging epochs

guozhangwang commented on pull request #10930: URL: https://github.com/apache/kafka/pull/10930#issuecomment-869764069 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [kafka] jsancio commented on a change in pull request #10932: KAFKA-12958: add an invariant that notified leaders are never asked t…

jsancio commented on a change in pull request #10932: URL: https://github.com/apache/kafka/pull/10932#discussion_r660140438 ## File path: raft/src/main/java/org/apache/kafka/raft/ReplicatedCounter.java ## @@ -38,6 +38,9 @@ private OptionalInt claimedEpoch = OptionalInt.emp

[GitHub] [kafka] hachikuji commented on a change in pull request #10913: KAFKA-12631; Implement `resign` API in `KafkaRaftClient`

hachikuji commented on a change in pull request #10913: URL: https://github.com/apache/kafka/pull/10913#discussion_r660007360 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1914,8 +1915,7 @@ private long pollLeader(long currentTimeMs) {

[GitHub] [kafka] ryannedolan commented on pull request #10652: KAFKA-9726 IdentityReplicationPolicy

ryannedolan commented on pull request #10652: URL: https://github.com/apache/kafka/pull/10652#issuecomment-869824087 I think changelog and documentation updates can come after this is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r660061129 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -231,20 +239,31 @@ class FetchSession(val id: Int, def metadata: JFetchMetadata =

[GitHub] [kafka] junrao commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

junrao commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r660016282 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -193,18 +197,22 @@ class CachedPartition(val topic: String, * Each fetch session i

[GitHub] [kafka] guozhangwang commented on a change in pull request #10917: KAFKA-10847: improve throughput of stream-stream join with spurious left/outer join fix

guozhangwang commented on a change in pull request #10917: URL: https://github.com/apache/kafka/pull/10917#discussion_r659908813 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -186,12 +190,17 @@ public void process(

[GitHub] [kafka] ijuma commented on pull request #10811: KAFKA-12598: remove zookeeper support on configCommand except security config

ijuma commented on pull request #10811: URL: https://github.com/apache/kafka/pull/10811#issuecomment-869697363 @rajinisivaram @rondagostino The two cases mentioned in the PR still require --zookeeper, right? -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [kafka] hachikuji merged pull request #10923: KAFKA-12976: Remove UNSUPPORTED_VERSION error from delete topics call

hachikuji merged pull request #10923: URL: https://github.com/apache/kafka/pull/10923 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubsc

[GitHub] [kafka] ueisele commented on a change in pull request #10935: KAFKA-13003: In kraft mode also advertise configured advertised port instead of socket port

ueisele commented on a change in pull request #10935: URL: https://github.com/apache/kafka/pull/10935#discussion_r660063967 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -283,7 +283,7 @@ class BrokerServer( networkListeners.add(new Listener().

[GitHub] [kafka] cadonna merged pull request #10920: MINOR: Improve test of log messages for dropped records

cadonna merged pull request #10920: URL: https://github.com/apache/kafka/pull/10920 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[GitHub] [kafka] mjsax merged pull request #10824: KAFKA-12718: SessionWindows are closed too early

mjsax merged pull request #10824: URL: https://github.com/apache/kafka/pull/10824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] dajac commented on a change in pull request #10936: KAFKA-13002 Fix for non max timestamp degrade case

dajac commented on a change in pull request #10936: URL: https://github.com/apache/kafka/pull/10936#discussion_r660318325 ## File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java ## @@ -4346,6 +4346,51 @@ public void testListOffsetsUnsupport

[GitHub] [kafka] showuon commented on a change in pull request #10838: MINOR: small fix and clean up for DynamicConfigManager

showuon commented on a change in pull request #10838: URL: https://github.com/apache/kafka/pull/10838#discussion_r660557813 ## File path: core/src/main/scala/kafka/server/DynamicConfigManager.scala ## @@ -86,25 +88,30 @@ object ConfigEntityName { */ class DynamicConfigManage

[GitHub] [kafka] cadonna commented on a change in pull request #10939: Avoid increasing app ID when test is executed multiple times

cadonna commented on a change in pull request #10939: URL: https://github.com/apache/kafka/pull/10939#discussion_r660542891 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/TaskMetadataIntegrationTest.java ## @@ -77,15 +77,16 @@ public static void close

[GitHub] [kafka] guozhangwang commented on pull request #10798: KAFKA-9168: Adding direct byte buffer support to rocksdb state store

guozhangwang commented on pull request #10798: URL: https://github.com/apache/kafka/pull/10798#issuecomment-870174294 You were referring to this commit https://github.com/apache/kafka/pull/10798/commits/68a947c0eb6a5cc4bdde24083c83f4638e708edb as for the tweaks right? BTW it's bit i

[GitHub] [kafka] mjsax commented on pull request #10824: KAFKA-12718: SessionWindows are closed too early

mjsax commented on pull request #10824: URL: https://github.com/apache/kafka/pull/10824#issuecomment-870094158 Thanks for your PR! Merged to `trunk`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] dajac merged pull request #10858: KAFKA-12926: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.sh

dajac merged pull request #10858: URL: https://github.com/apache/kafka/pull/10858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[jira] [Updated] (KAFKA-13001) UnitTest Failing in Kafka master branch

[ https://issues.apache.org/jira/browse/KAFKA-13001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srijoni Biswas updated KAFKA-13001: --- Summary: UnitTest Failing in Kafka master branch (was: UnitTest Failing ) > UnitTest Failin

[GitHub] [kafka] showuon commented on a change in pull request #10811: KAFKA-12598: remove zookeeper support on configCommand except security config

showuon commented on a change in pull request #10811: URL: https://github.com/apache/kafka/pull/10811#discussion_r660562020 ## File path: core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala ## @@ -60,6 +60,30 @@ class ConfigCommandTest extends ZooKeeperTestHarness with

[GitHub] [kafka] hachikuji commented on a change in pull request #10892: [WIP] New Admin API for deleteTopics

hachikuji commented on a change in pull request #10892: URL: https://github.com/apache/kafka/pull/10892#discussion_r660160050 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DeleteTopicsResult.java ## @@ -30,24 +31,62 @@ */ @InterfaceStability.Evolving p

[GitHub] [kafka] showuon closed pull request #10816: [WIP] MINOR: acl tests

showuon closed pull request #10816: URL: https://github.com/apache/kafka/pull/10816 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[GitHub] [kafka] mjsax commented on a change in pull request #10917: KAFKA-10847: improve throughput of stream-stream join with spurious left/outer join fix

mjsax commented on a change in pull request #10917: URL: https://github.com/apache/kafka/pull/10917#discussion_r660334734 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -186,12 +190,17 @@ public void process(final K

[GitHub] [kafka] cadonna commented on pull request #10920: MINOR: Improve test of log messages for dropped records

cadonna commented on pull request #10920: URL: https://github.com/apache/kafka/pull/10920#issuecomment-870493864 Test failures are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] cadonna commented on pull request #10939: Avoid increasing app ID when test is executed multiple times

cadonna commented on pull request #10939: URL: https://github.com/apache/kafka/pull/10939#issuecomment-870529462 Call for review: @wcarlson5 @mjsax @guozhangwang @abbccdda -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] dajac commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

dajac commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r660334702 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/AdminApiDriver.java ## @@ -250,6 +252,13 @@ public void onFailure(

[GitHub] [kafka] cmccabe commented on a change in pull request #10899: KAFKA-12952 Adding Delimiters to Metadata Snapshot

cmccabe commented on a change in pull request #10899: URL: https://github.com/apache/kafka/pull/10899#discussion_r660199695 ## File path: clients/src/main/resources/common/message/MetadataSnapshotFooterRecord.json ## @@ -0,0 +1,25 @@ +// Licensed to the Apache Software Foundat

[GitHub] [kafka] kkonstantine commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kkonstantine commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r660275673 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java ## @@ -357,6 +367,62 @@ public void validateConnect

[GitHub] [kafka] IgnacioAcunaF commented on pull request #10858: KAFKA-12926: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.sh

IgnacioAcunaF commented on pull request #10858: URL: https://github.com/apache/kafka/pull/10858#issuecomment-870107728 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [kafka] hachikuji merged pull request #10913: KAFKA-12631; Implement `resign` API in `KafkaRaftClient`

hachikuji merged pull request #10913: URL: https://github.com/apache/kafka/pull/10913 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubsc

[GitHub] [kafka] showuon commented on a change in pull request #10838: MINOR: small fix and clean up for DynamicConfigManager

showuon commented on a change in pull request #10838: URL: https://github.com/apache/kafka/pull/10838#discussion_r660645680 ## File path: core/src/main/scala/kafka/server/DynamicConfigManager.scala ## @@ -154,7 +156,7 @@ class DynamicConfigManager(private val zkClient: KafkaZk

[GitHub] [kafka] weichuliu closed pull request #7056: KAFKA-8633: Fix Auto Generated Kafka Configuration Docs

weichuliu closed pull request #7056: URL: https://github.com/apache/kafka/pull/7056 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[GitHub] [kafka] IgnacioAcunaF commented on a change in pull request #10858: KAFKA-12926: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.

IgnacioAcunaF commented on a change in pull request #10858: URL: https://github.com/apache/kafka/pull/10858#discussion_r660172772 ## File path: core/src/test/scala/unit/kafka/admin/ConsumerGroupServiceTest.scala ## @@ -62,6 +63,88 @@ class ConsumerGroupServiceTest { verify

[GitHub] [kafka] cmccabe commented on a change in pull request #10931: KAFKA-12998: Implement broker-side KRaft snapshots (WIP)

cmccabe commented on a change in pull request #10931: URL: https://github.com/apache/kafka/pull/10931#discussion_r660743774 ## File path: metadata/src/main/java/org/apache/kafka/image/TopicsDelta.java ## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] guozhangwang merged pull request #10930: KAFKA-12996; Return OFFSET_OUT_OF_RANGE for fetchOffset < startOffset even for diverging epochs

guozhangwang merged pull request #10930: URL: https://github.com/apache/kafka/pull/10930 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[GitHub] [kafka] guozhangwang commented on pull request #10930: KAFKA-12996; Return OFFSET_OUT_OF_RANGE for fetchOffset < startOffset even for diverging epochs

guozhangwang commented on pull request #10930: URL: https://github.com/apache/kafka/pull/10930#issuecomment-870715774 Merged to trunk. Thanks @rajinisivaram ! Should we cherry-pick to older branches too? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] junrao commented on a change in pull request #10763: KAFKA-12520: Ensure log loading does not truncate producer state unless required

junrao commented on a change in pull request #10763: URL: https://github.com/apache/kafka/pull/10763#discussion_r660769175 ## File path: core/src/main/scala/kafka/log/LogLoader.scala ## @@ -192,20 +230,10 @@ object LogLoader extends Logging { debug(s"${params.logIdenti

[GitHub] [kafka] omkreddy closed pull request #10866: [Test ] debug zk acl errors

omkreddy closed pull request #10866: URL: https://github.com/apache/kafka/pull/10866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr

[GitHub] [kafka] zhaohaidao commented on a change in pull request #10932: KAFKA-12958: add an invariant that notified leaders are never asked t…

zhaohaidao commented on a change in pull request #10932: URL: https://github.com/apache/kafka/pull/10932#discussion_r660772174 ## File path: raft/src/main/java/org/apache/kafka/raft/ReplicatedCounter.java ## @@ -157,13 +162,27 @@ public synchronized void handleSnapshot(Snapsho

[GitHub] [kafka] zhaohaidao commented on a change in pull request #10932: KAFKA-12958: add an invariant that notified leaders are never asked t…

zhaohaidao commented on a change in pull request #10932: URL: https://github.com/apache/kafka/pull/10932#discussion_r660772538 ## File path: raft/src/main/java/org/apache/kafka/raft/ReplicatedCounter.java ## @@ -38,6 +38,9 @@ private OptionalInt claimedEpoch = OptionalInt.

  1   2   >