ijuma commented on a change in pull request #10838:
URL: https://github.com/apache/kafka/pull/10838#discussion_r660562587
##########
File path: core/src/main/scala/kafka/server/DynamicConfigManager.scala
##########
@@ -154,7 +156,7 @@ class DynamicConfigManager(private val zkClient:
KafkaZkClient,
}
private val configChangeListener = new
ZkNodeChangeNotificationListener(zkClient,
ConfigEntityChangeNotificationZNode.path,
- ConfigEntityChangeNotificationSequenceZNode.SequenceNumberPrefix,
ConfigChangedNotificationHandler)
+ ConfigEntityChangeNotificationSequenceZNode.SequenceNumberPrefix,
ConfigChangedNotificationHandler, changeExpirationMs, time)
Review comment:
Default arguments are dangerous for things like this, I would remove
them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
