[
https://issues.apache.org/jira/browse/KAFKA-8940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360614#comment-17360614
]
Josep Prat commented on KAFKA-8940:
---
It failed again today:
{code:java}
Build / JDK 1
showuon commented on pull request #10736:
URL: https://github.com/apache/kafka/pull/10736#issuecomment-858384704
Thanks @mjsax ! I'll further investigate it and let you know~
@ableegoldman , since #10803 is already merged into trunk, now the default
session timeout is 45 seconds. I think
satishd commented on a change in pull request #10579:
URL: https://github.com/apache/kafka/pull/10579#discussion_r648927106
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerConfig.java
##
@@ -0,0 +1,197 @
mdedetrich commented on pull request #10839:
URL: https://github.com/apache/kafka/pull/10839#issuecomment-858409809
PR ready for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r648955649
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -1812,37 +1570,39 @@ class Log(@volatile private var _dir: File,
endOffset: Long
): Un
satishd commented on pull request #10733:
URL: https://github.com/apache/kafka/pull/10733#issuecomment-858418575
@junrao @kowshik Gentle reminder to review these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
showuon commented on pull request #10820:
URL: https://github.com/apache/kafka/pull/10820#issuecomment-858424436
@omkreddy @ijuma , the trunk build keeps failing with `InvalidAclException`
at least 1 build group (sometimes 2 or 3 failed) after the fix merged (in build
# 199). I think this
[
https://issues.apache.org/jira/browse/KAFKA-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360656#comment-17360656
]
Francisco Juan commented on KAFKA-8335:
---
We solved the issue by updating to version
kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r648978604
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -1788,17 +1554,9 @@ class Log(@volatile private var _dir: File,
maybeHandleIOException(s"
chia7712 opened a new pull request #10860:
URL: https://github.com/apache/kafka/pull/10860
Kraft already supports `DescribeAcls` (see
5b0c58ed53c420e93957369516f34346580dac95). Hence, the flag
`describe-acls-supported` should be `True` rather than `False`
### Committer Checklist
chia7712 commented on pull request #10860:
URL: https://github.com/apache/kafka/pull/10860#issuecomment-858436731
@rondagostino @ijuma Could you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
[
https://issues.apache.org/jira/browse/KAFKA-10501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360662#comment-17360662
]
Victor Garcia commented on KAFKA-10501:
---
As per this response
https://issues.apac
kowshik commented on pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#issuecomment-858438516
Thanks for the review @junrao! I've addressed your most recent comments in
28bf22af168ca0db76796b5d3cd67a38ed8ed1c2.
--
This is an automated message from the Apache Git Servic
cadonna commented on a change in pull request #10856:
URL: https://github.com/apache/kafka/pull/10856#discussion_r648988189
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java
##
@@ -562,10 +553,6 @@ private String e
dongjinleekr commented on pull request #9414:
URL: https://github.com/apache/kafka/pull/9414#issuecomment-858453218
Rebased onto the latest trunk. cc/ @vvcephei
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
mimaison commented on pull request #10665:
URL: https://github.com/apache/kafka/pull/10665#issuecomment-858466707
@showuon Sorry for the delay, thanks for the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
showuon commented on pull request #10665:
URL: https://github.com/apache/kafka/pull/10665#issuecomment-858472811
@mimaison , thanks for your time to review. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
Dongjin Lee created KAFKA-12928:
---
Summary: Add a check whether the Task's statestore is actually a
directory
Key: KAFKA-12928
URL: https://issues.apache.org/jira/browse/KAFKA-12928
Project: Kafka
mimaison merged pull request #10665:
URL: https://github.com/apache/kafka/pull/10665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
jlprat commented on pull request #10856:
URL: https://github.com/apache/kafka/pull/10856#issuecomment-858471996
Thanks both for the review!
Shall I do something else, or is it ready to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
mjsax opened a new pull request #10861:
URL: https://github.com/apache/kafka/pull/10861
We changed the behavior of left/outer stream-stream join via KAFKA-10847.
To avoid a breaking change during an upgrade, we need to disable this
fix by default.
We only enable the fix if users
dongjinleekr opened a new pull request #10862:
URL: https://github.com/apache/kafka/pull/10862
The first commit shows how to reproduce the problem, and the second commit
is the fix.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
-
dongjinleekr commented on pull request #10862:
URL: https://github.com/apache/kafka/pull/10862#issuecomment-858481552
@ableegoldman Please have a look when you are free. :pray:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
mjsax commented on a change in pull request #10861:
URL: https://github.com/apache/kafka/pull/10861#discussion_r649031614
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/JoinWindows.java
##
@@ -67,7 +67,7 @@
* @see KStream#outerJoin(KStream, ValueJoiner,
cadonna commented on pull request #10856:
URL: https://github.com/apache/kafka/pull/10856#issuecomment-858494872
I restarted the checks since all three builds failed with exit code 1, which
seems to be related to https://issues.apache.org/jira/browse/KAFKA-12892
--
This is an automated m
mjsax commented on pull request #10740:
URL: https://github.com/apache/kafka/pull/10740#issuecomment-858495684
Please consider https://github.com/apache/kafka/pull/10861 that slightly
overlaps with this PR.
--
This is an automated message from the Apache Git Service.
To respond to the me
cadonna commented on pull request #10835:
URL: https://github.com/apache/kafka/pull/10835#issuecomment-858498491
Test failures are unrelated and known to be flaky:
```
Build / JDK 8 and Scala 2.12 /
kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopicsWithManyPartitions
cadonna merged pull request #10835:
URL: https://github.com/apache/kafka/pull/10835
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
satishd commented on a change in pull request #10848:
URL: https://github.com/apache/kafka/pull/10848#discussion_r648768897
##
File path:
storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/LogSegmentData.java
##
@@ -33,31 +34,32 @@
private final Path log
edoardocomar commented on pull request #10649:
URL: https://github.com/apache/kafka/pull/10649#issuecomment-858526433
Hi @rajinisivaram would you be able to take a look ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
wycc commented on a change in pull request #10850:
URL: https://github.com/apache/kafka/pull/10850#discussion_r649082247
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/ProcessorNodeMetricsTest.java
##
@@ -18,87 +18,73 @@
import
[
https://issues.apache.org/jira/browse/KAFKA-12847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360752#comment-17360752
]
Abhijit Mane commented on KAFKA-12847:
--
Thanks [~chia7712] for the explanation. I u
[
https://issues.apache.org/jira/browse/KAFKA-12847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360752#comment-17360752
]
Abhijit Mane edited comment on KAFKA-12847 at 6/10/21, 11:11 AM:
-
[
https://issues.apache.org/jira/browse/KAFKA-12847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360752#comment-17360752
]
Abhijit Mane edited comment on KAFKA-12847 at 6/10/21, 11:12 AM:
-
[
https://issues.apache.org/jira/browse/KAFKA-12847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360767#comment-17360767
]
Chia-Ping Tsai commented on KAFKA-12847:
> it works as non-root but as root use
jlprat commented on pull request #10856:
URL: https://github.com/apache/kafka/pull/10856#issuecomment-858573500
Yes, I see that the part of the build running the test is finishing with
exit code 1. The one checking the compilation, spotbugs, and co finished
successfully, though.
--
This
mdedetrich commented on pull request #10775:
URL: https://github.com/apache/kafka/pull/10775#issuecomment-858574856
It seems that the `scheduler.tick()` method is a workaround rather than
solving the actual problem. From what I understand you are just suspending the
scheduler and as a resu
cadonna commented on a change in pull request #10428:
URL: https://github.com/apache/kafka/pull/10428#discussion_r649131550
##
File path: build.gradle
##
@@ -604,6 +625,9 @@ subprojects {
description = 'Run checkstyle on all main Java sources'
}
+ checkstyleMain.depe
cadonna commented on a change in pull request #10428:
URL: https://github.com/apache/kafka/pull/10428#discussion_r649130665
##
File path: README.md
##
@@ -207,6 +207,20 @@ You can run checkstyle using:
The checkstyle warnings will be found in
`reports/checkstyle/reports/main.
dongjinleekr commented on a change in pull request #10428:
URL: https://github.com/apache/kafka/pull/10428#discussion_r649135659
##
File path: README.md
##
@@ -207,6 +207,20 @@ You can run checkstyle using:
The checkstyle warnings will be found in
`reports/checkstyle/reports/
dongjinleekr commented on pull request #10428:
URL: https://github.com/apache/kafka/pull/10428#issuecomment-858588665
@cadonna Here it is. Rebased onto the latest trunk and removed the
formatting section from `README.md`.
--
This is an automated message from the Apache Git Service.
To re
[
https://issues.apache.org/jira/browse/KAFKA-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360866#comment-17360866
]
Alan Ning commented on KAFKA-12468:
---
I am running standalone mode, so I am not sure if
tang7526 commented on a change in pull request #10588:
URL: https://github.com/apache/kafka/pull/10588#discussion_r649155161
##
File path:
tools/src/test/java/org/apache/kafka/tools/ProducerPerformanceTest.java
##
@@ -0,0 +1,164 @@
+/*
+ * Licensed to the Apache Software Found
tang7526 commented on a change in pull request #10588:
URL: https://github.com/apache/kafka/pull/10588#discussion_r649155454
##
File path:
tools/src/test/java/org/apache/kafka/tools/ProducerPerformanceTest.java
##
@@ -0,0 +1,164 @@
+/*
+ * Licensed to the Apache Software Found
tang7526 commented on a change in pull request #10588:
URL: https://github.com/apache/kafka/pull/10588#discussion_r649155812
##
File path:
tools/src/test/java/org/apache/kafka/tools/ProducerPerformanceTest.java
##
@@ -0,0 +1,164 @@
+/*
+ * Licensed to the Apache Software Found
tang7526 commented on a change in pull request #10588:
URL: https://github.com/apache/kafka/pull/10588#discussion_r649156123
##
File path: tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java
##
@@ -190,8 +160,66 @@ public static void main(String[] args) throws E
tang7526 commented on a change in pull request #10588:
URL: https://github.com/apache/kafka/pull/10588#discussion_r649156123
##
File path: tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java
##
@@ -190,8 +160,66 @@ public static void main(String[] args) throws E
ijuma commented on a change in pull request #10852:
URL: https://github.com/apache/kafka/pull/10852#discussion_r649169159
##
File path:
log4j-appender/src/test/java/org/apache/kafka/log4jappender/KafkaLog4jAppenderTest.java
##
@@ -158,18 +160,18 @@ public void
testRealProduce
ijuma commented on a change in pull request #10852:
URL: https://github.com/apache/kafka/pull/10852#discussion_r649169530
##
File path:
log4j-appender/src/test/java/org/apache/kafka/log4jappender/KafkaLog4jAppenderTest.java
##
@@ -158,18 +160,18 @@ public void
testRealProduce
ijuma commented on a change in pull request #10848:
URL: https://github.com/apache/kafka/pull/10848#discussion_r649171232
##
File path:
storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/LogSegmentData.java
##
@@ -33,31 +34,32 @@
private final Path logSe
ijuma commented on a change in pull request #10848:
URL: https://github.com/apache/kafka/pull/10848#discussion_r649171869
##
File path:
storage/api/src/test/java/org/apache/kafka/server/log/remote/storage/LogSegmentDataTest.java
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apac
ijuma commented on pull request #10847:
URL: https://github.com/apache/kafka/pull/10847#issuecomment-858614341
This is a good change, but can we please quality the perf improvements
claim? My understanding is that only applies to certain compression levels and
Kafka currently always picks
ijuma commented on pull request #10847:
URL: https://github.com/apache/kafka/pull/10847#issuecomment-858615783
Also, why are we listing versions in the PR description that are not
relevant to this upgrade?
--
This is an automated message from the Apache Git Service.
To respond to the mes
ijuma commented on pull request #10860:
URL: https://github.com/apache/kafka/pull/10860#issuecomment-858624143
Do the system tests pass with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
ijuma commented on a change in pull request #10584:
URL: https://github.com/apache/kafka/pull/10584#discussion_r649187595
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/MetadataRequest.java
##
@@ -92,6 +93,15 @@ public MetadataRequest build(short version)
ijuma commented on a change in pull request #10584:
URL: https://github.com/apache/kafka/pull/10584#discussion_r649189502
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -1135,6 +1135,19 @@ class KafkaApis(val requestChannel: RequestChannel,
val metada
[
https://issues.apache.org/jira/browse/KAFKA-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360912#comment-17360912
]
Alexis Josephides commented on KAFKA-12468:
---
We are running in distributed mod
dajac opened a new pull request #10863:
URL: https://github.com/apache/kafka/pull/10863
TODO
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upg
[
https://issues.apache.org/jira/browse/KAFKA-12894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360918#comment-17360918
]
Ismael Juma commented on KAFKA-12894:
-
The KIP vote passed.
> KIP-750: Drop support
[
https://issues.apache.org/jira/browse/KAFKA-12894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360918#comment-17360918
]
Ismael Juma edited comment on KAFKA-12894 at 6/10/21, 1:49 PM:
---
mimaison commented on a change in pull request #10743:
URL: https://github.com/apache/kafka/pull/10743#discussion_r649208497
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/internals/AdminApiHandler.java
##
@@ -63,7 +64,7 @@
*
* @return result in
rqode commented on pull request #9671:
URL: https://github.com/apache/kafka/pull/9671#issuecomment-858645412
When you experience this issue on 2.6.0 consumers is it enough to only
upgrade the kafka client to 2.6.2 or does this fix require a server upgrade?
Thanks
--
This is an automated
jlprat commented on pull request #10856:
URL: https://github.com/apache/kafka/pull/10856#issuecomment-858645362
Some steps of the build seem to have passed while some others failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
[
https://issues.apache.org/jira/browse/KAFKA-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360923#comment-17360923
]
Ismael Juma commented on KAFKA-12895:
-
The KIP vote passed. I will create a subtask
Ismael Juma created KAFKA-12929:
---
Summary: KIP-750: Deprecate Java 8 in Kafka 3.0
Key: KAFKA-12929
URL: https://issues.apache.org/jira/browse/KAFKA-12929
Project: Kafka
Issue Type: Sub-task
Ismael Juma created KAFKA-12930:
---
Summary: Deprecate support for Scala 2.12 in Kafka 3.0
Key: KAFKA-12930
URL: https://issues.apache.org/jira/browse/KAFKA-12930
Project: Kafka
Issue Type: Sub-t
[
https://issues.apache.org/jira/browse/KAFKA-12930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-12930:
Summary: KIP-751: Deprecate support for Scala 2.12 in Kafka 3.0 (was:
Deprecate support for Scala
[
https://issues.apache.org/jira/browse/KAFKA-12929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-12929:
Summary: KIP-750: Deprecate support for Java 8 in Kafka 3.0 (was: KIP-750:
Deprecate Java 8 in Ka
chia7712 commented on pull request #10860:
URL: https://github.com/apache/kafka/pull/10860#issuecomment-858649375
> Do the system tests pass with this change?
yep. This system test shows following error message without this patch.
```
java.lang.RuntimeException: Did not expect d
mimaison commented on a change in pull request #10743:
URL: https://github.com/apache/kafka/pull/10743#discussion_r649213934
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -858,6 +885,12 @@ public void onSuccess(C
chia7712 merged pull request #10860:
URL: https://github.com/apache/kafka/pull/10860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
dongjinleekr commented on pull request #10847:
URL: https://github.com/apache/kafka/pull/10847#issuecomment-858653169
@ijuma @dchristle Since we have more time for
[KIP-390](https://cwiki.apache.org/confluence/display/KAFKA/KIP-390%3A+Allow+fine-grained+configuration+for+compression),
I wi
[
https://issues.apache.org/jira/browse/KAFKA-12870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-12870:
Fix Version/s: 3.0.0
> RecordAccumulator stuck in a flushing state
> -
[
https://issues.apache.org/jira/browse/KAFKA-12870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360937#comment-17360937
]
Ismael Juma commented on KAFKA-12870:
-
I think the claim is that there's a bug in th
mimaison commented on a change in pull request #9878:
URL: https://github.com/apache/kafka/pull/9878#discussion_r649241897
##
File path: clients/src/test/java/org/apache/kafka/common/KafkaFutureTest.java
##
@@ -17,68 +17,261 @@
package org.apache.kafka.common;
import org.ap
[
https://issues.apache.org/jira/browse/KAFKA-12892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360983#comment-17360983
]
Bruno Cadonna commented on KAFKA-12892:
---
Is PR #10821 supposed to solve the issue?
satishd commented on pull request #10848:
URL: https://github.com/apache/kafka/pull/10848#issuecomment-858686600
Thanks @junrao @ijuma for the review. Addressed the review comments with the
latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the mes
cadonna commented on pull request #10856:
URL: https://github.com/apache/kafka/pull/10856#issuecomment-858689473
JDK 11 and ARM passed. Failed tests are unrelated and the issue is known.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
cadonna merged pull request #10856:
URL: https://github.com/apache/kafka/pull/10856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
jlprat commented on pull request #10856:
URL: https://github.com/apache/kafka/pull/10856#issuecomment-858694138
Thanks both for the reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
mimaison commented on a change in pull request #10652:
URL: https://github.com/apache/kafka/pull/10652#discussion_r649253273
##
File path:
connect/mirror-client/src/test/java/org/apache/kafka/connect/mirror/MirrorClientTest.java
##
@@ -159,4 +191,12 @@ public void remoteTopics
IgnacioAcunaF commented on pull request #10858:
URL: https://github.com/apache/kafka/pull/10858#issuecomment-858703098
PING @hachikuji @apovzner as I saw you on
[KAFKA-9507](https://github.com/apache/kafka/pull/8057)
--
This is an automated message from the Apache Git Service.
To respond
IgnacioAcunaF edited a comment on pull request #10858:
URL: https://github.com/apache/kafka/pull/10858#issuecomment-858703098
PING @hachikuji @apovzner (as I saw you on
[KAFKA-9507](https://github.com/apache/kafka/pull/8057))
--
This is an automated message from the Apache Git Service.
T
jsancio commented on a change in pull request #10786:
URL: https://github.com/apache/kafka/pull/10786#discussion_r649273990
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -233,18 +233,40 @@ final class KafkaMetadataLog private (
log.topicId.get
jsancio commented on a change in pull request #10786:
URL: https://github.com/apache/kafka/pull/10786#discussion_r649281362
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##
@@ -1009,7 +999,7 @@ private QuorumController(LogContext logCon
[
https://issues.apache.org/jira/browse/KAFKA-12892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17361026#comment-17361026
]
Igor Soarez commented on KAFKA-12892:
-
Yes it was - by applying the ACL changes to a
socutes commented on a change in pull request #10749:
URL: https://github.com/apache/kafka/pull/10749#discussion_r649316231
##
File path: raft/src/main/java/org/apache/kafka/snapshot/Snapshots.java
##
@@ -68,15 +68,22 @@ public static Path snapshotPath(Path logDir, OffsetAndEpo
socutes commented on pull request #10749:
URL: https://github.com/apache/kafka/pull/10749#issuecomment-858743167
@hachikuji Please review the changes again! Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
jsancio commented on a change in pull request #10786:
URL: https://github.com/apache/kafka/pull/10786#discussion_r649320552
##
File path:
metadata/src/main/java/org/apache/kafka/controller/SnapshotGenerator.java
##
@@ -74,56 +74,49 @@ String name() {
this.batch = null
jsancio commented on a change in pull request #10786:
URL: https://github.com/apache/kafka/pull/10786#discussion_r649273990
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -233,18 +233,40 @@ final class KafkaMetadataLog private (
log.topicId.get
jsancio commented on pull request #10786:
URL: https://github.com/apache/kafka/pull/10786#issuecomment-858750625
@hachikuji thanks for the review. Updated the PR to address your comments.
cc @cmccabe
--
This is an automated message from the Apache Git Service.
To respond to the me
edoardocomar commented on pull request #10649:
URL: https://github.com/apache/kafka/pull/10649#issuecomment-858752590
This last commit (thanks @tombentley ) allows the integration test to leave
the Admin interface unchanged, the expanded factory method is only part of test
classes
--
Th
mimaison merged pull request #10849:
URL: https://github.com/apache/kafka/pull/10849
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
[
https://issues.apache.org/jira/browse/KAFKA-12925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17361062#comment-17361062
]
Michael Viamari commented on KAFKA-12925:
-
I can flesh out a larger example if n
mimaison commented on pull request #10805:
URL: https://github.com/apache/kafka/pull/10805#issuecomment-858766776
This KIP was adopted on the basis of having an IdentityReplicationPolicy
which is in this PR: https://github.com/apache/kafka/pull/10652
--
This is an automated message from
jolshan commented on a change in pull request #10584:
URL: https://github.com/apache/kafka/pull/10584#discussion_r649352099
##
File path: core/src/test/scala/unit/kafka/server/MetadataRequestTest.scala
##
@@ -234,6 +235,32 @@ class MetadataRequestTest extends
AbstractMetadataR
jolshan commented on a change in pull request #10584:
URL: https://github.com/apache/kafka/pull/10584#discussion_r649352825
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/MetadataRequest.java
##
@@ -92,6 +93,15 @@ public MetadataRequest build(short versio
jolshan commented on a change in pull request #10584:
URL: https://github.com/apache/kafka/pull/10584#discussion_r649353683
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/MetadataRequest.java
##
@@ -92,6 +93,15 @@ public MetadataRequest build(short versio
mimaison merged pull request #10653:
URL: https://github.com/apache/kafka/pull/10653
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
jolshan commented on a change in pull request #10584:
URL: https://github.com/apache/kafka/pull/10584#discussion_r649360987
##
File path: core/src/test/scala/unit/kafka/server/MetadataRequestTest.scala
##
@@ -234,6 +235,32 @@ class MetadataRequestTest extends
AbstractMetadataR
1 - 100 of 165 matches
Mail list logo
