cadonna commented on a change in pull request #10856:
URL: https://github.com/apache/kafka/pull/10856#discussion_r648988189
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java
##########
@@ -562,10 +553,6 @@ private String externalChildSensorName(final String
threadId, final String opera
+ SENSOR_NAME_DELIMITER + operationName;
}
- private String externalParentSensorName(final String threadId, final
String operationName) {
Review comment:
Same here
##########
File path:
streams/src/main/java/org/apache/kafka/streams/StoreQueryParameters.java
##########
@@ -25,8 +25,8 @@
*/
public class StoreQueryParameters<T> {
- private Integer partition;
- private boolean staleStores;
+ private final Integer partition;
+ private final boolean staleStores;
Review comment:
The checkstyle rule used only checks local variables, not member fields:
```
<!-- variables that can be final should be final (suppressed except for
Streams) -->
<module name="FinalLocalVariable">
<property name="tokens" value="VARIABLE_DEF,PARAMETER_DEF"/>
<property name="validateEnhancedForLoopVariable" value="true"/>
</module>
```
See
https://checkstyle.sourceforge.io/apidocs/com/puppycrawl/tools/checkstyle/checks/coding/FinalLocalVariableCheck.html
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java
##########
@@ -294,14 +293,6 @@ public final void removeAllThreadLevelSensors(final String
threadId) {
return tagMap;
}
- public Map<String, String> bufferLevelTagMap(final String threadId,
Review comment:
That is fine! Apparently I missed this method when I removed the old
Streams metrics structure. Thanks @jlprat !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
