qiang Liu created KAFKA-12889:
-
Summary: log clean group consider empty log segment to avoid empty
log left
Key: KAFKA-12889
URL: https://issues.apache.org/jira/browse/KAFKA-12889
Project: Kafka
dajac opened a new pull request #10817:
URL: https://github.com/apache/kafka/pull/10817
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade not
iamgd67 opened a new pull request #10818:
URL: https://github.com/apache/kafka/pull/10818
more detail see jira
[KAFKA-12889](https://issues.apache.org/jira/browse/KAFKA-12889)
to avoid log index 4 byte relative offset overflow, log cleaner group check
log segments offset to make sur
ijuma commented on a change in pull request #10794:
URL: https://github.com/apache/kafka/pull/10794#discussion_r645343056
##
File path: build.gradle
##
@@ -829,6 +829,7 @@ project(':core') {
testImplementation(libs.jfreechart) {
exclude group: 'junit', module: 'juni
[
https://issues.apache.org/jira/browse/KAFKA-12889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357114#comment-17357114
]
qiang Liu commented on KAFKA-12889:
---
create a pull request on github
> log clean grou
ijuma commented on pull request #10809:
URL: https://github.com/apache/kafka/pull/10809#issuecomment-854423913
You don't have to revert it, but can you please get a committer approval?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
junrao commented on a change in pull request #10753:
URL: https://github.com/apache/kafka/pull/10753#discussion_r644352228
##
File path:
metadata/src/main/java/org/apache/kafka/controller/RemovingAndAddingReplicas.java
##
@@ -0,0 +1,214 @@
+/*
+ * Licensed to the Apache Softwa
vitojeng commented on pull request #10668:
URL: https://github.com/apache/kafka/pull/10668#issuecomment-853445357
Thanks @mjsax !
Please take a look.🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
guozhangwang commented on pull request #10552:
URL: https://github.com/apache/kafka/pull/10552#issuecomment-853411553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For qu
guozhangwang commented on a change in pull request #10798:
URL: https://github.com/apache/kafka/pull/10798#discussion_r644356441
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##
@@ -505,6 +506,14 @@ private void closeOpenIterato
mjsax commented on a change in pull request #10731:
URL: https://github.com/apache/kafka/pull/10731#discussion_r644507242
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableTransformValues.java
##
@@ -158,7 +158,11 @@ public void init(final Pr
showuon closed pull request #9672:
URL: https://github.com/apache/kafka/pull/9672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please c
[
https://issues.apache.org/jira/browse/KAFKA-9929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-9929:
---
Labels: kip (was: needs-kip)
> Support reverse iterator on WindowStore
> ---
[
https://issues.apache.org/jira/browse/KAFKA-9929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-9929:
---
Description:
KIP-617:
[https://cwiki.apache.org/confluence/display/KAFKA/KIP-617%3A+Allow+Ka
hachikuji commented on pull request #10804:
URL: https://github.com/apache/kafka/pull/10804#issuecomment-854102079
The patch makes sense to me. One alternative to consider is to invert the
flexible version specification. Basically get rid of "flexibleVersions" and
instead add a "legacyVers
mjsax commented on pull request #10668:
URL: https://github.com/apache/kafka/pull/10668#issuecomment-853547323
Thanks @vitojeng! Merged to `trunk`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
cmccabe merged pull request #10752:
URL: https://github.com/apache/kafka/pull/10752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
vvcephei commented on a change in pull request #10731:
URL: https://github.com/apache/kafka/pull/10731#discussion_r645017943
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableTransformValues.java
##
@@ -158,7 +158,11 @@ public void init(final
dongjinleekr commented on pull request #10698:
URL: https://github.com/apache/kafka/pull/10698#issuecomment-853729405
Cool. Working Like a charm.
`./gradlew checkstyleMain checkstyleTest`:

David Jacot created KAFKA-12890:
---
Summary: Consumer group stuck in `CompletingRebalance`
Key: KAFKA-12890
URL: https://issues.apache.org/jira/browse/KAFKA-12890
Project: Kafka
Issue Type: Bug
showuon edited a comment on pull request #10794:
URL: https://github.com/apache/kafka/pull/10794#issuecomment-853761494
@hachikuji @mumrah @abbccdda @cmccabe , call for review since the tests keep
failing. Thank you.
--
This is an automated message from the Apache Git Service.
To respond
showuon commented on pull request #10471:
URL: https://github.com/apache/kafka/pull/10471#issuecomment-853665420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries
jlprat commented on pull request #10784:
URL: https://github.com/apache/kafka/pull/10784#issuecomment-854078089
Any chance any of you has time to check this? cc @mjsax @vvcephei
@guozhangwang
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the m
mdedetrich edited a comment on pull request #10648:
URL: https://github.com/apache/kafka/pull/10648#issuecomment-835180661
@mimaison I have just renamed `LegacyReplicationPolicy` to
`IdentityReplicationPolicy` and forced pushed the branch.
@ryannedolan I will have a look at
https://
mjsax commented on a change in pull request #10810:
URL: https://github.com/apache/kafka/pull/10810#discussion_r644509797
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/ProcessorContext.java
##
@@ -158,32 +165,52 @@ Cancellable schedule(final Duration i
vamossagar12 commented on a change in pull request #10798:
URL: https://github.com/apache/kafka/pull/10798#discussion_r644616944
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##
@@ -505,6 +506,14 @@ private void closeOpenIterato
guozhangwang commented on pull request #10646:
URL: https://github.com/apache/kafka/pull/10646#issuecomment-854262242
@cadonna
1. Filed a ticket for KStreams to enforce shutdown on illegal-X exceptions
as a future work.
2. Let the global state mgr to do closing before throwing il
tombentley commented on a change in pull request #9441:
URL: https://github.com/apache/kafka/pull/9441#discussion_r644571665
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -279,30 +279,33 @@ class KafkaApis(val requestChannel: RequestChannel,
new
vvcephei commented on a change in pull request #10810:
URL: https://github.com/apache/kafka/pull/10810#discussion_r645023265
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/ProcessorContext.java
##
@@ -158,32 +165,52 @@ Cancellable schedule(final Duratio
cadonna commented on a change in pull request #10428:
URL: https://github.com/apache/kafka/pull/10428#discussion_r644711679
##
File path: core/src/main/java/kafka/metrics/FilteringJmxReporter.java
##
@@ -51,7 +50,7 @@ public void updatePredicate(Predicate predicate) {
dongjinleekr commented on a change in pull request #10507:
URL: https://github.com/apache/kafka/pull/10507#discussion_r644545454
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/AbstractStream.java
##
@@ -16,6 +16,10 @@
*/
package org.apache.ka
dengziming commented on pull request #10793:
URL: https://github.com/apache/kafka/pull/10793#issuecomment-853911013
@hachikuji Thanks for the remindings, I think the validations in `read` are
useful and I copied them to `MetadataRecordSerde`, but not sure whether the
`DEFAULT_FRAME_VERSION
guozhangwang commented on a change in pull request #10609:
URL: https://github.com/apache/kafka/pull/10609#discussion_r644343550
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/SubscriptionInfo.java
##
@@ -125,6 +130,29 @@ public int
dejan2609 commented on pull request #10698:
URL: https://github.com/apache/kafka/pull/10698#issuecomment-853408053
Just tagging @ijuma here again (to come back up to the surface).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
dengziming commented on a change in pull request #10793:
URL: https://github.com/apache/kafka/pull/10793#discussion_r645205625
##
File path:
server-common/src/main/java/org/apache/kafka/server/common/serialization/AbstractApiMessageSerde.java
##
@@ -69,16 +76,42 @@ public void
dejan2609 commented on pull request #10428:
URL: https://github.com/apache/kafka/pull/10428#issuecomment-853411084
Shameless plug and related to CheckStyle: ⏩ #10698 (needs a review /
approval).
--
This is an automated message from the Apache Git Service.
To respond to the mess
hachikuji commented on a change in pull request #10793:
URL: https://github.com/apache/kafka/pull/10793#discussion_r645084226
##
File path:
server-common/src/main/java/org/apache/kafka/server/common/serialization/AbstractApiMessageSerde.java
##
@@ -69,16 +76,42 @@ public void
dongjinleekr commented on pull request #10428:
URL: https://github.com/apache/kafka/pull/10428#issuecomment-853821984
@cadonna Here it is, with the following: 1. making server-common to ignore
import orders. 2. rebasing onto the latest trunk.
+1. It seems like we can make the eclipse
ryannedolan commented on pull request #10652:
URL: https://github.com/apache/kafka/pull/10652#issuecomment-854215843
None of the failing tests are related. Ready to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
dongjinleekr commented on pull request #10678:
URL: https://github.com/apache/kafka/pull/10678#issuecomment-853838170
@ableegoldman Could you have a look? :pray:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
ijuma edited a comment on pull request #10471:
URL: https://github.com/apache/kafka/pull/10471#issuecomment-854399316
Unrelated test failures:
> Build / JDK 11 and Scala 2.13 /
kafka.server.RaftClusterTest.testCreateClusterAndCreateListDeleteTopic()
> Build / JDK 11 and Scala 2.13
ijuma commented on a change in pull request #10805:
URL: https://github.com/apache/kafka/pull/10805#discussion_r645317670
##
File path: core/src/main/scala/kafka/tools/MirrorMaker.scala
##
@@ -58,7 +58,10 @@ import scala.util.{Failure, Success, Try}
*enable.auto.c
ijuma commented on pull request #10809:
URL: https://github.com/apache/kafka/pull/10809#issuecomment-854385011
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries a
ijuma commented on pull request #10471:
URL: https://github.com/apache/kafka/pull/10471#issuecomment-854399316
Unrelated test failures:
> Build / JDK 11 and Scala 2.13 /
kafka.server.RaftClusterTest.testCreateClusterAndCreateListDeleteTopic() | 16
sec | 1
> -- | -- | --
> Buil
mjsax commented on pull request #10813:
URL: https://github.com/apache/kafka/pull/10813#issuecomment-854379331
How confident are we, that we covered most cases to avoid NPE and throw
ConfigException? Seems it's still many places that we need to cover, and I am
wondering if we follow the ri
mjsax commented on a change in pull request #10813:
URL: https://github.com/apache/kafka/pull/10813#discussion_r645299252
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/ChangedSerializer.java
##
@@ -40,7 +40,10 @@ public ChangedSerializer(final
abbccdda commented on pull request #10809:
URL: https://github.com/apache/kafka/pull/10809#issuecomment-854402436
@ijuma That's a good call, should I revert it? It was just a styling change
PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
ijuma commented on a change in pull request #10794:
URL: https://github.com/apache/kafka/pull/10794#discussion_r645318499
##
File path: build.gradle
##
@@ -829,6 +829,7 @@ project(':core') {
testImplementation(libs.jfreechart) {
exclude group: 'junit', module: 'juni
showuon commented on a change in pull request #10794:
URL: https://github.com/apache/kafka/pull/10794#discussion_r645321936
##
File path: build.gradle
##
@@ -829,6 +829,7 @@ project(':core') {
testImplementation(libs.jfreechart) {
exclude group: 'junit', module: 'ju
socutes commented on pull request #10815:
URL: https://github.com/apache/kafka/pull/10815#issuecomment-854395260
@showuon , please help review this PR. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
ijuma merged pull request #10471:
URL: https://github.com/apache/kafka/pull/10471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please c
ijuma commented on pull request #9302:
URL: https://github.com/apache/kafka/pull/9302#issuecomment-854395748
Is this still relevant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
jlprat commented on a change in pull request #10810:
URL: https://github.com/apache/kafka/pull/10810#discussion_r645405935
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/ProcessorContext.java
##
@@ -158,32 +165,52 @@ Cancellable schedule(final Duration
kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r643465477
##
File path: core/src/test/scala/unit/kafka/log/LocalLogTest.scala
##
@@ -0,0 +1,734 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under o
kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r645434947
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -1500,50 +1325,67 @@ class Log(@volatile private var _dir: File,
}
}
-delete
kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r645437282
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -1500,50 +1325,67 @@ class Log(@volatile private var _dir: File,
}
}
-delete
kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r645437580
##
File path: core/src/test/scala/unit/kafka/log/LocalLogTest.scala
##
@@ -0,0 +1,734 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under o
kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r645439534
##
File path: core/src/test/scala/unit/kafka/log/LocalLogTest.scala
##
@@ -0,0 +1,734 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under o
kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r645439645
##
File path: core/src/test/scala/unit/kafka/log/LocalLogTest.scala
##
@@ -0,0 +1,734 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under o
kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r645441207
##
File path: core/src/main/scala/kafka/log/LogLoader.scala
##
@@ -246,17 +262,17 @@ object LogLoader extends Logging {
return fn
} catch
Wenbing Shen created KAFKA-12891:
Summary: Add --files and --file-separator options to the
ConsoleProducer
Key: KAFKA-12891
URL: https://issues.apache.org/jira/browse/KAFKA-12891
Project: Kafka
sarwarbhuiyan commented on pull request #7499:
URL: https://github.com/apache/kafka/pull/7499#issuecomment-854551022
KIP passed voting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
kowshik commented on pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#issuecomment-854616475
@junrao Thanks for the review! I've addressed the comments in
e201295e03e0ea8a7102983888d1a7afc66d384a, and have also rebased this PR onto
most recent commit in `trunk`. It is r
kowshik edited a comment on pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#issuecomment-854616475
@junrao Thanks for the review! I've addressed your comments in
e201295e03e0ea8a7102983888d1a7afc66d384a, and have also rebased this PR onto
most recent commit in `trunk`.
kowshik edited a comment on pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#issuecomment-854616475
@junrao Thanks for the review! I've addressed your comments in
e201295e03e0ea8a7102983888d1a7afc66d384a, and have also rebased this PR onto
most recent commit in `trunk`.
kowshik opened a new pull request #10819:
URL: https://github.com/apache/kafka/pull/10819
While reading the code, I noticed that `LogLoader` had a few points where
the log identifier was not printed as part of the log message. I've fixed it in
this PR.
**Tests:**
Rely on existing
kowshik commented on pull request #10819:
URL: https://github.com/apache/kafka/pull/10819#issuecomment-854621853
@junrao Please could you help review this small change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/KAFKA-12847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357273#comment-17357273
]
Abhijit Mane commented on KAFKA-12847:
--
Thanks [~chia7712]
I guess my detailed exp
showuon commented on a change in pull request #10794:
URL: https://github.com/apache/kafka/pull/10794#discussion_r645522757
##
File path: build.gradle
##
@@ -829,6 +829,7 @@ project(':core') {
testImplementation(libs.jfreechart) {
exclude group: 'junit', module: 'ju
Luke Chen created KAFKA-12892:
-
Summary: InvalidACLException thrown in tests caused jenkins build
unstable
Key: KAFKA-12892
URL: https://issues.apache.org/jira/browse/KAFKA-12892
Project: Kafka
showuon opened a new pull request #10820:
URL: https://github.com/apache/kafka/pull/10820
Detail is described in https://issues.apache.org/jira/browse/KAFKA-12892.
Thanks.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Ver
showuon commented on pull request #10820:
URL: https://github.com/apache/kafka/pull/10820#issuecomment-854722099
@ijuma @omkreddy , could you take a look? This test keeps failing the
jenkins build, I think we should disable it before we know how to avoid
breaking jenkins build. Thanks.
-
ijuma commented on pull request #10820:
URL: https://github.com/apache/kafka/pull/10820#issuecomment-854724264
@omkreddy I will leave it to you to review this since you reviewed the
original PR. If this is failing often, it makes sense to disable temporarily,
but we need a JIRA to fix the
[
https://issues.apache.org/jira/browse/KAFKA-12892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-12892:
--
Description:
In KAFKA-12866, we fixed the issue that Kafka required ZK root access even when
using a
showuon commented on pull request #10820:
URL: https://github.com/apache/kafka/pull/10820#issuecomment-854725411
@ijuma , KAFKA-12892 is the JIRA ticket. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/KAFKA-12892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357362#comment-17357362
]
Luke Chen commented on KAFKA-12892:
---
I tried to set the original root acl back, but it
Tommi Vainikainen created KAFKA-12893:
-
Summary: MM2 fails to replicate if starting two+ nodes same time
Key: KAFKA-12893
URL: https://issues.apache.org/jira/browse/KAFKA-12893
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-12893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357372#comment-17357372
]
Daniel Urban commented on KAFKA-12893:
--
You might be hitting the issue of MM2 not r
Ismael Juma created KAFKA-12894:
---
Summary: KIP-750: Drop support for Java 8 in Kafka 4.0 (deprecate
in 3.0)
Key: KAFKA-12894
URL: https://issues.apache.org/jira/browse/KAFKA-12894
Project: Kafka
Ismael Juma created KAFKA-12895:
---
Summary: KIP-751: Drop support for Scala 2.12 in Kafka 4.0
(deprecate in 3.0)
Key: KAFKA-12895
URL: https://issues.apache.org/jira/browse/KAFKA-12895
Project: Kafka
Lucas Bradstreet created KAFKA-12896:
Summary: Group rebalance loop caused by repeated group leader
JoinGroups
Key: KAFKA-12896
URL: https://issues.apache.org/jira/browse/KAFKA-12896
Project: Kafk
1 - 100 of 140 matches
Mail list logo