[GitHub] [kafka] cadonna commented on a change in pull request #10664: KAFKA-12749: Changelog topic config on suppressed KTable lost

[GitBox]

cadonna commented on a change in pull request #10664:
URL: https://github.com/apache/kafka/pull/10664#discussion_r644644247



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/kstream/internals/suppress/EagerBufferConfigImpl.java
##########
@@ -28,13 +28,7 @@
     private final long maxBytes;
     private final Map<String, String> logConfig;
 
-    public EagerBufferConfigImpl(final long maxRecords, final long maxBytes) {
-        this.maxRecords = maxRecords;
-        this.maxBytes = maxBytes;
-        this.logConfig = Collections.emptyMap();
-    }
-
-    private EagerBufferConfigImpl(final long maxRecords,
+    public EagerBufferConfigImpl(final long maxRecords,
                                   final long maxBytes,
                                   final Map<String, String> logConfig) {

Review comment:
       nit
   ```suggestion
       public EagerBufferConfigImpl(final long maxRecords,
                                    final long maxBytes,
                                    final Map<String, String> logConfig) {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org