[jira] [Commented] (KAFKA-6898) org.apache.kafka.common.errors.TimeoutException

2021-06-01 Thread Luca Borzani (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354918#comment-17354918 ] Luca Borzani commented on KAFKA-6898: - Is anyone working on this? Is it maybe fixed i

[GitHub] [kafka] cadonna commented on pull request #10785: KIP-708 / A Rack awareness for Kafka Streams

2021-06-01 Thread GitBox
cadonna commented on pull request #10785: URL: https://github.com/apache/kafka/pull/10785#issuecomment-851926961 As far as I can see from skimming the PR, you could have a PR for the standby task assignors with corresponding unit tests without changing any existing public functionality and

[GitHub] [kafka] lkokhreidze commented on pull request #10785: KIP-708 / A Rack awareness for Kafka Streams

2021-06-01 Thread GitBox
lkokhreidze commented on pull request #10785: URL: https://github.com/apache/kafka/pull/10785#issuecomment-851937769 Sounds good, will try to split the PR into smaller chunks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [kafka] cadonna commented on a change in pull request #10770: MINOR: fix code listings security.html

2021-06-01 Thread GitBox
cadonna commented on a change in pull request #10770: URL: https://github.com/apache/kafka/pull/10770#discussion_r642904792 ## File path: docs/security.html ## @@ -384,56 +384,56 @@ SSL key and certificates in PEM format ssl.key.password=test1234 Other configura

[GitHub] [kafka] jlprat commented on pull request #10770: MINOR: fix code listings security.html

2021-06-01 Thread GitBox
jlprat commented on pull request #10770: URL: https://github.com/apache/kafka/pull/10770#issuecomment-851963549 Thanks @cadonna All comments addressed! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] jlprat commented on a change in pull request #10770: MINOR: fix code listings security.html

2021-06-01 Thread GitBox
jlprat commented on a change in pull request #10770: URL: https://github.com/apache/kafka/pull/10770#discussion_r642923211 ## File path: docs/security.html ## @@ -384,56 +384,56 @@ SSL key and certificates in PEM format ssl.key.password=test1234 Other configurat

[jira] [Created] (KAFKA-12870) RecordAccumulator stuck in a flushing state

2021-06-01 Thread Niclas Lockner (Jira)
Niclas Lockner created KAFKA-12870: -- Summary: RecordAccumulator stuck in a flushing state Key: KAFKA-12870 URL: https://issues.apache.org/jira/browse/KAFKA-12870 Project: Kafka Issue Type: B

[jira] [Updated] (KAFKA-12870) RecordAccumulator stuck in a flushing state

2021-06-01 Thread Niclas Lockner (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niclas Lockner updated KAFKA-12870: --- Attachment: RecordAccumulator.log full.log > RecordAccumulator stuck in a fl

[jira] [Updated] (KAFKA-12793) Client-side Circuit Breaker for Partition Write Errors

2021-06-01 Thread KahnCheny (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] KahnCheny updated KAFKA-12793: -- Description: When Kafka is used to build data pipeline in mission critical business scenarios, availa

[jira] [Updated] (KAFKA-12793) Client-side Circuit Breaker for Partition Write Errors

2021-06-01 Thread KahnCheny (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] KahnCheny updated KAFKA-12793: -- Description: When Kafka is used to build data pipeline in mission critical business scenarios, availa

[jira] [Updated] (KAFKA-12870) RecordAccumulator stuck in a flushing state

2021-06-01 Thread Niclas Lockner (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niclas Lockner updated KAFKA-12870: --- Description: After a Kafka Stream with exactly once enabled has performed its first commit,

[GitHub] [kafka] rajinisivaram commented on a change in pull request #10156: KAFKA-10345: File watch store reloading

2021-06-01 Thread GitBox
rajinisivaram commented on a change in pull request #10156: URL: https://github.com/apache/kafka/pull/10156#discussion_r642939618 ## File path: clients/src/main/java/org/apache/kafka/clients/ClientUtils.java ## @@ -98,7 +99,7 @@ private ClientUtils() { * * @return c

[GitHub] [kafka] thomaskwscott commented on a change in pull request #10760: KAFKA-12541 Extend ListOffset to fetch offset with max timestamp

2021-06-01 Thread GitBox
thomaskwscott commented on a change in pull request #10760: URL: https://github.com/apache/kafka/pull/10760#discussion_r642967602 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -4225,76 +4232,84 @@ public ListOffsetsResult listO

[jira] [Updated] (KAFKA-12870) RecordAccumulator stuck in a flushing state

2021-06-01 Thread Niclas Lockner (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niclas Lockner updated KAFKA-12870: --- Affects Version/s: (was: 2.6.1) 2.5.1 2.7.1

[jira] [Updated] (KAFKA-12870) RecordAccumulator stuck in a flushing state

2021-06-01 Thread Niclas Lockner (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niclas Lockner updated KAFKA-12870: --- Description: After a Kafka Stream with exactly once enabled has performed its first commit,

[jira] [Updated] (KAFKA-12793) Client-side Circuit Breaker for Partition Write Errors

2021-06-01 Thread KahnCheny (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] KahnCheny updated KAFKA-12793: -- Description: When Kafka is used to build data pipeline in mission critical business scenarios, availa

[GitHub] [kafka] cadonna commented on pull request #10770: MINOR: fix code listings security.html

2021-06-01 Thread GitBox
cadonna commented on pull request #10770: URL: https://github.com/apache/kafka/pull/10770#issuecomment-852043836 The test failures are unrelated since this is a pure doc change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] cadonna merged pull request #10770: MINOR: fix code listings security.html

2021-06-01 Thread GitBox
cadonna merged pull request #10770: URL: https://github.com/apache/kafka/pull/10770 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Updated] (KAFKA-12793) Client-side Circuit Breaker for Partition Write Errors

2021-06-01 Thread KahnCheny (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] KahnCheny updated KAFKA-12793: -- Attachment: (was: KAFKA-12793__KIP-693,_Client-side_supports_partitioned_circuit_breaker.patch) >

[jira] [Updated] (KAFKA-12793) Client-side Circuit Breaker for Partition Write Errors

2021-06-01 Thread KahnCheny (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] KahnCheny updated KAFKA-12793: -- Attachment: KAFKA-12793__KIP-693,_Client-side_supports_partitioned_circuit_breaker.patch > Client-sid

[jira] [Updated] (KAFKA-12793) Client-side Circuit Breaker for Partition Write Errors

2021-06-01 Thread KahnCheny (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] KahnCheny updated KAFKA-12793: -- Attachment: KAFKA-12793.patch > Client-side Circuit Breaker for Partition Write Errors > -

[jira] [Commented] (KAFKA-5676) MockStreamsMetrics should be in o.a.k.test

2021-06-01 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355048#comment-17355048 ] Bruno Cadonna commented on KAFKA-5676: -- [~marcolotz] Thank you for your analysis! I

[GitHub] [kafka] showuon commented on pull request #10746: MINOR: remove unneccessary public keyword from ProducerInterceptor/ConsumerInterceptor interface

2021-06-01 Thread GitBox
showuon commented on pull request #10746: URL: https://github.com/apache/kafka/pull/10746#issuecomment-852066023 @KahnCheny , it looks like you made some change after I approved this PR. Now, there are 162 files changed. Could you check again? Thanks. -- This is an automated message from

[GitHub] [kafka] jlprat commented on pull request #10770: MINOR: fix code listings security.html

2021-06-01 Thread GitBox
jlprat commented on pull request #10770: URL: https://github.com/apache/kafka/pull/10770#issuecomment-852066684 Thanks @cadonna ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [kafka] showuon commented on pull request #10749: KAFKA-12773: Use UncheckedIOException when wrapping IOException

2021-06-01 Thread GitBox
showuon commented on pull request #10749: URL: https://github.com/apache/kafka/pull/10749#issuecomment-852067814 @jsancio @mumrah , could you have another review for this PR since you are more familiar with this ticket. Thank you. -- This is an automated message from the Apache Git Servi

[GitHub] [kafka] cadonna commented on pull request #10765: KAFKA-12519: Remove built-in Streams metrics for versions 0.10.0-2.4

2021-06-01 Thread GitBox
cadonna commented on pull request #10765: URL: https://github.com/apache/kafka/pull/10765#issuecomment-852068844 @showuon Thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] showuon commented on pull request #10471: KAFKA-12597: remove deprecated zookeeper option in ReassignPartitionsCommand

2021-06-01 Thread GitBox
showuon commented on pull request #10471: URL: https://github.com/apache/kafka/pull/10471#issuecomment-852069445 @ijuma , could you help check this PR again? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] showuon commented on pull request #10457: KAFKA-12596: remove --zookeeper option from topic command

2021-06-01 Thread GitBox
showuon commented on pull request #10457: URL: https://github.com/apache/kafka/pull/10457#issuecomment-852069681 @ijuma , could you help check this PR again? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [kafka] cadonna merged pull request #10765: KAFKA-12519: Remove built-in Streams metrics for versions 0.10.0-2.4

2021-06-01 Thread GitBox
cadonna merged pull request #10765: URL: https://github.com/apache/kafka/pull/10765 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] showuon commented on pull request #10471: KAFKA-12597: remove deprecated zookeeper option in ReassignPartitionsCommand

2021-06-01 Thread GitBox
showuon commented on pull request #10471: URL: https://github.com/apache/kafka/pull/10471#issuecomment-852070237 Failed tests are flaky `RaftClusterTest` tests. Thanks. ``` Build / JDK 15 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopics()

[GitHub] [kafka] KahnCheny closed pull request #10746: MINOR: remove unneccessary public keyword from ProducerInterceptor/ConsumerInterceptor interface

2021-06-01 Thread GitBox
KahnCheny closed pull request #10746: URL: https://github.com/apache/kafka/pull/10746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [kafka] KahnCheny opened a new pull request #10801: MINOR: remove unneccessary public keyword from ProducerInterceptor/ConsumerInterceptor interface

2021-06-01 Thread GitBox
KahnCheny opened a new pull request #10801: URL: https://github.com/apache/kafka/pull/10801 remove unneccessary public keyword from ProducerInterceptor/ConsumerInterceptor interface ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation -

[GitHub] [kafka] KahnCheny commented on pull request #10746: MINOR: remove unneccessary public keyword from ProducerInterceptor/ConsumerInterceptor interface

2021-06-01 Thread GitBox
KahnCheny commented on pull request #10746: URL: https://github.com/apache/kafka/pull/10746#issuecomment-852083759 merge trunk will be automatically updated, so I submit a new PR, Thanks for your and re-review ? https://github.com/apache/kafka/pull/10801 Luke Chen ***@***.***>

[jira] [Created] (KAFKA-12871) Kafka-connect : rest api connect config, fields are not ordered

2021-06-01 Thread raphael auv (Jira)
raphael auv created KAFKA-12871: --- Summary: Kafka-connect : rest api connect config, fields are not ordered Key: KAFKA-12871 URL: https://issues.apache.org/jira/browse/KAFKA-12871 Project: Kafka

[GitHub] [kafka] rondagostino commented on pull request #10795: KAFKA-12866: Avoid root access to Zookeeper

2021-06-01 Thread GitBox
rondagostino commented on pull request #10795: URL: https://github.com/apache/kafka/pull/10795#issuecomment-852123180 Good catch @soarez, and thanks for the PR! Test failed without the fix and passed with it. Thanks again. -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] omkreddy merged pull request #10795: KAFKA-12866: Avoid root access to Zookeeper

2021-06-01 Thread GitBox
omkreddy merged pull request #10795: URL: https://github.com/apache/kafka/pull/10795 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[jira] [Updated] (KAFKA-12866) Kafka requires ZK root access even when using a chroot

2021-06-01 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar updated KAFKA-12866: -- Fix Version/s: 3.0.0 > Kafka requires ZK root access even when using a chroot > --

[jira] [Resolved] (KAFKA-12866) Kafka requires ZK root access even when using a chroot

2021-06-01 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-12866. --- Resolution: Fixed > Kafka requires ZK root access even when using a chroot > ---

[jira] [Resolved] (KAFKA-12519) Consider Removing Streams Old Built-in Metrics Version

2021-06-01 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna resolved KAFKA-12519. --- Resolution: Fixed > Consider Removing Streams Old Built-in Metrics Version > --

[GitHub] [kafka] ijuma commented on pull request #10457: KAFKA-12596: remove --zookeeper option from topic command

2021-06-01 Thread GitBox
ijuma commented on pull request #10457: URL: https://github.com/apache/kafka/pull/10457#issuecomment-852146723 Unrelated failures: > Build / JDK 8 and Scala 2.12 / testReplicationWithEmptyPartition() – org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest

[GitHub] [kafka] ijuma merged pull request #10457: KAFKA-12596: remove --zookeeper option from topic command

2021-06-01 Thread GitBox

[GitHub] [kafka] ijuma commented on pull request #10457: KAFKA-12596: remove --zookeeper option from topic command

2021-06-01 Thread GitBox
ijuma commented on pull request #10457: URL: https://github.com/apache/kafka/pull/10457#issuecomment-852149539 After merging, I noticed we are missing a note in upgrade.html. We can fix that as part of #10471, -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] ijuma edited a comment on pull request #10457: KAFKA-12596: remove --zookeeper option from topic command

2021-06-01 Thread GitBox
ijuma edited a comment on pull request #10457: URL: https://github.com/apache/kafka/pull/10457#issuecomment-852149539 After merging, I noticed we are missing a note in upgrade.html. We can fix that as part of #10471. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] ijuma commented on a change in pull request #10471: KAFKA-12597: remove deprecated zookeeper option in ReassignPartitionsCommand

2021-06-01 Thread GitBox
ijuma commented on a change in pull request #10471: URL: https://github.com/apache/kafka/pull/10471#discussion_r643139325 ## File path: core/src/test/scala/integration/kafka/admin/ReassignPartitionsIntegrationTest.scala ## @@ -151,7 +148,7 @@ class ReassignPartitionsIntegratio

[jira] [Updated] (KAFKA-12598) Remove deprecated --zookeeper in ConfigCommand

2021-06-01 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-12598: Fix Version/s: 3.0.0 > Remove deprecated --zookeeper in ConfigCommand > --

[jira] [Commented] (KAFKA-12598) Remove deprecated --zookeeper in ConfigCommand

2021-06-01 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355133#comment-17355133 ] Ismael Juma commented on KAFKA-12598: - [~showuon] We should do this for everything e

[jira] [Updated] (KAFKA-12598) Remove deprecated --zookeeper in ConfigCommand

2021-06-01 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-12598: Priority: Critical (was: Major) > Remove deprecated --zookeeper in ConfigCommand > --

[GitHub] [kafka] ijuma commented on pull request #10457: KAFKA-12596: remove --zookeeper option from topic command

2021-06-01 Thread GitBox
ijuma commented on pull request #10457: URL: https://github.com/apache/kafka/pull/10457#issuecomment-852167114 One more thing, did we check that there are no system tests using the flag we just removed? -- This is an automated message from the Apache Git Service. To respond to the messag

[jira] [Reopened] (KAFKA-12598) Remove deprecated --zookeeper in ConfigCommand

2021-06-01 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma reopened KAFKA-12598: - > Remove deprecated --zookeeper in ConfigCommand > -- >

[GitHub] [kafka] ijuma commented on pull request #10695: KAFKA-12783: Remove the deprecated ZK-based partition reassignment API

2021-06-01 Thread GitBox
ijuma commented on pull request #10695: URL: https://github.com/apache/kafka/pull/10695#issuecomment-852169319 I looked into it a bit more and this PR also removes the Controller functionality while #10471 only updates the reassign partitions command. We can probably get #10471 merged toda

[GitHub] [kafka] lkokhreidze opened a new pull request #10802: KAFKA-6718 / Part1: Update SubscriptionInfoData with clientTags

2021-06-01 Thread GitBox
lkokhreidze opened a new pull request #10802: URL: https://github.com/apache/kafka/pull/10802 Part 1 of [KIP-708](https://cwiki.apache.org/confluence/display/KAFKA/KIP-708%3A+Rack+awareness+for+Kafka+Streams) implementation. Full implementation can be checked here https://github.com/apach

[GitHub] [kafka] lkokhreidze commented on pull request #10802: KAFKA-6718 / Part1: Update SubscriptionInfoData with clientTags

2021-06-01 Thread GitBox
lkokhreidze commented on pull request #10802: URL: https://github.com/apache/kafka/pull/10802#issuecomment-852188025 Call for review @cadonna @vvcephei @ableegoldman -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[jira] [Created] (KAFKA-12872) KIP-724: Drop support for message formats v0 and v1

2021-06-01 Thread Ismael Juma (Jira)
Ismael Juma created KAFKA-12872: --- Summary: KIP-724: Drop support for message formats v0 and v1 Key: KAFKA-12872 URL: https://issues.apache.org/jira/browse/KAFKA-12872 Project: Kafka Issue Type:

[jira] [Updated] (KAFKA-12872) KIP-724: Drop support for message formats v0 and v1

2021-06-01 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-12872: Description: Message format v2 was introduced in Apache Kafka 0.11.0 (released in June 2017) via 

[jira] [Updated] (KAFKA-12872) KIP-724: Drop support for message formats v0 and v1

2021-06-01 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-12872: Description: Message format v2 was introduced in Apache Kafka 0.11.0 (released in June 2017) via 

[jira] [Updated] (KAFKA-12872) KIP-724: Drop support for message formats v0 and v1

2021-06-01 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-12872: Labels: kip (was: ) > KIP-724: Drop support for message formats v0 and v1 > -

[GitHub] [kafka] jolshan commented on pull request #10590: KAFKA-5761: support ByteBuffer as value in ProducerRecord and avoid redundant serialization when it's used

2021-06-01 Thread GitBox
jolshan commented on pull request #10590: URL: https://github.com/apache/kafka/pull/10590#issuecomment-852237161 Seems reasonable to me. One small thing I would say is to add comments to `tryAppend` and `append` like the versions that use the byte[] parameter. And of course, we will still

[GitHub] [kafka] jsancio commented on a change in pull request #10749: KAFKA-12773: Use UncheckedIOException when wrapping IOException

2021-06-01 Thread GitBox
jsancio commented on a change in pull request #10749: URL: https://github.com/apache/kafka/pull/10749#discussion_r643303043 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -372,27 +371,23 @@ private void maybeFireLeaderChange() { @Overri

[GitHub] [kafka] mumrah commented on a change in pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

2021-06-01 Thread GitBox
mumrah commented on a change in pull request #10593: URL: https://github.com/apache/kafka/pull/10593#discussion_r643376055 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -2276,6 +2277,24 @@ public void resign(int epoch) { ); }

[jira] [Assigned] (KAFKA-4793) Kafka Connect: POST /connectors/(string: name)/restart doesn't start failed tasks

2021-06-01 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch reassigned KAFKA-4793: Assignee: Randall Hauch > Kafka Connect: POST /connectors/(string: name)/restart doesn't s

[jira] [Created] (KAFKA-12873) Log truncation due to divergence should also remove snapshots

2021-06-01 Thread Jose Armando Garcia Sancio (Jira)
Jose Armando Garcia Sancio created KAFKA-12873: -- Summary: Log truncation due to divergence should also remove snapshots Key: KAFKA-12873 URL: https://issues.apache.org/jira/browse/KAFKA-12873

[GitHub] [kafka] jsancio commented on pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

2021-06-01 Thread GitBox
jsancio commented on pull request #10593: URL: https://github.com/apache/kafka/pull/10593#issuecomment-852353685 > Are there any concerns with multi-threading here? I think the answer is "no". Any thoughts @feyman2016 or @jsancio? Good point. There may be some concurrency issue with

[jira] [Resolved] (KAFKA-7749) confluent does not provide option to set consumer properties at connector level

2021-06-01 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-7749. -- Fix Version/s: 2.3.0 Resolution: Fixed [KIP-458|https://cwiki.apache.org/confluence/disp

[GitHub] [kafka] rhauch commented on pull request #3749: [KAFKA-4793] Restart tasks for connector endpoint

2021-06-01 Thread GitBox
rhauch commented on pull request #3749: URL: https://github.com/apache/kafka/pull/3749#issuecomment-852355451 This is an API change, which requires a KIP. Closing this without merging. Also, I think there are better ways to address this and improve the API. -- This is an automated messag

[GitHub] [kafka] rhauch closed pull request #3749: [KAFKA-4793] Restart tasks for connector endpoint

2021-06-01 Thread GitBox
rhauch closed pull request #3749: URL: https://github.com/apache/kafka/pull/3749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please co

[jira] [Commented] (KAFKA-4793) Kafka Connect: POST /connectors/(string: name)/restart doesn't start failed tasks

2021-06-01 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355287#comment-17355287 ] Randall Hauch commented on KAFKA-4793: -- I'm picking this up, and will add a KIP that

[jira] [Created] (KAFKA-12874) Increase default consumer session timeout to 40s (KIP-735)

2021-06-01 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-12874: --- Summary: Increase default consumer session timeout to 40s (KIP-735) Key: KAFKA-12874 URL: https://issues.apache.org/jira/browse/KAFKA-12874 Project: Kafka

[GitHub] [kafka] mattwong949 commented on pull request #9915: [KAKFA-8522] Streamline tombstone and transaction marker removal

2021-06-01 Thread GitBox
mattwong949 commented on pull request #9915: URL: https://github.com/apache/kafka/pull/9915#issuecomment-852379058 @ConcurrencyPractitioner Could you merge trunk back into this PR? I can help provide a review on top of what @junrao was able to help with on the other previous PR -- This

[jira] [Updated] (KAFKA-12874) Increase default consumer session timeout to 45s (KIP-735)

2021-06-01 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-12874: Summary: Increase default consumer session timeout to 45s (KIP-735) (was: Increase defaul

[jira] [Updated] (KAFKA-12874) Increase default consumer session timeout to 45s (KIP-735)

2021-06-01 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-12874: Description: As documented in KIP-735, we will increase the default session timeout to 45s

[GitHub] [kafka] hachikuji opened a new pull request #10803: KAFKA-12874; Increase default consumer session timeout to 45s

2021-06-01 Thread GitBox
hachikuji opened a new pull request #10803: URL: https://github.com/apache/kafka/pull/10803 This patch increases the default consumer session timeout to 45s as documented in KIP-735: https://cwiki.apache.org/confluence/display/KAFKA/KIP-735%3A+Increase+default+consumer+session+timeout.

[GitHub] [kafka] hachikuji commented on pull request #10803: KAFKA-12874; Increase default consumer session timeout to 45s

2021-06-01 Thread GitBox
hachikuji commented on pull request #10803: URL: https://github.com/apache/kafka/pull/10803#issuecomment-852392818 @mumrah We'll have to see. It wouldn't surprise me if we need a little additional tuning. -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KAFKA-12554: Refactor Log layer

2021-06-01 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r643433770 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1500,50 +1325,67 @@ class Log(@volatile private var _dir: File, } } -delete

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KAFKA-12554: Refactor Log layer

2021-06-01 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r643436284 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1500,50 +1325,67 @@ class Log(@volatile private var _dir: File, } } -delete

[GitHub] [kafka] Moovlin closed pull request #10718: KAFKA-12811: kafka-topics.sh should let the user know they cannot adjust the replication factor for a topic using the --alter flag and not warn abo

2021-06-01 Thread GitBox
Moovlin closed pull request #10718: URL: https://github.com/apache/kafka/pull/10718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] junrao commented on a change in pull request #10280: KAFKA-12554: Refactor Log layer

2021-06-01 Thread GitBox
junrao commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r643443877 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1500,50 +1325,67 @@ class Log(@volatile private var _dir: File, } } -deleteO

[GitHub] [kafka] junrao commented on a change in pull request #10280: KAFKA-12554: Refactor Log layer

2021-06-01 Thread GitBox
junrao commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r643445208 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1500,50 +1325,67 @@ class Log(@volatile private var _dir: File, } } -deleteO

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KAFKA-12554: Refactor Log layer

2021-06-01 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r643446123 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1572,144 +1414,69 @@ class Log(@volatile private var _dir: File, .map(_.messageOffse

[GitHub] [kafka] Moovlin commented on pull request #10718: KAFKA-12811: kafka-topics.sh should let the user know they cannot adjust the replication factor for a topic using the --alter flag and not wa

2021-06-01 Thread GitBox
Moovlin commented on pull request #10718: URL: https://github.com/apache/kafka/pull/10718#issuecomment-852414008 Seems I've done some bad things here in an effort to resolve issues. Let me figure out what I actually want need to do to resolve the issue with the PR. I apologize for the mess

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KAFKA-12554: Refactor Log layer

2021-06-01 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r643449279 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1852,65 +1612,24 @@ class Log(@volatile private var _dir: File, logString.toString }

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KAFKA-12554: Refactor Log layer

2021-06-01 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r643450237 ## File path: core/src/main/scala/kafka/log/LogLoader.scala ## @@ -246,17 +262,17 @@ object LogLoader extends Logging { return fn } catch

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KAFKA-12554: Refactor Log layer

2021-06-01 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r643450237 ## File path: core/src/main/scala/kafka/log/LogLoader.scala ## @@ -246,17 +262,17 @@ object LogLoader extends Logging { return fn } catch

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KAFKA-12554: Refactor Log layer

2021-06-01 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r643456815 ## File path: core/src/test/scala/unit/kafka/log/LocalLogTest.scala ## @@ -0,0 +1,734 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KAFKA-12554: Refactor Log layer

2021-06-01 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r643464231 ## File path: core/src/test/scala/unit/kafka/log/LocalLogTest.scala ## @@ -0,0 +1,734 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KAFKA-12554: Refactor Log layer

2021-06-01 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r643465477 ## File path: core/src/test/scala/unit/kafka/log/LocalLogTest.scala ## @@ -0,0 +1,734 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] bruto1 commented on pull request #10590: KAFKA-5761: support ByteBuffer as value in ProducerRecord and avoid redundant serialization when it's used

2021-06-01 Thread GitBox
bruto1 commented on pull request #10590: URL: https://github.com/apache/kafka/pull/10590#issuecomment-852435745 done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For qu

[jira] [Created] (KAFKA-12875) Change Log layer segment map mutations to avoid absence of active segment

2021-06-01 Thread Kowshik Prakasam (Jira)
Kowshik Prakasam created KAFKA-12875: Summary: Change Log layer segment map mutations to avoid absence of active segment Key: KAFKA-12875 URL: https://issues.apache.org/jira/browse/KAFKA-12875 Pro

[GitHub] [kafka] hachikuji commented on a change in pull request #10616: KAFKA-12709; Add Admin API for `ListTransactions`

2021-06-01 Thread GitBox
hachikuji commented on a change in pull request #10616: URL: https://github.com/apache/kafka/pull/10616#discussion_r643496029 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/ListTransactionsResult.java ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Soft

[jira] [Created] (KAFKA-12876) Log.roll() could forever delete producer state snapshot of empty active segment

2021-06-01 Thread Kowshik Prakasam (Jira)
Kowshik Prakasam created KAFKA-12876: Summary: Log.roll() could forever delete producer state snapshot of empty active segment Key: KAFKA-12876 URL: https://issues.apache.org/jira/browse/KAFKA-12876

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KAFKA-12554: Refactor Log layer

2021-06-01 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r643498093 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1500,50 +1325,67 @@ class Log(@volatile private var _dir: File, } } -delete

[GitHub] [kafka] hachikuji commented on a change in pull request #9441: KAFKA-10614: Ensure group state (un)load is executed in the submitted order

2021-06-01 Thread GitBox
hachikuji commented on a change in pull request #9441: URL: https://github.com/apache/kafka/pull/9441#discussion_r643513632 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -279,30 +279,33 @@ class KafkaApis(val requestChannel: RequestChannel, new

[GitHub] [kafka] hachikuji commented on pull request #9441: KAFKA-10614: Ensure group state (un)load is executed in the submitted order

2021-06-01 Thread GitBox
hachikuji commented on pull request #9441: URL: https://github.com/apache/kafka/pull/9441#issuecomment-852487435 @tombentley Apologies for the delay. I was out on leave for the past month. I responded to Guozhang's comment. Let me know if it makes sense or not. -- This is an automated me

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KAFKA-12554: Refactor Log layer

2021-06-01 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r643514883 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1806,37 +1566,37 @@ class Log(@volatile private var _dir: File, endOffset: Long ): Un

[GitHub] [kafka] hachikuji edited a comment on pull request #10803: KAFKA-12874; Increase default consumer session timeout to 45s

2021-06-01 Thread GitBox
hachikuji edited a comment on pull request #10803: URL: https://github.com/apache/kafka/pull/10803#issuecomment-852392818 @mumrah We'll have to see. It wouldn't surprise me if the integration tests need a little additional tuning. -- This is an automated message from the Apache Git Servi

[jira] [Created] (KAFKA-12877) Fix KRPC files with missing flexibleVersions annotation

2021-06-01 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-12877: Summary: Fix KRPC files with missing flexibleVersions annotation Key: KAFKA-12877 URL: https://issues.apache.org/jira/browse/KAFKA-12877 Project: Kafka Issue

[GitHub] [kafka] wcarlson5 commented on pull request #10664: KAFKA-12749: Changelog topic config on suppressed KTable lost

2021-06-01 Thread GitBox
wcarlson5 commented on pull request #10664: URL: https://github.com/apache/kafka/pull/10664#issuecomment-852546841 Sorry, this got lost in my inbox. @vichu if you can rebase I think its good to go. do you agree @ableegoldman ? -- This is an automated message from the Apache Git Service.

[jira] [Commented] (KAFKA-10681) MM2 translateOffsets returns wrong offsets

2021-06-01 Thread Sandeep mehta (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355371#comment-17355371 ] Sandeep mehta commented on KAFKA-10681: --- I am not sure why its happening with *Rem

[GitHub] [kafka] cmccabe opened a new pull request #10804: KAFKA-12877: fix KRPC files with missing flexibleVersions annotations

2021-06-01 Thread GitBox
cmccabe opened a new pull request #10804: URL: https://github.com/apache/kafka/pull/10804 Some KRPC files do not specify their flexibleVersions. Unfortunately, in this case, we default to not supporting any flexible versions. This is a poor default, since the flexible format is both mo

[jira] [Created] (KAFKA-12878) Support --bootstrap-server kafka-streams-application-reset

2021-06-01 Thread Neil Buesing (Jira)
Neil Buesing created KAFKA-12878: Summary: Support --bootstrap-server kafka-streams-application-reset Key: KAFKA-12878 URL: https://issues.apache.org/jira/browse/KAFKA-12878 Project: Kafka Is

[jira] [Updated] (KAFKA-12878) Support --bootstrap-server kafka-streams-application-reset

2021-06-01 Thread Neil Buesing (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neil Buesing updated KAFKA-12878: - Fix Version/s: (was: 2.5.0) > Support --bootstrap-server kafka-streams-application-reset > -

  1   2   >