cadonna commented on pull request #10785: URL: https://github.com/apache/kafka/pull/10785#issuecomment-851926961
As far as I can see from skimming the PR, you could have a PR for the standby task assignors with corresponding unit tests without changing any existing public functionality and without adding any partial public functionality. So I guess, it would be fine to have a PR for the standby task assignors. To give context to the reviewers, you should motivate the change in the PR description. Maybe you can do similar with the subscription changes and with some other aspects of this PR. Probably, it would be good to have the config PR that makes the functionality available to the public last, so that the functionality is never partly publicly available. I do not know the details of #7170, but most people with which I have talked about PR sizes agree that if it is possible to split them into smaller pieces, we should do it. Note, that the title of the PR should start with the issue ID of the JIRA tickets which in this case would be KAFKA-6718. In this way a link to the PR will show up on the ticket. You can also open multiple PRs whose title starts with KAFKA-6718. A link for each PR will then show up in the ticket. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
