[GitHub] [kafka] jlprat commented on a change in pull request #10768: MINOR: fix code listings for ops.html

jlprat commented on a change in pull request #10768: URL: https://github.com/apache/kafka/pull/10768#discussion_r640340174 ## File path: docs/ops.html ## @@ -248,98 +248,98 @@ only exist on brokers 5,6. Since the tool accepts the input list of topics as a json file, you

[GitHub] [kafka] jlprat commented on pull request #10769: MINOR: fix code listings connect.html

jlprat commented on pull request #10769: URL: https://github.com/apache/kafka/pull/10769#issuecomment-849385403 Thanks for the review @showuon ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] showuon commented on a change in pull request #10770: MINOR: fix code listings security.html

showuon commented on a change in pull request #10770: URL: https://github.com/apache/kafka/pull/10770#discussion_r640339525 ## File path: docs/security.html ## @@ -1835,28 +1834,28 @@ Authentication using Delegation Tokens section. +Authentication using Delegat

[GitHub] [kafka] socutes commented on pull request #10749: KAFKA-12773: Use UncheckedIOException when wrapping IOException

socutes commented on pull request #10749: URL: https://github.com/apache/kafka/pull/10749#issuecomment-849390939 @showuon Please review the changes again! Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [kafka] jlprat commented on a change in pull request #10770: MINOR: fix code listings security.html

jlprat commented on a change in pull request #10770: URL: https://github.com/apache/kafka/pull/10770#discussion_r640352656 ## File path: docs/security.html ## @@ -428,12 +428,12 @@ zookeeper.sasl.client.username to the appropriate name (e.g., -Dzookeeper.sasl.clien

[GitHub] [kafka] showuon commented on a change in pull request #10749: KAFKA-12773: Use UncheckedIOException when wrapping IOException

showuon commented on a change in pull request #10749: URL: https://github.com/apache/kafka/pull/10749#discussion_r640356874 ## File path: raft/src/test/java/org/apache/kafka/raft/QuorumStateTest.java ## @@ -945,11 +946,10 @@ public void testObserverUnattachedToFollower() throws

[jira] [Commented] (KAFKA-12849) Consider migrating TaskMetadata to interface with internal implementation

[ https://issues.apache.org/jira/browse/KAFKA-12849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352338#comment-17352338 ] Josep Prat commented on KAFKA-12849: KIP created https://cwiki.apache.org/confluence

[GitHub] [kafka] dajac commented on pull request #10467: KAFKA-12609: Rewrite ListOffsets using AdminApiDriver

dajac commented on pull request #10467: URL: https://github.com/apache/kafka/pull/10467#issuecomment-849464267 @dengziming Sure. I have added it to my review backlog. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[jira] [Commented] (KAFKA-12629) Failing Test: RaftClusterTest

[ https://issues.apache.org/jira/browse/KAFKA-12629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352353#comment-17352353 ] Bruno Cadonna commented on KAFKA-12629: --- Failed on: https://ci-builds.apache.org/

[GitHub] [kafka] cadonna commented on pull request #10710: KAFKA-12796: Removal of deprecated classes under `streams-scala`

cadonna commented on pull request #10710: URL: https://github.com/apache/kafka/pull/10710#issuecomment-849484765 Failed test is unrelated and known to be flaky: ``` kafka.server.RaftClusterTest.testCreateClusterAndCreateListDeleteTopic() ``` -- This is an automated message from t

[GitHub] [kafka] cadonna merged pull request #10710: KAFKA-12796: Removal of deprecated classes under `streams-scala`

cadonna merged pull request #10710: URL: https://github.com/apache/kafka/pull/10710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] jlprat commented on pull request #10710: KAFKA-12796: Removal of deprecated classes under `streams-scala`

jlprat commented on pull request #10710: URL: https://github.com/apache/kafka/pull/10710#issuecomment-849486858 Thanks for the review @cadonna ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] dajac commented on a change in pull request #10760: KAFKA-12541 Extend ListOffset to fetch offset with max timestamp

dajac commented on a change in pull request #10760: URL: https://github.com/apache/kafka/pull/10760#discussion_r640459341 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1316,6 +1316,16 @@ class Log(@volatile private var _dir: File, val latestEpochOpt = l

[GitHub] [kafka] mdedetrich commented on pull request #10652: KAFKA-9726 IdentityReplicationPolicy

mdedetrich commented on pull request #10652: URL: https://github.com/apache/kafka/pull/10652#issuecomment-849508419 @ryannedolan Since https://github.com/apache/kafka/pull/10762 was merged maybe it makes sense to rebase against the current `trunk`? Some of the tests in this PR have assert

[GitHub] [kafka] dgd-contributor opened a new pull request #10774: KAFKA-12380 Executor in Connect's Worker is not shut down when the worker is

dgd-contributor opened a new pull request #10774: URL: https://github.com/apache/kafka/pull/10774 The Worker class has an executor field that the public constructor initializes with a new cached thread pool (https://github.com/apache/kafka/blob/02226fa090513882b9229ac834fd493d71ae6d96/conn

[jira] [Commented] (KAFKA-9531) java.net.UnknownHostException loop on VM rolling update using CNAME

[ https://issues.apache.org/jira/browse/KAFKA-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352386#comment-17352386 ] Rui Abreu commented on KAFKA-9531: -- [~tcsantos] and [~Bolen] What helped us in our spe

[GitHub] [kafka] cadonna commented on a change in pull request #10770: MINOR: fix code listings security.html

cadonna commented on a change in pull request #10770: URL: https://github.com/apache/kafka/pull/10770#discussion_r640479762 ## File path: docs/security.html ## @@ -208,25 +208,25 @@ Host Name Verification Then create a database and serial number file, these will be

[GitHub] [kafka] feyman2016 commented on pull request #10377: KAFKA-12515 ApiVersionManager should create response based on request version

feyman2016 commented on pull request #10377: URL: https://github.com/apache/kafka/pull/10377#issuecomment-849526883 @rajinisivaram Thanks for the review, I will address it later~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [kafka] jlprat commented on a change in pull request #10770: MINOR: fix code listings security.html

jlprat commented on a change in pull request #10770: URL: https://github.com/apache/kafka/pull/10770#discussion_r640512166 ## File path: docs/security.html ## @@ -47,7 +47,7 @@ keytool -keystore {keystorefile} -alias localhost -validity {validity} -genkey -keyalg RSA -storety

[GitHub] [kafka] jlprat commented on a change in pull request #10770: MINOR: fix code listings security.html

jlprat commented on a change in pull request #10770: URL: https://github.com/apache/kafka/pull/10770#discussion_r640515305 ## File path: docs/security.html ## @@ -428,12 +428,12 @@ zookeeper.sasl.client.username to the appropriate name (e.g., -Dzookeeper.sasl.clien

[GitHub] [kafka] jlprat commented on a change in pull request #10770: MINOR: fix code listings security.html

jlprat commented on a change in pull request #10770: URL: https://github.com/apache/kafka/pull/10770#discussion_r640516748 ## File path: docs/security.html ## @@ -443,134 +443,133 @@ -If JAAS configuration is defined at different levels, the order of precedence

[GitHub] [kafka] jlprat commented on pull request #10770: MINOR: fix code listings security.html

jlprat commented on pull request #10770: URL: https://github.com/apache/kafka/pull/10770#issuecomment-849539579 Hi @cadonna thanks a lot for the feedback. I fixed the missing `>` characters. About the misalignment, you were right, it was but not from the lines you mention, but the previous

[GitHub] [kafka] thomaskwscott commented on a change in pull request #10760: KAFKA-12541 Extend ListOffset to fetch offset with max timestamp

thomaskwscott commented on a change in pull request #10760: URL: https://github.com/apache/kafka/pull/10760#discussion_r640520669 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -4225,76 +4232,84 @@ public ListOffsetsResult listO

[GitHub] [kafka] jlprat edited a comment on pull request #10770: MINOR: fix code listings security.html

jlprat edited a comment on pull request #10770: URL: https://github.com/apache/kafka/pull/10770#issuecomment-849539579 Hi @cadonna thanks a lot for the feedback. I fixed the missing `>` characters. About the misalignment, you were right, however it was not from the lines you mention, but t

[jira] [Created] (KAFKA-12855) Update ssl certificates of kafka connect worker runtime without restarting the worker process.

kaushik srinivas created KAFKA-12855: Summary: Update ssl certificates of kafka connect worker runtime without restarting the worker process. Key: KAFKA-12855 URL: https://issues.apache.org/jira/browse/KAFKA-1

[GitHub] [kafka] thomaskwscott commented on a change in pull request #10760: KAFKA-12541 Extend ListOffset to fetch offset with max timestamp

thomaskwscott commented on a change in pull request #10760: URL: https://github.com/apache/kafka/pull/10760#discussion_r640543594 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1316,6 +1316,16 @@ class Log(@volatile private var _dir: File, val latestEpoch

[GitHub] [kafka] thomaskwscott commented on a change in pull request #10760: KAFKA-12541 Extend ListOffset to fetch offset with max timestamp

thomaskwscott commented on a change in pull request #10760: URL: https://github.com/apache/kafka/pull/10760#discussion_r640544656 ## File path: core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala ## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Softw

[GitHub] [kafka] dajac commented on a change in pull request #10760: KAFKA-12541 Extend ListOffset to fetch offset with max timestamp

dajac commented on a change in pull request #10760: URL: https://github.com/apache/kafka/pull/10760#discussion_r640544984 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -4225,76 +4232,84 @@ public ListOffsetsResult listOffsets(M

[GitHub] [kafka] thomaskwscott commented on a change in pull request #10760: KAFKA-12541 Extend ListOffset to fetch offset with max timestamp

thomaskwscott commented on a change in pull request #10760: URL: https://github.com/apache/kafka/pull/10760#discussion_r640552093 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -4225,76 +4232,84 @@ public ListOffsetsResult listO

[GitHub] [kafka] ijuma merged pull request #10759: MINOR: Adjust parameter ordering of `waitForCondition` and `retryOnExceptionWithTimeout`

ijuma merged pull request #10759: URL: https://github.com/apache/kafka/pull/10759 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [kafka] iakunin opened a new pull request #10775: KAFKA-12668: Making MockScheduler.schedule safe to use in concurrent code

iakunin opened a new pull request #10775: URL: https://github.com/apache/kafka/pull/10775 Making MockScheduler.schedule safe to use in concurrent code by removing `tick()` call inside MockScheduler.schedule. To reproduce a bug I wrote a unit-test MockSchedulerTest. ### Comm

[jira] [Comment Edited] (KAFKA-12668) MockScheduler is not safe to use in concurrent code.

[ https://issues.apache.org/jira/browse/KAFKA-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352476#comment-17352476 ] Maksim Iakunin edited comment on KAFKA-12668 at 5/27/21, 1:29 PM:

[GitHub] [kafka] ijuma opened a new pull request #10776: MINOR: Adjust parameter ordering of `waitForCondition` and `retryOnExceptionWithTimeout`

ijuma opened a new pull request #10776: URL: https://github.com/apache/kafka/pull/10776 New parameters in overloaded methods should appear later apart from lambdas that should always be last. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implemen

[GitHub] [kafka] ijuma opened a new pull request #10777: MINOR: Adjust parameter ordering of `waitForCondition` and `retryOnExceptionWithTimeout`

ijuma opened a new pull request #10777: URL: https://github.com/apache/kafka/pull/10777 New parameters in overloaded methods should appear later apart from lambdas that should always be last. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implemen

[GitHub] [kafka] ijuma commented on pull request #10759: MINOR: Adjust parameter ordering of `waitForCondition` and `retryOnExceptionWithTimeout`

ijuma commented on pull request #10759: URL: https://github.com/apache/kafka/pull/10759#issuecomment-849642509 PRs for 2.8 and 2.7: * https://github.com/apache/kafka/pull/10777 * https://github.com/apache/kafka/pull/10776 -- This is an automated message from the Apache Git Service.

[GitHub] [kafka] ijuma commented on a change in pull request #10761: MINOR: Don't ignore deletion of partition metadata file and log topic id clean-ups

ijuma commented on a change in pull request #10761: URL: https://github.com/apache/kafka/pull/10761#discussion_r640639035 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -325,19 +325,25 @@ class Log(@volatile private var _dir: File, // Ensure we do not try to a

[GitHub] [kafka] dajac commented on a change in pull request #10760: KAFKA-12541 Extend ListOffset to fetch offset with max timestamp

dajac commented on a change in pull request #10760: URL: https://github.com/apache/kafka/pull/10760#discussion_r640640161 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -4225,76 +4232,84 @@ public ListOffsetsResult listOffsets(M

[GitHub] [kafka] ijuma commented on pull request #10176: KAFKA-12359: Update Jetty to 11

ijuma commented on pull request #10176: URL: https://github.com/apache/kafka/pull/10176#issuecomment-849652409 We are not planning to upgrade to Java 11 any time soon. Can you please submit a PR for the latest Jetty version that supports Java 8 still? -- This is an automated message from

[GitHub] [kafka] ijuma closed pull request #10176: KAFKA-12359: Update Jetty to 11

ijuma closed pull request #10176: URL: https://github.com/apache/kafka/pull/10176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[jira] [Commented] (KAFKA-12774) kafka-streams 2.8: logging in uncaught-exceptionhandler doesn't go through log4j

[ https://issues.apache.org/jira/browse/KAFKA-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352499#comment-17352499 ] Almog Gavra commented on KAFKA-12774: - I went back to triage the severity of this be

[jira] [Created] (KAFKA-12856) Upgrade Jackson to 2.12.3

Ismael Juma created KAFKA-12856: --- Summary: Upgrade Jackson to 2.12.3 Key: KAFKA-12856 URL: https://issues.apache.org/jira/browse/KAFKA-12856 Project: Kafka Issue Type: Bug Reporter:

[GitHub] [kafka] iakunin commented on pull request #10775: KAFKA-12668: Making MockScheduler.schedule safe to use in concurrent code

iakunin commented on pull request #10775: URL: https://github.com/apache/kafka/pull/10775#issuecomment-849675662 @jsancio could you have a look, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [kafka] ijuma opened a new pull request #10778: KAFKA-12856: Upgrade Jackson to 2.12.3

ijuma opened a new pull request #10778: URL: https://github.com/apache/kafka/pull/10778 2.10.x is no longer supported, so we should move to 2.12 for the 3.0 release. ScalaObjectMapper has been deprecated and it looks like we don't actually need it, so remove its usage. ##

[jira] [Commented] (KAFKA-12465) Decide whether inconsistent cluster id error are fatal

[ https://issues.apache.org/jira/browse/KAFKA-12465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352518#comment-17352518 ] Omnia Ibrahim commented on KAFKA-12465: --- I have been testing KRAFT and I was tryin

[jira] [Comment Edited] (KAFKA-12465) Decide whether inconsistent cluster id error are fatal

[ https://issues.apache.org/jira/browse/KAFKA-12465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352518#comment-17352518 ] Omnia Ibrahim edited comment on KAFKA-12465 at 5/27/21, 2:26 PM: -

[GitHub] [kafka] iakunin edited a comment on pull request #10775: KAFKA-12668: Making MockScheduler.schedule safe to use in concurrent code

iakunin edited a comment on pull request #10775: URL: https://github.com/apache/kafka/pull/10775#issuecomment-849675662 @jsancio hi! Could you have a look at this PR, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] cadonna commented on a change in pull request #10765: KAFKA-12519: Remove built-in Streams metrics for versions 0.10.0-2.4

cadonna commented on a change in pull request #10765: URL: https://github.com/apache/kafka/pull/10765#discussion_r640686291 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/MeteredWindowStoreTest.java ## @@ -272,21 +230,8 @@ public void shouldRecord

[GitHub] [kafka] ijuma commented on a change in pull request #10764: MINOR: make sure all fiedls of o.p.k.s.a.Action are NOT null

ijuma commented on a change in pull request #10764: URL: https://github.com/apache/kafka/pull/10764#discussion_r640705924 ## File path: clients/src/main/java/org/apache/kafka/server/authorizer/Action.java ## @@ -36,22 +36,22 @@ public Action(AclOperation operation,

[GitHub] [kafka] ijuma commented on a change in pull request #10764: MINOR: make sure all fiedls of o.p.k.s.a.Action are NOT null

ijuma commented on a change in pull request #10764: URL: https://github.com/apache/kafka/pull/10764#discussion_r640705924 ## File path: clients/src/main/java/org/apache/kafka/server/authorizer/Action.java ## @@ -36,22 +36,22 @@ public Action(AclOperation operation,

[GitHub] [kafka] lbradstreet commented on a change in pull request #10704: KAFKA-12791: ConcurrentModificationException in AbstractConfig use by KafkaProducer

lbradstreet commented on a change in pull request #10704: URL: https://github.com/apache/kafka/pull/10704#discussion_r640706594 ## File path: clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java ## @@ -106,7 +107,7 @@ public AbstractConfig(ConfigDef definit

[GitHub] [kafka] feyman2016 commented on a change in pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

feyman2016 commented on a change in pull request #10593: URL: https://github.com/apache/kafka/pull/10593#discussion_r640723618 ## File path: raft/src/test/java/org/apache/kafka/snapshot/SnapshotWriterReaderTest.java ## @@ -135,4 +141,18 @@ public static void assertSnapshot(Lis

[jira] [Comment Edited] (KAFKA-12465) Decide whether inconsistent cluster id error are fatal

[ https://issues.apache.org/jira/browse/KAFKA-12465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352518#comment-17352518 ] Omnia Ibrahim edited comment on KAFKA-12465 at 5/27/21, 3:40 PM: -

[GitHub] [kafka] junrao merged pull request #10684: MINOR: Improve Log layer segment iteration logic and few other areas

junrao merged pull request #10684: URL: https://github.com/apache/kafka/pull/10684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] feyman2016 commented on pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

feyman2016 commented on pull request #10593: URL: https://github.com/apache/kafka/pull/10593#issuecomment-849753337 @jsancio Addressed the comments but just found that I would need to generalize `context.advanceLeaderHighWatermarkToEndOffset ()`, will update later~ -- This is an automat

[GitHub] [kafka] abbccdda commented on a change in pull request #10744: KAFKA-8410: KTableProcessor migration groundwork

abbccdda commented on a change in pull request #10744: URL: https://github.com/apache/kafka/pull/10744#discussion_r640767449 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableImpl.java ## @@ -124,7 +124,10 @@ private static final String

[GitHub] [kafka] ijuma commented on a change in pull request #10704: KAFKA-12791: ConcurrentModificationException in AbstractConfig use by KafkaProducer

ijuma commented on a change in pull request #10704: URL: https://github.com/apache/kafka/pull/10704#discussion_r640788402 ## File path: clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java ## @@ -508,6 +509,55 @@ public void testDocumentationOfExpectNul

[GitHub] [kafka] chia7712 commented on pull request #10764: MINOR: make sure all fiedls of o.p.k.s.a.Action are NOT null

chia7712 commented on pull request #10764: URL: https://github.com/apache/kafka/pull/10764#issuecomment-849784432 @ijuma thanks for your suggestion. I have addressed all comments. PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] jsancio commented on pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

jsancio commented on pull request #10593: URL: https://github.com/apache/kafka/pull/10593#issuecomment-849787584 > @jsancio Addressed the comments but just found that I would need to generalize context.advanceLeaderHighWatermarkToEndOffset (), will update later~ I needed something si

[GitHub] [kafka] rondagostino opened a new pull request #10779: CONFLUENT: Complete version regex check in system tests

rondagostino opened a new pull request #10779: URL: https://github.com/apache/kafka/pull/10779 A couple of the sanity-check system tests confirm that the version of Kafka on the CLASSPATH during the test is the one that is expected. These tests were failing for the 2.8 release due to the

[GitHub] [kafka] rondagostino closed pull request #10779: CONFLUENT: Complete version regex check in system tests

rondagostino closed pull request #10779: URL: https://github.com/apache/kafka/pull/10779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [kafka] rondagostino commented on pull request #10779: CONFLUENT: Complete version regex check in system tests

rondagostino commented on pull request #10779: URL: https://github.com/apache/kafka/pull/10779#issuecomment-849788603 Wrong base -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [kafka] ijuma commented on pull request #10778: KAFKA-12856: Upgrade Jackson to 2.12.3

ijuma commented on pull request #10778: URL: https://github.com/apache/kafka/pull/10778#issuecomment-849789835 Tests look good, one job passed, the others had unrelated failures: > Build / JDK 15 and Scala 2.13 / testCreateClusterAndCreateAndManyTopicsWithManyPartitions() – kafka.se

[GitHub] [kafka] ijuma merged pull request #10778: KAFKA-12856: Upgrade Jackson to 2.12.3

ijuma merged pull request #10778: URL: https://github.com/apache/kafka/pull/10778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [kafka] ijuma commented on pull request #10776: MINOR: Adjust parameter ordering of `waitForCondition` and `retryOnExceptionWithTimeout`

ijuma commented on pull request #10776: URL: https://github.com/apache/kafka/pull/10776#issuecomment-849790914 Created the backport PR just to verify that tests passed, merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] ijuma merged pull request #10776: MINOR: Adjust parameter ordering of `waitForCondition` and `retryOnExceptionWithTimeout`

ijuma merged pull request #10776: URL: https://github.com/apache/kafka/pull/10776 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [kafka] jsancio commented on a change in pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

jsancio commented on a change in pull request #10593: URL: https://github.com/apache/kafka/pull/10593#discussion_r640805609 ## File path: raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java ## @@ -963,6 +952,20 @@ static void verifyLeaderChangeMessage(

[GitHub] [kafka] ijuma commented on pull request #10777: MINOR: Adjust parameter ordering of `waitForCondition` and `retryOnExceptionWithTimeout`

ijuma commented on pull request #10777: URL: https://github.com/apache/kafka/pull/10777#issuecomment-849791655 Created the backport PR just to check the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [kafka] ijuma merged pull request #10777: MINOR: Adjust parameter ordering of `waitForCondition` and `retryOnExceptionWithTimeout`

ijuma merged pull request #10777: URL: https://github.com/apache/kafka/pull/10777 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[jira] [Resolved] (KAFKA-12856) Upgrade Jackson to 2.12.3

[ https://issues.apache.org/jira/browse/KAFKA-12856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-12856. - Fix Version/s: 3.0.0 Resolution: Fixed > Upgrade Jackson to 2.12.3 >

[GitHub] [kafka] ijuma commented on pull request #10758: KAFKA-12782: Javadocs search sends you to a non-existent URL

ijuma commented on pull request #10758: URL: https://github.com/apache/kafka/pull/10758#issuecomment-849798924 Thanks for looking into this. Can we switch the release requirement to be Java 15 instead of Java 11 then? We can then switch to Java 17 once that's out and stick to that for a wh

[GitHub] [kafka] lbradstreet commented on a change in pull request #10704: KAFKA-12791: ConcurrentModificationException in AbstractConfig use by KafkaProducer

lbradstreet commented on a change in pull request #10704: URL: https://github.com/apache/kafka/pull/10704#discussion_r640820748 ## File path: clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java ## @@ -508,6 +509,55 @@ public void testDocumentationOfExp

[GitHub] [kafka] jlprat commented on pull request #10758: KAFKA-12782: Javadocs search sends you to a non-existent URL

jlprat commented on pull request #10758: URL: https://github.com/apache/kafka/pull/10758#issuecomment-849805196 Hi @ijuma, yes, if you would generate the Javadocs with JDK 15 (or 16) instead of 11, it would work (I tried it myself locally). Then one only needs to modify the `release.py` fi

[GitHub] [kafka] lbradstreet commented on a change in pull request #10704: KAFKA-12791: ConcurrentModificationException in AbstractConfig use by KafkaProducer

lbradstreet commented on a change in pull request #10704: URL: https://github.com/apache/kafka/pull/10704#discussion_r640823494 ## File path: clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java ## @@ -508,6 +509,55 @@ public void testDocumentationOfExp

[GitHub] [kafka] ijuma commented on pull request #10758: KAFKA-12782: Javadocs search sends you to a non-existent URL

ijuma commented on pull request #10758: URL: https://github.com/apache/kafka/pull/10758#issuecomment-849813756 Yes, let's go with 15 since Kafka doesn't work with 16 yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [kafka] jlprat commented on pull request #10758: KAFKA-12782: Javadocs search sends you to a non-existent URL

jlprat commented on pull request #10758: URL: https://github.com/apache/kafka/pull/10758#issuecomment-849814665 Shall, I close this PR and open a new one with the modified `release.py`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [kafka] vvcephei commented on a change in pull request #10744: KAFKA-8410: KTableProcessor migration groundwork

vvcephei commented on a change in pull request #10744: URL: https://github.com/apache/kafka/pull/10744#discussion_r640835700 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableNewProcessorSupplier.java ## @@ -0,0 +1,40 @@ +/* + * Licensed to t

[GitHub] [kafka] vvcephei commented on a change in pull request #10744: KAFKA-8410: KTableProcessor migration groundwork

vvcephei commented on a change in pull request #10744: URL: https://github.com/apache/kafka/pull/10744#discussion_r640835922 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/SessionCacheFlushListener.java ## @@ -19,30 +19,45 @@ import org.apache.

[GitHub] [kafka] vvcephei commented on a change in pull request #10744: KAFKA-8410: KTableProcessor migration groundwork

vvcephei commented on a change in pull request #10744: URL: https://github.com/apache/kafka/pull/10744#discussion_r640837000 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableNewProcessorSupplier.java ## @@ -0,0 +1,40 @@ +/* + * Licensed to t

[GitHub] [kafka] vvcephei commented on a change in pull request #10744: KAFKA-8410: KTableProcessor migration groundwork

vvcephei commented on a change in pull request #10744: URL: https://github.com/apache/kafka/pull/10744#discussion_r640837839 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/To.java ## @@ -89,4 +89,11 @@ public int hashCode() { throw new Unsupport

[GitHub] [kafka] ijuma commented on pull request #10758: KAFKA-12782: Javadocs search sends you to a non-existent URL

ijuma commented on pull request #10758: URL: https://github.com/apache/kafka/pull/10758#issuecomment-849820046 Or just replace the code in this branch. Whatever you prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] vvcephei commented on a change in pull request #10744: KAFKA-8410: KTableProcessor migration groundwork

vvcephei commented on a change in pull request #10744: URL: https://github.com/apache/kafka/pull/10744#discussion_r640838987 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/CacheFlushListener.java ## @@ -31,4 +34,9 @@ * @param timestamp tim

[GitHub] [kafka] jlprat opened a new pull request #10780: KAFKA-12782: Fix Javadocs generation by upgrading JDK

jlprat opened a new pull request #10780: URL: https://github.com/apache/kafka/pull/10780 This, upgrades JDK to version 15 for the docs generation, this way we can circumvent bug https://bugs.openjdk.java.net/browse/JDK-8215291 present in JDK11 ### Committer Checklist (excluded f

[GitHub] [kafka] jlprat closed pull request #10758: KAFKA-12782: Javadocs search sends you to a non-existent URL

jlprat closed pull request #10758: URL: https://github.com/apache/kafka/pull/10758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] jlprat commented on pull request #10758: KAFKA-12782: Javadocs search sends you to a non-existent URL

jlprat commented on pull request #10758: URL: https://github.com/apache/kafka/pull/10758#issuecomment-849820849 Closed in favor of https://github.com/apache/kafka/pull/10780 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] jlprat commented on a change in pull request #10780: KAFKA-12782: Fix Javadocs generation by upgrading JDK

jlprat commented on a change in pull request #10780: URL: https://github.com/apache/kafka/pull/10780#discussion_r640840181 ## File path: release.py ## @@ -265,7 +265,7 @@ def command_stage_docs(): # version due to already having bumped the bugfix version number. gradl

[GitHub] [kafka] vvcephei commented on a change in pull request #10744: KAFKA-8410: KTableProcessor migration groundwork

vvcephei commented on a change in pull request #10744: URL: https://github.com/apache/kafka/pull/10744#discussion_r640840509 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/SinkNode.java ## @@ -24,14 +24,14 @@ import static org.apache.kafka.s

[GitHub] [kafka] jlprat commented on pull request #10780: KAFKA-12782: Fix Javadocs generation by upgrading JDK

jlprat commented on pull request #10780: URL: https://github.com/apache/kafka/pull/10780#issuecomment-849822082 Hi, @ijuma ready for you to review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] ijuma commented on a change in pull request #10780: KAFKA-12782: Fix Javadocs generation by upgrading JDK

ijuma commented on a change in pull request #10780: URL: https://github.com/apache/kafka/pull/10780#discussion_r640841685 ## File path: release.py ## @@ -512,6 +512,7 @@ def command_release_announcement_email(): jdk8_env = get_jdk(prefs, 8) jdk11_env = get_jdk(prefs, 11) R

[GitHub] [kafka] jlprat commented on a change in pull request #10780: KAFKA-12782: Fix Javadocs generation by upgrading JDK

jlprat commented on a change in pull request #10780: URL: https://github.com/apache/kafka/pull/10780#discussion_r640841969 ## File path: release.py ## @@ -512,6 +512,7 @@ def command_release_announcement_email(): jdk8_env = get_jdk(prefs, 8) jdk11_env = get_jdk(prefs, 11)

[GitHub] [kafka] jlprat commented on a change in pull request #10780: KAFKA-12782: Fix Javadocs generation by upgrading JDK

jlprat commented on a change in pull request #10780: URL: https://github.com/apache/kafka/pull/10780#discussion_r640842878 ## File path: release.py ## @@ -512,6 +512,7 @@ def command_release_announcement_email(): jdk8_env = get_jdk(prefs, 8) jdk11_env = get_jdk(prefs, 11)

[GitHub] [kafka] ijuma commented on a change in pull request #10780: KAFKA-12782: Fix Javadocs generation by upgrading JDK

ijuma commented on a change in pull request #10780: URL: https://github.com/apache/kafka/pull/10780#discussion_r640842976 ## File path: release.py ## @@ -512,6 +512,7 @@ def command_release_announcement_email(): jdk8_env = get_jdk(prefs, 8) jdk11_env = get_jdk(prefs, 11) R

[GitHub] [kafka] jlprat commented on a change in pull request #10780: KAFKA-12782: Fix Javadocs generation by upgrading JDK

jlprat commented on a change in pull request #10780: URL: https://github.com/apache/kafka/pull/10780#discussion_r640843605 ## File path: release.py ## @@ -512,6 +512,7 @@ def command_release_announcement_email(): jdk8_env = get_jdk(prefs, 8) jdk11_env = get_jdk(prefs, 11)

[GitHub] [kafka] jlprat commented on a change in pull request #10780: KAFKA-12782: Fix Javadocs generation by upgrading JDK

jlprat commented on a change in pull request #10780: URL: https://github.com/apache/kafka/pull/10780#discussion_r640844354 ## File path: release.py ## @@ -512,6 +512,7 @@ def command_release_announcement_email(): jdk8_env = get_jdk(prefs, 8) jdk11_env = get_jdk(prefs, 11)

[GitHub] [kafka] jlprat commented on pull request #10780: KAFKA-12782: Fix Javadocs generation by upgrading JDK

jlprat commented on pull request #10780: URL: https://github.com/apache/kafka/pull/10780#issuecomment-849834440 An easy way to test this locally, is to search a Kafka class that contains a Javadoc link to a Standard Java Class. For example, searching for `KafkaFuture` and then clicking o

[jira] [Commented] (KAFKA-8295) Optimize count() using RocksDB merge operator

[ https://issues.apache.org/jira/browse/KAFKA-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352731#comment-17352731 ] A. Sophie Blee-Goldman commented on KAFKA-8295: --- Thanks for the initial res

[jira] [Commented] (KAFKA-5892) Connector property override does not work unless setting ALL converter properties

[ https://issues.apache.org/jira/browse/KAFKA-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352737#comment-17352737 ] Randall Hauch commented on KAFKA-5892: -- [~dc-heros], I've added your account as a co

[GitHub] [kafka] ijuma commented on pull request #10761: MINOR: Don't ignore deletion of partition metadata file and log topic id clean-ups

ijuma commented on pull request #10761: URL: https://github.com/apache/kafka/pull/10761#issuecomment-849931983 JDK 11 build passed, a few unrelated failures for the other builds: > Build / JDK 8 and Scala 2.12 / testMetricsDuringTopicCreateDelete() – kafka.integration.MetricsDuringTo

[GitHub] [kafka] ijuma merged pull request #10761: MINOR: Don't ignore deletion of partition metadata file and log topic id clean-ups

ijuma merged pull request #10761: URL: https://github.com/apache/kafka/pull/10761 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [kafka] ijuma commented on pull request #10704: KAFKA-12791: ConcurrentModificationException in AbstractConfig use by KafkaProducer

ijuma commented on pull request #10704: URL: https://github.com/apache/kafka/pull/10704#issuecomment-849934626 Unrelated flaky tests: > Build / JDK 15 and Scala 2.13 / kafka.network.ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit() > Build / JDK 11 and

[GitHub] [kafka] ijuma merged pull request #10704: KAFKA-12791: ConcurrentModificationException in AbstractConfig use by KafkaProducer

ijuma merged pull request #10704: URL: https://github.com/apache/kafka/pull/10704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

  1   2   >